* [PATCH v12 01/40] selftests/dyndbg: Add kselftest script to verify dynamic-debug
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
@ 2026-10-13 2:36 ` Jim Cromie via B4 Relay
2026-10-13 2:36 ` [PATCH v12 02/40] vmlinux.lds.h: refactor BOUNDED_SECTION_* macros into bounded_sections.lds.h Jim Cromie via B4 Relay
` (38 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:36 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie
From: Jim Cromie <jim.cromie@gmail.com>
Ad-hoc dynamic debug testing by grepping /proc/dynamic_debug/control for
counts (e.g. counting " =pmf ") is brittle: multi-query commands,
partial string matches, and broad module queries inadvertently alter
unrelated callsites and hide syntax regressions.
Introduce dyndbg_selftest.sh and reusable helper library
syslog_hash_validation.sh using "the canonical test" model
(baseline -> change -> verify) with two complementary validation
mechanisms:
0. Spatial control-file slicing:
capture_before captures the baseline state for a target range
["$range"]. After applying "$query", verify_after_change computes
a normalized diff against /proc/dynamic_debug/control, stripping
source line numbers and hunk headers. This renders checksum
verification immune to upstream C line churn while catching
unintended state drift.
1. Temporal syslog slicing:
log_start and log_stop emit bookend markers into /dev/kmsg around
an executed workload, slicing exact dmesg prints while stripping
system timestamp/CPU/PID headers to verify reproducible output.
This baseline introduces and executes the 3 built-in feature tests:
0. FT_grammar_ok:
Validates valid syntax (keywords, line ranges, and colon-delimited
file:line / file:func specs) using side-effect-free flags ("+_").
1. FT_grammar_errs:
Validates core parser error handling, token limits, and EINVAL paths.
2. FT_basic_queries:
Validates direct queries targeting the built-in kernel/params.c file.
Tests are verified against an embedded GOLDEN_RECORDS database of MD5
fingerprints. Downstream modular classmap tests
(FT_classmap_inheritance, FT_test_classes, FT_modprobe_w_param) are
left for commits that introduce corresponding kernel infrastructure.
Runtime configuration:
- V=0|1|2: output verbosity (0=silent pass, 1=summary, 2=full diff).
- K=0|1|2: golden record mode (0=strict fail, 1=fake pass, 2=soft pass).
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
v11:
. drop write-only CUMULATIVE_DDCMDS assignment block in ddcmd().
Sashiko review complaint (patch 1):
"Is this variable used anywhere? It appears CUMULATIVE_DDCMDS is
written to here in ddcmd() but is never read or evaluated in this
script or subsequent patches in the series."
v9:
. sanitize "$K" integer input alongside "$V".
. drop duplicate ifrmmod function declaration.
. replace undeclared "$error_msg" with "$output" in handle_exit_code().
. rework LACK_DD_BUILTIN record filtering to check label column ($3).
. truncate temp files (: > "$SEEN_HASHES_FILE") instead of rm -f
under mktemp.
. add handling for K=2 (silent soft-pass mode) to suppress
DRIFT/UNREG blocks.
v8: sashiko prompted cleanups
. dont-skip-nomod-config
. mktmp-in-test-script
. fn-renames/cleanups: log_ddcmd, my_modname, set_param,
verify_control_slice
---
MAINTAINERS | 1 +
tools/testing/selftests/dynamic_debug/Makefile | 10 +
tools/testing/selftests/dynamic_debug/config | 8 +
.../selftests/dynamic_debug/dyndbg_selftest.sh | 493 +++++++++++++++++++++
.../dynamic_debug/syslog_hash_validation.sh | 393 ++++++++++++++++
5 files changed, 905 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index bd6619bc107d..98954b1746f6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9262,6 +9262,7 @@ S: Maintained
F: include/linux/dynamic_debug.h
F: lib/dynamic_debug.c
F: lib/test_dynamic_debug.c
+F: tools/testing/selftests/dynamic_debug/
DYNAMIC INTERRUPT MODERATION
M: Tal Gilboa <talgi@nvidia.com>
diff --git a/tools/testing/selftests/dynamic_debug/Makefile b/tools/testing/selftests/dynamic_debug/Makefile
new file mode 100644
index 000000000000..d998f485a9bc
--- /dev/null
+++ b/tools/testing/selftests/dynamic_debug/Makefile
@@ -0,0 +1,10 @@
+# SPDX-License-Identifier: GPL-2.0-only
+# borrowed from Makefile for user memory selftests
+
+# No binaries, but make sure arg-less "make" doesn't trigger "run_tests"
+all:
+
+TEST_PROGS := dyndbg_selftest.sh
+TEST_FILES := syslog_hash_validation.sh
+
+include ../lib.mk
diff --git a/tools/testing/selftests/dynamic_debug/config b/tools/testing/selftests/dynamic_debug/config
new file mode 100644
index 000000000000..ec478b17873d
--- /dev/null
+++ b/tools/testing/selftests/dynamic_debug/config
@@ -0,0 +1,8 @@
+
+# basic tests ref the builtin params module
+CONFIG_DYNAMIC_DEBUG=y
+
+# more testing is possible with these,
+# but insisting on them here skips testing entirely for such configs
+# CONFIG_TEST_DYNAMIC_DEBUG=m
+# CONFIG_TEST_DYNAMIC_DEBUG_SUBMOD=m
diff --git a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
new file mode 100755
index 000000000000..c1475c755542
--- /dev/null
+++ b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
@@ -0,0 +1,493 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-2.0-only
+
+# Standard kselftest exit codes
+ksft_pass=0
+ksft_fail=1
+ksft_skip=4
+
+ESC=$'\033'
+RED="${ESC}[0;31m"
+GREEN="${ESC}[0;32m"
+YELLOW="${ESC}[0;33m"
+BLUE="${ESC}[0;34m"
+MAGENTA="${ESC}[0;35m"
+CYAN="${ESC}[0;36m"
+NC="${ESC}[0;0m"
+# Environment Controls:
+# V=0,1,2 : Verbosity (0=concise summary, 1=verified assertions, 2=full captured outputs)
+# K=0 : Strict mode (fails with exit 1 on checksum drift or stale records)
+# K=1 : Soft-pass mode (prints DRIFT/STALE diffs, exits 0 with 'fake success')
+# K=2 : Silent soft-pass mode (suppresses DRIFT/STALE diffs, exits 0 with 'fake success')
+V=${V:=0}
+K=${K:=0}
+
+# Sanitize V and K to ensure they are valid integers
+if [[ ! "$V" =~ ^[0-9]+$ ]]; then
+ V=0
+fi
+if [[ ! "$K" =~ ^[0-9]+$ ]]; then
+ K=0
+fi
+
+function v_echo {
+ [ "${V:-0}" -ge 1 ] && echo -e "$@"
+}
+
+[ -e /proc/dynamic_debug/control ] || {
+ echo -e "${RED}: this test requires CONFIG_DYNAMIC_DEBUG=y ${NC}"
+ exit $ksft_skip # nothing to test here, no good reason to fail.
+}
+
+lsmod >/dev/null 2>&1 || {
+ echo -e "${RED}: lsmod requires /proc/modules ${NC}"
+ # exit $ksft_skip # maybe later we can do more
+}
+
+# need info to avoid failures due to untestable configs
+
+[ -f "$KCONFIG_CONFIG" ] || KCONFIG_CONFIG=".config"
+if [ -f "$KCONFIG_CONFIG" ]; then
+ v_echo "# consulting KCONFIG_CONFIG: $KCONFIG_CONFIG"
+ grep -q "CONFIG_DYNAMIC_DEBUG=y" $KCONFIG_CONFIG ; LACK_DD_BUILTIN=$?
+ grep -q "CONFIG_TEST_DYNAMIC_DEBUG=m" $KCONFIG_CONFIG ; LACK_TMOD=$?
+else
+ # if no config, try runtime probes
+ modprobe -n test_dynamic_debug 2>/dev/null ; LACK_TMOD=$?
+ # assume builtin dyndbg if control exists (checked above)
+ LACK_DD_BUILTIN=0
+fi
+
+function ifrmmod {
+ [ "${LACK_TMOD:-0}" -eq 1 ] && return
+ grep -q "^$1 " /proc/modules 2>/dev/null && rmmod $1
+}
+
+# Clean up any leftover loaded test modules at initialization
+ifrmmod test_dynamic_debug
+
+# ===========================================================================
+# TESTING STRATEGY 1.
+# Change and observe control-file settings:
+# ddcmd: ie echo $dd_query_cmd > /proc/dynamic_debug/control
+# read back control, count changes due to query_cmd
+# ===========================================================================
+DDCMD_LOG="" # accumulate
+
+function log_ddcmd {
+ local cmd="$1"
+ if [ "${IN_BOOKEND:-0}" -eq 1 ] && [ -n "$DDCMD_LOG" ]; then
+ DDCMD_LOG="${DDCMD_LOG}; $cmd"
+ else
+ DDCMD_LOG="$cmd"
+ fi
+}
+
+function my_modprobe {
+ log_ddcmd "modprobe $*"
+ modprobe "$@"
+}
+
+function set_param {
+ local val="$1"
+ local path="$2"
+ log_ddcmd "echo $val > $path"
+ echo "$val" > "$path"
+}
+
+function ddcmd () {
+ # ddcmd <query_args> [range_pattern] [pass|fail|log]
+ local args="$1"
+ local range="$2"
+ local action="${3:-pass}"
+ local exp_exit=0
+
+ [ "$action" = "fail" ] && exp_exit=1
+ log_ddcmd "$args"
+
+ [ "$action" != "pass" ] && log_start
+ [ -n "$range" ] && capture_before "$range"
+
+ output=$( (echo "$args" > /proc/dynamic_debug/control) 2>&1 )
+ handle_exit_code $BASH_LINENO $FUNCNAME $? $exp_exit
+
+ [ "$action" != "pass" ] && log_stop
+ [ -n "$range" ] && verify_after_change
+}
+
+function ddcmd_err () {
+ # ddcmd_err <query_args>
+ # Semantic wrapper for parser syntax & error validation
+ ddcmd "$1" "" fail
+}
+
+function ddcmd_load () {
+ # ddcmd_load <query_args> <range_pattern> <workload_param_path> <workload_val>
+ # Semantic wrapper for end-to-end filter setup and live workload logging
+ local query="$1"
+ local range="$2"
+ local param_path="$3"
+ local val="$4"
+
+ # 1. Setup the control filters (using positional ddcmd range-check)
+ echo "$query" "$range"
+ ddcmd "$query" "$range"
+
+ # 2. Execute the workload and capture syslog prints
+ log_start
+ echo "$val" > "$param_path"
+ log_stop
+}
+
+function handle_exit_code() {
+ local exp_exit_code=0
+ [ $# == 4 ] && exp_exit_code=$4
+ if [ "$3" -ne $exp_exit_code ]; then
+ echo -e "${RED}: $BASH_SOURCE:$1 $2() " \
+ "expected to exit with code $exp_exit_code, got $3${NC}"
+ [ "$3" == 1 ] && echo "Error: '$output'"
+ exit $ksft_fail
+ fi
+}
+
+# ==============================================================================
+# TESTING STRATEGY 2.
+# do 1 to setup test expectations.
+# run logging-workload
+# capture output
+# hash-validate it against GOLDEN_SAMPLE db (at file end)
+#
+# ==============================================================================
+# Source hash-based validation and state verification helper library
+DIR="$(dirname "$(readlink -f "$0")")"
+. "$DIR/syslog_hash_validation.sh"
+
+# Define target validation file path
+CONTROL_FILE="/proc/dynamic_debug/control"
+
+# App-specific wrappers mapping to generic library helpers
+function verify_control_slice {
+ # $1 - pattern to slice
+ # $2 - optional extra args
+ verify_file_slice "$1" $CONTROL_FILE "$2"
+}
+
+function slice_and_hash_ddctrl {
+ local slice=$(slice_by_grep "$1" "$CONTROL_FILE" | strip_control_linenos)
+ echo "$slice" | tr -d '\r' | md5sum | cut -d' ' -f1
+}
+
+# ==============================================================================
+# FEATURE TESTS (FT_*)
+#
+# test legal queries which should execute and return 0 (success)
+# so we dont look for errors in dmesg
+function FT_grammar_ok {
+ v_echo "${GREEN}# GRAMMAR_OK_TESTS ${NC}"
+ ddcmd "+_"
+ ddcmd "-_"
+
+ # use 4 keywords (max 9 words inc flags)
+ ddcmd "module foo file bar.c func buz class D2_CORE +_" # 4 keywords
+ #ddcmd "module foo file bar.c func buz class D2 line 100 +_" # 5 keywords
+
+ # 3. Dedicated lineno range grammar assertions (side-effect-free proofs)
+ ddcmd "line 42 +_" # test exact line syntax
+ ddcmd "line 10- +_" # test open-ended line range (starting at 10)
+ ddcmd "line -100 +_" # test open-ended line range (ending at 100)
+ ddcmd "line 10-100 +_" # test closed-interval line range
+
+ # 4. Dedicated colon-delimited file:line and file:func assertions
+ ddcmd "file a_file.c:1-100 +_" # test file:linerange syntax
+ ddcmd "file b_file.c:30 +_" # test file:exact_line syntax
+ ddcmd "file c_file.c:c_func +_" # test file:function_name syntax
+ ddcmd "file c_file.c:start_* +_" # test file:wildcard_function syntax
+
+ # 5. Advanced formatting and separator checks (side-effect-free proofs)
+ ddcmd "format \"space\\040here\" +_" # test format query with octal escape
+ #ddcmd "module,foo +_" # test comma token separator syntax
+ ddcmd "func *my_func* +_" # test wildcard func syntax
+ ddcmd "file drivers/usb/* +_" # test wildcard file path syntax
+}
+
+# test grammar, no actual sites chosen/changed
+# use dyndbg's embedded comments in queries
+function FT_grammar_errs {
+ v_echo "${GREEN}# GRAMMAR_ERROR_TESTS ${NC}"
+ ddcmd =_
+ local verbose
+
+ # Reset before loop
+ echo 0 > /sys/module/dynamic_debug/parameters/verbose
+
+ # Sequence verbose level 0..3 to verify error diagnostics across all verbosity states!
+ for verbose in 1 2 3; do
+ echo $verbose > /sys/module/dynamic_debug/parameters/verbose
+
+ ddcmd_err 'module foo format "parse +p #! unclosed quote: parse +p'
+
+ # comments in queries tell the error in the logs
+ ddcmd_err "module foo unknown_keyword value #! bad flag-op v, at start of value"
+ ddcmd_err "module foo %pm #! bad flag-op %, at start of %pm"
+ ddcmd_err "module foo +pfmHKDD #! unknown flag 'H'"
+
+ ddcmd_err "w1 w2 w3 w4 w5 w6 w7 w8 w9 w10 w11 w12 w13 w 14 w15 w16 #! too many words, legal max <=15"
+ ddcmd_err "func w2 w3 w4 w5 w6 w7 w8 w9 w10 w11 w12 +p #! unknown keyword \"w3\""
+ ddcmd_err "module foo line =_ #! expecting pairs of match-spec <value>"
+
+ # match-spec duplicate keywords
+ ddcmd_err "func foo func bar =_ #! match-spec:func val:foo overridden by bar"
+ ddcmd_err "file foo.c file bar.c =_ #! match-spec:file val:foo.c overridden by bar.c"
+ ddcmd_err "module foo module baz =_ #! match-spec:module val:foo overridden by baz"
+ ddcmd_err "format foo format bar =_ #! match-spec:format val:foo overridden by bar"
+ ddcmd_err "class D2_CORE class D2_KMS +p #! match-spec:class val:D2_CORE overridden by D2_KMS"
+ ddcmd_err "module foo +x #! unknown flag 'x'"
+
+ # line value errs
+ ddcmd_err "line 10 line 20 +l #! match-spec: line used 2x"
+ ddcmd_err "line 10a +pl #! bad line-number: 10a"
+ ddcmd_err "line 100-10 +pf #! last-line:10 < 1st-line:100"
+
+ # colon-delimited syntax errs
+ ddcmd_err "func foo file bar.c:func_bar =_ #! match-spec:func val:foo overridden by func_bar"
+ ddcmd_err "file bar.c:100-10 +pf #! last-line:10 < 1st-line:100"
+ ddcmd_err "file bar.c:10a +pl #! bad line-number: 10a"
+ ddcmd_err "line 10-20 file bar.c:30 +pl #! match-spec: line used 2x"
+ done
+
+ # Reset to default verbose level 0 at the end of basic errors
+ echo 0 > /sys/module/dynamic_debug/parameters/verbose
+ ddcmd =_
+}
+
+# these queries run against the builtin file: kernel/params.c, and change
+# flags. The control file state-of-interest is found by path $f,
+# perfectly binding the stimulus scope to the observation slice.
+function FT_basic_queries {
+ v_echo "${GREEN}# BASIC_TESTS ${NC}"
+ if [ $LACK_DD_BUILTIN -eq 1 ]; then
+ echo "SKIP - test requires dynamic_debug built into kernel"
+ return
+ fi
+ local f='kernel/params.c'
+ ddcmd =_ # zero everything
+
+ ddcmd "file $f +mf" "$f"
+ ddcmd "file $f +l" "$f"
+ ddcmd "file $f -m" "$f"
+ ddcmd "file $f =_" "$f"
+
+ # multi-query commands split on ; on a single line
+ ddcmd "file $f +mf ; file $f func parse_args +sl" "$f"
+
+ # verify multi-cmd input, newline separated, with embedded comments
+ ddcmd =_ # reset before multiline query to capture full transition
+ ddcmd "file $f =_ # clear params
+ file $f +ml # set flags
+ file $f func parse_args +fs # set other flags" \
+ "$f"
+
+ # clear flags and verify
+ ddcmd "file $f =_" "$f"
+}
+
+# Built-in Feature Tests (Can run on any CONFIG_DYNAMIC_DEBUG kernel, modular or monolithic)
+builtin_tests=(
+ FT_grammar_ok
+ FT_grammar_errs
+ FT_basic_queries
+)
+
+# Modular Feature Tests (Require CONFIG_MODULES=y and test_dynamic_debug*.ko available)
+modular_tests=(
+)
+
+# ==============================================================================
+# GOLDEN_RECORDS (MD5 Fingerprint Verification Database)
+#
+# This database stores the expected invariant log content hashes for our tests.
+# Since the key has the line-number of the callsite, we dont yet
+# support looping over a test-call, maybe we'll need to address that
+# later.
+#
+# NB: records have lineno of the test in code above. table at bottom
+# means inserts dont shift test-lines.
+#
+# ==============================================================================
+function GOLDEN_RECORDS {
+ cat << 'EOF' | {
+#K= b938440930e5f1297d524e6c0c1ec85c FT_grammar_errs.1
+#K= b9a397e807148d13ba07da7db7e69817 FT_grammar_errs.2
+#K= 5abefa504937a329f974504f1896e368 FT_grammar_errs.3
+#K= 1d94d0f239bf40bf51280caeab499de0 FT_grammar_errs.4
+#K= 135035c8a17ae100cc4ec954c4d75b2f FT_grammar_errs.5
+#K= a9cc14244f91a12d3174ad1314144a8e FT_grammar_errs.6
+#K= 5d400aad1a7d71f548b6b81274d00a55 FT_grammar_errs.7
+#K= 61cd359b10f9051862d3745eda07a295 FT_grammar_errs.8
+#K= 567379f4f4d099f00f37d1469d9370bd FT_grammar_errs.9
+#K= 31a026d10f85e8f4c9f8cf3e1cef3c61 FT_grammar_errs.10
+#K= ba62952b671a553d4b14e344a61926f7 FT_grammar_errs.11
+#K= 49aec6c2e99cc70a1e4137f86e94f6f4 FT_grammar_errs.12
+#K= cc02cccf15988a98dfd5b1df1e492e31 FT_grammar_errs.13
+#K= 2bbf3fac2b77b88b6cebe459ff9631d3 FT_grammar_errs.14
+#K= 93b67411c254875a6bae5c01c0239729 FT_grammar_errs.15
+#K= b22f2efe54a1637156b9521b2794806e FT_grammar_errs.16
+#K= de410dba40d8b097524f91da8ae2b1c5 FT_grammar_errs.17
+#K= 6c922048c21f6198720dfd68ae16fdad FT_grammar_errs.18
+#K= 4ddd57e9cbc3da2613ac59eb285ad8c1 FT_grammar_errs.19
+#K= ba65062f6be00a1d04907dd176d26c19 FT_grammar_errs.20
+#K= 94cdf3b32afa4f12a00a704208aa2e53 FT_grammar_errs.21
+#K= 1f6fedfe222af475211b3bfc6d08bc63 FT_grammar_errs.22
+#K= c67dfeca97697b707acdd70672816dff FT_grammar_errs.23
+#K= 9574dbfdac063409b41a44e6251fbcd9 FT_grammar_errs.24
+#K= 644b81753949ac1285e38ac995eeba46 FT_grammar_errs.25
+#K= 1bf2a93a39961f40e0c2dd4c5e2edc6d FT_grammar_errs.26
+#K= cdddf4ffd7fde3c12eb0c73770b872bf FT_grammar_errs.27
+#K= cdf7a2e2740ec007efbd29feda478420 FT_grammar_errs.28
+#K= f6650d69963cef433c50e1f2acb899fc FT_grammar_errs.29
+#K= e150a96693eb561a20eebebfd637e667 FT_grammar_errs.30
+#K= b63514cf73a93962311d098284d7b491 FT_grammar_errs.31
+#K= b253cde723889c42d2c944c1b14f5a45 FT_grammar_errs.32
+#K= 7ad3dfb73e82f4d75b0770179e6dc264 FT_grammar_errs.33
+#K= f4d905e4f72dbd535bb80d7fe9df84b0 FT_grammar_errs.34
+#K= 5bf50b198d8e5fe300541adfce92e073 FT_grammar_errs.35
+#K= 7c4d73d42cff377cd84a7683b0c3e0b9 FT_grammar_errs.36
+#K= 19f1aa8d33d71888be74b19a3143938f FT_grammar_errs.37
+#K= 84309c1322631ae74ecf2c729b6aa210 FT_grammar_errs.38
+#K= 8cfe48871f91a90e6eaaef9123892394 FT_grammar_errs.39
+#K= 8aaa5fdd50ead5cd429fbba4123b215c FT_grammar_errs.40
+#K= 94cdf3b32afa4f12a00a704208aa2e53 FT_grammar_errs.41
+#K= 1a402ada248d0d50cec13a1af150ea33 FT_grammar_errs.42
+#K= 5b46a8eb0d74009462f74cf7553e3228 FT_grammar_errs.43
+#K= 546e440044828d86135dd63f1eb9ed17 FT_grammar_errs.44
+#K= 644b81753949ac1285e38ac995eeba46 FT_grammar_errs.45
+#K= 1bf2a93a39961f40e0c2dd4c5e2edc6d FT_grammar_errs.46
+#K= 3e3acfb800cfb1bcb0cc07f33b75830a FT_grammar_errs.47
+#K= 42dc6cb4fe938bb82b64c82924ef28d8 FT_grammar_errs.48
+#K= cf9320d2188f5b48d508d610d95298b2 FT_grammar_errs.49
+#K= 1f33fb1fd2365e77c3cfbd61d1ae2a7c FT_grammar_errs.50
+#K= 67588c71f92f319c6224d5917456ecd2 FT_grammar_errs.51
+#K= 22e7795f7dbeb6dc2fce5e113312781c FT_grammar_errs.52
+#K= 66d253407728c1f8a850519eadd66880 FT_grammar_errs.53
+#K= 27e8345aaeed85c1de5516871e0bbd0c FT_grammar_errs.54
+#K= 43cc8a154f28f1a668ab409a1af4e77a FT_grammar_errs.55
+#K= eda21551fcdd76ef2f192e1d9950a05f FT_grammar_errs.56
+#K= 0a8a986b5610630cb75c0568deff8315 FT_grammar_errs.57
+#K= 29bfae73351c3157a5fe409febcef276 FT_grammar_errs.58
+#K= 73a9e53428d1fb1a9813e3eab7d0ea18 FT_grammar_errs.59
+#K= 800951095b297532e25785ab101a2ba9 FT_grammar_errs.60
+#K= 6e8599556a312200fb6d484565b6c52f FT_basic_queries.1
+#K= db17180b59444e5e34a8fc20c40e4530 FT_basic_queries.2
+#K= f7bd56bd407ff255ef2e3b5fb093ae6a FT_basic_queries.3
+#K= 4ce44468b3b5f80ae42ade1f261b952f FT_basic_queries.4
+#K= 02e4fd94602e108cb89bfc70d47a5dad FT_basic_queries.5
+#K= f03a7ca7316e8db4c0e16523dc41e75d FT_basic_queries.6
+#K= c518a50ba30ba8099d0dc874a27ecf16 FT_basic_queries.7
+EOF
+ # Read the K-recs and skip those for tests that can't run
+ while read -r line; do
+ # Filter built-in if needed
+ if [ "${LACK_DD_BUILTIN:-0}" -eq 1 ]; then
+ # Extract label (3rd field) from #K= line
+ local label=$(echo "$line" | awk '{print $3}')
+ if [[ "$label" == FT_basic_queries* \
+ || "$label" == FT_comma_terminators* \
+ || "$label" == FT_multi_query* ]]; then
+ continue
+ fi
+ fi
+ # Filter modular if needed
+ if [ "${LACK_TMOD:-0}" -eq 1 ]; then
+ # Extract label (3rd field) from #K= line
+ local label=$(echo "$line" | awk '{print $3}')
+ if [[ "$label" == FT_test_classes* \
+ || "$label" == FT_classmap_inheritance* \
+ || "$label" == FT_modprobe_w_param* ]]; then
+ continue
+ fi
+ fi
+ echo "$line"
+ done
+ }
+}
+
+# ==============================================================================
+# Run tests
+
+# Clear any stale seen/unregistered/drifted hashes from previous runs
+: > "$SEEN_HASHES_FILE"
+: > "$UNREG_HASHES_FILE"
+: > "$DRIFT_HASHES_FILE"
+
+ifrmmod test_dynamic_debug
+
+# Check if loadable module support or our test modules are missing/builtin
+LACK_TMOD=0
+if [ -d "/sys/module/test_dynamic_debug" ]; then
+ # If module is present but not in /proc/modules,
+ # it is a builtin module (cannot unload/reload)
+ if ! grep -q "^test_dynamic_debug " /proc/modules 2>/dev/null; then
+ LACK_TMOD=1
+ fi
+else
+ # Check if we can modprobe it from disk
+ modprobe -q -n test_dynamic_debug || LACK_TMOD=1
+fi
+
+# 1. Run all Built-in Feature Tests
+v_echo "${GREEN}# RUNNING BUILT-IN FEATURE TESTS ${NC}"
+for test_func in "${builtin_tests[@]}"; do
+ $test_func
+ v_echo ""
+done
+
+# 2. Run Modular Feature Tests only if test modules are available
+if [ $LACK_TMOD -eq 0 ]; then
+ v_echo "${GREEN}# RUNNING MODULAR FEATURE TESTS ${NC}"
+ for test_func in "${modular_tests[@]}"; do
+ $test_func
+ v_echo ""
+ done
+else
+ v_echo "${YELLOW}# SKIPPING MODULAR TESTS: test_dynamic_debug.ko not available ${NC}"
+fi
+
+if [ "$V" -ge 1 ]; then
+ echo -en "${GREEN}# Done on: "
+ date
+ echo -en "${NC}"
+fi
+
+audit_golden_records
+
+# Output consolidated blocks of unregistered and drifted fingerprints
+failed=0
+
+if [ -s "$UNREG_HASHES_FILE" ]; then
+ if [ "$K" -ne 2 ]; then
+ echo -e "${YELLOW}\n# --- Unregistered Baselines ---"
+ cat "$UNREG_HASHES_FILE"
+ echo -e "# ------------------------------${NC}"
+ fi
+ : > "$UNREG_HASHES_FILE"
+ failed=1
+fi
+
+if [ -s "$DRIFT_HASHES_FILE" ]; then
+ if [ "$K" -ne 2 ]; then
+ echo -e "${RED}\n# --- Drifted Baselines ---"
+ cat "$DRIFT_HASHES_FILE"
+ echo -e "# -------------------------${NC}"
+ fi
+ : > "$DRIFT_HASHES_FILE"
+ failed=1
+fi
+
+if [ $failed -eq 1 ]; then
+ [ "$K" -eq 1 ] && echo "fake success" && exit $ksft_pass
+ [ "$K" -eq 2 ] && exit $ksft_pass
+ exit $ksft_fail
+fi
+
+exit $ksft_pass
+
diff --git a/tools/testing/selftests/dynamic_debug/syslog_hash_validation.sh b/tools/testing/selftests/dynamic_debug/syslog_hash_validation.sh
new file mode 100644
index 000000000000..8c6e91f5d9c2
--- /dev/null
+++ b/tools/testing/selftests/dynamic_debug/syslog_hash_validation.sh
@@ -0,0 +1,393 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-2.0-only
+#
+# Generic, zero-dependency syslog and file-slicing verification helper library.
+#
+# Provides 2 validation mechanisms:
+# 1. Spatial Control-File Slicing (State Checks & Transitions):
+# - verify_file_slice: Hashes module state in /proc/.../control.
+# - capture_before / verify_after_change: Hashes normalized diff between
+# pre- and post-stimulus states. Strips line numbers and hunk headers,
+# making the hash immune to upstream line churn in C source files.
+# 2. Temporal Syslog Slicing (Workload Logging Checks):
+# - log_start / log_stop / verify_dmesg_slice: Emits bookend markers to
+# /dev/kmsg, slicing exact dmesg prints produced during a workload while
+# stripping multi-bracket timestamp/CPU/PID headers.
+
+# Default APP to DYNDBG if not already set
+APP="${APP:-DYNDBG}"
+APP_LOWER=$(echo "$APP" | tr '[:upper:]' '[:lower:]')
+
+# Global files for tracking seen, unregistered, and drifted hashes securely via mktemp
+SEEN_HASHES_FILE=$(mktemp -t "${APP_LOWER}_seen_hashes.XXXXXX")
+UNREG_HASHES_FILE=$(mktemp -t "${APP_LOWER}_unreg_hashes.XXXXXX")
+DRIFT_HASHES_FILE=$(mktemp -t "${APP_LOWER}_drift_hashes.XXXXXX")
+
+# Secure trap handler to clean up temp files on exit or interrupt
+trap 'rm -f "$SEEN_HASHES_FILE" "$UNREG_HASHES_FILE" "$DRIFT_HASHES_FILE"' EXIT INT TERM HUP
+
+# Global variables for tracking active function transitions and sequence resets
+LAST_FT_FUNC=""
+TEST_SEQ_CTR=0
+ACTIVE_RESOLVED_LABEL=""
+
+# Global variables for bookending state transitions and local stimulus tracking
+IN_BOOKEND=0
+DDCMD_LOG=""
+
+# Global variable to track the active dmesg block label
+ACTIVE_LOG_LABEL=""
+
+# Helper function to auto-resolve active FT_ test and sequence label
+function rdi_resolve_label {
+ local caller_fn=""
+ # Traverse the call stack to find the active Feature Test function (FT_*)
+ for fn in "${FUNCNAME[@]}"; do
+ if [[ "$fn" == FT_* ]]; then
+ caller_fn="$fn"
+ break
+ fi
+ done
+
+ # Fallback to the immediate caller if no FT_ is in the stack
+ if [ -z "$caller_fn" ]; then
+ caller_fn="${FUNCNAME[1]:-}"
+ fi
+
+ # Automatically reset sequence counter if the executing function has transitioned
+ if [ -n "$caller_fn" ] && [ "$caller_fn" != "$LAST_FT_FUNC" ]; then
+ TEST_SEQ_CTR=1
+ LAST_FT_FUNC="$caller_fn"
+ fi
+
+ if [ -n "$caller_fn" ]; then
+ ACTIVE_RESOLVED_LABEL="${caller_fn}.${TEST_SEQ_CTR}"
+ else
+ ACTIVE_RESOLVED_LABEL="${TEST_SEQ_CTR}"
+ fi
+}
+
+function log_start {
+ ((TEST_SEQ_CTR++))
+
+ rdi_resolve_label
+ ACTIVE_LOG_LABEL="$ACTIVE_RESOLVED_LABEL"
+
+ IN_BOOKEND=1
+
+ echo "${APP}_START_${ACTIVE_LOG_LABEL}_$$" > /dev/kmsg
+}
+
+function log_stop {
+ # Ends the dmesg capture block and verifies the slice
+ if [ -z "$ACTIVE_LOG_LABEL" ]; then
+ echo "Error: log_stop called without a matching log_start!" >&2
+ return 1
+ fi
+
+ echo "${APP}_END_${ACTIVE_LOG_LABEL}_$$" > /dev/kmsg
+
+ # Verify the dmesg slice
+ verify_dmesg_slice "$ACTIVE_LOG_LABEL"
+
+ # Reset active state, bookend flag, and command tracker at teardown
+ ACTIVE_LOG_LABEL=""
+ IN_BOOKEND=0
+ DDCMD_LOG=""
+}
+
+function verify_fingerprint {
+ # Verifies a calculated fingerprint against the GOLDEN_RECORDS database
+ # $1 - unique test key (e.g. normal_513)
+ # $2 - the calculated fingerprint hash to verify
+ # $3 - description of what was captured (e.g. "Dmesg Log" or "File Slice")
+ # $4 - the raw captured text block (to display in case of mismatch)
+
+ local label="$1"
+ local fingerprint="$2"
+ local capture_desc="$3"
+ local raw_capture="$4"
+
+ # Require GOLDEN_RECORDS to be defined in the caller script
+ if ! declare -f GOLDEN_RECORDS >/dev/null; then
+ echo "Error: GOLDEN_RECORDS() is not defined in the caller script." >&2
+ return 1
+ fi
+
+ # Resolve the expected hash specifically for this label
+ local expected_hash_field
+ expected_hash_field=$(GOLDEN_RECORDS | \
+ grep -E "[[:space:]]${label}([[:space:]]|$)" | head -n1 | awk '{print $2}')
+
+ local matched=0
+ local h
+ local OLD_IFS="$IFS"
+ IFS=","
+ for h in $expected_hash_field; do
+ if [ "$h" = "$fingerprint" ]; then
+ matched=1
+ break
+ fi
+ done
+ IFS="$OLD_IFS"
+
+ # Strictly verify that the computed fingerprint matches any
+ # expected hash for this label
+ if [ -n "$expected_hash_field" ] && [ $matched -eq 1 ]; then
+ local short_hash="${fingerprint:0:12}"
+ [ "$V" -ge 1 ] && echo -e "${GREEN}✔ Verified '${label}' " \
+ "(${short_hash}) [via: '${DDCMD_LOG}']${NC}"
+
+ if [ "$V" -ge 2 ]; then
+ echo -e "${CYAN}--- Captured Invariant ${capture_desc} Output ($label) ---"
+ printf "#K= %-32s %-24s\n" "${fingerprint}" "${label}"
+ echo "$raw_capture"
+ echo -e "-----------------------------------${NC}"
+ fi
+ echo "$fingerprint" >> "$SEEN_HASHES_FILE"
+ else
+ # Failure path: display mismatch and append to corrections
+ local status_str="UNREGISTERED"
+ local stimulus="${DDCMD_LOG:-direct write to control}"
+ if [ -n "$expected_hash_field" ]; then
+ local short_expected="${expected_hash_field:0:12}"
+ local short_got="${fingerprint:0:12}"
+ if [ "${K:-0}" -ne 2 ]; then
+ echo -e "${RED}: DRIFT for '${label}'${NC}"
+ echo -e " Stimulus: ${stimulus}"
+ echo -e " Expected: '${short_expected}' (${expected_hash_field})"
+ echo -e " Got: '${short_got}' (${fingerprint})${NC}"
+ fi
+ status_str="DRIFTED"
+ else
+ if [ "${K:-0}" -ne 2 ]; then
+ echo -e "${YELLOW}: NO RECORD for '${label}'${NC}"
+ echo -e " Stimulus: ${stimulus}${NC}"
+ fi
+ fi
+
+ if [ "${K:-0}" -ne 2 ]; then
+ echo -e "\nAdd or replace this line in GOLDEN_RECORDS():"
+ printf "#K= %-32s %-24s\n" "${fingerprint}" "${label}"
+ echo -e "\n--- Captured Invariant ${capture_desc} Output ---"
+ if [ "$capture_desc" = "File Slice" ]; then
+ echo "$raw_capture" | \
+ sed -E "s/ =([_a-z]*[a-z][_a-z]*) / ${YELLOW}=\1${NC} /g"
+ else
+ echo "$raw_capture"
+ fi
+ echo -e "-----------------------------------${NC}"
+ fi
+
+ if [ "$status_str" = "DRIFTED" ]; then
+ printf "#K= %-32s %s\n" \
+ "${fingerprint}" "${label}" \
+ >> "$DRIFT_HASHES_FILE"
+ else
+ printf "#K= %-32s %s\n" \
+ "${fingerprint}" "${label}" \
+ >> "$UNREG_HASHES_FILE"
+ fi
+ fi
+}
+
+function verify_dmesg_slice {
+ # Slices dmesg, computes its hash, and verifies it against the database.
+ # $1 - unique test key (e.g. normal_513)
+ # $2 - optional start marker (defaults to ${APP}_START_${label})
+ # $3 - optional end marker (defaults to ${APP}_END_${label})
+
+ local label="$1"
+ local app="${APP:-DYNDBG}"
+ local start_marker="${2:-${app}_START_${label}_$$}"
+ local end_marker="${3:-${app}_END_${label}_$$}"
+
+ # 1. Capture the log slice (exactly once!)
+ local log_slice=$(dmesg | sed -n "/$start_marker/,/$end_marker/p" | \
+ grep -E -v "$start_marker|$end_marker" | \
+ sed -E -e 's/^(\[[^]]*\][[:space:]]*)+//' )
+
+ # 2. Compute its fingerprint
+ local fingerprint=$(echo "$log_slice" | tr -d '\r' | md5sum | cut -d' ' -f1)
+
+ # 3. Verify
+ verify_fingerprint "$label" "$fingerprint" "Dmesg Log" "$log_slice"
+}
+
+function strip_control_linenos {
+ # Normalizes 'filename:123' to 'filename:0' for /proc/dynamic_debug/control output
+ sed -E 's/^([^:]+):[0-9]+/\1:0/'
+}
+
+function slice_by_grep {
+ # Isolate lines matching a pattern from a file
+ # $1 - pattern to grep (returns entire file if empty or "*")
+ # $2 - file path (reads $CONTROL_FILE if not provided)
+ local pattern="$1"
+ local file_path="${2:-$CONTROL_FILE}"
+
+ if [ -z "$pattern" ] || [ "$pattern" = "*" ]; then
+ cat "$file_path"
+ else
+ grep "$pattern" "$file_path"
+ fi
+}
+
+function verify_file_slice {
+ # Captures a file slice by pattern, computes its hash,
+ # and verifies it against the database.
+ # $1 - pattern to slice
+ # $2 - optional file path (defaults to $CONTROL_FILE)
+
+ local pattern="$1"
+ local file="${2:-$CONTROL_FILE}"
+
+ # Always auto-resolve label via call stack sequence resets!
+ ((TEST_SEQ_CTR++))
+ rdi_resolve_label
+ local label="$ACTIVE_RESOLVED_LABEL"
+
+ # 1. Capture the file slice (exactly once!)
+ local slice=$(slice_by_grep "$pattern" "$file")
+ if [ "$file" = "$CONTROL_FILE" ]; then
+ slice=$(echo "$slice" | strip_control_linenos)
+ fi
+
+ # 2. Compute its fingerprint
+ local fingerprint=$(echo "$slice" | tr -d '\r' | md5sum | cut -d' ' -f1)
+
+ # 3. Verify
+ verify_fingerprint "$label" "$fingerprint" "File Slice" "$slice"
+
+ # Reset state, bookend flag, and command tracker at teardown
+ IN_BOOKEND=0
+ DDCMD_LOG=""
+}
+
+# Global variables for bookending state transitions
+BEFORE_CAPTURE_SLICE=""
+BEFORE_CAPTURE_PATTERN=""
+BEFORE_CAPTURE_FILE=""
+
+function capture_before {
+ # Captures and stores the 'before' state for a file slice transition
+ # $1 - pattern to slice
+ # $2 - optional file path (defaults to $CONTROL_FILE)
+
+ BEFORE_CAPTURE_PATTERN="$1"
+ BEFORE_CAPTURE_FILE="${2:-$CONTROL_FILE}"
+ BEFORE_CAPTURE_SLICE=$(slice_by_grep "$BEFORE_CAPTURE_PATTERN" "$BEFORE_CAPTURE_FILE")
+ if [ "$BEFORE_CAPTURE_FILE" = "$CONTROL_FILE" ]; then
+ BEFORE_CAPTURE_SLICE=$(echo "$BEFORE_CAPTURE_SLICE" | strip_control_linenos)
+ fi
+
+ IN_BOOKEND=1
+}
+
+function verify_after_change {
+ # Verifies the transition between the stored 'before' state and the current state
+ # $1 - optional unique test key (resolved via stack if empty)
+
+ local label="$1"
+
+ if [ -z "$label" ]; then
+ ((TEST_SEQ_CTR++))
+ rdi_resolve_label
+ label="$ACTIVE_RESOLVED_LABEL"
+ fi
+
+ if [ -z "$BEFORE_CAPTURE_PATTERN" ]; then
+ echo "Error: verify_after_change called without a matching capture_before!" >&2
+ return 1
+ fi
+
+ # 1. Capture the 'after' state (exactly once!)
+ local after_slice=$(slice_by_grep "$BEFORE_CAPTURE_PATTERN" "$BEFORE_CAPTURE_FILE")
+ if [ "$BEFORE_CAPTURE_FILE" = "$CONTROL_FILE" ]; then
+ after_slice=$(echo "$after_slice" | strip_control_linenos)
+ fi
+
+ # 2. Generate the unified diff, stripped of volatile diff headers AND hunk line-numbers
+ local transition_diff=$(diff -u <(echo "$BEFORE_CAPTURE_SLICE") <(echo "$after_slice") | \
+ tail -n +3 | \
+ sed -E 's/^@@ -[0-9]+.* \+[0-9]+.* @@/@@/g')
+
+ # 3. Compute its fingerprint
+ local fingerprint=$(echo "$transition_diff" | tr -d '\r' | md5sum | cut -d' ' -f1)
+
+ # 4. Verify the diff as the captured text block
+ verify_fingerprint "$label" "$fingerprint" "File Change Diff" "$transition_diff"
+
+ # Reset state, bookend flag, and command tracker at teardown
+ BEFORE_CAPTURE_SLICE=""
+ BEFORE_CAPTURE_PATTERN=""
+ BEFORE_CAPTURE_FILE=""
+ IN_BOOKEND=0
+ DDCMD_LOG=""
+}
+
+function audit_golden_records {
+ local seen_file="$SEEN_HASHES_FILE"
+
+ if [ ! -f "$seen_file" ]; then
+ return
+ fi
+
+ # Require GOLDEN_RECORDS to be defined in the caller script
+ if ! declare -f GOLDEN_RECORDS >/dev/null; then
+ return
+ fi
+
+ [ "${V:-0}" -ge 1 ] && echo -e "${YELLOW}# --- GOLDEN_RECORDS Audit ---${NC}"
+ local stale_found=0
+ local total_records=$(GOLDEN_RECORDS | grep -c "^#K=")
+
+ # Read each active record line from GOLDEN_RECORDS
+ while read -r line; do
+ # Extract the hash/hashes (second word) from the #K= line
+ local hash_field=$(echo "$line" | awk '{print $2}')
+
+ # Check if at least one of the comma-separated hashes was seen
+ local hash_seen=0
+ local h
+ local OLD_IFS="$IFS"
+ IFS=","
+ for h in $hash_field; do
+ if grep -q "$h" "$seen_file" 2>/dev/null; then
+ hash_seen=1
+ break
+ fi
+ done
+ IFS="$OLD_IFS"
+
+ # Check if this hash field was seen during the run
+ if [ $hash_seen -eq 0 ]; then
+ if [ "${K:-0}" -ne 2 ]; then
+ if [ $stale_found -eq 0 ]; then
+ # On first failure, print header if not already printed
+ [ "${V:-0}" -eq 0 ] && \
+ echo -e "${YELLOW}# --- GOLDEN_RECORDS Audit ---${NC}"
+ echo -e "${YELLOW}# The following GOLDEN_RECORDS entries " \
+ "were never hit and may be stale:${NC}"
+ fi
+ echo -e "${YELLOW}#K_STALE= $line${NC}"
+ fi
+ stale_found=1
+ fi
+ done < <(GOLDEN_RECORDS | grep "^#K=" | grep -v "<md5_hash>")
+
+ if [ $stale_found -eq 0 ] && [ "${V:-0}" -ge 1 ]; then
+ echo -e "${GREEN}# All $total_records GOLDEN_RECORDS entries " \
+ "were successfully hit!${NC}"
+ fi
+
+ # Detect duplicate labels in the database
+ local dupes=$(GOLDEN_RECORDS | grep "^#K=" | awk '{print $3}' | sort | uniq -d)
+ if [ -n "$dupes" ]; then
+ echo -e "\n${RED}# WARNING: Duplicate labels detected in GOLDEN_RECORDS():${NC}"
+ echo "$dupes" | sed 's/^/# /'
+ fi
+
+ # Clean up
+ rm -f "$seen_file"
+}
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 02/40] vmlinux.lds.h: refactor BOUNDED_SECTION_* macros into bounded_sections.lds.h
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
2026-10-13 2:36 ` [PATCH v12 01/40] selftests/dyndbg: Add kselftest script to verify dynamic-debug Jim Cromie via B4 Relay
@ 2026-10-13 2:36 ` Jim Cromie via B4 Relay
2026-10-13 2:36 ` [PATCH v12 03/40] vmlinux.lds.h: drop unused HEADERED_SECTION* macros Jim Cromie via B4 Relay
` (37 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:36 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie
From: Jim Cromie <jim.cromie@gmail.com>
Move BOUNDED_SECTION_* macros to a new helper file:
include/asm-generic/bounded_sections.lds.h and include it back into
vmlinux.lds.h. This allows its reuse later to fix a failure to keep
dyndbg sections in some circumstances.
NOTES:
These macros are only for use in vmlinux.lds.h, where the _start &
_end symbols are needed. Modules keep sections separate in ELF
sections, with their boundaries known, so the _start and _end are not
useful, and may confuse tools not expecting them.
This patch ignores a checkpatch warning, because new file is covered
by "GENERIC INCLUDE/ASM HEADER FILES" in MAINTAINERS
CC: Arnd Bergmann <arnd@arndb.de>
CC: linux-arch@vger.kernel.org
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
v3: move include to top
---
include/asm-generic/bounded_sections.lds.h | 36 ++++++++++++++++++++++++++++++
include/asm-generic/vmlinux.lds.h | 31 +------------------------
2 files changed, 37 insertions(+), 30 deletions(-)
diff --git a/include/asm-generic/bounded_sections.lds.h b/include/asm-generic/bounded_sections.lds.h
new file mode 100644
index 000000000000..8c29293ca7fb
--- /dev/null
+++ b/include/asm-generic/bounded_sections.lds.h
@@ -0,0 +1,36 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#ifndef _ASM_GENERIC_BOUNDED_SECTIONS_H
+#define _ASM_GENERIC_BOUNDED_SECTIONS_H
+
+#define BOUNDED_SECTION_PRE_LABEL(_sec_, _label_, _BEGIN_, _END_) \
+ _BEGIN_##_label_ = .; \
+ KEEP(*(_sec_)) \
+ _END_##_label_ = .;
+
+#define BOUNDED_SECTION_POST_LABEL(_sec_, _label_, _BEGIN_, _END_) \
+ _label_##_BEGIN_ = .; \
+ KEEP(*(_sec_)) \
+ _label_##_END_ = .;
+
+#define BOUNDED_SECTION_BY(_sec_, _label_) \
+ BOUNDED_SECTION_PRE_LABEL(_sec_, _label_, __start, __stop)
+
+#define BOUNDED_SECTION(_sec) BOUNDED_SECTION_BY(_sec, _sec)
+
+#define HEADERED_SECTION_PRE_LABEL(_sec_, _label_, _BEGIN_, _END_, _HDR_) \
+ _HDR_##_label_ = .; \
+ KEEP(*(.gnu.linkonce.##_sec_)) \
+ BOUNDED_SECTION_PRE_LABEL(_sec_, _label_, _BEGIN_, _END_)
+
+#define HEADERED_SECTION_POST_LABEL(_sec_, _label_, _BEGIN_, _END_, _HDR_) \
+ _label_##_HDR_ = .; \
+ KEEP(*(.gnu.linkonce.##_sec_)) \
+ BOUNDED_SECTION_POST_LABEL(_sec_, _label_, _BEGIN_, _END_)
+
+#define HEADERED_SECTION_BY(_sec_, _label_) \
+ HEADERED_SECTION_PRE_LABEL(_sec_, _label_, __start, __stop)
+
+#define HEADERED_SECTION(_sec) HEADERED_SECTION_BY(_sec, _sec)
+
+#endif /* _ASM_GENERIC_BOUNDED_SECTIONS_H */
diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
index b2988aa12f66..b4ece391f7b1 100644
--- a/include/asm-generic/vmlinux.lds.h
+++ b/include/asm-generic/vmlinux.lds.h
@@ -50,6 +50,7 @@
* [__nosave_begin, __nosave_end] for the nosave data
*/
+#include <asm-generic/bounded_sections.lds.h>
#include <asm-generic/codetag.lds.h>
#ifndef LOAD_OFFSET
@@ -211,36 +212,6 @@
# endif
#endif
-#define BOUNDED_SECTION_PRE_LABEL(_sec_, _label_, _BEGIN_, _END_) \
- _BEGIN_##_label_ = .; \
- KEEP(*(_sec_)) \
- _END_##_label_ = .;
-
-#define BOUNDED_SECTION_POST_LABEL(_sec_, _label_, _BEGIN_, _END_) \
- _label_##_BEGIN_ = .; \
- KEEP(*(_sec_)) \
- _label_##_END_ = .;
-
-#define BOUNDED_SECTION_BY(_sec_, _label_) \
- BOUNDED_SECTION_PRE_LABEL(_sec_, _label_, __start, __stop)
-
-#define BOUNDED_SECTION(_sec) BOUNDED_SECTION_BY(_sec, _sec)
-
-#define HEADERED_SECTION_PRE_LABEL(_sec_, _label_, _BEGIN_, _END_, _HDR_) \
- _HDR_##_label_ = .; \
- KEEP(*(.gnu.linkonce.##_sec_)) \
- BOUNDED_SECTION_PRE_LABEL(_sec_, _label_, _BEGIN_, _END_)
-
-#define HEADERED_SECTION_POST_LABEL(_sec_, _label_, _BEGIN_, _END_, _HDR_) \
- _label_##_HDR_ = .; \
- KEEP(*(.gnu.linkonce.##_sec_)) \
- BOUNDED_SECTION_POST_LABEL(_sec_, _label_, _BEGIN_, _END_)
-
-#define HEADERED_SECTION_BY(_sec_, _label_) \
- HEADERED_SECTION_PRE_LABEL(_sec_, _label_, __start, __stop)
-
-#define HEADERED_SECTION(_sec) HEADERED_SECTION_BY(_sec, _sec)
-
#ifdef CONFIG_TRACE_BRANCH_PROFILING
#define LIKELY_PROFILE() \
BOUNDED_SECTION_BY(_ftrace_annotated_branch, _annotated_branch_profile)
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 03/40] vmlinux.lds.h: drop unused HEADERED_SECTION* macros
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
2026-10-13 2:36 ` [PATCH v12 01/40] selftests/dyndbg: Add kselftest script to verify dynamic-debug Jim Cromie via B4 Relay
2026-10-13 2:36 ` [PATCH v12 02/40] vmlinux.lds.h: refactor BOUNDED_SECTION_* macros into bounded_sections.lds.h Jim Cromie via B4 Relay
@ 2026-10-13 2:36 ` Jim Cromie via B4 Relay
2026-10-13 2:36 ` [PATCH v12 04/40] vmlinux.lds.h: Fix ALIGN(8) omission causing NULL ptr on i386 Jim Cromie via B4 Relay
` (36 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:36 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie
From: Jim Cromie <jim.cromie@gmail.com>
These macros are unused, no point in carrying them any more.
NB: these macros were just moved to bounded_sections.lds.h, from
vmlinux.lds.h, which is the known entity, and therefore more
meaningful in the 1-line summary, so thats what I used as the topic.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
include/asm-generic/bounded_sections.lds.h | 15 ---------------
1 file changed, 15 deletions(-)
diff --git a/include/asm-generic/bounded_sections.lds.h b/include/asm-generic/bounded_sections.lds.h
index 8c29293ca7fb..268cdc34389b 100644
--- a/include/asm-generic/bounded_sections.lds.h
+++ b/include/asm-generic/bounded_sections.lds.h
@@ -18,19 +18,4 @@
#define BOUNDED_SECTION(_sec) BOUNDED_SECTION_BY(_sec, _sec)
-#define HEADERED_SECTION_PRE_LABEL(_sec_, _label_, _BEGIN_, _END_, _HDR_) \
- _HDR_##_label_ = .; \
- KEEP(*(.gnu.linkonce.##_sec_)) \
- BOUNDED_SECTION_PRE_LABEL(_sec_, _label_, _BEGIN_, _END_)
-
-#define HEADERED_SECTION_POST_LABEL(_sec_, _label_, _BEGIN_, _END_, _HDR_) \
- _label_##_HDR_ = .; \
- KEEP(*(.gnu.linkonce.##_sec_)) \
- BOUNDED_SECTION_POST_LABEL(_sec_, _label_, _BEGIN_, _END_)
-
-#define HEADERED_SECTION_BY(_sec_, _label_) \
- HEADERED_SECTION_PRE_LABEL(_sec_, _label_, __start, __stop)
-
-#define HEADERED_SECTION(_sec) HEADERED_SECTION_BY(_sec, _sec)
-
#endif /* _ASM_GENERIC_BOUNDED_SECTIONS_H */
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 04/40] vmlinux.lds.h: Fix ALIGN(8) omission causing NULL ptr on i386
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (2 preceding siblings ...)
2026-10-13 2:36 ` [PATCH v12 03/40] vmlinux.lds.h: drop unused HEADERED_SECTION* macros Jim Cromie via B4 Relay
@ 2026-10-13 2:36 ` Jim Cromie via B4 Relay
2026-10-13 2:36 ` [PATCH v12 05/40] vmlinux.lds.h: remove redundant ALIGN(8) directives Jim Cromie via B4 Relay
` (35 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:36 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie,
Louis Chauvet
From: Jim Cromie <jim.cromie@gmail.com>
Almost all uses of the BOUNDED_SECTION macros are ALIGN(8), either
explicitly, or by being below an aligned section containing x*8 byte
objects. The noteworthy exception is BOUNDED_SECTION(__dyndbg), which
immediately follows BOUNDED_SECTION(__dyndbg_classes).
On i386, struct _ddebug_classmap is 28 bytes, so without an explicit
ALIGN(8) in the macro, the following __dyndbg section gets misaligned,
causing a NULL ptr deref in dynamic_debug_init().
So fix this with an explicit ALIGN(8) in the existing BOUNDED_SECTION
macros, and introduce _ALIGNED variants to handle the cases with an
explicit . = ALIGN(x)
Also add explicit alignments for: EXCEPTION_TABLE, ORC_UNWIND_TABLE,
TRACEDATA, INIT_SETUP, and NOTES.
update BOUNDED_SECTION uses inside . = ALIGN(x) stanzas to use
_ALIGNED variants, but keep the outer ALIGNs so the symbols between
them are not "re-aligned".
In particular, scripts/sorttable.c does not tolerate sloppy padding.
At the top of ORC_UNWIND_TABLE, add . = ALIGN(4) to match the struct
orc_header __align() call in the code:
commit b9f174c811e3 ("x86/unwind/orc: Add ELF section with ORC version identifier")
Suggested-by: Louis Chauvet <louis.chauvet@bootlin.com> # _ALIGNED variants.
Link: https://lore.kernel.org/lkml/177402491426.6181.12855763650074831089.b4-review@b4/
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
v3:
sashiko complained about NOTES and .BTF_ids.
gemini asserts that NOTES are natively 4-byte aligned, add comment repeating it.
.BTF_ids doesnt use BOUNDED_BY, since start/end isnt needed;
sashiko evidently got confused by immediately preceding usage.
v2:
sashiko picked up 2 cases, added to the explicit list above
https://sashiko.dev/#/patchset/20260515-asm-generic-1-v3-0-680b273666d4%40gmail.com
---
include/asm-generic/bounded_sections.lds.h | 17 ++++++++++++++---
include/asm-generic/vmlinux.lds.h | 18 ++++++++++--------
2 files changed, 24 insertions(+), 11 deletions(-)
diff --git a/include/asm-generic/bounded_sections.lds.h b/include/asm-generic/bounded_sections.lds.h
index 268cdc34389b..8ff3e3420f60 100644
--- a/include/asm-generic/bounded_sections.lds.h
+++ b/include/asm-generic/bounded_sections.lds.h
@@ -3,19 +3,30 @@
#ifndef _ASM_GENERIC_BOUNDED_SECTIONS_H
#define _ASM_GENERIC_BOUNDED_SECTIONS_H
-#define BOUNDED_SECTION_PRE_LABEL(_sec_, _label_, _BEGIN_, _END_) \
+#define BOUNDED_SECTION_PRE_LABEL_ALIGNED(_sec_, _label_, _BEGIN_, _END_, _ALIGNED_) \
+ . = ALIGN(_ALIGNED_); \
_BEGIN_##_label_ = .; \
KEEP(*(_sec_)) \
_END_##_label_ = .;
-#define BOUNDED_SECTION_POST_LABEL(_sec_, _label_, _BEGIN_, _END_) \
+#define BOUNDED_SECTION_PRE_LABEL(_sec_, _label_, _BEGIN_, _END_) \
+ BOUNDED_SECTION_PRE_LABEL_ALIGNED(_sec_, _label_, _BEGIN_, _END_, 8)
+
+#define BOUNDED_SECTION_POST_LABEL_ALIGNED(_sec_, _label_, _BEGIN_, _END_, _ALIGNED_) \
+ . = ALIGN(_ALIGNED_); \
_label_##_BEGIN_ = .; \
KEEP(*(_sec_)) \
_label_##_END_ = .;
+#define BOUNDED_SECTION_POST_LABEL(_sec_, _label_, _BEGIN_, _END_) \
+ BOUNDED_SECTION_POST_LABEL_ALIGNED(_sec_, _label_, _BEGIN_, _END_, 8)
+
#define BOUNDED_SECTION_BY(_sec_, _label_) \
BOUNDED_SECTION_PRE_LABEL(_sec_, _label_, __start, __stop)
-#define BOUNDED_SECTION(_sec) BOUNDED_SECTION_BY(_sec, _sec)
+#define BOUNDED_SECTION_BY_ALIGNED(_sec_, _label_, _ALIGNED_) \
+ BOUNDED_SECTION_PRE_LABEL_ALIGNED(_sec_, _label_, __start, __stop, _ALIGNED_)
+
+#define BOUNDED_SECTION(_sec) BOUNDED_SECTION_BY(_sec, _sec)
#endif /* _ASM_GENERIC_BOUNDED_SECTIONS_H */
diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
index b4ece391f7b1..b1a69f8af6d2 100644
--- a/include/asm-generic/vmlinux.lds.h
+++ b/include/asm-generic/vmlinux.lds.h
@@ -640,7 +640,7 @@
#define EXCEPTION_TABLE(align) \
. = ALIGN(align); \
__ex_table : AT(ADDR(__ex_table) - LOAD_OFFSET) { \
- BOUNDED_SECTION_BY(__ex_table, ___ex_table) \
+ BOUNDED_SECTION_BY_ALIGNED(__ex_table, ___ex_table, align) \
}
/*
@@ -650,7 +650,7 @@
#define BTF \
. = ALIGN(PAGE_SIZE); \
.BTF : AT(ADDR(.BTF) - LOAD_OFFSET) { \
- BOUNDED_SECTION_BY(.BTF, _BTF) \
+ BOUNDED_SECTION_BY_ALIGNED(.BTF, _BTF, PAGE_SIZE) \
} \
. = ALIGN(PAGE_SIZE); \
.BTF_ids : AT(ADDR(.BTF_ids) - LOAD_OFFSET) { \
@@ -840,16 +840,17 @@
#ifdef CONFIG_UNWINDER_ORC
#define ORC_UNWIND_TABLE \
+ . = ALIGN(4); \
.orc_header : AT(ADDR(.orc_header) - LOAD_OFFSET) { \
- BOUNDED_SECTION_BY(.orc_header, _orc_header) \
+ BOUNDED_SECTION_BY_ALIGNED(.orc_header, _orc_header, 4) \
} \
. = ALIGN(4); \
.orc_unwind_ip : AT(ADDR(.orc_unwind_ip) - LOAD_OFFSET) { \
- BOUNDED_SECTION_BY(.orc_unwind_ip, _orc_unwind_ip) \
+ BOUNDED_SECTION_BY_ALIGNED(.orc_unwind_ip, _orc_unwind_ip, 4)\
} \
. = ALIGN(2); \
.orc_unwind : AT(ADDR(.orc_unwind) - LOAD_OFFSET) { \
- BOUNDED_SECTION_BY(.orc_unwind, _orc_unwind) \
+ BOUNDED_SECTION_BY_ALIGNED(.orc_unwind, _orc_unwind, 2) \
} \
text_size = _etext - _stext; \
. = ALIGN(4); \
@@ -877,7 +878,7 @@
#define TRACEDATA \
. = ALIGN(4); \
.tracedata : AT(ADDR(.tracedata) - LOAD_OFFSET) { \
- BOUNDED_SECTION_POST_LABEL(.tracedata, __tracedata, _start, _end) \
+ BOUNDED_SECTION_POST_LABEL_ALIGNED(.tracedata, __tracedata, _start, _end, 4) \
}
#else
#define TRACEDATA
@@ -906,13 +907,14 @@
*(.note.gnu.property) \
} \
.notes : AT(ADDR(.notes) - LOAD_OFFSET) { \
- BOUNDED_SECTION_BY(.note.*, _notes) \
+ /* *(.note.*) are natively 4-byte aligned */ \
+ BOUNDED_SECTION_BY_ALIGNED(.note.*, _notes, 4) \
} NOTES_HEADERS \
NOTES_HEADERS_RESTORE
#define INIT_SETUP(initsetup_align) \
. = ALIGN(initsetup_align); \
- BOUNDED_SECTION_POST_LABEL(.init.setup, __setup, _start, _end)
+ BOUNDED_SECTION_POST_LABEL_ALIGNED(.init.setup, __setup, _start, _end, initsetup_align)
#define INIT_CALLS_LEVEL(level) \
__initcall##level##_start = .; \
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 05/40] vmlinux.lds.h: remove redundant ALIGN(8) directives
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (3 preceding siblings ...)
2026-10-13 2:36 ` [PATCH v12 04/40] vmlinux.lds.h: Fix ALIGN(8) omission causing NULL ptr on i386 Jim Cromie via B4 Relay
@ 2026-10-13 2:36 ` Jim Cromie via B4 Relay
2026-10-13 2:36 ` [PATCH v12 06/40] dyndbg.lds.S: fix lost dyndbg sections in modules Jim Cromie via B4 Relay
` (34 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:36 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie
From: Jim Cromie <jim.cromie@gmail.com>
The BOUNDED_SECTION_PRE_LABEL and BOUNDED_SECTION_POST_LABEL macros
were recently updated to inherently enforce an 8-byte alignment. This
makes the explicit '. = ALIGN(8);' statements preceding 'naked' macro
calls in vmlinux.lds.h redundant.
Remove these redundant alignment directives to clean up the file and
clarify that the macros handle their own alignment padding.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
include/asm-generic/vmlinux.lds.h | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
index b1a69f8af6d2..c3376665d027 100644
--- a/include/asm-generic/vmlinux.lds.h
+++ b/include/asm-generic/vmlinux.lds.h
@@ -228,7 +228,6 @@
#ifdef CONFIG_KPROBES
#define KPROBE_BLACKLIST() \
- . = ALIGN(8); \
BOUNDED_SECTION(_kprobe_blacklist)
#else
#define KPROBE_BLACKLIST()
@@ -244,7 +243,6 @@
#ifdef CONFIG_EVENT_TRACING
#define FTRACE_EVENTS() \
- . = ALIGN(8); \
BOUNDED_SECTION(_ftrace_events) \
BOUNDED_SECTION_BY(_ftrace_eval_map, _ftrace_eval_maps)
#else
@@ -261,7 +259,6 @@
#ifdef CONFIG_FTRACE_SYSCALLS
#define TRACE_SYSCALLS() \
- . = ALIGN(8); \
BOUNDED_SECTION_BY(__syscalls_metadata, _syscalls_metadata)
#else
#define TRACE_SYSCALLS()
@@ -276,7 +273,6 @@
#ifdef CONFIG_SERIAL_EARLYCON
#define EARLYCON_TABLE() \
- . = ALIGN(8); \
BOUNDED_SECTION_POST_LABEL(__earlycon_table, __earlycon_table, , _end)
#else
#define EARLYCON_TABLE()
@@ -284,11 +280,9 @@
#ifdef CONFIG_SECURITY
#define LSM_TABLE() \
- . = ALIGN(8); \
BOUNDED_SECTION_PRE_LABEL(.lsm_info.init, _lsm_info, __start, __end)
#define EARLY_LSM_TABLE() \
- . = ALIGN(8); \
BOUNDED_SECTION_PRE_LABEL(.early_lsm_info.init, _early_lsm_info, __start, __end)
#else
#define LSM_TABLE()
@@ -314,7 +308,6 @@
#ifdef CONFIG_ACPI
#define ACPI_PROBE_TABLE(name) \
- . = ALIGN(8); \
BOUNDED_SECTION_POST_LABEL(__##name##_acpi_probe_table, \
__##name##_acpi_probe_table,, _end)
#else
@@ -323,7 +316,6 @@
#ifdef CONFIG_THERMAL
#define THERMAL_TABLE(name) \
- . = ALIGN(8); \
BOUNDED_SECTION_POST_LABEL(__##name##_thermal_table, \
__##name##_thermal_table,, _end)
#else
@@ -403,12 +395,10 @@
__end_init_stack = .;
#define JUMP_TABLE_DATA \
- . = ALIGN(8); \
BOUNDED_SECTION_BY(__jump_table, ___jump_table)
#ifdef CONFIG_HAVE_STATIC_CALL_INLINE
#define STATIC_CALL_DATA \
- . = ALIGN(8); \
BOUNDED_SECTION_BY(.static_call_sites, _static_call_sites) \
BOUNDED_SECTION_BY(.static_call_tramp_key, _static_call_tramp_key)
#else
@@ -453,7 +443,6 @@
*(.rodata) *(.rodata.*) *(.data.rel.ro*) \
SCHED_DATA \
RO_AFTER_INIT_DATA /* Read only after init */ \
- . = ALIGN(8); \
BOUNDED_SECTION_BY(__tracepoints_ptrs, ___tracepoints_ptrs) \
*(__tracepoints_strings)/* Tracepoints: strings */ \
} \
@@ -958,12 +947,10 @@
/* Alignment must be consistent with (kunit_suite *) in include/kunit/test.h */
#define KUNIT_TABLE() \
- . = ALIGN(8); \
BOUNDED_SECTION_POST_LABEL(.kunit_test_suites, __kunit_suites, _start, _end)
/* Alignment must be consistent with (kunit_suite *) in include/kunit/test.h */
#define KUNIT_INIT_TABLE() \
- . = ALIGN(8); \
BOUNDED_SECTION_POST_LABEL(.kunit_init_test_suites, \
__kunit_init_suites, _start, _end)
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 06/40] dyndbg.lds.S: fix lost dyndbg sections in modules
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (4 preceding siblings ...)
2026-10-13 2:36 ` [PATCH v12 05/40] vmlinux.lds.h: remove redundant ALIGN(8) directives Jim Cromie via B4 Relay
@ 2026-10-13 2:36 ` Jim Cromie via B4 Relay
2026-10-13 2:36 ` [PATCH v12 07/40] dyndbg: factor ddebug_match_desc out from ddebug_change Jim Cromie via B4 Relay
` (33 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:36 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie
From: Jim Cromie <jim.cromie@gmail.com>
With CONFIG_DRM_USE_DYNAMIC_DEBUG=y, several build configs had
problems with __dyndbg* sections getting lost in drm drivers. Fix
this by following the model demonstrated in codetag.lds.h.
Introduce include/asm-generic/dyndbg.lds.h, to bundle dynamic-debug's
multiple sections together, into 2 macros:
vmlinux.lds.h DATA_DATA: move the 2 BOUNDED_SECTION_BY(__dyndbg*)
calls into dyndbg.lds.h DYNDBG_SECTIONS(). vmlinux.lds.h now includes
the new file and calls the new macro.
MOD_DYNDBG_SECTIONS keeps the 2 sections by name, aligns them and sets
the output address to 0 when the sections are empty.
dyndbg.lds.h includes (reuses) bounded-section.lds.h
scripts/module.lds.S: now calls MOD_DYNDBG_SECTIONS right before the
CODETAG macro (consistent with their placements in vmlinux.lds.h), and
also includes dyndbg.lds.h
This isolates vmlinux.lds.h from further __dyndbg section additions.
CC: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Reviewed-by: Petr Pavlu <petr.pavlu@suse.com>
---
v3: move #includes to top, drop extra ALIGN(8) in DYNDBG_SECTIONS, add RvBy
v2: Address linker script review feedback for relocatable modules.
MOD_DYNDBG_SECTIONS() used the BOUNDED_SECTION_BY() macro, which
proved problematic for kernel modules for two reasons:
1. Unwanted Empty Sections:
BOUNDED_SECTION_BY() automatically generates `__start` and `__stop`
symbols. When applied to `MOD_DYNDBG_SECTIONS()`, the linker assumes
the sections are populated due to the symbol definitions, forcing an
empty `__dyndbg` and `__dyndbg_classes` output section in every
compiled module, even those without dynamic debug configuration.
Since the module loader uses `section_objs()` to locate data via
ELF headers instead of relying on `__start`/`__stop` symbols, these
assignments are completely unnecessary.
2. Non-zero Output Addresses:
During relocatable linking (e.g., `ld.bfd -r`), omitting an explicit
base address causes the section to inherit the current location
counter. This results in non-zero sh_addr values in `.ko` files,
which is confusing, degrades compressibility, and can cause issues
with external tools parsing the ELF.
Fix both issues by dropping `BOUNDED_SECTION_BY()` in favor of a simple
`KEEP(*(...))` constraint and explicitly defining the sections with a `0`
base address: `__dyndbg 0 : ALIGN(8) { ... }`.
fixup-inc-vml
---
MAINTAINERS | 1 +
include/asm-generic/dyndbg.lds.h | 18 ++++++++++++++++++
include/asm-generic/vmlinux.lds.h | 6 ++----
scripts/module.lds.S | 2 ++
4 files changed, 23 insertions(+), 4 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 98954b1746f6..af888d6c660c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9259,6 +9259,7 @@ DYNAMIC DEBUG
M: Jason Baron <jbaron@akamai.com>
M: Jim Cromie <jim.cromie@gmail.com>
S: Maintained
+F: include/asm-generic/dyndbg.lds.h
F: include/linux/dynamic_debug.h
F: lib/dynamic_debug.c
F: lib/test_dynamic_debug.c
diff --git a/include/asm-generic/dyndbg.lds.h b/include/asm-generic/dyndbg.lds.h
new file mode 100644
index 000000000000..9d8951bef688
--- /dev/null
+++ b/include/asm-generic/dyndbg.lds.h
@@ -0,0 +1,18 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+#ifndef __ASM_GENERIC_DYNDBG_LDS_H
+#define __ASM_GENERIC_DYNDBG_LDS_H
+
+#include <asm-generic/bounded_sections.lds.h>
+#define DYNDBG_SECTIONS() \
+ BOUNDED_SECTION_BY(__dyndbg, ___dyndbg) \
+ BOUNDED_SECTION_BY(__dyndbg_classes, ___dyndbg_classes)
+
+#define MOD_DYNDBG_SECTIONS() \
+ __dyndbg 0 : ALIGN(8) { \
+ KEEP(*(__dyndbg)) \
+ } \
+ __dyndbg_classes 0 : ALIGN(8) { \
+ KEEP(*(__dyndbg_classes)) \
+ }
+
+#endif /* __ASM_GENERIC_DYNDBG_LDS_H */
diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
index c3376665d027..48f00c5e8762 100644
--- a/include/asm-generic/vmlinux.lds.h
+++ b/include/asm-generic/vmlinux.lds.h
@@ -52,6 +52,7 @@
#include <asm-generic/bounded_sections.lds.h>
#include <asm-generic/codetag.lds.h>
+#include <asm-generic/dyndbg.lds.h>
#ifndef LOAD_OFFSET
#define LOAD_OFFSET 0
@@ -344,10 +345,7 @@
*(.data..do_once) \
STRUCT_ALIGN(); \
*(__tracepoints) \
- /* implement dynamic printk debug */ \
- . = ALIGN(8); \
- BOUNDED_SECTION_BY(__dyndbg_classes, ___dyndbg_classes) \
- BOUNDED_SECTION_BY(__dyndbg, ___dyndbg) \
+ DYNDBG_SECTIONS() \
CODETAG_SECTIONS() \
LIKELY_PROFILE() \
BRANCH_PROFILE() \
diff --git a/scripts/module.lds.S b/scripts/module.lds.S
index d0f200428957..5950ff8edc31 100644
--- a/scripts/module.lds.S
+++ b/scripts/module.lds.S
@@ -5,6 +5,7 @@
*/
#include <asm-generic/codetag.lds.h>
+#include <asm-generic/dyndbg.lds.h>
SECTIONS {
/DISCARD/ : {
@@ -56,6 +57,7 @@ SECTIONS {
*(.rodata..L*)
}
+ MOD_DYNDBG_SECTIONS()
MOD_SEPARATE_CODETAG_SECTIONS()
}
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 07/40] dyndbg: factor ddebug_match_desc out from ddebug_change
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (5 preceding siblings ...)
2026-10-13 2:36 ` [PATCH v12 06/40] dyndbg.lds.S: fix lost dyndbg sections in modules Jim Cromie via B4 Relay
@ 2026-10-13 2:36 ` Jim Cromie via B4 Relay
2026-10-13 2:36 ` [PATCH v12 08/40] dyndbg: add stub macro for DECLARE_DYNDBG_CLASSMAP Jim Cromie via B4 Relay
` (32 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:36 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie,
Louis Chauvet
From: Jim Cromie <jim.cromie@gmail.com>
ddebug_change() is a big (~100 lines) function with a nested for loop.
The outer loop walks the per-module ddebug_tables list, and does
module stuff: it filters on a query's "module FOO*" and "class BAR",
failures here skip the entire inner loop.
The inner loop (60 lines) scans a module's descriptors. It starts
with a long block of filters on function, line, format, and the
validated "BAR" class (or the legacy/_DPRINTK_CLASS_DFLT).
These filters "continue" past pr_debugs that don't match the query
criteria, before it falls through the code below that counts matches,
then adjusts the flags and static-keys. This is unnecessarily hard to
think about.
So move the per-descriptor filter-block into a boolean function:
ddebug_match_desc(desc), and change each "continue" to "return false".
This puts a clear interface in place, so any future changes are either
inside, outside, or across this interface.
also fix checkpatch complaints about spaces and braces.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
---
v11:
. move doc comment block down to precede ddebug_change().
Sashiko review complaint (patch 7):
"Does this placement separate the block comment from its intended
target? The comment describes a function that returns the number of
matching callsites and takes ddebug_lock, which accurately describes
ddebug_change(). However, by inserting ddebug_match_desc()
immediately after this comment, does it leave ddebug_change()
undocumented and make the comment falsely apply to
ddebug_match_desc()..."
v5: check for null format in callsite. shouldnt happen, but pr_debug() isnt illegal
v7: elevate null format to pr_err adding filename, function, lineno.
---
lib/dynamic_debug.c | 91 ++++++++++++++++++++++++++++++++---------------------
1 file changed, 55 insertions(+), 36 deletions(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 49334d1aa4b3..8682c23b5fe7 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -166,6 +166,60 @@ static struct ddebug_class_map *ddebug_find_valid_class(struct ddebug_table cons
}
#define __outvar /* filled by callee */
+static bool ddebug_match_desc(const struct ddebug_query *query,
+ struct _ddebug *dp,
+ int valid_class)
+{
+ /* match site against query-class */
+ if (dp->class_id != valid_class)
+ return false;
+
+ if (!dp->format) {
+ pr_err_ratelimited("ddebug: NULL format string at %s:%s:%u\n",
+ dp->filename ? dp->filename : "?",
+ dp->function ? dp->function : "?",
+ dp->lineno);
+ return false;
+ }
+
+ /* match against the source filename */
+ if (query->filename &&
+ !match_wildcard(query->filename, dp->filename) &&
+ !match_wildcard(query->filename,
+ kbasename(dp->filename)) &&
+ !match_wildcard(query->filename,
+ trim_prefix(dp->filename)))
+ return false;
+
+ /* match against the function */
+ if (query->function &&
+ !match_wildcard(query->function, dp->function))
+ return false;
+
+ /* match against the format */
+ if (query->format) {
+ if (*query->format == '^') {
+ char *p;
+ /* anchored search. match must be at beginning */
+ p = strstr(dp->format, query->format + 1);
+ if (p != dp->format)
+ return false;
+ } else if (!strstr(dp->format, query->format)) {
+ return false;
+ }
+ }
+
+ /* match against the line number range */
+ if (query->first_lineno &&
+ dp->lineno < query->first_lineno)
+ return false;
+ if (query->last_lineno &&
+ dp->lineno > query->last_lineno)
+ return false;
+
+ return true;
+}
+
/*
* Search the tables for _ddebug's which match the given `query' and
* apply the `flags' and `mask' to them. Returns number of matching
@@ -204,42 +258,7 @@ static int ddebug_change(const struct ddebug_query *query,
for (i = 0; i < dt->num_ddebugs; i++) {
struct _ddebug *dp = &dt->ddebugs[i];
- /* match site against query-class */
- if (dp->class_id != valid_class)
- continue;
-
- /* match against the source filename */
- if (query->filename &&
- !match_wildcard(query->filename, dp->filename) &&
- !match_wildcard(query->filename,
- kbasename(dp->filename)) &&
- !match_wildcard(query->filename,
- trim_prefix(dp->filename)))
- continue;
-
- /* match against the function */
- if (query->function &&
- !match_wildcard(query->function, dp->function))
- continue;
-
- /* match against the format */
- if (query->format) {
- if (*query->format == '^') {
- char *p;
- /* anchored search. match must be at beginning */
- p = strstr(dp->format, query->format+1);
- if (p != dp->format)
- continue;
- } else if (!strstr(dp->format, query->format))
- continue;
- }
-
- /* match against the line number range */
- if (query->first_lineno &&
- dp->lineno < query->first_lineno)
- continue;
- if (query->last_lineno &&
- dp->lineno > query->last_lineno)
+ if (!ddebug_match_desc(query, dp, valid_class))
continue;
nfound++;
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 08/40] dyndbg: add stub macro for DECLARE_DYNDBG_CLASSMAP
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (6 preceding siblings ...)
2026-10-13 2:36 ` [PATCH v12 07/40] dyndbg: factor ddebug_match_desc out from ddebug_change Jim Cromie via B4 Relay
@ 2026-10-13 2:36 ` Jim Cromie via B4 Relay
2026-10-13 2:36 ` [PATCH v12 09/40] dyndbg: reword "class unknown," to "class:_UNKNOWN_" Jim Cromie via B4 Relay
` (31 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:36 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie
From: Jim Cromie <jim.cromie@gmail.com>
Add the stub macro for !DYNAMIC_DEBUG builds, after moving the
original macro-defn down under the big ifdef. Do it now so future
changes have a cleaner starting point.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
include/linux/dynamic_debug.h | 43 ++++++++++++++++++++++---------------------
1 file changed, 22 insertions(+), 21 deletions(-)
diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
index 05743900a116..a10adac8e8f0 100644
--- a/include/linux/dynamic_debug.h
+++ b/include/linux/dynamic_debug.h
@@ -93,27 +93,6 @@ struct ddebug_class_map {
enum class_map_type map_type;
};
-/**
- * DECLARE_DYNDBG_CLASSMAP - declare classnames known by a module
- * @_var: a struct ddebug_class_map, passed to module_param_cb
- * @_type: enum class_map_type, chooses bits/verbose, numeric/symbolic
- * @_base: offset of 1st class-name. splits .class_id space
- * @classes: class-names used to control class'd prdbgs
- */
-#define DECLARE_DYNDBG_CLASSMAP(_var, _maptype, _base, ...) \
- static const char *_var##_classnames[] = { __VA_ARGS__ }; \
- static struct ddebug_class_map __aligned(8) __used \
- __section("__dyndbg_classes") _var = { \
- .mod = THIS_MODULE, \
- .mod_name = KBUILD_MODNAME, \
- .base = _base, \
- .map_type = _maptype, \
- .length = NUM_TYPE_ARGS(char*, __VA_ARGS__), \
- .class_names = _var##_classnames, \
- }
-#define NUM_TYPE_ARGS(eltype, ...) \
- (sizeof((eltype[]){__VA_ARGS__}) / sizeof(eltype))
-
/* encapsulate linker provided built-in (or module) dyndbg data */
struct _ddebug_info {
struct _ddebug *descs;
@@ -138,6 +117,27 @@ struct ddebug_class_param {
#if defined(CONFIG_DYNAMIC_DEBUG) || \
(defined(CONFIG_DYNAMIC_DEBUG_CORE) && defined(DYNAMIC_DEBUG_MODULE))
+/**
+ * DECLARE_DYNDBG_CLASSMAP - declare classnames known by a module
+ * @_var: a struct ddebug_class_map, passed to module_param_cb
+ * @_type: enum class_map_type, chooses bits/verbose, numeric/symbolic
+ * @_base: offset of 1st class-name. splits .class_id space
+ * @classes: class-names used to control class'd prdbgs
+ */
+#define DECLARE_DYNDBG_CLASSMAP(_var, _maptype, _base, ...) \
+ static const char *_var##_classnames[] = { __VA_ARGS__ }; \
+ static struct ddebug_class_map __aligned(8) __used \
+ __section("__dyndbg_classes") _var = { \
+ .mod = THIS_MODULE, \
+ .mod_name = KBUILD_MODNAME, \
+ .base = _base, \
+ .map_type = _maptype, \
+ .length = NUM_TYPE_ARGS(char*, __VA_ARGS__), \
+ .class_names = _var##_classnames, \
+ }
+#define NUM_TYPE_ARGS(eltype, ...) \
+ (sizeof((eltype[]) {__VA_ARGS__}) / sizeof(eltype))
+
extern __printf(2, 3)
void __dynamic_pr_debug(struct _ddebug *descriptor, const char *fmt, ...);
@@ -314,6 +314,7 @@ void __dynamic_ibdev_dbg(struct _ddebug *descriptor,
#define DEFINE_DYNAMIC_DEBUG_METADATA(name, fmt)
#define DYNAMIC_DEBUG_BRANCH(descriptor) false
+#define DECLARE_DYNDBG_CLASSMAP(...)
#define dynamic_pr_debug(fmt, ...) \
no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 09/40] dyndbg: reword "class unknown," to "class:_UNKNOWN_"
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (7 preceding siblings ...)
2026-10-13 2:36 ` [PATCH v12 08/40] dyndbg: add stub macro for DECLARE_DYNDBG_CLASSMAP Jim Cromie via B4 Relay
@ 2026-10-13 2:36 ` Jim Cromie via B4 Relay
2026-10-13 2:36 ` [PATCH v12 10/40] dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code Jim Cromie via B4 Relay
` (30 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:36 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie,
Louis Chauvet
From: Jim Cromie <jim.cromie@gmail.com>
When a dyndbg classname is unknown to a kernel module, the callsite is
un-addressable via >control queries, and therefore uncontrollable.
The control-file displays this condition as "class unknown, _id:N"
currently. That spelling is sub-optimal/too-generic, so change it to
"class:_UNKNOWN_ _id:N" to loudly announce the erroneous situation,
and to make it uniquely greppable.
NB: while this might be seen as a user-visible change, this shouldn't
disqualify the change:
a- it reports a classmap coding error condition, which should be
detected in (or before) review.
b- SHOUTING the error makes it more visible, uniquely greppable.
c- the classmap feature is marked BROKEN for its only current user.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
---
lib/dynamic_debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 8682c23b5fe7..13a3d1a8c3ca 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -1174,7 +1174,7 @@ static int ddebug_proc_show(struct seq_file *m, void *p)
if (class)
seq_printf(m, " class:%s", class);
else
- seq_printf(m, " class unknown, _id:%d", dp->class_id);
+ seq_printf(m, " class:_UNKNOWN_ _id:%d", dp->class_id);
}
seq_putc(m, '\n');
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 10/40] dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (8 preceding siblings ...)
2026-10-13 2:36 ` [PATCH v12 09/40] dyndbg: reword "class unknown," to "class:_UNKNOWN_" Jim Cromie via B4 Relay
@ 2026-10-13 2:36 ` Jim Cromie via B4 Relay
2026-10-13 2:36 ` [PATCH v12 11/40] dyndbg: drop NUM_TYPE_ARGS Jim Cromie via B4 Relay
` (29 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:36 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie,
Louis Chauvet
From: Jim Cromie <jim.cromie@gmail.com>
Remove the DD_CLASS_TYPE_*_NAMES classmap types and code.
These 2 classmap types accept class names at the PARAM interface, for
example:
echo +DRM_UT_CORE,-DRM_UT_KMS > /sys/module/drm/parameters/debug_names
The code works, but its only used by test-dynamic-debug, and wasn't
asked for by anyone else, so reduce LOC & test-surface; simplify things.
Also rename enum class_map_type to enum ddebug_class_map_type.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
---
v3:
fix name of enum in kdoc
also change name of struct (to future name)
v2:
move RvB after SoB
respect const instr in param_set_dyndbg_module_classes, return -EINVAL on classtype err.
---
include/linux/dynamic_debug.h | 28 ++++---------
lib/dynamic_debug.c | 98 +++----------------------------------------
lib/test_dynamic_debug.c | 26 ------------
3 files changed, 15 insertions(+), 137 deletions(-)
diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
index a10adac8e8f0..9607121c3072 100644
--- a/include/linux/dynamic_debug.h
+++ b/include/linux/dynamic_debug.h
@@ -59,27 +59,17 @@ struct _ddebug {
#endif
} __attribute__((aligned(8)));
-enum class_map_type {
+enum ddebug_class_map_type {
DD_CLASS_TYPE_DISJOINT_BITS,
/**
- * DD_CLASS_TYPE_DISJOINT_BITS: classes are independent, one per bit.
- * expecting hex input. Built for drm.debug, basis for other types.
+ * DD_CLASS_TYPE_DISJOINT_BITS: classes are independent,
+ * mapped to bits[0..N]. Expects hex input. Built for
+ * drm.debug, basis for other types.
*/
DD_CLASS_TYPE_LEVEL_NUM,
/**
- * DD_CLASS_TYPE_LEVEL_NUM: input is numeric level, 0-N.
- * N turns on just bits N-1 .. 0, so N=0 turns all bits off.
- */
- DD_CLASS_TYPE_DISJOINT_NAMES,
- /**
- * DD_CLASS_TYPE_DISJOINT_NAMES: input is a CSV of [+-]CLASS_NAMES,
- * classes are independent, like _DISJOINT_BITS.
- */
- DD_CLASS_TYPE_LEVEL_NAMES,
- /**
- * DD_CLASS_TYPE_LEVEL_NAMES: input is a CSV of [+-]CLASS_NAMES,
- * intended for names like: INFO,DEBUG,TRACE, with a module prefix
- * avoid EMERG,ALERT,CRIT,ERR,WARNING: they're not debug
+ * DD_CLASS_TYPE_LEVEL_NUM: input is numeric level, 0..N.
+ * Input N turns on bits 0..N-1
*/
};
@@ -90,7 +80,7 @@ struct ddebug_class_map {
const char **class_names;
const int length;
const int base; /* index of 1st .class_id, allows split/shared space */
- enum class_map_type map_type;
+ enum ddebug_class_map_type map_type;
};
/* encapsulate linker provided built-in (or module) dyndbg data */
@@ -119,8 +109,8 @@ struct ddebug_class_param {
/**
* DECLARE_DYNDBG_CLASSMAP - declare classnames known by a module
- * @_var: a struct ddebug_class_map, passed to module_param_cb
- * @_type: enum class_map_type, chooses bits/verbose, numeric/symbolic
+ * @_var: a struct _ddebug_class_map, passed to module_param_cb
+ * @_maptype: enum ddebug_class_map_type, chooses bits/verbose
* @_base: offset of 1st class-name. splits .class_id space
* @classes: class-names used to control class'd prdbgs
*/
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 13a3d1a8c3ca..a39144fd7c8c 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -654,76 +654,6 @@ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp,
#define CLASSMAP_BITMASK(width) ((1UL << (width)) - 1)
-/* accept comma-separated-list of [+-] classnames */
-static int param_set_dyndbg_classnames(const char *instr, const struct kernel_param *kp)
-{
- const struct ddebug_class_param *dcp = kp->arg;
- const struct ddebug_class_map *map = dcp->map;
- unsigned long curr_bits, old_bits;
- char *cl_str, *p, *tmp;
- int cls_id, totct = 0;
- bool wanted;
-
- cl_str = tmp = kstrdup_and_replace(instr, '\n', '\0', GFP_KERNEL);
- if (!tmp)
- return -ENOMEM;
-
- /* start with previously set state-bits, then modify */
- curr_bits = old_bits = *dcp->bits;
- vpr_info("\"%s\" > %s:0x%lx\n", cl_str, KP_NAME(kp), curr_bits);
-
- for (; cl_str; cl_str = p) {
- p = strchr(cl_str, ',');
- if (p)
- *p++ = '\0';
-
- if (*cl_str == '-') {
- wanted = false;
- cl_str++;
- } else {
- wanted = true;
- if (*cl_str == '+')
- cl_str++;
- }
- cls_id = match_string(map->class_names, map->length, cl_str);
- if (cls_id < 0) {
- pr_err("%s unknown to %s\n", cl_str, KP_NAME(kp));
- continue;
- }
-
- /* have one or more valid class_ids of one *_NAMES type */
- switch (map->map_type) {
- case DD_CLASS_TYPE_DISJOINT_NAMES:
- /* the +/- pertains to a single bit */
- if (test_bit(cls_id, &curr_bits) == wanted) {
- v3pr_info("no change on %s\n", cl_str);
- continue;
- }
- curr_bits ^= BIT(cls_id);
- totct += ddebug_apply_class_bitmap(dcp, &curr_bits, dcp->bits);
- *dcp->bits = curr_bits;
- v2pr_info("%s: changed bit %d:%s\n", KP_NAME(kp), cls_id,
- map->class_names[cls_id]);
- break;
- case DD_CLASS_TYPE_LEVEL_NAMES:
- /* cls_id = N in 0..max. wanted +/- determines N or N-1 */
- old_bits = CLASSMAP_BITMASK(*dcp->lvl);
- curr_bits = CLASSMAP_BITMASK(cls_id + (wanted ? 1 : 0 ));
-
- totct += ddebug_apply_class_bitmap(dcp, &curr_bits, &old_bits);
- *dcp->lvl = (cls_id + (wanted ? 1 : 0));
- v2pr_info("%s: changed bit-%d: \"%s\" %lx->%lx\n", KP_NAME(kp), cls_id,
- map->class_names[cls_id], old_bits, curr_bits);
- break;
- default:
- pr_err("illegal map-type value %d\n", map->map_type);
- }
- }
- kfree(tmp);
- vpr_info("total matches: %d\n", totct);
- return 0;
-}
-
/**
* param_set_dyndbg_classes - class FOO >control
* @instr: string echo>d to sysfs, input depends on map_type
@@ -742,28 +672,15 @@ int param_set_dyndbg_classes(const char *instr, const struct kernel_param *kp)
unsigned long inrep, new_bits, old_bits;
int rc, totct = 0;
- switch (map->map_type) {
-
- case DD_CLASS_TYPE_DISJOINT_NAMES:
- case DD_CLASS_TYPE_LEVEL_NAMES:
- /* handle [+-]classnames list separately, we are done here */
- return param_set_dyndbg_classnames(instr, kp);
+ rc = kstrtoul(instr, 0, &inrep);
+ if (rc) {
+ int len = strcspn(instr, "\n");
- case DD_CLASS_TYPE_DISJOINT_BITS:
- case DD_CLASS_TYPE_LEVEL_NUM:
- /* numeric input, accept and fall-thru */
- rc = kstrtoul(instr, 0, &inrep);
- if (rc) {
- pr_err("expecting numeric input: %s > %s\n", instr, KP_NAME(kp));
- return -EINVAL;
- }
- break;
- default:
- pr_err("%s: bad map type: %d\n", KP_NAME(kp), map->map_type);
+ pr_err("expecting numeric input, not: %.*s > %s\n",
+ len, instr, KP_NAME(kp));
return -EINVAL;
}
- /* only _BITS,_NUM (numeric) map-types get here */
switch (map->map_type) {
case DD_CLASS_TYPE_DISJOINT_BITS:
/* expect bits. mask and warn if too many */
@@ -791,6 +708,7 @@ int param_set_dyndbg_classes(const char *instr, const struct kernel_param *kp)
break;
default:
pr_warn("%s: bad map type: %d\n", KP_NAME(kp), map->map_type);
+ return -EINVAL;
}
vpr_info("%s: total matches: %d\n", KP_NAME(kp), totct);
return 0;
@@ -812,12 +730,8 @@ int param_get_dyndbg_classes(char *buffer, const struct kernel_param *kp)
const struct ddebug_class_map *map = dcp->map;
switch (map->map_type) {
-
- case DD_CLASS_TYPE_DISJOINT_NAMES:
case DD_CLASS_TYPE_DISJOINT_BITS:
return scnprintf(buffer, PAGE_SIZE, "0x%lx\n", *dcp->bits);
-
- case DD_CLASS_TYPE_LEVEL_NAMES:
case DD_CLASS_TYPE_LEVEL_NUM:
return scnprintf(buffer, PAGE_SIZE, "%d\n", *dcp->lvl);
default:
diff --git a/lib/test_dynamic_debug.c b/lib/test_dynamic_debug.c
index 77c2a669b6af..74d183ebf3e0 100644
--- a/lib/test_dynamic_debug.c
+++ b/lib/test_dynamic_debug.c
@@ -74,13 +74,6 @@ DECLARE_DYNDBG_CLASSMAP(map_disjoint_bits, DD_CLASS_TYPE_DISJOINT_BITS, 0,
DD_SYS_WRAP(disjoint_bits, p);
DD_SYS_WRAP(disjoint_bits, T);
-/* symbolic input, independent bits */
-enum cat_disjoint_names { LOW = 11, MID, HI };
-DECLARE_DYNDBG_CLASSMAP(map_disjoint_names, DD_CLASS_TYPE_DISJOINT_NAMES, 10,
- "LOW", "MID", "HI");
-DD_SYS_WRAP(disjoint_names, p);
-DD_SYS_WRAP(disjoint_names, T);
-
/* numeric verbosity, V2 > V1 related */
enum cat_level_num { V0 = 14, V1, V2, V3, V4, V5, V6, V7 };
DECLARE_DYNDBG_CLASSMAP(map_level_num, DD_CLASS_TYPE_LEVEL_NUM, 14,
@@ -88,13 +81,6 @@ DECLARE_DYNDBG_CLASSMAP(map_level_num, DD_CLASS_TYPE_LEVEL_NUM, 14,
DD_SYS_WRAP(level_num, p);
DD_SYS_WRAP(level_num, T);
-/* symbolic verbosity */
-enum cat_level_names { L0 = 22, L1, L2, L3, L4, L5, L6, L7 };
-DECLARE_DYNDBG_CLASSMAP(map_level_names, DD_CLASS_TYPE_LEVEL_NAMES, 22,
- "L0", "L1", "L2", "L3", "L4", "L5", "L6", "L7");
-DD_SYS_WRAP(level_names, p);
-DD_SYS_WRAP(level_names, T);
-
/* stand-in for all pr_debug etc */
#define prdbg(SYM) __pr_debug_cls(SYM, #SYM " msg\n")
@@ -102,10 +88,6 @@ static void do_cats(void)
{
pr_debug("doing categories\n");
- prdbg(LOW);
- prdbg(MID);
- prdbg(HI);
-
prdbg(D2_CORE);
prdbg(D2_DRIVER);
prdbg(D2_KMS);
@@ -129,14 +111,6 @@ static void do_levels(void)
prdbg(V5);
prdbg(V6);
prdbg(V7);
-
- prdbg(L1);
- prdbg(L2);
- prdbg(L3);
- prdbg(L4);
- prdbg(L5);
- prdbg(L6);
- prdbg(L7);
}
static void do_prints(void)
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 11/40] dyndbg: drop NUM_TYPE_ARGS
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (9 preceding siblings ...)
2026-10-13 2:36 ` [PATCH v12 10/40] dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code Jim Cromie via B4 Relay
@ 2026-10-13 2:36 ` Jim Cromie via B4 Relay
2026-10-13 2:36 ` [PATCH v12 12/40] dyndbg: bump num-tokens in a query-cmd from 9 to 15 Jim Cromie via B4 Relay
` (28 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:36 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie,
Louis Chauvet
From: Jim Cromie <jim.cromie@gmail.com>
ARRAY_SIZE almost works here, since array decl is complete.
But define it locally, named __DDEBUG_ARRAY_SIZE, to avoid
include conflicts with boot/<something> on some arch.
no functional change
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
---
v7: actually use macro
v5: drop include, it causes redefined probs in /boot/* for some arch.
v2: include linux/array_size.h, correct commit subject, review after sob
---
include/linux/dynamic_debug.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
index 9607121c3072..baf5c0853f45 100644
--- a/include/linux/dynamic_debug.h
+++ b/include/linux/dynamic_debug.h
@@ -8,6 +8,8 @@
#include <linux/build_bug.h>
+#define __DDEBUG_ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))
+
/*
* An instance of this structure is created in a special
* ELF section at every dynamic debug callsite. At runtime,
@@ -122,11 +124,9 @@ struct ddebug_class_param {
.mod_name = KBUILD_MODNAME, \
.base = _base, \
.map_type = _maptype, \
- .length = NUM_TYPE_ARGS(char*, __VA_ARGS__), \
.class_names = _var##_classnames, \
+ .length = __DDEBUG_ARRAY_SIZE(_var##_classnames), \
}
-#define NUM_TYPE_ARGS(eltype, ...) \
- (sizeof((eltype[]) {__VA_ARGS__}) / sizeof(eltype))
extern __printf(2, 3)
void __dynamic_pr_debug(struct _ddebug *descriptor, const char *fmt, ...);
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 12/40] dyndbg: bump num-tokens in a query-cmd from 9 to 15
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (10 preceding siblings ...)
2026-10-13 2:36 ` [PATCH v12 11/40] dyndbg: drop NUM_TYPE_ARGS Jim Cromie via B4 Relay
@ 2026-10-13 2:36 ` Jim Cromie via B4 Relay
2026-10-13 2:36 ` [PATCH v12 13/40] dyndbg: reduce verbose/debug clutter Jim Cromie via B4 Relay
` (27 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:36 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie
From: Jim Cromie <jim.cromie@gmail.com>
Current MAXWORDS in ddebug_exec_query() is too small to accept a legal
query-command using all 6 keywords. We *need* 13, but this adds a few
extra to allow certain errors to fail on subsequent, more meaningful
grammar checks.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
lib/dynamic_debug.c | 2 +-
tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh | 12 ++++++------
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index a39144fd7c8c..a0723343e2a7 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -558,7 +558,7 @@ static int ddebug_exec_query(char *query_string, const char *modname)
{
struct flag_settings modifiers = {};
struct ddebug_query query = {};
-#define MAXWORDS 9
+#define MAXWORDS 15
int nwords, nfound;
char *words[MAXWORDS];
diff --git a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
index c1475c755542..5e52d957e2fd 100755
--- a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
+++ b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
@@ -320,8 +320,8 @@ function GOLDEN_RECORDS {
#K= b9a397e807148d13ba07da7db7e69817 FT_grammar_errs.2
#K= 5abefa504937a329f974504f1896e368 FT_grammar_errs.3
#K= 1d94d0f239bf40bf51280caeab499de0 FT_grammar_errs.4
-#K= 135035c8a17ae100cc4ec954c4d75b2f FT_grammar_errs.5
-#K= a9cc14244f91a12d3174ad1314144a8e FT_grammar_errs.6
+#K= 9a5e1c1856f1ebbe57a4afdfc4c9703a FT_grammar_errs.5
+#K= b3809a6f9f643f049f1ef30827d4b001 FT_grammar_errs.6
#K= 5d400aad1a7d71f548b6b81274d00a55 FT_grammar_errs.7
#K= 61cd359b10f9051862d3745eda07a295 FT_grammar_errs.8
#K= 567379f4f4d099f00f37d1469d9370bd FT_grammar_errs.9
@@ -340,8 +340,8 @@ function GOLDEN_RECORDS {
#K= 1f6fedfe222af475211b3bfc6d08bc63 FT_grammar_errs.22
#K= c67dfeca97697b707acdd70672816dff FT_grammar_errs.23
#K= 9574dbfdac063409b41a44e6251fbcd9 FT_grammar_errs.24
-#K= 644b81753949ac1285e38ac995eeba46 FT_grammar_errs.25
-#K= 1bf2a93a39961f40e0c2dd4c5e2edc6d FT_grammar_errs.26
+#K= 3c694a0ee2cf3a1d39f2ca8a9f3b9094 FT_grammar_errs.25
+#K= c23be05426c8727be833ff055944aa96 FT_grammar_errs.26
#K= cdddf4ffd7fde3c12eb0c73770b872bf FT_grammar_errs.27
#K= cdf7a2e2740ec007efbd29feda478420 FT_grammar_errs.28
#K= f6650d69963cef433c50e1f2acb899fc FT_grammar_errs.29
@@ -360,8 +360,8 @@ function GOLDEN_RECORDS {
#K= 1a402ada248d0d50cec13a1af150ea33 FT_grammar_errs.42
#K= 5b46a8eb0d74009462f74cf7553e3228 FT_grammar_errs.43
#K= 546e440044828d86135dd63f1eb9ed17 FT_grammar_errs.44
-#K= 644b81753949ac1285e38ac995eeba46 FT_grammar_errs.45
-#K= 1bf2a93a39961f40e0c2dd4c5e2edc6d FT_grammar_errs.46
+#K= 3c694a0ee2cf3a1d39f2ca8a9f3b9094 FT_grammar_errs.45
+#K= 37b7ab754e579683a28ce086c470cdc9 FT_grammar_errs.46
#K= 3e3acfb800cfb1bcb0cc07f33b75830a FT_grammar_errs.47
#K= 42dc6cb4fe938bb82b64c82924ef28d8 FT_grammar_errs.48
#K= cf9320d2188f5b48d508d610d95298b2 FT_grammar_errs.49
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 13/40] dyndbg: reduce verbose/debug clutter
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (11 preceding siblings ...)
2026-10-13 2:36 ` [PATCH v12 12/40] dyndbg: bump num-tokens in a query-cmd from 9 to 15 Jim Cromie via B4 Relay
@ 2026-10-13 2:36 ` Jim Cromie via B4 Relay
2026-10-13 2:36 ` [PATCH v12 14/40] dyndbg: refactor param_set_dyndbg_classes and below Jim Cromie via B4 Relay
` (26 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:36 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie,
Louis Chauvet
From: Jim Cromie <jim.cromie@gmail.com>
currently, for verbose=3, these are logged (blank lines for clarity):
dyndbg: query 0: "class DRM_UT_CORE +p" mod:*
dyndbg: split into words: "class" "DRM_UT_CORE" "+p"
dyndbg: op='+'
dyndbg: flags=0x1
dyndbg: *flagsp=0x1 *maskp=0xffffffff
dyndbg: parsed: func="" file="" module="" format="" lineno=0-0 class=...
dyndbg: no matches for query
dyndbg: no-match: func="" file="" module="" format="" lineno=0-0 class=...
dyndbg: processed 1 queries, with 0 matches, 0 errs
That is excessive, so this patch:
- shrinks 3 lines of 2nd stanza to single line
- drops 1st 2 lines of 3rd stanza
3rd line is like 1st, with result, not procedure.
2nd line is just status, retold in 4th, with more info.
New output:
dyndbg: query 0: "class DRM_UT_CORE +p"
dyndbg: split into words: "class" "DRM_UT_CORE" "+p"
dyndbg: op='+' flags=0x1 maskp=0xffffffff
dyndbg: processed 1 queries, with 0 matches, 0 errs
Also drop several verbose=3 messages in ddebug_add_module. When
modprobing a module, dyndbg currently logs/says "add-module", and then
"skipping" if the module has no prdbgs. Instead just check 1st and
return quietly.
Unmatched query diagnostics are intentionally restricted to verbose
level 3 (v3pr_info_dq) to reduce dmesg output clutter on standard
verbose levels (verbose=1 and verbose=2), aligning with the overall
de-cluttering of dynamic debug logging.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
---
v7: update fingerprints of grammar-errs changed here
v4: rename vpr_dq_info to v3pr_dq_info to tell its active logging level
adjust some vX levels per doc'd intentions
v2: RvB after SoB
trivial change to verbose-debug output line to output the actual
"module" keyword rather than "mod:", and do so only when the module is
constrained by the callchain (ie as part of a modprobe).
was: query X: "(keyword value)* [+-=]flags" mod:*
now: query X: "(keyword value)* [+-=]flags"
or query X: module FOO "keyword value)* [+-=]flags"
IOW, adjust output to reflect the input grammar more closely.
---
lib/dynamic_debug.c | 24 ++---
.../selftests/dynamic_debug/dyndbg_selftest.sh | 120 ++++++++++-----------
2 files changed, 70 insertions(+), 74 deletions(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index a0723343e2a7..d0e793a05655 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -128,7 +128,7 @@ do { \
#define v3pr_info(fmt, ...) vnpr_info(3, fmt, ##__VA_ARGS__)
#define v4pr_info(fmt, ...) vnpr_info(4, fmt, ##__VA_ARGS__)
-static void vpr_info_dq(const struct ddebug_query *query, const char *msg)
+static void v3pr_info_dq(const struct ddebug_query *query, const char *msg)
{
/* trim any trailing newlines */
int fmtlen = 0;
@@ -284,9 +284,6 @@ static int ddebug_change(const struct ddebug_query *query,
}
mutex_unlock(&ddebug_lock);
- if (!nfound && verbose)
- pr_info("no matches for query\n");
-
return nfound;
}
@@ -495,7 +492,6 @@ static int ddebug_parse_query(char *words[], int nwords,
*/
query->module = modname;
- vpr_info_dq(query, "parsed");
return 0;
}
@@ -519,7 +515,6 @@ static int ddebug_parse_flags(const char *str, struct flag_settings *modifiers)
pr_err("bad flag-op %c, at start of %s\n", *str, str);
return -EINVAL;
}
- v3pr_info("op='%c'\n", op);
for (; *str ; ++str) {
for (i = ARRAY_SIZE(opt_array) - 1; i >= 0; i--) {
@@ -533,7 +528,6 @@ static int ddebug_parse_flags(const char *str, struct flag_settings *modifiers)
return -EINVAL;
}
}
- v3pr_info("flags=0x%x\n", modifiers->flags);
/* calculate final flags, mask based upon op */
switch (op) {
@@ -549,7 +543,7 @@ static int ddebug_parse_flags(const char *str, struct flag_settings *modifiers)
modifiers->flags = 0;
break;
}
- v3pr_info("*flagsp=0x%x *maskp=0x%x\n", modifiers->flags, modifiers->mask);
+ v3pr_info("op='%c' flags=0x%x maskp=0x%x\n", op, modifiers->flags, modifiers->mask);
return 0;
}
@@ -578,7 +572,7 @@ static int ddebug_exec_query(char *query_string, const char *modname)
}
/* actually go and implement the change */
nfound = ddebug_change(&query, &modifiers);
- vpr_info_dq(&query, nfound ? "applied" : "no-match");
+ v3pr_info_dq(&query, nfound ? "applied" : "no-match");
return nfound;
}
@@ -601,7 +595,10 @@ static int ddebug_exec_queries(char *query, const char *modname)
if (!query || !*query || *query == '#')
continue;
- vpr_info("query %d: \"%s\" mod:%s\n", i, query, modname ?: "*");
+ if (modname)
+ v2pr_info("query %d: module %s \"%s\"\n", i, modname, query);
+ else
+ v2pr_info("query %d: \"%s\"\n", i, query);
rc = ddebug_exec_query(query, modname);
if (rc < 0) {
@@ -1168,11 +1165,10 @@ static int ddebug_add_module(struct _ddebug_info *di, const char *modname)
{
struct ddebug_table *dt;
- v3pr_info("add-module: %s.%d sites\n", modname, di->num_descs);
- if (!di->num_descs) {
- v3pr_info(" skip %s\n", modname);
+ if (!di->num_descs)
return 0;
- }
+
+ v3pr_info("add-module: %s %d sites\n", modname, di->num_descs);
dt = kzalloc_obj(*dt);
if (dt == NULL) {
diff --git a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
index 5e52d957e2fd..c279c795867b 100755
--- a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
+++ b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
@@ -316,66 +316,66 @@ modular_tests=(
# ==============================================================================
function GOLDEN_RECORDS {
cat << 'EOF' | {
-#K= b938440930e5f1297d524e6c0c1ec85c FT_grammar_errs.1
-#K= b9a397e807148d13ba07da7db7e69817 FT_grammar_errs.2
-#K= 5abefa504937a329f974504f1896e368 FT_grammar_errs.3
-#K= 1d94d0f239bf40bf51280caeab499de0 FT_grammar_errs.4
-#K= 9a5e1c1856f1ebbe57a4afdfc4c9703a FT_grammar_errs.5
-#K= b3809a6f9f643f049f1ef30827d4b001 FT_grammar_errs.6
-#K= 5d400aad1a7d71f548b6b81274d00a55 FT_grammar_errs.7
-#K= 61cd359b10f9051862d3745eda07a295 FT_grammar_errs.8
-#K= 567379f4f4d099f00f37d1469d9370bd FT_grammar_errs.9
-#K= 31a026d10f85e8f4c9f8cf3e1cef3c61 FT_grammar_errs.10
-#K= ba62952b671a553d4b14e344a61926f7 FT_grammar_errs.11
-#K= 49aec6c2e99cc70a1e4137f86e94f6f4 FT_grammar_errs.12
-#K= cc02cccf15988a98dfd5b1df1e492e31 FT_grammar_errs.13
-#K= 2bbf3fac2b77b88b6cebe459ff9631d3 FT_grammar_errs.14
-#K= 93b67411c254875a6bae5c01c0239729 FT_grammar_errs.15
-#K= b22f2efe54a1637156b9521b2794806e FT_grammar_errs.16
-#K= de410dba40d8b097524f91da8ae2b1c5 FT_grammar_errs.17
-#K= 6c922048c21f6198720dfd68ae16fdad FT_grammar_errs.18
-#K= 4ddd57e9cbc3da2613ac59eb285ad8c1 FT_grammar_errs.19
-#K= ba65062f6be00a1d04907dd176d26c19 FT_grammar_errs.20
-#K= 94cdf3b32afa4f12a00a704208aa2e53 FT_grammar_errs.21
-#K= 1f6fedfe222af475211b3bfc6d08bc63 FT_grammar_errs.22
-#K= c67dfeca97697b707acdd70672816dff FT_grammar_errs.23
-#K= 9574dbfdac063409b41a44e6251fbcd9 FT_grammar_errs.24
-#K= 3c694a0ee2cf3a1d39f2ca8a9f3b9094 FT_grammar_errs.25
-#K= c23be05426c8727be833ff055944aa96 FT_grammar_errs.26
-#K= cdddf4ffd7fde3c12eb0c73770b872bf FT_grammar_errs.27
-#K= cdf7a2e2740ec007efbd29feda478420 FT_grammar_errs.28
-#K= f6650d69963cef433c50e1f2acb899fc FT_grammar_errs.29
-#K= e150a96693eb561a20eebebfd637e667 FT_grammar_errs.30
-#K= b63514cf73a93962311d098284d7b491 FT_grammar_errs.31
-#K= b253cde723889c42d2c944c1b14f5a45 FT_grammar_errs.32
-#K= 7ad3dfb73e82f4d75b0770179e6dc264 FT_grammar_errs.33
-#K= f4d905e4f72dbd535bb80d7fe9df84b0 FT_grammar_errs.34
-#K= 5bf50b198d8e5fe300541adfce92e073 FT_grammar_errs.35
-#K= 7c4d73d42cff377cd84a7683b0c3e0b9 FT_grammar_errs.36
-#K= 19f1aa8d33d71888be74b19a3143938f FT_grammar_errs.37
-#K= 84309c1322631ae74ecf2c729b6aa210 FT_grammar_errs.38
-#K= 8cfe48871f91a90e6eaaef9123892394 FT_grammar_errs.39
-#K= 8aaa5fdd50ead5cd429fbba4123b215c FT_grammar_errs.40
-#K= 94cdf3b32afa4f12a00a704208aa2e53 FT_grammar_errs.41
-#K= 1a402ada248d0d50cec13a1af150ea33 FT_grammar_errs.42
-#K= 5b46a8eb0d74009462f74cf7553e3228 FT_grammar_errs.43
-#K= 546e440044828d86135dd63f1eb9ed17 FT_grammar_errs.44
-#K= 3c694a0ee2cf3a1d39f2ca8a9f3b9094 FT_grammar_errs.45
-#K= 37b7ab754e579683a28ce086c470cdc9 FT_grammar_errs.46
-#K= 3e3acfb800cfb1bcb0cc07f33b75830a FT_grammar_errs.47
-#K= 42dc6cb4fe938bb82b64c82924ef28d8 FT_grammar_errs.48
-#K= cf9320d2188f5b48d508d610d95298b2 FT_grammar_errs.49
-#K= 1f33fb1fd2365e77c3cfbd61d1ae2a7c FT_grammar_errs.50
-#K= 67588c71f92f319c6224d5917456ecd2 FT_grammar_errs.51
-#K= 22e7795f7dbeb6dc2fce5e113312781c FT_grammar_errs.52
-#K= 66d253407728c1f8a850519eadd66880 FT_grammar_errs.53
-#K= 27e8345aaeed85c1de5516871e0bbd0c FT_grammar_errs.54
-#K= 43cc8a154f28f1a668ab409a1af4e77a FT_grammar_errs.55
-#K= eda21551fcdd76ef2f192e1d9950a05f FT_grammar_errs.56
-#K= 0a8a986b5610630cb75c0568deff8315 FT_grammar_errs.57
-#K= 29bfae73351c3157a5fe409febcef276 FT_grammar_errs.58
-#K= 73a9e53428d1fb1a9813e3eab7d0ea18 FT_grammar_errs.59
-#K= 800951095b297532e25785ab101a2ba9 FT_grammar_errs.60
+#K= 26fd1565f209b383d9f2fbf0b54cd5fc FT_grammar_errs.1
+#K= 200c01632c52a63f6d186da1c6460740 FT_grammar_errs.2
+#K= 7d7141900ce6e32f15c99202309c63a4 FT_grammar_errs.3
+#K= 1bb798a5831d0119789d424ef6cb55c4 FT_grammar_errs.4
+#K= 5edd66e308b2792d5694df86c07a3eaf FT_grammar_errs.5
+#K= 6f87d92ffe0812550f43287127c6f2b9 FT_grammar_errs.6
+#K= c0eb05b58a008c722e091e1ae74440ec FT_grammar_errs.7
+#K= 911929ec0e2ffc1f13822b479dec6805 FT_grammar_errs.8
+#K= 1ac52ce8ba553ec23eb70faa3ffa1197 FT_grammar_errs.9
+#K= c1407512376369d2e591a4b25a4b607a FT_grammar_errs.10
+#K= ea94add1d76d17dbb69c1b86f3aa42b2 FT_grammar_errs.11
+#K= 2046abda72725ea06fe339d5f364f1c9 FT_grammar_errs.12
+#K= b72f7fccf76f8a5bee47a05d7bb545fb FT_grammar_errs.13
+#K= 98e2bd3e4f3da58536496a38ec3e6238 FT_grammar_errs.14
+#K= b371c6ba52503d037dbc43da788af8be FT_grammar_errs.15
+#K= cb8288d607b0c5282125852f3ab05107 FT_grammar_errs.16
+#K= c2a8d0401e4cf85ccebedf61c5d0ff4b FT_grammar_errs.17
+#K= cb8288d607b0c5282125852f3ab05107 FT_grammar_errs.18
+#K= b371c6ba52503d037dbc43da788af8be FT_grammar_errs.19
+#K= 98e2bd3e4f3da58536496a38ec3e6238 FT_grammar_errs.20
+#K= 02b210b2646aceb68f3d6d2876a3d57a FT_grammar_errs.21
+#K= 51030cd01ed601a68dd48356902954b1 FT_grammar_errs.22
+#K= af8818de076407d4e7f4e384ba110ac5 FT_grammar_errs.23
+#K= 023ba04ffced833b4776fb4fcaae7755 FT_grammar_errs.24
+#K= 0a082bb9d50f9a6257c3be5938758150 FT_grammar_errs.25
+#K= 3b956344b2338de9dd0625391b41ed35 FT_grammar_errs.26
+#K= 97779a5b22bb43912268caca0dc391d8 FT_grammar_errs.27
+#K= c02a669a8b76e15f0dcced9c4aacc5da FT_grammar_errs.28
+#K= 89822eac51e11b55c50c4e72a1203452 FT_grammar_errs.29
+#K= 56a65b28955c743f18001d1b423356fb FT_grammar_errs.30
+#K= ff1186fdf1ffe20c89fe38db596e75c2 FT_grammar_errs.31
+#K= 10945c0e8920342903ffeeb0d601babd FT_grammar_errs.32
+#K= 6a333eb2cfbb2c347b8fdfb06a979aa9 FT_grammar_errs.33
+#K= 55dba10e65775dfd1e229ddf0eb2608e FT_grammar_errs.34
+#K= dfa3b6908ea9f4b23005925d95dedd8e FT_grammar_errs.35
+#K= 3cfcc96931e76ce6396da3e27c61a6ef FT_grammar_errs.36
+#K= 04e37fe069eed91515c6a24301378548 FT_grammar_errs.37
+#K= 130bf64b92a5e34d1c4cce98899084e1 FT_grammar_errs.38
+#K= 9681a05658f1a50e3434aa991b5ce992 FT_grammar_errs.39
+#K= 38506317363a188fbb7a417ff50457a9 FT_grammar_errs.40
+#K= 02b210b2646aceb68f3d6d2876a3d57a FT_grammar_errs.41
+#K= 8c08a8b5cacbf885d022360ed856e7a1 FT_grammar_errs.42
+#K= f0f4d894a49bd2c1856cf4f013f83e54 FT_grammar_errs.43
+#K= 25b92d52cb299fa8d84c5584e490bd97 FT_grammar_errs.44
+#K= 0a082bb9d50f9a6257c3be5938758150 FT_grammar_errs.45
+#K= 2a41940f70efa80e39cb3356931e49af FT_grammar_errs.46
+#K= a3cbfcf5e452fb11994fdf41254c6775 FT_grammar_errs.47
+#K= d47387d5885927ac4d33f0675a721963 FT_grammar_errs.48
+#K= 37d2984315284521b084e62feb889527 FT_grammar_errs.49
+#K= 99b7d60f3afb7ab9fb8e14340c30df02 FT_grammar_errs.50
+#K= a16f404c515c40418f43ea1d4d8e6a7b FT_grammar_errs.51
+#K= 424841345d03bcfad704e9cdfce29794 FT_grammar_errs.52
+#K= de2bf9687e8374f566db45d45274c313 FT_grammar_errs.53
+#K= 6d923562c9fc7aaf1ac1c393aa7b55f9 FT_grammar_errs.54
+#K= 704bfc82d4cf8fee52552d33bacfc7df FT_grammar_errs.55
+#K= 426bf966b975ade7ec8c6ccf40463583 FT_grammar_errs.56
+#K= 59a11ff06013a43e7bb6a21f8f55e7b7 FT_grammar_errs.57
+#K= d6fde9bf3500a509fbd9cbf69fedb04f FT_grammar_errs.58
+#K= c6a1064235d93bc17a623216b3817cb8 FT_grammar_errs.59
+#K= 4042bdb2ea75ed254c429324b20c82b8 FT_grammar_errs.60
#K= 6e8599556a312200fb6d484565b6c52f FT_basic_queries.1
#K= db17180b59444e5e34a8fc20c40e4530 FT_basic_queries.2
#K= f7bd56bd407ff255ef2e3b5fb093ae6a FT_basic_queries.3
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 14/40] dyndbg: refactor param_set_dyndbg_classes and below
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (12 preceding siblings ...)
2026-10-13 2:36 ` [PATCH v12 13/40] dyndbg: reduce verbose/debug clutter Jim Cromie via B4 Relay
@ 2026-10-13 2:36 ` Jim Cromie via B4 Relay
2026-10-13 2:36 ` [PATCH v12 15/40] dyndbg: tighten fn-sig of ddebug_apply_class_bitmap Jim Cromie via B4 Relay
` (25 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:36 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie,
Louis Chauvet
From: Jim Cromie <jim.cromie@gmail.com>
Refactor the callchain below param_set_dyndbg_classes(1) to allow
mod-name specific settings. Split (1) into upper/lower fns, adding
modname param to lower, and passing NULL in from upper. Below that,
add the same param to ddebug_apply_class_bitmap(), and pass it thru to
_ddebug_queries(), replacing NULL with the param.
This allows the callchain to update the classmap in just one module,
vs just all as currently done. While the sysfs param is unlikely to
ever update just one module, the callchain will be used for modprobe
handling, which should update only that just-probed module.
In ddebug_apply_class_bitmap(), also check for actual changes to the
bits before announcing them, to declutter logs.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
---
v2: move RvB after SoB
v8: drop kdoc on static fn,
---
lib/dynamic_debug.c | 73 ++++++++++++++++++++++++++++++++++-------------------
1 file changed, 47 insertions(+), 26 deletions(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index d0e793a05655..bbe32fab74e8 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -618,9 +618,10 @@ static int ddebug_exec_queries(char *query, const char *modname)
return nfound;
}
-/* apply a new bitmap to the sys-knob's current bit-state */
+/* apply a new class-param setting */
static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp,
- unsigned long *new_bits, unsigned long *old_bits)
+ unsigned long *new_bits, unsigned long *old_bits,
+ const char *query_modname)
{
#define QUERY_SIZE 128
char query[QUERY_SIZE];
@@ -628,7 +629,9 @@ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp,
int matches = 0;
int bi, ct;
- v2pr_info("apply: 0x%lx to: 0x%lx\n", *new_bits, *old_bits);
+ if (*new_bits != *old_bits)
+ v2pr_info("apply bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits,
+ *old_bits, query_modname ?: "'*'");
for (bi = 0; bi < map->length; bi++) {
if (test_bit(bi, new_bits) == test_bit(bi, old_bits))
@@ -637,12 +640,16 @@ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp,
snprintf(query, QUERY_SIZE, "class %s %c%s", map->class_names[bi],
test_bit(bi, new_bits) ? '+' : '-', dcp->flags);
- ct = ddebug_exec_queries(query, NULL);
+ ct = ddebug_exec_queries(query, query_modname);
matches += ct;
v2pr_info("bit_%d: %d matches on class: %s -> 0x%lx\n", bi,
ct, map->class_names[bi], *new_bits);
}
+ if (*new_bits != *old_bits)
+ v2pr_info("applied bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits,
+ *old_bits, query_modname ?: "'*'");
+
return matches;
}
@@ -651,22 +658,17 @@ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp,
#define CLASSMAP_BITMASK(width) ((1UL << (width)) - 1)
-/**
- * param_set_dyndbg_classes - class FOO >control
- * @instr: string echo>d to sysfs, input depends on map_type
- * @kp: kp->arg has state: bits/lvl, map, map_type
- *
- * Enable/disable prdbgs by their class, as given in the arguments to
- * DECLARE_DYNDBG_CLASSMAP. For LEVEL map-types, enforce relative
- * levels by bitpos.
- *
- * Returns: 0 or <0 if error.
+/*
+ * param-setter helper to validate numeric input, clamp its value by
+ * the classmap type and size, and apply the bits.
*/
-int param_set_dyndbg_classes(const char *instr, const struct kernel_param *kp)
+static int param_set_dyndbg_module_classes(const char *instr,
+ const struct kernel_param *kp,
+ const char *mod_name)
{
const struct ddebug_class_param *dcp = kp->arg;
const struct ddebug_class_map *map = dcp->map;
- unsigned long inrep, new_bits, old_bits;
+ unsigned long inrep, new_bits, old_bits, old_val;
int rc, totct = 0;
rc = kstrtoul(instr, 0, &inrep);
@@ -686,9 +688,10 @@ int param_set_dyndbg_classes(const char *instr, const struct kernel_param *kp)
KP_NAME(kp), inrep, CLASSMAP_BITMASK(map->length));
inrep &= CLASSMAP_BITMASK(map->length);
}
- v2pr_info("bits:%lx > %s\n", inrep, KP_NAME(kp));
- totct += ddebug_apply_class_bitmap(dcp, &inrep, dcp->bits);
- *dcp->bits = inrep;
+ old_val = READ_ONCE(*dcp->bits);
+ v2pr_info("bits:0x%lx > %s.%s\n", inrep, mod_name ?: "*", KP_NAME(kp));
+ totct += ddebug_apply_class_bitmap(dcp, &inrep, &old_val, mod_name);
+ WRITE_ONCE(*dcp->bits, inrep);
break;
case DD_CLASS_TYPE_LEVEL_NUM:
/* input is bitpos, of highest verbosity to be enabled */
@@ -697,11 +700,12 @@ int param_set_dyndbg_classes(const char *instr, const struct kernel_param *kp)
KP_NAME(kp), inrep, map->length);
inrep = map->length;
}
- old_bits = CLASSMAP_BITMASK(*dcp->lvl);
+ old_val = READ_ONCE(*dcp->lvl);
+ old_bits = CLASSMAP_BITMASK(old_val);
new_bits = CLASSMAP_BITMASK(inrep);
v2pr_info("lvl:%ld bits:0x%lx > %s\n", inrep, new_bits, KP_NAME(kp));
- totct += ddebug_apply_class_bitmap(dcp, &new_bits, &old_bits);
- *dcp->lvl = inrep;
+ totct += ddebug_apply_class_bitmap(dcp, &new_bits, &old_bits, mod_name);
+ WRITE_ONCE(*dcp->lvl, inrep);
break;
default:
pr_warn("%s: bad map type: %d\n", KP_NAME(kp), map->map_type);
@@ -710,16 +714,33 @@ int param_set_dyndbg_classes(const char *instr, const struct kernel_param *kp)
vpr_info("%s: total matches: %d\n", KP_NAME(kp), totct);
return 0;
}
+
+/**
+ * param_set_dyndbg_classes - classmap-based kernel parameter setter
+ * @instr: string value to set (numeric bitmask or level)
+ * @kp: kernel parameter info referencing classmap state
+ *
+ * Enable or disable all class'd pr_debug callsites in the classmap,
+ * independent of the module they're in.
+ *
+ * Returns: 0 on success, or a negative error code.
+ */
+int param_set_dyndbg_classes(const char *instr, const struct kernel_param *kp)
+{
+ return param_set_dyndbg_module_classes(instr, kp, NULL);
+}
EXPORT_SYMBOL(param_set_dyndbg_classes);
/**
- * param_get_dyndbg_classes - classes reader
+ * param_get_dyndbg_classes - classmap kparam getter
* @buffer: string description of controlled bits -> classes
* @kp: kp->arg has state: bits, map
*
- * Reads last written state, underlying prdbg state may have been
- * altered by direct >control. Displays 0x for DISJOINT, 0-N for
- * LEVEL Returns: #chars written or <0 on error
+ * Reads last written state, underlying pr_debug states may have been
+ * altered by direct >control. Displays 0x for DISJOINT classmap
+ * types, 0-N for LEVEL types.
+ *
+ * Returns: ct of chars written or <0 on error
*/
int param_get_dyndbg_classes(char *buffer, const struct kernel_param *kp)
{
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 15/40] dyndbg: tighten fn-sig of ddebug_apply_class_bitmap
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (13 preceding siblings ...)
2026-10-13 2:36 ` [PATCH v12 14/40] dyndbg: refactor param_set_dyndbg_classes and below Jim Cromie via B4 Relay
@ 2026-10-13 2:36 ` Jim Cromie via B4 Relay
2026-10-13 2:36 ` [PATCH v12 16/40] dyndbg: replace classmap list with an array-slice Jim Cromie via B4 Relay
` (24 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:36 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie,
Louis Chauvet
From: Jim Cromie <jim.cromie@gmail.com>
old_bits arg is currently a pointer to the input bits, but this could
allow inadvertent changes to the input by the fn. Disallow this.
And constify new_bits while here.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
---
v2: move RvB after SoB
---
lib/dynamic_debug.c | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index bbe32fab74e8..474df0dbedc1 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -620,7 +620,8 @@ static int ddebug_exec_queries(char *query, const char *modname)
/* apply a new class-param setting */
static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp,
- unsigned long *new_bits, unsigned long *old_bits,
+ const unsigned long *new_bits,
+ const unsigned long old_bits,
const char *query_modname)
{
#define QUERY_SIZE 128
@@ -629,12 +630,12 @@ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp,
int matches = 0;
int bi, ct;
- if (*new_bits != *old_bits)
+ if (*new_bits != old_bits)
v2pr_info("apply bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits,
- *old_bits, query_modname ?: "'*'");
+ old_bits, query_modname ?: "'*'");
for (bi = 0; bi < map->length; bi++) {
- if (test_bit(bi, new_bits) == test_bit(bi, old_bits))
+ if (test_bit(bi, new_bits) == test_bit(bi, &old_bits))
continue;
snprintf(query, QUERY_SIZE, "class %s %c%s", map->class_names[bi],
@@ -646,9 +647,9 @@ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp,
v2pr_info("bit_%d: %d matches on class: %s -> 0x%lx\n", bi,
ct, map->class_names[bi], *new_bits);
}
- if (*new_bits != *old_bits)
+ if (*new_bits != old_bits)
v2pr_info("applied bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits,
- *old_bits, query_modname ?: "'*'");
+ old_bits, query_modname ?: "'*'");
return matches;
}
@@ -690,7 +691,7 @@ static int param_set_dyndbg_module_classes(const char *instr,
}
old_val = READ_ONCE(*dcp->bits);
v2pr_info("bits:0x%lx > %s.%s\n", inrep, mod_name ?: "*", KP_NAME(kp));
- totct += ddebug_apply_class_bitmap(dcp, &inrep, &old_val, mod_name);
+ totct += ddebug_apply_class_bitmap(dcp, &inrep, old_val, mod_name);
WRITE_ONCE(*dcp->bits, inrep);
break;
case DD_CLASS_TYPE_LEVEL_NUM:
@@ -704,7 +705,7 @@ static int param_set_dyndbg_module_classes(const char *instr,
old_bits = CLASSMAP_BITMASK(old_val);
new_bits = CLASSMAP_BITMASK(inrep);
v2pr_info("lvl:%ld bits:0x%lx > %s\n", inrep, new_bits, KP_NAME(kp));
- totct += ddebug_apply_class_bitmap(dcp, &new_bits, &old_bits, mod_name);
+ totct += ddebug_apply_class_bitmap(dcp, &new_bits, old_bits, mod_name);
WRITE_ONCE(*dcp->lvl, inrep);
break;
default:
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 16/40] dyndbg: replace classmap list with an array-slice
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (14 preceding siblings ...)
2026-10-13 2:36 ` [PATCH v12 15/40] dyndbg: tighten fn-sig of ddebug_apply_class_bitmap Jim Cromie via B4 Relay
@ 2026-10-13 2:36 ` Jim Cromie via B4 Relay
2026-10-13 2:36 ` [PATCH v12 17/40] dyndbg: macrofy a 2-index for-loop pattern Jim Cromie via B4 Relay
` (23 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:36 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie,
Louis Chauvet
From: Jim Cromie <jim.cromie@gmail.com>
Classmaps are stored in an elf section/array, but currently are
individually list-linked onto dyndbg's per-module ddebug_table for
operation. This is unnecessary.
Just like dyndbg's descriptors, classmaps are packed in compile order;
so even with many builtin modules employing multiple classmaps, each
modules' maps are packed contiguously, and can be treated as a
array-start-address & array-length.
So this drops the whole list building operation done in
ddebug_attach_module_classes(), and removes the list-head members of
the classmap structs. The "select-by-modname" condition is reused to
find the start,end of the subrange of classmaps belonging to the module.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
---
v2: RvB after SoB
---
include/linux/dynamic_debug.h | 1 -
lib/dynamic_debug.c | 64 +++++++++++++++++++++++--------------------
2 files changed, 35 insertions(+), 30 deletions(-)
diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
index baf5c0853f45..9cd262a3fcba 100644
--- a/include/linux/dynamic_debug.h
+++ b/include/linux/dynamic_debug.h
@@ -76,7 +76,6 @@ enum ddebug_class_map_type {
};
struct ddebug_class_map {
- struct list_head link;
struct module *mod;
const char *mod_name; /* needed for builtins */
const char **class_names;
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 474df0dbedc1..1c0604d7e3cc 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -45,10 +45,11 @@ extern struct ddebug_class_map __start___dyndbg_classes[];
extern struct ddebug_class_map __stop___dyndbg_classes[];
struct ddebug_table {
- struct list_head link, maps;
+ struct list_head link;
const char *mod_name;
- unsigned int num_ddebugs;
struct _ddebug *ddebugs;
+ struct ddebug_class_map *classes;
+ unsigned int num_ddebugs, num_classes;
};
struct ddebug_query {
@@ -149,12 +150,13 @@ static void v3pr_info_dq(const struct ddebug_query *query, const char *msg)
}
static struct ddebug_class_map *ddebug_find_valid_class(struct ddebug_table const *dt,
- const char *class_string, int *class_id)
+ const char *class_string,
+ int *class_id)
{
struct ddebug_class_map *map;
- int idx;
+ int i, idx;
- list_for_each_entry(map, &dt->maps, link) {
+ for (map = dt->classes, i = 0; i < dt->num_classes; i++, map++) {
idx = match_string(map->class_names, map->length, class_string);
if (idx >= 0) {
*class_id = idx + map->base;
@@ -235,7 +237,7 @@ static int ddebug_change(const struct ddebug_query *query,
unsigned int nfound = 0;
struct flagsbuf fbuf, nbuf;
struct ddebug_class_map *map = NULL;
- int __outvar valid_class;
+ int valid_class;
/* search for matching ddebugs */
mutex_lock(&ddebug_lock);
@@ -1067,9 +1069,10 @@ static void *ddebug_proc_next(struct seq_file *m, void *p, loff_t *pos)
static const char *ddebug_class_name(struct ddebug_iter *iter, struct _ddebug *dp)
{
- struct ddebug_class_map *map;
+ struct ddebug_class_map *map = iter->table->classes;
+ int i, nc = iter->table->num_classes;
- list_for_each_entry(map, &iter->table->maps, link)
+ for (i = 0; i < nc; i++, map++)
if (class_in_range(dp->class_id, map))
return map->class_names[dp->class_id - map->base];
@@ -1153,30 +1156,34 @@ static const struct proc_ops proc_fops = {
.proc_write = ddebug_proc_write
};
-static void ddebug_attach_module_classes(struct ddebug_table *dt,
- struct ddebug_class_map *classes,
- int num_classes)
+static void ddebug_attach_module_classes(struct ddebug_table *dt, struct _ddebug_info *di)
{
struct ddebug_class_map *cm;
- int i, j, ct = 0;
+ int i, nc = 0;
- for (cm = classes, i = 0; i < num_classes; i++, cm++) {
+ /*
+ * Find this module's classmaps in a subrange/wholerange of
+ * the builtin/modular classmap vector/section. Save the start
+ * and length of the subrange at its edges.
+ */
+ for (cm = di->classes, i = 0; i < di->num_classes; i++, cm++) {
if (!strcmp(cm->mod_name, dt->mod_name)) {
-
- v2pr_info("class[%d]: module:%s base:%d len:%d ty:%d\n", i,
- cm->mod_name, cm->base, cm->length, cm->map_type);
-
- for (j = 0; j < cm->length; j++)
- v3pr_info(" %d: %d %s\n", j + cm->base, j,
- cm->class_names[j]);
-
- list_add(&cm->link, &dt->maps);
- ct++;
+ if (!nc) {
+ v2pr_info("start subrange, class[%d]: module:%s base:%d len:%d ty:%d\n",
+ i, cm->mod_name, cm->base, cm->length, cm->map_type);
+ dt->classes = cm;
+ }
+ nc++;
+ } else if (nc) {
+ /* end of matching classmaps */
+ break;
}
}
- if (ct)
- vpr_info("module:%s attached %d classes\n", dt->mod_name, ct);
+ if (nc) {
+ dt->num_classes = nc;
+ vpr_info("module:%s attached %d classes\n", dt->mod_name, nc);
+ }
}
/*
@@ -1208,10 +1215,9 @@ static int ddebug_add_module(struct _ddebug_info *di, const char *modname)
dt->num_ddebugs = di->num_descs;
INIT_LIST_HEAD(&dt->link);
- INIT_LIST_HEAD(&dt->maps);
if (di->classes && di->num_classes)
- ddebug_attach_module_classes(dt, di->classes, di->num_classes);
+ ddebug_attach_module_classes(dt, di);
mutex_lock(&ddebug_lock);
list_add_tail(&dt->link, &ddebug_tables);
@@ -1324,8 +1330,8 @@ static void ddebug_remove_all_tables(void)
mutex_lock(&ddebug_lock);
while (!list_empty(&ddebug_tables)) {
struct ddebug_table *dt = list_entry(ddebug_tables.next,
- struct ddebug_table,
- link);
+ struct ddebug_table,
+ link);
ddebug_table_free(dt);
}
mutex_unlock(&ddebug_lock);
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 17/40] dyndbg: macrofy a 2-index for-loop pattern
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (15 preceding siblings ...)
2026-10-13 2:36 ` [PATCH v12 16/40] dyndbg: replace classmap list with an array-slice Jim Cromie via B4 Relay
@ 2026-10-13 2:36 ` Jim Cromie via B4 Relay
2026-10-13 2:36 ` [PATCH v12 18/40] dyndbg: reduce class param storage to u32 Jim Cromie via B4 Relay
` (22 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:36 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie,
Louis Chauvet
From: Jim Cromie <jim.cromie@gmail.com>
dynamic-debug currently has 2 __sections (__dyndbg, __dyndb_classes),
struct _ddebug_info keeps track of them both, with 2 members each:
_vec and _vec#_len.
We need to loop over these sections, with index and record pointer,
making ref to both _vec and _vec_len. This is already fiddly and
error-prone, and will get worse as we add a 3rd section.
Lets instead embed/abstract the fiddly-ness in the `for_subvec()`
macro, and avoid repeating it going forward.
This is a for-loop macro expander, so it syntactically expects to
precede either a single statement or a { block } of them, and the
usual typeof or do-while-0 tricks are unavailable to fix the
multiple-expansion warning.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
---
v2: move RvB after SoB
---
lib/dynamic_debug.c | 19 ++++++++++++++++---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 1c0604d7e3cc..84a311fac657 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -149,6 +149,20 @@ static void v3pr_info_dq(const struct ddebug_query *query, const char *msg)
query->first_lineno, query->last_lineno, query->class_string);
}
+/*
+ * simplify a repeated for-loop pattern walking N steps in a T _vec
+ * member inside a struct _box. It expects int i and T *_sp to be
+ * declared in the caller.
+ * @_i: caller provided counter.
+ * @_sp: cursor into _vec, to examine each item.
+ * @_box: ptr to a struct containing @_vec member
+ * @_vec: name of a member in @_box
+ */
+#define for_subvec(_i, _sp, _box, _vec) \
+ for ((_i) = 0, (_sp) = (_box)->_vec; \
+ (_i) < (_box)->num_##_vec; \
+ (_i)++, (_sp)++) /* { block } */
+
static struct ddebug_class_map *ddebug_find_valid_class(struct ddebug_table const *dt,
const char *class_string,
int *class_id)
@@ -156,7 +170,7 @@ static struct ddebug_class_map *ddebug_find_valid_class(struct ddebug_table cons
struct ddebug_class_map *map;
int i, idx;
- for (map = dt->classes, i = 0; i < dt->num_classes; i++, map++) {
+ for_subvec(i, map, dt, classes) {
idx = match_string(map->class_names, map->length, class_string);
if (idx >= 0) {
*class_id = idx + map->base;
@@ -1166,8 +1180,7 @@ static void ddebug_attach_module_classes(struct ddebug_table *dt, struct _ddebug
* the builtin/modular classmap vector/section. Save the start
* and length of the subrange at its edges.
*/
- for (cm = di->classes, i = 0; i < di->num_classes; i++, cm++) {
-
+ for_subvec(i, cm, di, classes) {
if (!strcmp(cm->mod_name, dt->mod_name)) {
if (!nc) {
v2pr_info("start subrange, class[%d]: module:%s base:%d len:%d ty:%d\n",
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 18/40] dyndbg: reduce class param storage to u32
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (16 preceding siblings ...)
2026-10-13 2:36 ` [PATCH v12 17/40] dyndbg: macrofy a 2-index for-loop pattern Jim Cromie via B4 Relay
@ 2026-10-13 2:36 ` Jim Cromie via B4 Relay
2026-10-13 2:36 ` [PATCH v12 19/40] dyndbg,module: make proper substructs in _ddebug_info Jim Cromie via B4 Relay
` (21 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:36 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie
From: Jim Cromie <jim.cromie@gmail.com>
Currently, `struct ddebug_class_param` uses pointers to `unsigned
long` values which store the state of `bits` and `lvl`, so it changes
sizes depending upon the architecture. Make it always u32 for
consistency.
The bits field references __drm_debug, which was unsigned int, before
commit f158936b60a7 ("drm: POC drm on dyndbg - use in core, 2 helpers, 3 drivers.")
changed it to unsigned long. This patch changes it back.
That enlargement was a thinko; although modules can have up to 63
classes, and *could* have put all those classes in a single classmap,
the reason for it is to support multiple classmaps (with
non-overlapping class-id ranges).
32 bits is a practical limit for a class-param's usability since all
classes are set together with a single write of a hex value; 16 would
be a realistic limit, drm.debug has ~12 classes.
#> echo 0x0fff > /sys/module/drm/parameters/debug
Several followon patches add a number of compile-time validations,
including a num-classes <=32 check.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
v8: add a <32 limit to prevent undefined shifts on 32 bit number
v5: u32 for all arches
v4: undo change struct ddebug_class_param to _ddebug_class_param
v3:
fix undefd behavior when classmaps is all 64 bits.
change module_param_named( type-arg from ulong to ullong)
change struct ddebug_class_param to _ddebug_class_param
in drivers/gpu/drm/drm_print.{c,h}
api change later
v2:
patch was "make bits & lvl same size"
but that size was unsigned long, only 32 bits on i386 etc
use u64 for all bits, and %llu %llx
u64-fix
u64-drm-dbg
---
drivers/gpu/drm/drm_print.c | 4 ++--
include/drm/drm_print.h | 2 +-
include/linux/dynamic_debug.h | 4 ++--
lib/dynamic_debug.c | 37 ++++++++++++++++++++-----------------
lib/test_dynamic_debug.c | 2 +-
5 files changed, 26 insertions(+), 23 deletions(-)
diff --git a/drivers/gpu/drm/drm_print.c b/drivers/gpu/drm/drm_print.c
index 86cef1a37678..794417c62097 100644
--- a/drivers/gpu/drm/drm_print.c
+++ b/drivers/gpu/drm/drm_print.c
@@ -40,7 +40,7 @@
* __drm_debug: Enable debug output.
* Bitmask of DRM_UT_x. See include/drm/drm_print.h for details.
*/
-unsigned long __drm_debug;
+u32 __drm_debug;
EXPORT_SYMBOL(__drm_debug);
MODULE_PARM_DESC(debug, "Enable debug output, where each bit enables a debug category.\n"
@@ -56,7 +56,7 @@ MODULE_PARM_DESC(debug, "Enable debug output, where each bit enables a debug cat
"\t\tBit 9 (0x200) will enable DRMRES messages (managed resources code)");
#if !defined(CONFIG_DRM_USE_DYNAMIC_DEBUG)
-module_param_named(debug, __drm_debug, ulong, 0600);
+module_param_named(debug, __drm_debug, uint, 0600);
#else
/* classnames must match vals of enum drm_debug_category */
DECLARE_DYNDBG_CLASSMAP(drm_debug_classes, DD_CLASS_TYPE_DISJOINT_BITS, 0,
diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
index 2adc5ac688e1..50b3ba0ae76d 100644
--- a/include/drm/drm_print.h
+++ b/include/drm/drm_print.h
@@ -39,7 +39,7 @@ struct drm_device;
struct seq_file;
/* Do *not* use outside of drm_print.[ch]! */
-extern unsigned long __drm_debug;
+extern u32 __drm_debug;
/**
* DOC: print
diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
index 9cd262a3fcba..36b7d341076d 100644
--- a/include/linux/dynamic_debug.h
+++ b/include/linux/dynamic_debug.h
@@ -94,8 +94,8 @@ struct _ddebug_info {
struct ddebug_class_param {
union {
- unsigned long *bits;
- unsigned int *lvl;
+ u32 *bits;
+ u32 *lvl;
};
char flags[8];
const struct ddebug_class_map *map;
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 84a311fac657..72bfbec0ac02 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -586,6 +586,7 @@ static int ddebug_exec_query(char *query_string, const char *modname)
pr_err("query parse failed\n");
return -EINVAL;
}
+
/* actually go and implement the change */
nfound = ddebug_change(&query, &modifiers);
v3pr_info_dq(&query, nfound ? "applied" : "no-match");
@@ -636,8 +637,7 @@ static int ddebug_exec_queries(char *query, const char *modname)
/* apply a new class-param setting */
static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp,
- const unsigned long *new_bits,
- const unsigned long old_bits,
+ const u32 *new_bits, const u32 old_bits,
const char *query_modname)
{
#define QUERY_SIZE 128
@@ -647,24 +647,27 @@ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp,
int bi, ct;
if (*new_bits != old_bits)
- v2pr_info("apply bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits,
+ v2pr_info("apply bitmap: 0x%x to: 0x%x for %s\n", *new_bits,
old_bits, query_modname ?: "'*'");
- for (bi = 0; bi < map->length; bi++) {
- if (test_bit(bi, new_bits) == test_bit(bi, &old_bits))
+ for (bi = 0; bi < map->length && bi < 32; bi++) {
+ bool new_b = !!(*new_bits & BIT(bi));
+ bool old_b = !!(old_bits & BIT(bi));
+
+ if (new_b == old_b)
continue;
snprintf(query, QUERY_SIZE, "class %s %c%s", map->class_names[bi],
- test_bit(bi, new_bits) ? '+' : '-', dcp->flags);
+ new_b ? '+' : '-', dcp->flags);
ct = ddebug_exec_queries(query, query_modname);
matches += ct;
- v2pr_info("bit_%d: %d matches on class: %s -> 0x%lx\n", bi,
+ v2pr_info("bit_%d: %d matches on class: %s -> 0x%x\n", bi,
ct, map->class_names[bi], *new_bits);
}
if (*new_bits != old_bits)
- v2pr_info("applied bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits,
+ v2pr_info("applied bitmap: 0x%x to: 0x%x for %s\n", *new_bits,
old_bits, query_modname ?: "'*'");
return matches;
@@ -673,7 +676,7 @@ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp,
/* stub to later conditionally add "$module." prefix where not already done */
#define KP_NAME(kp) kp->name
-#define CLASSMAP_BITMASK(width) ((1UL << (width)) - 1)
+#define CLASSMAP_BITMASK(width) ((width) >= 32 ? ~0U : (1U << (width)) - 1)
/*
* param-setter helper to validate numeric input, clamp its value by
@@ -685,10 +688,10 @@ static int param_set_dyndbg_module_classes(const char *instr,
{
const struct ddebug_class_param *dcp = kp->arg;
const struct ddebug_class_map *map = dcp->map;
- unsigned long inrep, new_bits, old_bits, old_val;
+ u32 inrep, new_bits, old_bits, old_val;
int rc, totct = 0;
- rc = kstrtoul(instr, 0, &inrep);
+ rc = kstrtou32(instr, 0, &inrep);
if (rc) {
int len = strcspn(instr, "\n");
@@ -701,26 +704,26 @@ static int param_set_dyndbg_module_classes(const char *instr,
case DD_CLASS_TYPE_DISJOINT_BITS:
/* expect bits. mask and warn if too many */
if (inrep & ~CLASSMAP_BITMASK(map->length)) {
- pr_warn("%s: input: 0x%lx exceeds mask: 0x%lx, masking\n",
+ pr_warn("%s: input: 0x%x exceeds mask: 0x%x, masking\n",
KP_NAME(kp), inrep, CLASSMAP_BITMASK(map->length));
inrep &= CLASSMAP_BITMASK(map->length);
}
old_val = READ_ONCE(*dcp->bits);
- v2pr_info("bits:0x%lx > %s.%s\n", inrep, mod_name ?: "*", KP_NAME(kp));
+ v2pr_info("bits:0x%x > %s.%s\n", inrep, mod_name ?: "*", KP_NAME(kp));
totct += ddebug_apply_class_bitmap(dcp, &inrep, old_val, mod_name);
WRITE_ONCE(*dcp->bits, inrep);
break;
case DD_CLASS_TYPE_LEVEL_NUM:
/* input is bitpos, of highest verbosity to be enabled */
if (inrep > map->length) {
- pr_warn("%s: level:%ld exceeds max:%d, clamping\n",
+ pr_warn("%s: level:%u exceeds max:%d, clamping\n",
KP_NAME(kp), inrep, map->length);
inrep = map->length;
}
old_val = READ_ONCE(*dcp->lvl);
old_bits = CLASSMAP_BITMASK(old_val);
new_bits = CLASSMAP_BITMASK(inrep);
- v2pr_info("lvl:%ld bits:0x%lx > %s\n", inrep, new_bits, KP_NAME(kp));
+ v2pr_info("lvl:%u bits:0x%x > %s\n", inrep, new_bits, KP_NAME(kp));
totct += ddebug_apply_class_bitmap(dcp, &new_bits, old_bits, mod_name);
WRITE_ONCE(*dcp->lvl, inrep);
break;
@@ -766,9 +769,9 @@ int param_get_dyndbg_classes(char *buffer, const struct kernel_param *kp)
switch (map->map_type) {
case DD_CLASS_TYPE_DISJOINT_BITS:
- return scnprintf(buffer, PAGE_SIZE, "0x%lx\n", *dcp->bits);
+ return scnprintf(buffer, PAGE_SIZE, "0x%x\n", *dcp->bits);
case DD_CLASS_TYPE_LEVEL_NUM:
- return scnprintf(buffer, PAGE_SIZE, "%d\n", *dcp->lvl);
+ return scnprintf(buffer, PAGE_SIZE, "%u\n", *dcp->lvl);
default:
return -1;
}
diff --git a/lib/test_dynamic_debug.c b/lib/test_dynamic_debug.c
index 74d183ebf3e0..9e8e028461ad 100644
--- a/lib/test_dynamic_debug.c
+++ b/lib/test_dynamic_debug.c
@@ -40,7 +40,7 @@ module_param_cb(do_prints, ¶m_ops_do_prints, NULL, 0600);
* - tie together sysname, mapname, bitsname, flagsname
*/
#define DD_SYS_WRAP(_model, _flags) \
- static unsigned long bits_##_model; \
+ static u32 bits_##_model; \
static struct ddebug_class_param _flags##_model = { \
.bits = &bits_##_model, \
.flags = #_flags, \
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 19/40] dyndbg,module: make proper substructs in _ddebug_info
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (17 preceding siblings ...)
2026-10-13 2:36 ` [PATCH v12 18/40] dyndbg: reduce class param storage to u32 Jim Cromie via B4 Relay
@ 2026-10-13 2:36 ` Jim Cromie via B4 Relay
2026-10-13 2:36 ` [PATCH v12 20/40] dyndbg: move mod_name down from struct ddebug_table to _ddebug_info Jim Cromie via B4 Relay
` (20 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:36 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie,
Louis Chauvet
From: Jim Cromie <jim.cromie@gmail.com>
recompose struct _ddebug_info, inserting proper sub-structs.
The struct _ddebug_info has 2 pairs of _vec, num_##_vec fields, for
descs and classes respectively. for_subvec() makes walking these
vectors less cumbersome, now lets move those field pairs into their
own "vec" structs: _ddebug_descs & _ddebug_class_maps, and re-compose
struct _ddebug_info to contain them cleanly. This also lets us get
rid of for_subvec()'s num_##_vec paste-up.
Also recompose struct ddebug_table to contain a _ddebug_info. This
reinforces _ddebug_info's use as a cursor into relevant data for a
builtin module, and access to the full _ddebug state for modules.
NOTES:
rename section:__dyndbg_classes to _class_maps, to better align with
struct _ddebug_class_maps.
names together, for more obvious name pairing.
Invariant: These vectors ref a contiguous subrange of __section memory
in builtin/DATA or in loadable modules via mod->dyndbg_info; with
guaranteed life-time for us.
struct module contains a _ddebug_info field and module/main.c sets it
up, so that gets adjusted rather obviously.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
---
v8: set maps.len = nc unconditionally
v3: squash in section name changes.
v2:
Move RvB after SoB
In structs _ddebug_descs & _ddebug_class_maps, change int length to unsigned int
No use of <0 vals is contemplated.
dyndbg: improve section names
change __dyndbg to __dyndbg_descs
change __dyndbg_classes to __dyndbg_class_maps
this sets up for adding __dyndbg_class_users
fixup-drmprint
---
include/asm-generic/dyndbg.lds.h | 14 +++---
include/linux/dynamic_debug.h | 34 ++++++++-----
kernel/module/main.c | 12 ++---
lib/dynamic_debug.c | 101 +++++++++++++++++++--------------------
4 files changed, 86 insertions(+), 75 deletions(-)
diff --git a/include/asm-generic/dyndbg.lds.h b/include/asm-generic/dyndbg.lds.h
index 9d8951bef688..ec661f9f3793 100644
--- a/include/asm-generic/dyndbg.lds.h
+++ b/include/asm-generic/dyndbg.lds.h
@@ -3,16 +3,16 @@
#define __ASM_GENERIC_DYNDBG_LDS_H
#include <asm-generic/bounded_sections.lds.h>
-#define DYNDBG_SECTIONS() \
- BOUNDED_SECTION_BY(__dyndbg, ___dyndbg) \
- BOUNDED_SECTION_BY(__dyndbg_classes, ___dyndbg_classes)
+#define DYNDBG_SECTIONS() \
+ BOUNDED_SECTION_BY(__dyndbg_descs, ___dyndbg_descs) \
+ BOUNDED_SECTION_BY(__dyndbg_class_maps, ___dyndbg_class_maps)
#define MOD_DYNDBG_SECTIONS() \
- __dyndbg 0 : ALIGN(8) { \
- KEEP(*(__dyndbg)) \
+ __dyndbg_descs 0 : ALIGN(8) { \
+ KEEP(*(__dyndbg_descs)) \
} \
- __dyndbg_classes 0 : ALIGN(8) { \
- KEEP(*(__dyndbg_classes)) \
+ __dyndbg_class_maps 0 : ALIGN(8) { \
+ KEEP(*(__dyndbg_class_maps)) \
}
#endif /* __ASM_GENERIC_DYNDBG_LDS_H */
diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
index 36b7d341076d..b05dc843a1d8 100644
--- a/include/linux/dynamic_debug.h
+++ b/include/linux/dynamic_debug.h
@@ -76,7 +76,7 @@ enum ddebug_class_map_type {
};
struct ddebug_class_map {
- struct module *mod;
+ struct module *mod; /* NULL for builtins */
const char *mod_name; /* needed for builtins */
const char **class_names;
const int length;
@@ -84,12 +84,24 @@ struct ddebug_class_map {
enum ddebug_class_map_type map_type;
};
-/* encapsulate linker provided built-in (or module) dyndbg data */
+/*
+ * @_ddebug_info: gathers module/builtin dyndbg_* __sections together.
+ * For builtins, it is used as a cursor, with the inner structs
+ * marking sub-vectors of the builtin __sections in DATA.
+ */
+struct _ddebug_descs {
+ struct _ddebug *start;
+ unsigned int len;
+};
+
+struct _ddebug_class_maps {
+ struct ddebug_class_map *start;
+ unsigned int len;
+};
+
struct _ddebug_info {
- struct _ddebug *descs;
- struct ddebug_class_map *classes;
- unsigned int num_descs;
- unsigned int num_classes;
+ struct _ddebug_descs descs;
+ struct _ddebug_class_maps maps;
};
struct ddebug_class_param {
@@ -110,7 +122,7 @@ struct ddebug_class_param {
/**
* DECLARE_DYNDBG_CLASSMAP - declare classnames known by a module
- * @_var: a struct _ddebug_class_map, passed to module_param_cb
+ * @_var: a struct ddebug_class_map, passed to module_param_cb
* @_maptype: enum ddebug_class_map_type, chooses bits/verbose
* @_base: offset of 1st class-name. splits .class_id space
* @classes: class-names used to control class'd prdbgs
@@ -118,7 +130,7 @@ struct ddebug_class_param {
#define DECLARE_DYNDBG_CLASSMAP(_var, _maptype, _base, ...) \
static const char *_var##_classnames[] = { __VA_ARGS__ }; \
static struct ddebug_class_map __aligned(8) __used \
- __section("__dyndbg_classes") _var = { \
+ __section("__dyndbg_class_maps") _var = { \
.mod = THIS_MODULE, \
.mod_name = KBUILD_MODNAME, \
.base = _base, \
@@ -158,7 +170,7 @@ void __dynamic_ibdev_dbg(struct _ddebug *descriptor,
#define DEFINE_DYNAMIC_DEBUG_METADATA_CLS(name, cls, fmt) \
static struct _ddebug __aligned(8) \
- __section("__dyndbg") name = { \
+ __section("__dyndbg_descs") name = { \
.modname = KBUILD_MODNAME, \
.function = __func__, \
.filename = __FILE__, \
@@ -245,7 +257,7 @@ void __dynamic_ibdev_dbg(struct _ddebug *descriptor,
* macro.
*/
#define _dynamic_func_call_cls(cls, fmt, func, ...) \
- __dynamic_func_call_cls(__UNIQUE_ID(ddebug), cls, fmt, func, ##__VA_ARGS__)
+ __dynamic_func_call_cls(__UNIQUE_ID(_ddebug), cls, fmt, func, ##__VA_ARGS__)
#define _dynamic_func_call(fmt, func, ...) \
_dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
@@ -255,7 +267,7 @@ void __dynamic_ibdev_dbg(struct _ddebug *descriptor,
* with precisely the macro's varargs.
*/
#define _dynamic_func_call_cls_no_desc(cls, fmt, func, ...) \
- __dynamic_func_call_cls_no_desc(__UNIQUE_ID(ddebug), cls, fmt, \
+ __dynamic_func_call_cls_no_desc(__UNIQUE_ID(_ddebug), cls, fmt, \
func, ##__VA_ARGS__)
#define _dynamic_func_call_no_desc(fmt, func, ...) \
_dynamic_func_call_cls_no_desc(_DPRINTK_CLASS_DFLT, fmt, \
diff --git a/kernel/module/main.c b/kernel/module/main.c
index c1b34dc1e89a..852cce2c5113 100644
--- a/kernel/module/main.c
+++ b/kernel/module/main.c
@@ -2785,12 +2785,12 @@ static int find_module_sections(struct module *mod, struct load_info *info)
pr_warn("%s: Ignoring obsolete parameters\n", mod->name);
#ifdef CONFIG_DYNAMIC_DEBUG_CORE
- mod->dyndbg_info.descs = section_objs(info, "__dyndbg",
- sizeof(*mod->dyndbg_info.descs),
- &mod->dyndbg_info.num_descs);
- mod->dyndbg_info.classes = section_objs(info, "__dyndbg_classes",
- sizeof(*mod->dyndbg_info.classes),
- &mod->dyndbg_info.num_classes);
+ mod->dyndbg_info.descs.start = section_objs(info, "__dyndbg_descs",
+ sizeof(*mod->dyndbg_info.descs.start),
+ &mod->dyndbg_info.descs.len);
+ mod->dyndbg_info.maps.start = section_objs(info, "__dyndbg_class_maps",
+ sizeof(*mod->dyndbg_info.maps.start),
+ &mod->dyndbg_info.maps.len);
#endif
return 0;
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 72bfbec0ac02..1880a9546944 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -39,17 +39,15 @@
#include <rdma/ib_verbs.h>
-extern struct _ddebug __start___dyndbg[];
-extern struct _ddebug __stop___dyndbg[];
-extern struct ddebug_class_map __start___dyndbg_classes[];
-extern struct ddebug_class_map __stop___dyndbg_classes[];
+extern struct _ddebug __start___dyndbg_descs[];
+extern struct _ddebug __stop___dyndbg_descs[];
+extern struct ddebug_class_map __start___dyndbg_class_maps[];
+extern struct ddebug_class_map __stop___dyndbg_class_maps[];
struct ddebug_table {
struct list_head link;
const char *mod_name;
- struct _ddebug *ddebugs;
- struct ddebug_class_map *classes;
- unsigned int num_ddebugs, num_classes;
+ struct _ddebug_info info;
};
struct ddebug_query {
@@ -159,18 +157,18 @@ static void v3pr_info_dq(const struct ddebug_query *query, const char *msg)
* @_vec: name of a member in @_box
*/
#define for_subvec(_i, _sp, _box, _vec) \
- for ((_i) = 0, (_sp) = (_box)->_vec; \
- (_i) < (_box)->num_##_vec; \
+ for ((_i) = 0, (_sp) = (_box)->_vec.start; \
+ (_i) < (_box)->_vec.len; \
(_i)++, (_sp)++) /* { block } */
static struct ddebug_class_map *ddebug_find_valid_class(struct ddebug_table const *dt,
- const char *class_string,
- int *class_id)
+ const char *class_string,
+ int *class_id)
{
struct ddebug_class_map *map;
int i, idx;
- for_subvec(i, map, dt, classes) {
+ for_subvec(i, map, &dt->info, maps) {
idx = match_string(map->class_names, map->length, class_string);
if (idx >= 0) {
*class_id = idx + map->base;
@@ -271,8 +269,8 @@ static int ddebug_change(const struct ddebug_query *query,
valid_class = _DPRINTK_CLASS_DFLT;
}
- for (i = 0; i < dt->num_ddebugs; i++) {
- struct _ddebug *dp = &dt->ddebugs[i];
+ for (i = 0; i < dt->info.descs.len; i++) {
+ struct _ddebug *dp = &dt->info.descs.start[i];
if (!ddebug_match_desc(query, dp, valid_class))
continue;
@@ -1012,8 +1010,8 @@ static struct _ddebug *ddebug_iter_first(struct ddebug_iter *iter)
}
iter->table = list_entry(ddebug_tables.next,
struct ddebug_table, link);
- iter->idx = iter->table->num_ddebugs;
- return &iter->table->ddebugs[--iter->idx];
+ iter->idx = iter->table->info.descs.len;
+ return &iter->table->info.descs.start[--iter->idx];
}
/*
@@ -1034,10 +1032,10 @@ static struct _ddebug *ddebug_iter_next(struct ddebug_iter *iter)
}
iter->table = list_entry(iter->table->link.next,
struct ddebug_table, link);
- iter->idx = iter->table->num_ddebugs;
+ iter->idx = iter->table->info.descs.len;
--iter->idx;
}
- return &iter->table->ddebugs[iter->idx];
+ return &iter->table->info.descs.start[iter->idx];
}
/*
@@ -1081,16 +1079,19 @@ static void *ddebug_proc_next(struct seq_file *m, void *p, loff_t *pos)
return dp;
}
-#define class_in_range(class_id, map) \
- (class_id >= map->base && class_id < map->base + map->length)
+static bool ddebug_class_in_range(const int class_id, const struct ddebug_class_map *map)
+{
+ return (class_id >= map->base &&
+ class_id < map->base + map->length);
+}
-static const char *ddebug_class_name(struct ddebug_iter *iter, struct _ddebug *dp)
+static const char *ddebug_class_name(struct ddebug_table *dt, struct _ddebug *dp)
{
- struct ddebug_class_map *map = iter->table->classes;
- int i, nc = iter->table->num_classes;
+ struct ddebug_class_map *map;
+ int i;
- for (i = 0; i < nc; i++, map++)
- if (class_in_range(dp->class_id, map))
+ for_subvec(i, map, &dt->info, maps)
+ if (ddebug_class_in_range(dp->class_id, map))
return map->class_names[dp->class_id - map->base];
return NULL;
@@ -1123,7 +1124,7 @@ static int ddebug_proc_show(struct seq_file *m, void *p)
seq_putc(m, '"');
if (dp->class_id != _DPRINTK_CLASS_DFLT) {
- class = ddebug_class_name(iter, dp);
+ class = ddebug_class_name(iter->table, dp);
if (class)
seq_printf(m, " class:%s", class);
else
@@ -1183,12 +1184,12 @@ static void ddebug_attach_module_classes(struct ddebug_table *dt, struct _ddebug
* the builtin/modular classmap vector/section. Save the start
* and length of the subrange at its edges.
*/
- for_subvec(i, cm, di, classes) {
+ for_subvec(i, cm, di, maps) {
if (!strcmp(cm->mod_name, dt->mod_name)) {
if (!nc) {
v2pr_info("start subrange, class[%d]: module:%s base:%d len:%d ty:%d\n",
i, cm->mod_name, cm->base, cm->length, cm->map_type);
- dt->classes = cm;
+ dt->info.maps.start = cm;
}
nc++;
} else if (nc) {
@@ -1196,10 +1197,9 @@ static void ddebug_attach_module_classes(struct ddebug_table *dt, struct _ddebug
break;
}
}
- if (nc) {
- dt->num_classes = nc;
+ dt->info.maps.len = nc;
+ if (nc)
vpr_info("module:%s attached %d classes\n", dt->mod_name, nc);
- }
}
/*
@@ -1210,10 +1210,10 @@ static int ddebug_add_module(struct _ddebug_info *di, const char *modname)
{
struct ddebug_table *dt;
- if (!di->num_descs)
+ if (!di->descs.len)
return 0;
- v3pr_info("add-module: %s %d sites\n", modname, di->num_descs);
+ v3pr_info("add-module: %s %d sites\n", modname, di->descs.len);
dt = kzalloc_obj(*dt);
if (dt == NULL) {
@@ -1227,19 +1227,18 @@ static int ddebug_add_module(struct _ddebug_info *di, const char *modname)
* this struct ddebug_table.
*/
dt->mod_name = modname;
- dt->ddebugs = di->descs;
- dt->num_ddebugs = di->num_descs;
+ dt->info = *di;
INIT_LIST_HEAD(&dt->link);
- if (di->classes && di->num_classes)
+ if (di->maps.len)
ddebug_attach_module_classes(dt, di);
mutex_lock(&ddebug_lock);
list_add_tail(&dt->link, &ddebug_tables);
mutex_unlock(&ddebug_lock);
- vpr_info("%3u debug prints in module %s\n", di->num_descs, modname);
+ vpr_info("%3u debug prints in module %s\n", di->descs.len, modname);
return 0;
}
@@ -1386,10 +1385,10 @@ static int __init dynamic_debug_init(void)
char *cmdline;
struct _ddebug_info di = {
- .descs = __start___dyndbg,
- .classes = __start___dyndbg_classes,
- .num_descs = __stop___dyndbg - __start___dyndbg,
- .num_classes = __stop___dyndbg_classes - __start___dyndbg_classes,
+ .descs.start = __start___dyndbg_descs,
+ .maps.start = __start___dyndbg_class_maps,
+ .descs.len = __stop___dyndbg_descs - __start___dyndbg_descs,
+ .maps.len = __stop___dyndbg_class_maps - __start___dyndbg_class_maps,
};
#ifdef CONFIG_MODULES
@@ -1400,7 +1399,7 @@ static int __init dynamic_debug_init(void)
}
#endif /* CONFIG_MODULES */
- if (&__start___dyndbg == &__stop___dyndbg) {
+ if (&__start___dyndbg_descs == &__stop___dyndbg_descs) {
if (IS_ENABLED(CONFIG_DYNAMIC_DEBUG)) {
pr_warn("_ddebug table is empty in a CONFIG_DYNAMIC_DEBUG build\n");
return 1;
@@ -1410,14 +1409,14 @@ static int __init dynamic_debug_init(void)
return 0;
}
- iter = iter_mod_start = __start___dyndbg;
+ iter = iter_mod_start = __start___dyndbg_descs;
modname = iter->modname;
i = mod_sites = mod_ct = 0;
- for (; iter < __stop___dyndbg; iter++, i++, mod_sites++) {
+ for (; iter < __stop___dyndbg_descs; iter++, i++, mod_sites++) {
if (strcmp(modname, iter->modname)) {
- di.descs = iter_mod_start;
- di.num_descs = mod_sites;
+ di.descs.len = mod_sites;
+ di.descs.start = iter_mod_start;
ret = ddebug_add_module(&di, modname);
if (ret)
goto out_err;
@@ -1430,8 +1429,8 @@ static int __init dynamic_debug_init(void)
}
}
- di.descs = iter_mod_start;
- di.num_descs = mod_sites;
+ di.descs.len = mod_sites;
+ di.descs.start = iter_mod_start;
ret = ddebug_add_module(&di, modname);
if (ret)
goto out_err;
@@ -1439,12 +1438,12 @@ static int __init dynamic_debug_init(void)
mod_ct++;
ddebug_init_success = 1;
- vpr_info("%d prdebugs in %d modules, %d KiB in ddebug tables, %d kiB in __dyndbg section\n",
+ vpr_info("%d prdebugs in %d modules, %d KiB in ddebug tables, %d kiB in __dyndbg_descs section\n",
i, mod_ct, (int)((mod_ct * sizeof(struct ddebug_table)) >> 10),
(int)((i * sizeof(struct _ddebug)) >> 10));
- if (di.num_classes)
- v2pr_info(" %d builtin ddebug class-maps\n", di.num_classes);
+ if (di.maps.len)
+ v2pr_info(" %d builtin ddebug class-maps\n", di.maps.len);
/* now that ddebug tables are loaded, process all boot args
* again to find and activate queries given in dyndbg params.
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 20/40] dyndbg: move mod_name down from struct ddebug_table to _ddebug_info
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (18 preceding siblings ...)
2026-10-13 2:36 ` [PATCH v12 19/40] dyndbg,module: make proper substructs in _ddebug_info Jim Cromie via B4 Relay
@ 2026-10-13 2:36 ` Jim Cromie via B4 Relay
2026-10-13 2:36 ` [PATCH v12 21/40] dyndbg: hoist classmap-filter-by-modname up to ddebug_add_module Jim Cromie via B4 Relay
` (19 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:36 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie,
Louis Chauvet
From: Jim Cromie <jim.cromie@gmail.com>
struct _ddebug_info already has most of dyndbg's info for a module;
push debug_table.mod_name down into it, finishing the encapsulation.
This allows refactoring several callchains, passing &_ddebug_info
instead of &ddebug_table, and hoisting the "&dt->info" deref up
instead of repeating it thru the callchans
ddebug_table contains a _ddebug_info member, so code with a ptr to a
ddebug_table still have access to mod_name, just now with "->info."
added in.
In static ddebug_add_module(&di), reinforce the cursor-model by
dropping the modname arg, and setting di->mod_name at each caller.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
---
v2: move RvB after SoB
old-v12
. moved up 1 position in series, ahead of hoist...
---
include/linux/dynamic_debug.h | 1 +
lib/dynamic_debug.c | 50 ++++++++++++++++++++++---------------------
2 files changed, 27 insertions(+), 24 deletions(-)
diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
index b05dc843a1d8..4d2ad0df9060 100644
--- a/include/linux/dynamic_debug.h
+++ b/include/linux/dynamic_debug.h
@@ -100,6 +100,7 @@ struct _ddebug_class_maps {
};
struct _ddebug_info {
+ const char *mod_name;
struct _ddebug_descs descs;
struct _ddebug_class_maps maps;
};
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 1880a9546944..1627e40efc8f 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -46,7 +46,6 @@ extern struct ddebug_class_map __stop___dyndbg_class_maps[];
struct ddebug_table {
struct list_head link;
- const char *mod_name;
struct _ddebug_info info;
};
@@ -254,10 +253,11 @@ static int ddebug_change(const struct ddebug_query *query,
/* search for matching ddebugs */
mutex_lock(&ddebug_lock);
list_for_each_entry(dt, &ddebug_tables, link) {
+ struct _ddebug_info *di = &dt->info;
/* match against the module name */
if (query->module &&
- !match_wildcard(query->module, dt->mod_name))
+ !match_wildcard(query->module, di->mod_name))
continue;
if (query->class_string) {
@@ -269,8 +269,8 @@ static int ddebug_change(const struct ddebug_query *query,
valid_class = _DPRINTK_CLASS_DFLT;
}
- for (i = 0; i < dt->info.descs.len; i++) {
- struct _ddebug *dp = &dt->info.descs.start[i];
+ for (i = 0; i < di->descs.len; i++) {
+ struct _ddebug *dp = &di->descs.start[i];
if (!ddebug_match_desc(query, dp, valid_class))
continue;
@@ -290,7 +290,7 @@ static int ddebug_change(const struct ddebug_query *query,
#endif
v4pr_info("changed %s:%d [%s]%s %s => %s\n",
trim_prefix(dp->filename), dp->lineno,
- dt->mod_name, dp->function,
+ di->mod_name, dp->function,
ddebug_describe_flags(dp->flags, &fbuf),
ddebug_describe_flags(newflags, &nbuf));
dp->flags = newflags;
@@ -1085,12 +1085,12 @@ static bool ddebug_class_in_range(const int class_id, const struct ddebug_class_
class_id < map->base + map->length);
}
-static const char *ddebug_class_name(struct ddebug_table *dt, struct _ddebug *dp)
+static const char *ddebug_class_name(struct _ddebug_info *di, struct _ddebug *dp)
{
struct ddebug_class_map *map;
int i;
- for_subvec(i, map, &dt->info, maps)
+ for_subvec(i, map, di, maps)
if (ddebug_class_in_range(dp->class_id, map))
return map->class_names[dp->class_id - map->base];
@@ -1118,13 +1118,13 @@ static int ddebug_proc_show(struct seq_file *m, void *p)
seq_printf(m, "%s:%u [%s]%s =%s \"",
trim_prefix(dp->filename), dp->lineno,
- iter->table->mod_name, dp->function,
+ iter->table->info.mod_name, dp->function,
ddebug_describe_flags(dp->flags, &flags));
seq_escape_str(m, dp->format, ESCAPE_SPACE, "\t\r\n\"");
seq_putc(m, '"');
if (dp->class_id != _DPRINTK_CLASS_DFLT) {
- class = ddebug_class_name(iter->table, dp);
+ class = ddebug_class_name(&iter->table->info, dp);
if (class)
seq_printf(m, " class:%s", class);
else
@@ -1185,7 +1185,7 @@ static void ddebug_attach_module_classes(struct ddebug_table *dt, struct _ddebug
* and length of the subrange at its edges.
*/
for_subvec(i, cm, di, maps) {
- if (!strcmp(cm->mod_name, dt->mod_name)) {
+ if (!strcmp(cm->mod_name, dt->info.mod_name)) {
if (!nc) {
v2pr_info("start subrange, class[%d]: module:%s base:%d len:%d ty:%d\n",
i, cm->mod_name, cm->base, cm->length, cm->map_type);
@@ -1199,34 +1199,33 @@ static void ddebug_attach_module_classes(struct ddebug_table *dt, struct _ddebug
}
dt->info.maps.len = nc;
if (nc)
- vpr_info("module:%s attached %d classes\n", dt->mod_name, nc);
+ vpr_info("module:%s attached %d classes\n", dt->info.mod_name, nc);
}
/*
* Allocate a new ddebug_table for the given module
* and add it to the global list.
*/
-static int ddebug_add_module(struct _ddebug_info *di, const char *modname)
+static int ddebug_add_module(struct _ddebug_info *di)
{
struct ddebug_table *dt;
if (!di->descs.len)
return 0;
- v3pr_info("add-module: %s %d sites\n", modname, di->descs.len);
+ v3pr_info("add-module: %s %d sites\n", di->mod_name, di->descs.len);
dt = kzalloc_obj(*dt);
if (dt == NULL) {
- pr_err("error adding module: %s\n", modname);
+ pr_err("error adding module: %s\n", di->mod_name);
return -ENOMEM;
}
/*
- * For built-in modules, name lives in .rodata and is
- * immortal. For loaded modules, name points at the name[]
- * member of struct module, which lives at least as long as
- * this struct ddebug_table.
+ * For built-in modules, name (as supplied in di by its
+ * callers) lives in .rodata and is immortal. For loaded
+ * modules, name points at the name[] member of struct module,
+ * which lives at least as long as this struct ddebug_table.
*/
- dt->mod_name = modname;
dt->info = *di;
INIT_LIST_HEAD(&dt->link);
@@ -1238,7 +1237,7 @@ static int ddebug_add_module(struct _ddebug_info *di, const char *modname)
list_add_tail(&dt->link, &ddebug_tables);
mutex_unlock(&ddebug_lock);
- vpr_info("%3u debug prints in module %s\n", di->descs.len, modname);
+ vpr_info("%3u debug prints in module %s\n", di->descs.len, di->mod_name);
return 0;
}
@@ -1301,7 +1300,7 @@ static int ddebug_remove_module(const char *mod_name)
mutex_lock(&ddebug_lock);
list_for_each_entry_safe(dt, nextdt, &ddebug_tables, link) {
- if (dt->mod_name == mod_name) {
+ if (dt->info.mod_name == mod_name) {
ddebug_table_free(dt);
ret = 0;
break;
@@ -1321,7 +1320,8 @@ static int ddebug_module_notify(struct notifier_block *self, unsigned long val,
switch (val) {
case MODULE_STATE_COMING:
- ret = ddebug_add_module(&mod->dyndbg_info, mod->name);
+ mod->dyndbg_info.mod_name = mod->name;
+ ret = ddebug_add_module(&mod->dyndbg_info);
if (ret)
WARN(1, "Failed to allocate memory: dyndbg may not work properly.\n");
break;
@@ -1417,7 +1417,8 @@ static int __init dynamic_debug_init(void)
if (strcmp(modname, iter->modname)) {
di.descs.len = mod_sites;
di.descs.start = iter_mod_start;
- ret = ddebug_add_module(&di, modname);
+ di.mod_name = modname;
+ ret = ddebug_add_module(&di);
if (ret)
goto out_err;
@@ -1431,7 +1432,8 @@ static int __init dynamic_debug_init(void)
di.descs.len = mod_sites;
di.descs.start = iter_mod_start;
- ret = ddebug_add_module(&di, modname);
+ di.mod_name = modname;
+ ret = ddebug_add_module(&di);
if (ret)
goto out_err;
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 21/40] dyndbg: hoist classmap-filter-by-modname up to ddebug_add_module
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (19 preceding siblings ...)
2026-10-13 2:36 ` [PATCH v12 20/40] dyndbg: move mod_name down from struct ddebug_table to _ddebug_info Jim Cromie via B4 Relay
@ 2026-10-13 2:36 ` Jim Cromie via B4 Relay
2026-10-13 2:36 ` [PATCH v12 22/40] dyndbg-API: replace DECLARE_DYNDBG_CLASSMAP Jim Cromie via B4 Relay
` (18 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:36 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie,
Louis Chauvet
From: Jim Cromie <jim.cromie@gmail.com>
The body of ddebug_attach_module_classes() is just a code-block that
finds the contiguous subrange of classmaps matching on modname, and
saves it into the ddebug_table's info record.
Implement this block in a macro to accommodate different component
vectors in the "box" (as named in the for_subvec macro). We will
reuse this macro shortly.
And hoist its invocation out of ddebug_attach_module_classes() up into
ddebug_add_module(). This moves the filtering step up closer to
dynamic_debug_init(), which already segments the builtin pr_debug
descriptors on their mod_name boundaries.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
---
v8: set maps.len = nc unconditionally
v3: expand block-comment in ddebug_add_module
v2: move RvB after SoB
finish hoist - drop old fn - ddebug_attach_module_classes
the v1 rev left the old ddebug_attach_module_classes in place, but it
is completely redundant now, since it already lost the list-linking
job it was doing.
It was being cut out later in the patchset (in the unsent API
adaptation phase), but for cleaner review, lets excise it now.
OLD all-in-1-series (pre split into reviewable chunks)
v10?- reordered params to match kdoc
v12- refactor/rename: s/dd_mark_vector_subrange/dd_set_module_subrange/
1. Renamed the macro from dd_mark_vector_subrange to
dd_set_module_subrange to better reflect its purpose of narrowing a
vector to a module-specific subrange.
2. Simplified the arguments by removing the redundant _dst, as the _di
pointer already provides access to the target _ddebug_info struct.
3. Refactored for Clarity: Instead of overwriting the struct's start
pointer while the for_subvec loop is using it to iterate, I
introduced a temporary __start variable. This avoids the "subtle"
side effect and makes the logic easier to follow.
4. Updated Documentation: Improved the comment block to explicitly
state that the macro scans for the first match and counts
contiguous elements.
fiuxp
---
lib/dynamic_debug.c | 79 +++++++++++++++++++++++++++++------------------------
1 file changed, 43 insertions(+), 36 deletions(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 1627e40efc8f..18289ca7170b 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -1174,33 +1174,34 @@ static const struct proc_ops proc_fops = {
.proc_write = ddebug_proc_write
};
-static void ddebug_attach_module_classes(struct ddebug_table *dt, struct _ddebug_info *di)
-{
- struct ddebug_class_map *cm;
- int i, nc = 0;
-
- /*
- * Find this module's classmaps in a subrange/wholerange of
- * the builtin/modular classmap vector/section. Save the start
- * and length of the subrange at its edges.
- */
- for_subvec(i, cm, di, maps) {
- if (!strcmp(cm->mod_name, dt->info.mod_name)) {
- if (!nc) {
- v2pr_info("start subrange, class[%d]: module:%s base:%d len:%d ty:%d\n",
- i, cm->mod_name, cm->base, cm->length, cm->map_type);
- dt->info.maps.start = cm;
- }
- nc++;
- } else if (nc) {
- /* end of matching classmaps */
- break;
- }
- }
- dt->info.maps.len = nc;
- if (nc)
- vpr_info("module:%s attached %d classes\n", dt->info.mod_name, nc);
-}
+/*
+ * dd_set_module_subrange - find matching subrange of classmaps
+ * @_i: caller-provided index var
+ * @_sp: cursor into @_vec
+ * @_di: pointer to the struct _ddebug_info to be narrowed
+ * @_vec: name of the vector member (must have .start and .len)
+ *
+ * Narrow a _ddebug_info's vector (@_vec) of classmaps to the
+ * contiguous subrange of elements where ->mod_name matches
+ * @__di->mod_name. This is primarily for builtins, loadable modules
+ * have only their classmaps, and dont need this sub-selection.
+ */
+#define dd_set_module_subrange(_i, _sp, _di, _vec) ({ \
+ struct _ddebug_info *__di = (_di); \
+ typeof(__di->_vec.start) __start = NULL; \
+ int __nc = 0; \
+ for_subvec(_i, _sp, __di, _vec) { \
+ if (!strcmp((_sp)->mod_name, __di->mod_name)) { \
+ if (!__nc++) \
+ __start = (_sp); \
+ } else if (__nc) { \
+ break; /* end of consecutive matches */ \
+ } \
+ } \
+ __di->_vec.len = __nc; \
+ if (__nc) \
+ __di->_vec.start = __start; \
+})
/*
* Allocate a new ddebug_table for the given module
@@ -1209,6 +1210,8 @@ static void ddebug_attach_module_classes(struct ddebug_table *dt, struct _ddebug
static int ddebug_add_module(struct _ddebug_info *di)
{
struct ddebug_table *dt;
+ struct ddebug_class_map *cm;
+ int i;
if (!di->descs.len)
return 0;
@@ -1221,17 +1224,21 @@ static int ddebug_add_module(struct _ddebug_info *di)
return -ENOMEM;
}
/*
- * For built-in modules, name (as supplied in di by its
- * callers) lives in .rodata and is immortal. For loaded
- * modules, name points at the name[] member of struct module,
- * which lives at least as long as this struct ddebug_table.
+ * For built-in modules, di is a partial cursor into the
+ * builtin dyndbg data; the descriptors are the subrange
+ * matching the modname, but the classmaps are the full set.
+ * We find and set the relevant subrange of classmaps here.
+ *
+ * The modname string is in .rodata, the descriptors and
+ * classmaps are in writable .data. All are immortal.
+ *
+ * For loaded modules, mod_name points at the name[] member
+ * of struct module, and the descriptors and classmaps point
+ * at the module's ELF sections; all have lifetimes matching
+ * the module's presence.
*/
dt->info = *di;
-
- INIT_LIST_HEAD(&dt->link);
-
- if (di->maps.len)
- ddebug_attach_module_classes(dt, di);
+ dd_set_module_subrange(i, cm, &dt->info, maps);
mutex_lock(&ddebug_lock);
list_add_tail(&dt->link, &ddebug_tables);
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 22/40] dyndbg-API: replace DECLARE_DYNDBG_CLASSMAP
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (20 preceding siblings ...)
2026-10-13 2:36 ` [PATCH v12 21/40] dyndbg: hoist classmap-filter-by-modname up to ddebug_add_module Jim Cromie via B4 Relay
@ 2026-10-13 2:36 ` Jim Cromie via B4 Relay
2026-10-13 2:36 ` [PATCH v12 23/40] selftests/dyndbg: Enable FT_classmap_inheritance Jim Cromie via B4 Relay
` (17 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:36 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie,
Louis Chauvet
From: Jim Cromie <jim.cromie@gmail.com>
DECLARE_DYNDBG_CLASSMAP had a flaw: multiple invocations across both
core and driver modules broke the K&R "define once, refer afterwards"
principle, causing boot-time parameter propagation failures.
Replace it with an explicit client-server model:
- DYNAMIC_DEBUG_CLASSMAP_DEFINE: invoked once in the core module, creating
and exporting the classmap.
- DYNAMIC_DEBUG_CLASSMAP_USE: invoked across driver/helper modules,
placing a reference record into the __dyndbg_class_users section.
At module load time, dyndbg scans __dyndbg_class_users, resolves the
reference to the parent classmap, finds the associated controlling
kernel parameter, and automatically applies the initial bitmap to the
loading module.
Fixes: aad0214f3026 ("dyndbg: add DECLARE_DYNDBG_CLASSMAP macro")
Cc: linux-doc@vger.kernel.org
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
v11:
. introduce ddebug_apply_class_maps() alongside ddebug_apply_class_users()
in ddebug_add_module() for complete lifecycle symmetry between definers
and users at module load time.
. drop init_bits and misleading _DPRINTK_FLAGS_DEFAULT check in
ddebug_sync_classbits(), passing 0 directly as old_bits. Initial sync
only asserts active parameter bits (+p), leaving local -DDEBUG
overrides intact. Divergent state can be synchronized at runtime by
cycling the parameter knob (noted by Sashiko review).
. document publication ordering and deadlock avoidance in
ddebug_add_module() and ddebug_sync_classbits().
v10:
. pass init_bits computed from (_DPRINTK_FLAGS_DEFAULT & _DPRINTK_FLAGS_PRINT) in
ddebug_sync_classbits() to properly disable -DDEBUG callsites.
---
include/asm-generic/dyndbg.lds.h | 6 +-
include/linux/dynamic_debug.h | 165 +++++++++++++++++++++++++---
kernel/module/main.c | 3 +
lib/Kconfig.debug | 24 ++++-
lib/Makefile | 3 +
lib/dynamic_debug.c | 227 +++++++++++++++++++++++++++++++++++++--
lib/test_dynamic_debug.c | 131 +++++++++++++++++-----
lib/test_dynamic_debug_submod.c | 14 +++
8 files changed, 516 insertions(+), 57 deletions(-)
diff --git a/include/asm-generic/dyndbg.lds.h b/include/asm-generic/dyndbg.lds.h
index ec661f9f3793..0ffc9cde4377 100644
--- a/include/asm-generic/dyndbg.lds.h
+++ b/include/asm-generic/dyndbg.lds.h
@@ -5,7 +5,8 @@
#include <asm-generic/bounded_sections.lds.h>
#define DYNDBG_SECTIONS() \
BOUNDED_SECTION_BY(__dyndbg_descs, ___dyndbg_descs) \
- BOUNDED_SECTION_BY(__dyndbg_class_maps, ___dyndbg_class_maps)
+ BOUNDED_SECTION_BY(__dyndbg_class_maps, ___dyndbg_class_maps) \
+ BOUNDED_SECTION_BY(__dyndbg_class_users, ___dyndbg_class_users)
#define MOD_DYNDBG_SECTIONS() \
__dyndbg_descs 0 : ALIGN(8) { \
@@ -13,6 +14,9 @@
} \
__dyndbg_class_maps 0 : ALIGN(8) { \
KEEP(*(__dyndbg_class_maps)) \
+ } \
+ __dyndbg_class_users 0 : ALIGN(8) { \
+ KEEP(*(__dyndbg_class_users)) \
}
#endif /* __ASM_GENERIC_DYNDBG_LDS_H */
diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
index 4d2ad0df9060..3c2ab0ec23c1 100644
--- a/include/linux/dynamic_debug.h
+++ b/include/linux/dynamic_debug.h
@@ -75,19 +75,30 @@ enum ddebug_class_map_type {
*/
};
+/*
+ * map @class_names 0..N to consecutive constants starting at @base.
+ */
struct ddebug_class_map {
- struct module *mod; /* NULL for builtins */
- const char *mod_name; /* needed for builtins */
+ const struct module *mod; /* NULL for builtins */
+ const char *mod_name; /* needed for builtins */
const char **class_names;
const int length;
const int base; /* index of 1st .class_id, allows split/shared space */
enum ddebug_class_map_type map_type;
-};
+} __aligned(8);
+
+struct ddebug_class_user {
+ const char *mod_name;
+ struct ddebug_class_map *map;
+ const int offset; /* offset from map->base */
+} __aligned(8);
/*
- * @_ddebug_info: gathers module/builtin dyndbg_* __sections together.
+ * @_ddebug_info: gathers module/builtin __dyndbg_<T> __sections
+ * together, each is a vec_<T>: a struct { struct T start[], int len }.
+ *
* For builtins, it is used as a cursor, with the inner structs
- * marking sub-vectors of the builtin __sections in DATA.
+ * marking sub-vectors of the builtin __sections in DATA_DATA
*/
struct _ddebug_descs {
struct _ddebug *start;
@@ -99,10 +110,16 @@ struct _ddebug_class_maps {
unsigned int len;
};
+struct _ddebug_class_users {
+ struct ddebug_class_user *start;
+ unsigned int len;
+};
+
struct _ddebug_info {
const char *mod_name;
struct _ddebug_descs descs;
struct _ddebug_class_maps maps;
+ struct _ddebug_class_users users;
};
struct ddebug_class_param {
@@ -121,17 +138,86 @@ struct ddebug_class_param {
#if defined(CONFIG_DYNAMIC_DEBUG) || \
(defined(CONFIG_DYNAMIC_DEBUG_CORE) && defined(DYNAMIC_DEBUG_MODULE))
+/*
+ * dyndbg classmaps is modelled closely upon drm.debug:
+ *
+ * 1. run-time control via sysfs node (api/abi)
+ * 2. each bit 0..N controls a single "category"
+ * 3. a pr_debug can have only 1 category, not several.
+ * 4. "kind" is a compile-time constant: 0..N or BIT() thereof
+ * 5. macro impls - give compile-time resolution or fail.
+ *
+ * dyndbg classmaps design axioms/constraints:
+ *
+ * . optimizing compilers use 1-5 above, so preserve them.
+ * . classmaps.class_id *is* the category.
+ * . classmap definers/users are modules.
+ * . every user wants 0..N
+ * . 0..N exposes as ABI
+ * . no 1 use-case wants N > 32, 16 is more usable
+ * . N <= 64 in *all* cases
+ * . modules/subsystems make category/classmap decisions
+ * . ie an enum: DRM has DRM_UT_CORE..DRM_UT_DRMRES
+ * . some categories are exposed to user: ABI
+ * . making modules change their numbering is bogus, avoid if possible
+ *
+ * We can solve for all these at once:
+ * A: map class-names to a .class_id range at compile-time
+ * B: allow only "class NAME" changes to class'd callsites at run-time
+ * C: users/modules must manage 0..62 hardcoded .class_id range limit.
+ * D: existing pr_debugs get CLASS_DFLT=63
+ *
+ * By mapping class-names at >control to class-ids underneath, and
+ * responding only to class-names DEFINEd or USEd by the module, we
+ * can private-ize the class-id, and adjust class'd pr_debugs only by
+ * their names.
+ *
+ * This give us:
+ * E: class_ids without classnames are unreachable
+ * F: user modules opt-in by DEFINEing a classmap and/or USEing another
+ *
+ * Multi-classmap modules/groups are supported, if the classmaps share
+ * the class_id space [0..62] without overlap/conflict.
+ *
+ * NOTE: Due to the integer class_id, this api cannot disallow these:
+ * __pr_debug_cls(0, "fake CORE msg"); works only if a classmap maps 0.
+ * __pr_debug_cls(22, "no such class"); compiles but is not reachable
+ */
+
/**
- * DECLARE_DYNDBG_CLASSMAP - declare classnames known by a module
- * @_var: a struct ddebug_class_map, passed to module_param_cb
- * @_maptype: enum ddebug_class_map_type, chooses bits/verbose
- * @_base: offset of 1st class-name. splits .class_id space
- * @classes: class-names used to control class'd prdbgs
+ * DYNAMIC_DEBUG_CLASSMAP_DEFINE - define debug classes used by a module.
+ * @_var: name of the classmap, exported for other modules coordinated use.
+ * @_mapty: enum ddebug_class_map_type: 0:DISJOINT - independent, 1:LEVEL - v2>v1
+ * @_base: reserve N classids starting at _base, to split 0..62 classid space
+ * @classes: names of the N classes.
+ *
+ * This tells dyndbg what class_ids the module is using: _base..+N, by
+ * mapping names onto them. This qualifies "class NAME" >controls on
+ * the defining module, ignoring unknown names.
+ */
+#define DYNAMIC_DEBUG_CLASSMAP_DEFINE(_var, _mapty, _base, ...) \
+ static const char *_var##_classnames[] = { __VA_ARGS__ }; \
+ extern struct ddebug_class_map _var; \
+ struct ddebug_class_map __aligned(8) __used \
+ __section("__dyndbg_class_maps") _var = { \
+ .mod = THIS_MODULE, \
+ .mod_name = KBUILD_MODNAME, \
+ .base = (_base), \
+ .map_type = (_mapty), \
+ .length = ARRAY_SIZE(_var##_classnames), \
+ .class_names = _var##_classnames, \
+ }; \
+ EXPORT_SYMBOL(_var)
+
+/*
+ * XXX: keep this until DRM adapts to use the DEFINE/USE api, it
+ * differs from DYNAMIC_DEBUG_CLASSMAP_DEFINE by the lack of the
+ * extern/EXPORT on the struct init, and cascading thinkos.
*/
#define DECLARE_DYNDBG_CLASSMAP(_var, _maptype, _base, ...) \
static const char *_var##_classnames[] = { __VA_ARGS__ }; \
static struct ddebug_class_map __aligned(8) __used \
- __section("__dyndbg_class_maps") _var = { \
+ __section("__dyndbg_class_maps") _var = { \
.mod = THIS_MODULE, \
.mod_name = KBUILD_MODNAME, \
.base = _base, \
@@ -140,6 +226,44 @@ struct ddebug_class_param {
.length = __DDEBUG_ARRAY_SIZE(_var##_classnames), \
}
+/**
+ * DYNAMIC_DEBUG_CLASSMAP_USE - refer to a classmap, DEFINEd elsewhere.
+ * @_var: name of the exported classmap var
+ *
+ * This tells dyndbg that the module has prdbgs with classids defined
+ * in the named classmap. This qualifies "class NAME" >controls on
+ * the user module, and ignores unknown names. This is a wrapper for
+ * DYNAMIC_DEBUG_CLASSMAP_USE_() with a base offset of 0.
+ */
+#define DYNAMIC_DEBUG_CLASSMAP_USE(_var) \
+ DYNAMIC_DEBUG_CLASSMAP_USE_(_var, 0)
+
+/**
+ * DYNAMIC_DEBUG_CLASSMAP_USE_ - refer to a classmap with a manual offset.
+ * @_var: name of the exported classmap var to use.
+ * @_offset: an integer offset to add to the class IDs of the used map.
+ *
+ * This is an extended version of DYNAMIC_DEBUG_CLASSMAP_USE(). It should
+ * only be used to resolve class ID conflicts when a module uses multiple
+ * classmaps that have overlapping ID ranges.
+ *
+ * The final class IDs for the used map will be calculated as:
+ * original_map_base + class_index + @_offset.
+ */
+#define DYNAMIC_DEBUG_CLASSMAP_USE_(_var, _offset) \
+ extern struct ddebug_class_map _var; \
+ static_assert((_offset) >= 0 && (_offset) < _DPRINTK_CLASS_DFLT, \
+ "classmap use offset must be in 0..62"); \
+ extern struct ddebug_class_user __aligned(8) \
+ __PASTE(_var ## _, __KBUILD_MODNAME); \
+ struct ddebug_class_user __aligned(8) __used \
+ __section("__dyndbg_class_users") \
+ __PASTE(_var ## _, __KBUILD_MODNAME) = { \
+ .mod_name = KBUILD_MODNAME, \
+ .map = &(_var), \
+ .offset = _offset \
+ }
+
extern __printf(2, 3)
void __dynamic_pr_debug(struct _ddebug *descriptor, const char *fmt, ...);
@@ -301,12 +425,18 @@ void __dynamic_ibdev_dbg(struct _ddebug *descriptor,
KERN_DEBUG, prefix_str, prefix_type, \
rowsize, groupsize, buf, len, ascii)
-/* for test only, generally expect drm.debug style macro wrappers */
-#define __pr_debug_cls(cls, fmt, ...) do { \
+/*
+ * This is the "model" class variant of pr_debug. It is not really
+ * intended for direct use; I'd encourage DRM-style drm_dbg_<T>
+ * macros for the interface, along with an enum for the <T>
+ *
+ * __printf(2, 3) would apply.
+ */
+#define __pr_debug_cls(cls, fmt, ...) ({ \
BUILD_BUG_ON_MSG(!__builtin_constant_p(cls), \
"expecting constant class int/enum"); \
dynamic_pr_debug_cls(cls, fmt, ##__VA_ARGS__); \
- } while (0)
+})
#else /* !(CONFIG_DYNAMIC_DEBUG || (CONFIG_DYNAMIC_DEBUG_CORE && DYNAMIC_DEBUG_MODULE)) */
@@ -314,6 +444,10 @@ void __dynamic_ibdev_dbg(struct _ddebug *descriptor,
#include <linux/errno.h>
#include <linux/printk.h>
+/* unused args preserve macro ABIs */
+#define DYNAMIC_DEBUG_CLASSMAP_DEFINE(_var, _mapty, _base, ...)
+#define DYNAMIC_DEBUG_CLASSMAP_USE(_var)
+#define DYNAMIC_DEBUG_CLASSMAP_USE_(_var, _offset)
#define DEFINE_DYNAMIC_DEBUG_METADATA(name, fmt)
#define DYNAMIC_DEBUG_BRANCH(descriptor) false
#define DECLARE_DYNDBG_CLASSMAP(...)
@@ -360,8 +494,7 @@ static inline int param_set_dyndbg_classes(const char *instr, const struct kerne
static inline int param_get_dyndbg_classes(char *buffer, const struct kernel_param *kp)
{ return 0; }
-#endif
-
+#endif /* !CONFIG_DYNAMIC_DEBUG_CORE */
extern const struct kernel_param_ops param_ops_dyndbg_classes;
diff --git a/kernel/module/main.c b/kernel/module/main.c
index 852cce2c5113..abf0c6991f66 100644
--- a/kernel/module/main.c
+++ b/kernel/module/main.c
@@ -2791,6 +2791,9 @@ static int find_module_sections(struct module *mod, struct load_info *info)
mod->dyndbg_info.maps.start = section_objs(info, "__dyndbg_class_maps",
sizeof(*mod->dyndbg_info.maps.start),
&mod->dyndbg_info.maps.len);
+ mod->dyndbg_info.users.start = section_objs(info, "__dyndbg_class_users",
+ sizeof(*mod->dyndbg_info.users.start),
+ &mod->dyndbg_info.users.len);
#endif
return 0;
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 56228eefdb4a..d95e3c64507b 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -3137,12 +3137,26 @@ config TEST_STATIC_KEYS
If unsure, say N.
config TEST_DYNAMIC_DEBUG
- tristate "Test DYNAMIC_DEBUG"
- depends on DYNAMIC_DEBUG
+ tristate "Build test-dynamic-debug module"
+ depends on DYNAMIC_DEBUG || DYNAMIC_DEBUG_CORE
help
- This module registers a tracer callback to count enabled
- pr_debugs in a 'do_debugging' function, then alters their
- enablements, calls the function, and compares counts.
+ This module exercises/demonstrates dyndbg's classmap API, by
+ creating 2 classes: a DISJOINT classmap (supporting DRM.debug)
+ and a LEVELS/VERBOSE classmap (like verbose2 > verbose1).
+
+ If unsure, say N.
+
+config TEST_DYNAMIC_DEBUG_SUBMOD
+ tristate "Build test-dynamic-debug submodule"
+ default m
+ depends on DYNAMIC_DEBUG || DYNAMIC_DEBUG_CORE
+ depends on TEST_DYNAMIC_DEBUG
+ help
+ This sub-module uses a classmap defined and exported by the
+ parent module, recapitulating drm & driver's shared use of
+ drm.debug to control enabled debug-categories.
+ It is tristate, independent of parent, to allow testing all
+ proper combinations of parent=y/m submod=y/m.
If unsure, say N.
diff --git a/lib/Makefile b/lib/Makefile
index dfab958327c5..9cdf0a430f5f 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -85,6 +85,7 @@ obj-$(CONFIG_TEST_RHASHTABLE) += test_rhashtable.o
obj-$(CONFIG_TEST_STATIC_KEYS) += test_static_keys.o
obj-$(CONFIG_TEST_STATIC_KEYS) += test_static_key_base.o
obj-$(CONFIG_TEST_DYNAMIC_DEBUG) += test_dynamic_debug.o
+obj-$(CONFIG_TEST_DYNAMIC_DEBUG_SUBMOD) += test_dynamic_debug_submod.o
obj-$(CONFIG_TEST_BITMAP) += test_bitmap.o
ifeq ($(CONFIG_CC_IS_CLANG)$(CONFIG_KASAN),yy)
@@ -206,6 +207,8 @@ obj-$(CONFIG_ARCH_NEED_CMPXCHG_1_EMU) += cmpxchg-emu.o
obj-$(CONFIG_DYNAMIC_DEBUG_CORE) += dynamic_debug.o
#ensure exported functions have prototypes
CFLAGS_dynamic_debug.o := -DDYNAMIC_DEBUG_MODULE
+CFLAGS_test_dynamic_debug.o := -DDYNAMIC_DEBUG_MODULE
+CFLAGS_test_dynamic_debug_submod.o := -DDYNAMIC_DEBUG_MODULE
obj-$(CONFIG_SYMBOLIC_ERRNAME) += errname.o
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 18289ca7170b..8c314a52d8f9 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -29,6 +29,7 @@
#include <linux/string_helpers.h>
#include <linux/uaccess.h>
#include <linux/dynamic_debug.h>
+
#include <linux/debugfs.h>
#include <linux/slab.h>
#include <linux/jump_label.h>
@@ -43,6 +44,8 @@ extern struct _ddebug __start___dyndbg_descs[];
extern struct _ddebug __stop___dyndbg_descs[];
extern struct ddebug_class_map __start___dyndbg_class_maps[];
extern struct ddebug_class_map __stop___dyndbg_class_maps[];
+extern struct ddebug_class_user __start___dyndbg_class_users[];
+extern struct ddebug_class_user __stop___dyndbg_class_users[];
struct ddebug_table {
struct list_head link;
@@ -160,20 +163,39 @@ static void v3pr_info_dq(const struct ddebug_query *query, const char *msg)
(_i) < (_box)->_vec.len; \
(_i)++, (_sp)++) /* { block } */
-static struct ddebug_class_map *ddebug_find_valid_class(struct ddebug_table const *dt,
- const char *class_string,
+#define v2pr_di_info(di_p, msg_p, ...) \
+({ \
+ struct _ddebug_info const *_di = di_p; \
+ v2pr_info(msg_p "module:%s nd:%d nc:%d nu:%d\n", ##__VA_ARGS__, \
+ _di->mod_name, _di->descs.len, _di->maps.len, \
+ _di->users.len); \
+})
+
+static struct ddebug_class_map *ddebug_find_valid_class(struct _ddebug_info const *di,
+ const char *query_class,
int *class_id)
{
struct ddebug_class_map *map;
+ struct ddebug_class_user *cli;
int i, idx;
- for_subvec(i, map, &dt->info, maps) {
- idx = match_string(map->class_names, map->length, class_string);
+ for_subvec(i, map, di, maps) {
+ idx = match_string(map->class_names, map->length, query_class);
if (idx >= 0) {
+ v2pr_di_info(di, "good-class: %s.%s ", map->mod_name, query_class);
*class_id = idx + map->base;
return map;
}
}
+ for_subvec(i, cli, di, users) {
+ idx = match_string(cli->map->class_names, cli->map->length, query_class);
+ if (idx >= 0) {
+ v2pr_di_info(di, "class-ref: %s -> %s.%s ",
+ cli->mod_name, cli->map->mod_name, query_class);
+ *class_id = idx + cli->map->base + cli->offset;
+ return cli->map;
+ }
+ }
*class_id = -ENOENT;
return NULL;
}
@@ -239,8 +261,7 @@ static bool ddebug_match_desc(const struct ddebug_query *query,
* callsites, normally the same as number of changes. If verbose,
* logs the changes. Takes ddebug_lock.
*/
-static int ddebug_change(const struct ddebug_query *query,
- struct flag_settings *modifiers)
+static int ddebug_change(const struct ddebug_query *query, struct flag_settings *modifiers)
{
int i;
struct ddebug_table *dt;
@@ -261,7 +282,8 @@ static int ddebug_change(const struct ddebug_query *query,
continue;
if (query->class_string) {
- map = ddebug_find_valid_class(dt, query->class_string, &valid_class);
+ map = ddebug_find_valid_class(&dt->info, query->class_string,
+ &valid_class);
if (!map)
continue;
} else {
@@ -594,7 +616,7 @@ static int ddebug_exec_query(char *query_string, const char *modname)
/* handle multiple queries in query string, continue on error, return
last error or number of matching callsites. Module name is either
- in param (for boot arg) or perhaps in query string.
+ in the modname arg (for boot args) or perhaps in query string.
*/
static int ddebug_exec_queries(char *query, const char *modname)
{
@@ -773,6 +795,7 @@ int param_get_dyndbg_classes(char *buffer, const struct kernel_param *kp)
default:
return -1;
}
+ return 0;
}
EXPORT_SYMBOL(param_get_dyndbg_classes);
@@ -1085,15 +1108,28 @@ static bool ddebug_class_in_range(const int class_id, const struct ddebug_class_
class_id < map->base + map->length);
}
+static bool ddebug_user_class_in_range(const int class_id, const struct ddebug_class_user *cli)
+{
+ if (!cli || !cli->map)
+ return false;
+ int base = cli->map->base + cli->offset;
+ return (class_id >= base && class_id < base + cli->map->length);
+}
+
static const char *ddebug_class_name(struct _ddebug_info *di, struct _ddebug *dp)
{
struct ddebug_class_map *map;
+ struct ddebug_class_user *cli;
int i;
for_subvec(i, map, di, maps)
if (ddebug_class_in_range(dp->class_id, map))
return map->class_names[dp->class_id - map->base];
+ for_subvec(i, cli, di, users)
+ if (ddebug_user_class_in_range(dp->class_id, cli))
+ return cli->map->class_names[dp->class_id - cli->map->base - cli->offset];
+
return NULL;
}
@@ -1174,6 +1210,163 @@ static const struct proc_ops proc_fops = {
.proc_write = ddebug_proc_write
};
+#define vpr_cm_info(cm_p, msg_fmt, ...) ({ \
+ struct ddebug_class_map const *_cm = cm_p; \
+ v2pr_info(msg_fmt "%s [%d..%d] %s..%s\n", ##__VA_ARGS__, \
+ _cm->mod_name, _cm->base, _cm->base + _cm->length, \
+ _cm->class_names[0], _cm->class_names[_cm->length - 1]); \
+ })
+
+/*
+ * Modules which define classmaps get them initialized by
+ * param-callback via module.c:parse_one. Modules which use other's
+ * classmaps must be initialized explicitly.
+ */
+static inline u32 ddebug_class_param_to_bits(const struct ddebug_class_param *dcp)
+{
+ const struct ddebug_class_map *map = dcp->map;
+
+ switch (map->map_type) {
+ case DD_CLASS_TYPE_DISJOINT_BITS:
+ return *dcp->bits & CLASSMAP_BITMASK(map->length);
+ case DD_CLASS_TYPE_LEVEL_NUM:
+ return CLASSMAP_BITMASK(min_t(u32, *dcp->lvl, map->length));
+ default:
+ return 0;
+ }
+}
+
+static void __maybe_unused ddebug_class_param_clamp_input(u32 *inrep, const struct kernel_param *kp)
+{
+ const struct ddebug_class_param *dcp = kp->arg;
+ const struct ddebug_class_map *map = dcp->map;
+
+ switch (map->map_type) {
+ case DD_CLASS_TYPE_DISJOINT_BITS:
+ /* expect bits. mask and warn if too many */
+ if (*inrep & ~CLASSMAP_BITMASK(map->length)) {
+ pr_warn("%s: input: 0x%x exceeds mask: 0x%x, masking\n",
+ KP_NAME(kp), *inrep, CLASSMAP_BITMASK(map->length));
+ *inrep &= CLASSMAP_BITMASK(map->length);
+ }
+ break;
+ case DD_CLASS_TYPE_LEVEL_NUM:
+ /* input is bitpos, of highest verbosity to be enabled */
+ if (*inrep > map->length) {
+ pr_warn("%s: level:%d exceeds max:%d, clamping\n",
+ KP_NAME(kp), *inrep, map->length);
+ *inrep = map->length;
+ }
+ break;
+ }
+}
+
+/*
+ * Called for class-users and native classmaps during module load.
+ *
+ * Initial sync assumes 0 as old_bits, so it only asserts (+p) classes
+ * explicitly set by the parameter. -DDEBUGs invalidate this assumption
+ * for some pr_debugs; a user can override the developer/builder choice
+ * by toggling the param at runtime.
+ *
+ * Parameters are sampled via READ_ONCE without ddebug_lock;
+ * holding ddebug_lock here would deadlock against ddebug_change().
+ */
+static void ddebug_sync_classbits(const struct kernel_param *kp, const char *modname)
+{
+ const struct ddebug_class_param *dcp = kp->arg;
+ u32 val, new_bits;
+
+ if (!dcp || !dcp->map)
+ return;
+
+ switch (dcp->map->map_type) {
+ case DD_CLASS_TYPE_DISJOINT_BITS:
+ val = READ_ONCE(*dcp->bits);
+ new_bits = val;
+ v2pr_info(" %s: classbits: 0x%x\n", KP_NAME(kp), new_bits);
+ ddebug_apply_class_bitmap(dcp, &new_bits, 0, modname);
+ break;
+ case DD_CLASS_TYPE_LEVEL_NUM:
+ val = READ_ONCE(*dcp->lvl);
+ new_bits = CLASSMAP_BITMASK(val);
+ v2pr_info(" %s: lvl:%d bits:0x%x\n", KP_NAME(kp), val, new_bits);
+ ddebug_apply_class_bitmap(dcp, &new_bits, 0, modname);
+ break;
+ default:
+ pr_err("bad map type %d\n", dcp->map->map_type);
+ return;
+ }
+}
+
+static void ddebug_match_apply_kparam(const struct kernel_param *kp,
+ const struct ddebug_class_map *map,
+ const char *mod_name)
+{
+ struct ddebug_class_param *dcp;
+
+ if (kp->ops != ¶m_ops_dyndbg_classes)
+ return;
+
+ dcp = (struct ddebug_class_param *)kp->arg;
+
+ if (dcp && dcp->map == map) {
+ v2pr_info(" kp:%s.%s =0x%x", mod_name, kp->name, *dcp->bits);
+ vpr_cm_info(map, " %s maps ", mod_name);
+ ddebug_sync_classbits(kp, mod_name);
+ }
+}
+
+static void ddebug_apply_params(const struct ddebug_class_map *cm, const char *mod_name)
+{
+ const struct kernel_param *kp;
+
+ if (!cm)
+ return;
+#if IS_ENABLED(CONFIG_MODULES)
+ int i;
+
+ if (cm->mod) {
+ vpr_cm_info(cm, "loaded classmap: %s ", mod_name);
+ /* ifdef protects the cm->mod->kp deref */
+ for (i = 0, kp = cm->mod->kp; i < cm->mod->num_kp; i++, kp++)
+ ddebug_match_apply_kparam(kp, cm, mod_name);
+ }
+#endif
+ if (!cm->mod) {
+ vpr_cm_info(cm, "builtin classmap: %s ", mod_name);
+ for (kp = __start___param; kp < __stop___param; kp++)
+ ddebug_match_apply_kparam(kp, cm, mod_name);
+ }
+}
+
+/*
+ * Symmetrically bind controlling parameters and sync initial classbits:
+ * - ddebug_apply_class_maps(): for native classmaps defined by this module.
+ * - ddebug_apply_class_users(): for imported classmaps referenced via USE.
+ */
+static void ddebug_apply_class_maps(const struct _ddebug_info *di)
+{
+ struct ddebug_class_map *cm;
+ int i;
+
+ for_subvec(i, cm, di, maps)
+ ddebug_apply_params(cm, di->mod_name);
+
+ v2pr_di_info(di, "attached %d class-maps to ", i);
+}
+
+static void ddebug_apply_class_users(const struct _ddebug_info *di)
+{
+ struct ddebug_class_user *cli;
+ int i;
+
+ for_subvec(i, cli, di, users)
+ ddebug_apply_params(cli->map, cli->mod_name);
+
+ v2pr_di_info(di, "attached %d class-users to ", i);
+}
+
/*
* dd_set_module_subrange - find matching subrange of classmaps
* @_i: caller-provided index var
@@ -1211,6 +1404,7 @@ static int ddebug_add_module(struct _ddebug_info *di)
{
struct ddebug_table *dt;
struct ddebug_class_map *cm;
+ struct ddebug_class_user *cli;
int i;
if (!di->descs.len)
@@ -1223,6 +1417,7 @@ static int ddebug_add_module(struct _ddebug_info *di)
pr_err("error adding module: %s\n", di->mod_name);
return -ENOMEM;
}
+ INIT_LIST_HEAD(&dt->link);
/*
* For built-in modules, di is a partial cursor into the
* builtin dyndbg data; the descriptors are the subrange
@@ -1239,12 +1434,24 @@ static int ddebug_add_module(struct _ddebug_info *di)
*/
dt->info = *di;
dd_set_module_subrange(i, cm, &dt->info, maps);
+ dd_set_module_subrange(i, cli, &dt->info, users);
mutex_lock(&ddebug_lock);
list_add_tail(&dt->link, &ddebug_tables);
mutex_unlock(&ddebug_lock);
+ /*
+ * Now that dt is on the list, ddebug_change() (which also
+ * takes the lock) can find it, so apply_class_*() can lookup
+ * the class-param (if any) and set pr_debugs accordingly,
+ * arming them before the module's init() runs.
+ */
+ if (dt->info.maps.len)
+ ddebug_apply_class_maps(&dt->info);
+ if (dt->info.users.len)
+ ddebug_apply_class_users(&dt->info);
- vpr_info("%3u debug prints in module %s\n", di->descs.len, di->mod_name);
+ vpr_info("%3u debug prints in module %s\n",
+ dt->info.descs.len, dt->info.mod_name);
return 0;
}
@@ -1394,8 +1601,10 @@ static int __init dynamic_debug_init(void)
struct _ddebug_info di = {
.descs.start = __start___dyndbg_descs,
.maps.start = __start___dyndbg_class_maps,
+ .users.start = __start___dyndbg_class_users,
.descs.len = __stop___dyndbg_descs - __start___dyndbg_descs,
.maps.len = __stop___dyndbg_class_maps - __start___dyndbg_class_maps,
+ .users.len = __stop___dyndbg_class_users - __start___dyndbg_class_users,
};
#ifdef CONFIG_MODULES
diff --git a/lib/test_dynamic_debug.c b/lib/test_dynamic_debug.c
index 9e8e028461ad..34e51996aa20 100644
--- a/lib/test_dynamic_debug.c
+++ b/lib/test_dynamic_debug.c
@@ -6,11 +6,30 @@
* Jim Cromie <jim.cromie@gmail.com>
*/
-#define pr_fmt(fmt) "test_dd: " fmt
+/*
+ * This file is built 2x, also making test_dynamic_debug_submod.ko,
+ * whose 2-line src file #includes this file. This gives us a _submod
+ * clone with identical pr_debugs, without further maintenance.
+ *
+ * If things are working properly, they should operate identically
+ * when printed or adjusted by >control. This eases visual perusal of
+ * the logs, and simplifies testing, by easing the proper accounting
+ * of expectations.
+ *
+ * It also puts both halves of the subsystem _DEFINE & _USE use case
+ * together, and integrates the common ENUM providing both class_ids
+ * and class-names to both _DEFINErs and _USERs. I think this makes
+ * the usage clearer.
+ */
+#if defined(TEST_DYNAMIC_DEBUG_SUBMOD)
+ #define pr_fmt(fmt) "test_dd_submod: " fmt
+#else
+ #define pr_fmt(fmt) "test_dd: " fmt
+#endif
#include <linux/module.h>
-/* run tests by reading or writing sysfs node: do_prints */
+/* re-gen output by reading or writing sysfs node: do_prints */
static void do_prints(void); /* device under test */
static int param_set_do_prints(const char *instr, const struct kernel_param *kp)
@@ -39,14 +58,36 @@ module_param_cb(do_prints, ¶m_ops_do_prints, NULL, 0600);
* Additionally, here:
* - tie together sysname, mapname, bitsname, flagsname
*/
-#define DD_SYS_WRAP(_model, _flags) \
- static u32 bits_##_model; \
- static struct ddebug_class_param _flags##_model = { \
+#define DYNAMIC_DEBUG_CLASSMAP_PARAM_(_model, _flags, _init) \
+ static u32 bits_##_model = _init; \
+ static struct ddebug_class_param _flags##_##_model = { \
.bits = &bits_##_model, \
.flags = #_flags, \
.map = &map_##_model, \
}; \
- module_param_cb(_flags##_##_model, ¶m_ops_dyndbg_classes, &_flags##_model, 0600)
+ module_param_cb(_flags##_##_model, ¶m_ops_dyndbg_classes, \
+ &_flags##_##_model, 0600)
+#ifdef DEBUG
+#define DYNAMIC_DEBUG_CLASSMAP_PARAM(_model, _flags) \
+ DYNAMIC_DEBUG_CLASSMAP_PARAM_(_model, _flags, ~0)
+#else
+#define DYNAMIC_DEBUG_CLASSMAP_PARAM(_model, _flags) \
+ DYNAMIC_DEBUG_CLASSMAP_PARAM_(_model, _flags, 0)
+#endif
+
+/*
+ * Demonstrate/test DISJOINT & LEVEL typed classmaps with a sys-param.
+ *
+ * To comport with DRM debug-category (an int), classmaps map names to
+ * ids (also an int). So a classmap starts with an enum; DRM has enum
+ * debug_category: with DRM_UT_<CORE,DRIVER,KMS,etc>. We use the enum
+ * values as class-ids, and stringified enum-symbols as classnames.
+ *
+ * Modules with multiple CLASSMAPS must have enums with distinct
+ * value-ranges, as arranged below with explicit enum_sym = X inits.
+ * To clarify this sharing, declare the 2 enums now, for the 2
+ * different classmap types
+ */
/* numeric input, independent bits */
enum cat_disjoint_bits {
@@ -60,26 +101,53 @@ enum cat_disjoint_bits {
D2_LEASE,
D2_DP,
D2_DRMRES };
-DECLARE_DYNDBG_CLASSMAP(map_disjoint_bits, DD_CLASS_TYPE_DISJOINT_BITS, 0,
- "D2_CORE",
- "D2_DRIVER",
- "D2_KMS",
- "D2_PRIME",
- "D2_ATOMIC",
- "D2_VBL",
- "D2_STATE",
- "D2_LEASE",
- "D2_DP",
- "D2_DRMRES");
-DD_SYS_WRAP(disjoint_bits, p);
-DD_SYS_WRAP(disjoint_bits, T);
-
-/* numeric verbosity, V2 > V1 related */
-enum cat_level_num { V0 = 14, V1, V2, V3, V4, V5, V6, V7 };
-DECLARE_DYNDBG_CLASSMAP(map_level_num, DD_CLASS_TYPE_LEVEL_NUM, 14,
- "V0", "V1", "V2", "V3", "V4", "V5", "V6", "V7");
-DD_SYS_WRAP(level_num, p);
-DD_SYS_WRAP(level_num, T);
+
+/* numeric verbosity, V2 > V1 related. V1 is > D2_DRMRES */
+enum cat_level_num { V1 = 16, V2, V3, V4, V5, V6, V7 };
+
+/* recapitulate DRM's multi-classmap setup */
+#if !defined(TEST_DYNAMIC_DEBUG_SUBMOD)
+/*
+ * In single user, or parent / coordinator (drm.ko) modules, define
+ * classmaps on the client enums above, and then declares the PARAMS
+ * ref'g the classmaps. Each is exported.
+ */
+DYNAMIC_DEBUG_CLASSMAP_DEFINE(map_disjoint_bits, DD_CLASS_TYPE_DISJOINT_BITS,
+ D2_CORE,
+ "D2_CORE",
+ "D2_DRIVER",
+ "D2_KMS",
+ "D2_PRIME",
+ "D2_ATOMIC",
+ "D2_VBL",
+ "D2_STATE",
+ "D2_LEASE",
+ "D2_DP",
+ "D2_DRMRES");
+
+DYNAMIC_DEBUG_CLASSMAP_DEFINE(map_level_num, DD_CLASS_TYPE_LEVEL_NUM,
+ V1, "V1", "V2", "V3", "V4", "V5", "V6", "V7");
+
+#else /* TEST_DYNAMIC_DEBUG_SUBMOD */
+
+/*
+ * in submod/drm-drivers, use the classmaps defined in top/parent
+ * module above.
+ */
+
+DYNAMIC_DEBUG_CLASSMAP_USE(map_disjoint_bits);
+DYNAMIC_DEBUG_CLASSMAP_USE_(map_level_num, 7);
+
+enum cat_level_offset { Vu1 = V1 + 7, Vu2, Vu3, Vu4, Vu5, Vu6, Vu7 };
+
+#endif
+
+/*
+ * now add the sysfs-params
+ */
+
+DYNAMIC_DEBUG_CLASSMAP_PARAM(disjoint_bits, p);
+DYNAMIC_DEBUG_CLASSMAP_PARAM(level_num, p);
/* stand-in for all pr_debug etc */
#define prdbg(SYM) __pr_debug_cls(SYM, #SYM " msg\n")
@@ -104,6 +172,7 @@ static void do_levels(void)
{
pr_debug("doing levels\n");
+#if !defined(TEST_DYNAMIC_DEBUG_SUBMOD)
prdbg(V1);
prdbg(V2);
prdbg(V3);
@@ -111,10 +180,20 @@ static void do_levels(void)
prdbg(V5);
prdbg(V6);
prdbg(V7);
+#else
+ prdbg(Vu1);
+ prdbg(Vu2);
+ prdbg(Vu3);
+ prdbg(Vu4);
+ prdbg(Vu5);
+ prdbg(Vu6);
+ prdbg(Vu7);
+#endif
}
static void do_prints(void)
{
+ pr_debug("do_prints:\n");
do_cats();
do_levels();
}
diff --git a/lib/test_dynamic_debug_submod.c b/lib/test_dynamic_debug_submod.c
new file mode 100644
index 000000000000..672aabf40160
--- /dev/null
+++ b/lib/test_dynamic_debug_submod.c
@@ -0,0 +1,14 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Kernel module for testing dynamic_debug
+ *
+ * Authors:
+ * Jim Cromie <jim.cromie@gmail.com>
+ */
+
+/*
+ * clone the parent, inherit all the properties, for consistency and
+ * simpler accounting in test expectations.
+ */
+#define TEST_DYNAMIC_DEBUG_SUBMOD
+#include "test_dynamic_debug.c"
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 23/40] selftests/dyndbg: Enable FT_classmap_inheritance
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (21 preceding siblings ...)
2026-10-13 2:36 ` [PATCH v12 22/40] dyndbg-API: replace DECLARE_DYNDBG_CLASSMAP Jim Cromie via B4 Relay
@ 2026-10-13 2:36 ` Jim Cromie via B4 Relay
2026-10-13 2:36 ` [PATCH v12 24/40] dyndbg: detect class_id reservation conflicts Jim Cromie via B4 Relay
` (16 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:36 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie
From: Jim Cromie <jim.cromie@gmail.com>
Exercise classmap state inheritance between supermod and submod,
verifying that class settings and controlling parameter states propagate
from parent classmap definitions to dependent class users upon module
load and during runtime reconfiguration.
Add FT_classmap_inheritance to exercise classmap parameter propagation
across test_dynamic_debug and test_dynamic_debug_submod. Enable it under
modular_tests and register its 8 golden record checksums.
Uncomment the 5-keyword query in FT_grammar_ok now that commit 12
("dyndbg: bump num-tokens in a query-cmd from 9 to 15") expands
MAX_WORDS to accommodate queries with >9 tokens.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
.../selftests/dynamic_debug/dyndbg_selftest.sh | 84 +++++++++++++++++++++-
1 file changed, 83 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
index c279c795867b..d759243a4cbe 100755
--- a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
+++ b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
@@ -64,6 +64,7 @@ function ifrmmod {
}
# Clean up any leftover loaded test modules at initialization
+ifrmmod test_dynamic_debug_submod
ifrmmod test_dynamic_debug
# ===========================================================================
@@ -189,7 +190,7 @@ function FT_grammar_ok {
# use 4 keywords (max 9 words inc flags)
ddcmd "module foo file bar.c func buz class D2_CORE +_" # 4 keywords
- #ddcmd "module foo file bar.c func buz class D2 line 100 +_" # 5 keywords
+ ddcmd "module foo file bar.c func buz class D2 line 100 +_" # 5 keywords
# 3. Dedicated lineno range grammar assertions (side-effect-free proofs)
ddcmd "line 42 +_" # test exact line syntax
@@ -291,6 +292,78 @@ function FT_basic_queries {
ddcmd "file $f =_" "$f"
}
+function FT_classmap_inheritance {
+ v_echo "${GREEN}# TEST_MOD_SUBMOD ${NC}"
+
+ ifrmmod test_dynamic_debug_submod
+ ifrmmod test_dynamic_debug
+
+ # modprobe with plain-old +p & 3 class enablements
+ my_modprobe test_dynamic_debug \
+ "dyndbg=+p;class D2_CORE +pf;class D2_KMS +pt;class D2_ATOMIC +pm"
+ verify_control_slice '\[test_dynamic_debug\]'
+
+ set_param 5 /sys/module/test_dynamic_debug/parameters/p_level_num
+ verify_control_slice '\[test_dynamic_debug\]'
+
+ my_modprobe test_dynamic_debug_submod
+ verify_control_slice 'test_dynamic_debug_submod'
+
+ # fresh start, to clear all above flags (test-fn limits)
+ ifrmmod test_dynamic_debug_submod
+ ifrmmod test_dynamic_debug
+
+ # load submod, which loads supermod
+ my_modprobe test_dynamic_debug_submod \
+ "dyndbg=+p;class D2_CORE +pfs;class D2_KMS +pts;class D2_ATOMIC +pmf"
+ verify_control_slice 'test_dynamic_debug'
+
+ # runtime changes to both
+ set_param 0x57 /sys/module/test_dynamic_debug/parameters/p_disjoint_bits
+ set_param 4 /sys/module/test_dynamic_debug/parameters/p_level_num
+ verify_control_slice 'test_dynamic_debug'
+
+ ifrmmod test_dynamic_debug_submod
+ ifrmmod test_dynamic_debug
+
+ # set super-mod params at load-time
+ my_modprobe test_dynamic_debug p_disjoint_bits=0x16 p_level_num=5
+ verify_control_slice '\[test_dynamic_debug\]'
+
+ # see them picked up by submod
+ my_modprobe test_dynamic_debug_submod
+ verify_control_slice 'test_dynamic_debug'
+
+ # Real-time mathematical proof that load-time (modprobe) parameter parsing
+ # and runtime (sysfs write) parameter configurations are perfectly equivalent!
+ local hash_modprobe=$(slice_and_hash_ddctrl '\[test_dynamic_debug*\]')
+
+ # Fresh load with default parameters, then configure them dynamically at runtime
+ ifrmmod test_dynamic_debug_submod
+ ifrmmod test_dynamic_debug
+ my_modprobe test_dynamic_debug
+ my_modprobe test_dynamic_debug_submod
+ echo 0x16 > /sys/module/test_dynamic_debug/parameters/p_disjoint_bits
+ echo 5 > /sys/module/test_dynamic_debug/parameters/p_level_num
+
+ local hash_sysfs=$(slice_and_hash_ddctrl '\[test_dynamic_debug*\]')
+ if [ "$hash_modprobe" != "$hash_sysfs" ]; then
+ echo -e "${RED}: Load-time vs runtime parameter equivalence check failed!${NC}"
+ exit $ksft_fail
+ else
+ v_echo "${GREEN}: Proven: parameter load-time (modprobe) " \
+ "and runtime (sysfs write) are equivalent!${NC}"
+ fi
+ # --- Live Content Fingerprinting Phase ---
+ log_start
+ echo 1 > /sys/module/test_dynamic_debug/parameters/do_prints
+ echo 1 > /sys/module/test_dynamic_debug_submod/parameters/do_prints
+ log_stop
+
+ ifrmmod test_dynamic_debug_submod
+ ifrmmod test_dynamic_debug
+}
+
# Built-in Feature Tests (Can run on any CONFIG_DYNAMIC_DEBUG kernel, modular or monolithic)
builtin_tests=(
FT_grammar_ok
@@ -300,6 +373,7 @@ builtin_tests=(
# Modular Feature Tests (Require CONFIG_MODULES=y and test_dynamic_debug*.ko available)
modular_tests=(
+ FT_classmap_inheritance
)
# ==============================================================================
@@ -383,6 +457,14 @@ function GOLDEN_RECORDS {
#K= 02e4fd94602e108cb89bfc70d47a5dad FT_basic_queries.5
#K= f03a7ca7316e8db4c0e16523dc41e75d FT_basic_queries.6
#K= c518a50ba30ba8099d0dc874a27ecf16 FT_basic_queries.7
+#K= fb294f02a4207b28b2a874524ef07afd FT_classmap_inheritance.1
+#K= 7a0b87016fdc237077dfe96bbbb3661b FT_classmap_inheritance.2
+#K= 2784d60f5056fc5cc03b3ceb854293f5 FT_classmap_inheritance.3
+#K= bf66aaf8ff612272c0cda29778ed2131 FT_classmap_inheritance.4
+#K= 49fdd29d91a4c1d16f8b59bb431e741b FT_classmap_inheritance.5
+#K= a8aa244285d048b5ebe33061fa99c424 FT_classmap_inheritance.6
+#K= 3060b86a0f553dd5a826bb7023284925 FT_classmap_inheritance.7
+#K= f43e0aff8a4b38435b73d90ed8100d1b FT_classmap_inheritance.8
EOF
# Read the K-recs and skip those for tests that can't run
while read -r line; do
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 24/40] dyndbg: detect class_id reservation conflicts
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (22 preceding siblings ...)
2026-10-13 2:36 ` [PATCH v12 23/40] selftests/dyndbg: Enable FT_classmap_inheritance Jim Cromie via B4 Relay
@ 2026-10-13 2:36 ` Jim Cromie via B4 Relay
2026-10-13 2:36 ` [PATCH v12 25/40] dyndbg: check DYNAMIC_DEBUG_CLASSMAP_{DEFINE,USE_} args at compile-time Jim Cromie via B4 Relay
` (15 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:36 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie,
Louis Chauvet
From: Jim Cromie <jim.cromie@gmail.com>
If a module _DEFINEs 2 or more classmaps, it must devise them to share
the per-module 0..62 class-id space; ie their respective base,+length
reservations cannot overlap.
To detect conflicts at modprobe, add ddebug_class_range_overlap(),
call it from ddebug_add_module(), and WARN and return -EINVAL when
they're detected.
This insures that class_id -> classname lookup has just 1 answer, so
the 1st-found search in find-class-name works properly.
test_dynamic_debug.c:
If built with -DFORCE_CLASSID_CONFLICT, the test-modules invoke 2
conflicting DYNAMIC_DEBUG_CLASSMAP_DEFINE() declarations, into parent
and the _submod. These conflict with one of the good ones in the
parent (D2_CORE..etc), causing the modprobe(s) to WARN and fail.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
---
v11:
. only increment mod_ct when ddebug_add_module() returns 0.
Sashiko review complaint (patch 25):
"Is it intentional to unconditionally increment mod_ct here? By
changing this from a fatal error to a warn-and-continue, if
ddebug_add_module() fails, the inflated mod_ct will cause inaccurate
initialization logs (vpr_info) and an incorrect calculation for memory
used by ddebug tables. Should the increment only happen on success?"
v9:
. make ddebug_add_module() failure non-fatal during dynamic_debug_init(),
logging warning and continuing instead of tearing down all tables kernel-wide.
v2: RvB after SoB
old-v9 - fix WARN() by adding new 1st arg 1.
old-v12 - drop maybe_unused on range-overlap fn
---
lib/dynamic_debug.c | 73 ++++++++++++++++++++++++++++--------------------
lib/test_dynamic_debug.c | 8 ++++++
2 files changed, 50 insertions(+), 31 deletions(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 8c314a52d8f9..64ad70738d95 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -1102,18 +1102,19 @@ static void *ddebug_proc_next(struct seq_file *m, void *p, loff_t *pos)
return dp;
}
-static bool ddebug_class_in_range(const int class_id, const struct ddebug_class_map *map)
+static bool ddebug_class_map_in_range(const int class_id, const struct ddebug_class_map *map)
{
+ if (!map)
+ return false;
return (class_id >= map->base &&
class_id < map->base + map->length);
}
-static bool ddebug_user_class_in_range(const int class_id, const struct ddebug_class_user *cli)
+static bool ddebug_class_user_in_range(const int class_id, const struct ddebug_class_user *user)
{
- if (!cli || !cli->map)
+ if (!user)
return false;
- int base = cli->map->base + cli->offset;
- return (class_id >= base && class_id < base + cli->map->length);
+ return ddebug_class_map_in_range(class_id - user->offset, user->map);
}
static const char *ddebug_class_name(struct _ddebug_info *di, struct _ddebug *dp)
@@ -1123,11 +1124,11 @@ static const char *ddebug_class_name(struct _ddebug_info *di, struct _ddebug *dp
int i;
for_subvec(i, map, di, maps)
- if (ddebug_class_in_range(dp->class_id, map))
+ if (ddebug_class_map_in_range(dp->class_id, map))
return map->class_names[dp->class_id - map->base];
for_subvec(i, cli, di, users)
- if (ddebug_user_class_in_range(dp->class_id, cli))
+ if (ddebug_class_user_in_range(dp->class_id, cli))
return cli->map->class_names[dp->class_id - cli->map->base - cli->offset];
return NULL;
@@ -1396,6 +1397,20 @@ static void ddebug_apply_class_users(const struct _ddebug_info *di)
__di->_vec.start = __start; \
})
+static int ddebug_class_range_overlap(struct ddebug_class_map *cm, u64 *reserved_ids)
+{
+ u64 range = (((1ULL << cm->length) - 1) << cm->base);
+
+ if (range & *reserved_ids) {
+ pr_err("[%d..%d] on %s conflicts with %llx\n", cm->base,
+ cm->base + cm->length - 1, cm->class_names[0],
+ *reserved_ids);
+ return -EINVAL;
+ }
+ *reserved_ids |= range;
+ return 0;
+}
+
/*
* Allocate a new ddebug_table for the given module
* and add it to the global list.
@@ -1405,6 +1420,7 @@ static int ddebug_add_module(struct _ddebug_info *di)
struct ddebug_table *dt;
struct ddebug_class_map *cm;
struct ddebug_class_user *cli;
+ u64 reserved_ids = 0;
int i;
if (!di->descs.len)
@@ -1436,6 +1452,13 @@ static int ddebug_add_module(struct _ddebug_info *di)
dd_set_module_subrange(i, cm, &dt->info, maps);
dd_set_module_subrange(i, cli, &dt->info, users);
+ /* insure 2+ classmaps share the per-module 0..62 class_id space */
+ for_subvec(i, cm, &dt->info, maps)
+ if (ddebug_class_range_overlap(cm, &reserved_ids))
+ goto cleanup;
+
+ /*
+ */
mutex_lock(&ddebug_lock);
list_add_tail(&dt->link, &ddebug_tables);
mutex_unlock(&ddebug_lock);
@@ -1453,6 +1476,10 @@ static int ddebug_add_module(struct _ddebug_info *di)
vpr_info("%3u debug prints in module %s\n",
dt->info.descs.len, dt->info.mod_name);
return 0;
+cleanup:
+ WARN_ONCE(1, "dyndbg multi-classmap conflict in %s\n", di->mod_name);
+ kfree(dt);
+ return -EINVAL;
}
/* helper for ddebug_dyndbg_(boot|module)_param_cb */
@@ -1495,14 +1522,14 @@ int ddebug_dyndbg_module_param_cb(char *param, char *val, const char *module)
return ddebug_dyndbg_param_cb(param, val, module, -ENOENT);
}
+#ifdef CONFIG_MODULES
+
static void ddebug_table_free(struct ddebug_table *dt)
{
list_del_init(&dt->link);
kfree(dt);
}
-#ifdef CONFIG_MODULES
-
/*
* Called in response to a module being unloaded. Removes
* any ddebug_table's which point at the module.
@@ -1554,18 +1581,6 @@ static struct notifier_block ddebug_module_nb = {
#endif /* CONFIG_MODULES */
-static void ddebug_remove_all_tables(void)
-{
- mutex_lock(&ddebug_lock);
- while (!list_empty(&ddebug_tables)) {
- struct ddebug_table *dt = list_entry(ddebug_tables.next,
- struct ddebug_table,
- link);
- ddebug_table_free(dt);
- }
- mutex_unlock(&ddebug_lock);
-}
-
static __initdata int ddebug_init_success;
static int __init dynamic_debug_init_control(void)
@@ -1636,9 +1651,9 @@ static int __init dynamic_debug_init(void)
di.mod_name = modname;
ret = ddebug_add_module(&di);
if (ret)
- goto out_err;
-
- mod_ct++;
+ pr_warn("failed to add built-in module %s: %d\n", modname, ret);
+ else
+ mod_ct++;
iter_mod_start = iter;
modname = iter->modname;
@@ -1651,9 +1666,9 @@ static int __init dynamic_debug_init(void)
di.mod_name = modname;
ret = ddebug_add_module(&di);
if (ret)
- goto out_err;
-
- mod_ct++;
+ pr_warn("failed to add built-in module %s: %d\n", modname, ret);
+ else
+ mod_ct++;
ddebug_init_success = 1;
vpr_info("%d prdebugs in %d modules, %d KiB in ddebug tables, %d kiB in __dyndbg_descs section\n",
@@ -1676,10 +1691,6 @@ static int __init dynamic_debug_init(void)
0, 0, 0, NULL, &ddebug_dyndbg_boot_param_cb);
kfree(cmdline);
return 0;
-
-out_err:
- ddebug_remove_all_tables();
- return 0;
}
/* Allow early initialization for boot messages via boot param */
early_initcall(dynamic_debug_init);
diff --git a/lib/test_dynamic_debug.c b/lib/test_dynamic_debug.c
index 34e51996aa20..3a69cc3cae6d 100644
--- a/lib/test_dynamic_debug.c
+++ b/lib/test_dynamic_debug.c
@@ -128,6 +128,14 @@ DYNAMIC_DEBUG_CLASSMAP_DEFINE(map_disjoint_bits, DD_CLASS_TYPE_DISJOINT_BITS,
DYNAMIC_DEBUG_CLASSMAP_DEFINE(map_level_num, DD_CLASS_TYPE_LEVEL_NUM,
V1, "V1", "V2", "V3", "V4", "V5", "V6", "V7");
+#ifdef FORCE_CLASSID_CONFLICT
+/*
+ * Enable with -Dflag on compile to test overlapping class-id range
+ * detection. This should warn on modprobes.
+ */
+DYNAMIC_DEBUG_CLASSMAP_DEFINE(classid_range_conflict, 0, D2_CORE + 1, "D3_CORE");
+#endif
+
#else /* TEST_DYNAMIC_DEBUG_SUBMOD */
/*
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 25/40] dyndbg: check DYNAMIC_DEBUG_CLASSMAP_{DEFINE,USE_} args at compile-time
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (23 preceding siblings ...)
2026-10-13 2:36 ` [PATCH v12 24/40] dyndbg: detect class_id reservation conflicts Jim Cromie via B4 Relay
@ 2026-10-13 2:36 ` Jim Cromie via B4 Relay
2026-10-13 2:36 ` [PATCH v12 26/40] dyndbg-test: add do_bulk testpoint, rename do_prints to do_classes Jim Cromie via B4 Relay
` (14 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:36 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie
From: Jim Cromie <jim.cromie@gmail.com>
Add __DYNAMIC_DEBUG_CLASSMAP_CHECK to implement the following
arg-checks at compile-time:
0 <= _base < 63
class_names is not empty
class_names[0] is a string
class_names.length <= 32
(class_names.length + _base) < 63
dd-map-type is known value
These compile-time checks will prevent several simple misuses, issuing
obvious errors if violated.
Several bad examples are ifdef DD_MACRO_ARGCHECK qualified in
test_dynamic_debug_submod.c and will fail compilation if enabled.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
include/linux/dynamic_debug.h | 16 +++++++++++++++-
lib/test_dynamic_debug.c | 20 +++++++++++++++++---
2 files changed, 32 insertions(+), 4 deletions(-)
diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
index 3c2ab0ec23c1..cd733f256b90 100644
--- a/include/linux/dynamic_debug.h
+++ b/include/linux/dynamic_debug.h
@@ -184,6 +184,19 @@ struct ddebug_class_param {
* __pr_debug_cls(22, "no such class"); compiles but is not reachable
*/
+#define __DYNAMIC_DEBUG_CLASSMAP_CHECK(_clnames, _base, _mapty) \
+ static_assert(((_base) >= 0 && (_base) < _DPRINTK_CLASS_DFLT), \
+ "_base must be in 0..62"); \
+ static_assert(__DDEBUG_ARRAY_SIZE(_clnames) > 0, \
+ "classnames array size must be > 0"); \
+ static_assert(__DDEBUG_ARRAY_SIZE(_clnames) <= 32, \
+ "classnames array size must be <= 32"); \
+ static_assert((__DDEBUG_ARRAY_SIZE(_clnames) + (_base)) <= _DPRINTK_CLASS_DFLT, \
+ "_base + classnames.length must be <= 63"); \
+ static_assert(((_mapty) >= DD_CLASS_TYPE_DISJOINT_BITS) && \
+ ((_mapty) <= DD_CLASS_TYPE_LEVEL_NUM), \
+ "unknown class_map_type")
+
/**
* DYNAMIC_DEBUG_CLASSMAP_DEFINE - define debug classes used by a module.
* @_var: name of the classmap, exported for other modules coordinated use.
@@ -197,6 +210,7 @@ struct ddebug_class_param {
*/
#define DYNAMIC_DEBUG_CLASSMAP_DEFINE(_var, _mapty, _base, ...) \
static const char *_var##_classnames[] = { __VA_ARGS__ }; \
+ __DYNAMIC_DEBUG_CLASSMAP_CHECK(_var##_classnames, (_base), (_mapty)); \
extern struct ddebug_class_map _var; \
struct ddebug_class_map __aligned(8) __used \
__section("__dyndbg_class_maps") _var = { \
@@ -204,7 +218,7 @@ struct ddebug_class_param {
.mod_name = KBUILD_MODNAME, \
.base = (_base), \
.map_type = (_mapty), \
- .length = ARRAY_SIZE(_var##_classnames), \
+ .length = __DDEBUG_ARRAY_SIZE(_var##_classnames), \
.class_names = _var##_classnames, \
}; \
EXPORT_SYMBOL(_var)
diff --git a/lib/test_dynamic_debug.c b/lib/test_dynamic_debug.c
index 3a69cc3cae6d..01ce07001d4c 100644
--- a/lib/test_dynamic_debug.c
+++ b/lib/test_dynamic_debug.c
@@ -148,12 +148,26 @@ DYNAMIC_DEBUG_CLASSMAP_USE_(map_level_num, 7);
enum cat_level_offset { Vu1 = V1 + 7, Vu2, Vu3, Vu4, Vu5, Vu6, Vu7 };
-#endif
-
+#if defined(DD_MACRO_ARGCHECK)
/*
- * now add the sysfs-params
+ * Exersize compile-time arg-checks in DYNAMIC_DEBUG_CLASSMAP_DEFINE.
+ * These will break compilation.
*/
+DYNAMIC_DEBUG_CLASSMAP_DEFINE(fail_base_neg, 0, -1, "NEGATIVE_BASE_ARG");
+DYNAMIC_DEBUG_CLASSMAP_DEFINE(fail_base_big, 0, 100, "TOOBIG_BASE_ARG");
+DYNAMIC_DEBUG_CLASSMAP_DEFINE(fail_str_type, 0, 0, 1 /* not a string */);
+DYNAMIC_DEBUG_CLASSMAP_DEFINE(fail_emptyclass, 0, 0 /* ,empty */);
+DYNAMIC_DEBUG_CLASSMAP_DEFINE(fail_maptype, 3, 10, "no such type");
+DYNAMIC_DEBUG_CLASSMAP_DEFINE(fail_base_len, 0, 60,
+ "base", "plus", "classes", "length", "too-big");
+DYNAMIC_DEBUG_CLASSMAP_USE_(fail_offset_big, 100);
+#endif /* DD_MACRO_ARGCHECK */
+
+#endif /* TEST_DYNAMIC_DEBUG_SUBMOD */
+/*
+ * now add the sysfs-params to both sub/super-mods
+ */
DYNAMIC_DEBUG_CLASSMAP_PARAM(disjoint_bits, p);
DYNAMIC_DEBUG_CLASSMAP_PARAM(level_num, p);
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 26/40] dyndbg-test: add do_bulk testpoint, rename do_prints to do_classes
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (24 preceding siblings ...)
2026-10-13 2:36 ` [PATCH v12 25/40] dyndbg: check DYNAMIC_DEBUG_CLASSMAP_{DEFINE,USE_} args at compile-time Jim Cromie via B4 Relay
@ 2026-10-13 2:36 ` Jim Cromie via B4 Relay
2026-10-13 2:36 ` [PATCH v12 27/40] dyndbg-API: promote DYNAMIC_DEBUG_CLASSMAP_PARAM to API Jim Cromie via B4 Relay
` (13 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:36 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie
From: Jim Cromie <jim.cromie@gmail.com>
test_dynamic_debug.ko currently has the do_prints sysnode to support
testing of the classmaps feature, it calls ~16 class'd pr_debug()s,
*once* for each class defined in the module.
Improve the versatility of this support by:
1. changing do_prints() to do_classes()
to better align with its actual purpose
2. new parameters/do_bulk & do_bulk(N):
loops over 10 pr_debugs, N times
creates idempotent non-repetetive (ie 1..N lines) output
meant for creating high-volume workloads
3. using common param-ops for both (no reason not to)
ie: do_classes(N) now accepts work-count.
So now we can generate significant workloads with a single write.
modprobe test_dynamic_debug dyndbg=+p
echo 100 > /sys/module/test_dynamic_debug/parameters/do_classes
echo 2000 > /sys/module/test_dynamic_debug/parameters/do_bulk
TODO: enable do_bulk() callsites by default, since the modprobe is an
explicit act, the user intends to use it, lets turn it on.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
v11:
. clamp repeat count input to 10,000 in param_set_do_repeats() and add
signal_pending(current) break check to do_classes() and do_bulk()
loops to prevent unbounded print storms and allow interactive aborts.
. add timed execution mode for negative repeats: convert repeat
parameter to signed int, interpreting -N as duration in seconds
(clamped to 60s) looping until timeout expires or signal received.
v9:
. use unsigned int for loop index in do_bulk() to prevent wrapping lockups on UINT_MAX.
. add cond_resched() to do_classes() and do_bulk() loops.
v8: fix a test which had commas, from the future, adjust KRECs
---
lib/test_dynamic_debug.c | 162 ++++++++++++++++----
.../selftests/dynamic_debug/dyndbg_selftest.sh | 170 +++++++++++++++++----
2 files changed, 275 insertions(+), 57 deletions(-)
diff --git a/lib/test_dynamic_debug.c b/lib/test_dynamic_debug.c
index 01ce07001d4c..19e27b5747ac 100644
--- a/lib/test_dynamic_debug.c
+++ b/lib/test_dynamic_debug.c
@@ -28,25 +28,57 @@
#endif
#include <linux/module.h>
+#include <linux/sched.h>
+#include <linux/sched/signal.h>
+#include <linux/jiffies.h>
-/* re-gen output by reading or writing sysfs node: do_prints */
+#define TEST_MAX_REPEATS 10000
+#define TEST_MAX_SECONDS 60
-static void do_prints(void); /* device under test */
-static int param_set_do_prints(const char *instr, const struct kernel_param *kp)
+/* re-trigger debug output by reading or writing sysfs nodes: do_classes or do_bulk */
+static void do_classes(int); /* device under test */
+static void do_bulk(int); /* device under test */
+
+static int param_set_do_repeats(const char *instr, const struct kernel_param *kp)
{
- do_prints();
+ int rc, ct;
+ void (*repeat_fn)(int) = kp->arg;
+
+ rc = kstrtoint(instr, 0, &ct);
+ if (rc) {
+ pr_err("expecting numeric input, using 1 instead\n");
+ ct = 1;
+ }
+ if (ct > TEST_MAX_REPEATS) {
+ pr_warn("%s: clamping %d to %d\n", kp->name, ct, TEST_MAX_REPEATS);
+ ct = TEST_MAX_REPEATS;
+ } else if (ct < -TEST_MAX_SECONDS) {
+ pr_warn("%s: clamping %d seconds to -%d\n",
+ kp->name, ct, TEST_MAX_SECONDS);
+ ct = -TEST_MAX_SECONDS;
+ }
+
+ repeat_fn(ct);
+
return 0;
}
-static int param_get_do_prints(char *buffer, const struct kernel_param *kp)
+
+static int param_get_do_repeats(char *buffer, const struct kernel_param *kp)
{
- do_prints();
- return scnprintf(buffer, PAGE_SIZE, "did do_prints\n");
+ void (*repeat_fn)(int) = kp->arg;
+
+ repeat_fn(1);
+
+ return scnprintf(buffer, PAGE_SIZE, "did 1 %s\n", kp->name);
}
-static const struct kernel_param_ops param_ops_do_prints = {
- .set = param_set_do_prints,
- .get = param_get_do_prints,
+
+static const struct kernel_param_ops param_ops_do_repeats = {
+ .set = param_set_do_repeats,
+ .get = param_get_do_repeats,
};
-module_param_cb(do_prints, ¶m_ops_do_prints, NULL, 0600);
+
+module_param_cb(do_classes, ¶m_ops_do_repeats, do_classes, 0600);
+module_param_cb(do_bulk, ¶m_ops_do_repeats, do_bulk, 0600);
/*
* Using the CLASSMAP api:
@@ -103,7 +135,10 @@ enum cat_disjoint_bits {
D2_DRMRES };
/* numeric verbosity, V2 > V1 related. V1 is > D2_DRMRES */
-enum cat_level_num { V1 = 16, V2, V3, V4, V5, V6, V7 };
+enum cat_level_num { V1 = 16, V2, V3, V4, V5, V6, V7, V8 };
+
+/* test _USE_ w offset */
+enum cat_level_offset { Vu1 = V1 + 8, Vu2, Vu3, Vu4, Vu5, Vu6, Vu7, Vu8 };
/* recapitulate DRM's multi-classmap setup */
#if !defined(TEST_DYNAMIC_DEBUG_SUBMOD)
@@ -126,7 +161,7 @@ DYNAMIC_DEBUG_CLASSMAP_DEFINE(map_disjoint_bits, DD_CLASS_TYPE_DISJOINT_BITS,
"D2_DRMRES");
DYNAMIC_DEBUG_CLASSMAP_DEFINE(map_level_num, DD_CLASS_TYPE_LEVEL_NUM,
- V1, "V1", "V2", "V3", "V4", "V5", "V6", "V7");
+ V1, "V1", "V2", "V3", "V4", "V5", "V6", "V7", "V8");
#ifdef FORCE_CLASSID_CONFLICT
/*
@@ -136,18 +171,6 @@ DYNAMIC_DEBUG_CLASSMAP_DEFINE(map_level_num, DD_CLASS_TYPE_LEVEL_NUM,
DYNAMIC_DEBUG_CLASSMAP_DEFINE(classid_range_conflict, 0, D2_CORE + 1, "D3_CORE");
#endif
-#else /* TEST_DYNAMIC_DEBUG_SUBMOD */
-
-/*
- * in submod/drm-drivers, use the classmaps defined in top/parent
- * module above.
- */
-
-DYNAMIC_DEBUG_CLASSMAP_USE(map_disjoint_bits);
-DYNAMIC_DEBUG_CLASSMAP_USE_(map_level_num, 7);
-
-enum cat_level_offset { Vu1 = V1 + 7, Vu2, Vu3, Vu4, Vu5, Vu6, Vu7 };
-
#if defined(DD_MACRO_ARGCHECK)
/*
* Exersize compile-time arg-checks in DYNAMIC_DEBUG_CLASSMAP_DEFINE.
@@ -160,6 +183,19 @@ DYNAMIC_DEBUG_CLASSMAP_DEFINE(fail_emptyclass, 0, 0 /* ,empty */);
DYNAMIC_DEBUG_CLASSMAP_DEFINE(fail_maptype, 3, 10, "no such type");
DYNAMIC_DEBUG_CLASSMAP_DEFINE(fail_base_len, 0, 60,
"base", "plus", "classes", "length", "too-big");
+#endif
+
+#else /* TEST_DYNAMIC_DEBUG_SUBMOD */
+
+/*
+ * in submod/drm-drivers, use the classmaps defined in top/parent
+ * module above.
+ */
+
+DYNAMIC_DEBUG_CLASSMAP_USE(map_disjoint_bits);
+DYNAMIC_DEBUG_CLASSMAP_USE_(map_level_num, 7);
+
+#if defined(DD_MACRO_ARGCHECK)
DYNAMIC_DEBUG_CLASSMAP_USE_(fail_offset_big, 100);
#endif /* DD_MACRO_ARGCHECK */
@@ -202,6 +238,7 @@ static void do_levels(void)
prdbg(V5);
prdbg(V6);
prdbg(V7);
+ prdbg(V8);
#else
prdbg(Vu1);
prdbg(Vu2);
@@ -210,20 +247,85 @@ static void do_levels(void)
prdbg(Vu5);
prdbg(Vu6);
prdbg(Vu7);
+ prdbg(Vu8);
#endif
}
-static void do_prints(void)
+static void do_classes(int ct)
+{
+ if (ct < 0) {
+ unsigned long timeout = jiffies + (-ct) * HZ;
+
+ pr_debug("%s for %d seconds:\n", __func__, -ct);
+ while (time_before(jiffies, timeout)) {
+ if (signal_pending(current))
+ break;
+ do_cats();
+ do_levels();
+ cond_resched();
+ }
+ return;
+ }
+
+ pr_debug("do_classes %u times:\n", ct);
+ for (; ct; ct--) {
+ if (signal_pending(current))
+ break;
+ do_cats();
+ do_levels();
+ cond_resched();
+ }
+}
+
+static void do_bulk(int ct)
{
- pr_debug("do_prints:\n");
- do_cats();
- do_levels();
+ unsigned int i;
+
+ if (ct < 0) {
+ unsigned long timeout = jiffies + (-ct) * HZ;
+
+ pr_debug("%s for %d seconds:\n", __func__, -ct);
+ for (i = 0; time_before(jiffies, timeout); i++) {
+ if (signal_pending(current))
+ break;
+ pr_debug("bulk msg %u.0\n", i + 1);
+ pr_debug("bulk msg %u.1\n", i + 1);
+ pr_debug("bulk msg %u.2\n", i + 1);
+ pr_debug("bulk msg %u.3\n", i + 1);
+ pr_debug("bulk msg %u.4\n", i + 1);
+ pr_debug("bulk msg %u.5\n", i + 1);
+ pr_debug("bulk msg %u.6\n", i + 1);
+ pr_debug("bulk msg %u.7\n", i + 1);
+ pr_debug("bulk msg %u.8\n", i + 1);
+ pr_debug("bulk msg %u.9\n", i + 1);
+ cond_resched();
+ }
+ return;
+ }
+
+ pr_debug("do_bulk %u times:\n", ct);
+ for (i = 0; i < ct; i++) {
+ if (signal_pending(current))
+ break;
+ pr_debug("bulk msg %u.0\n", i + 1);
+ pr_debug("bulk msg %u.1\n", i + 1);
+ pr_debug("bulk msg %u.2\n", i + 1);
+ pr_debug("bulk msg %u.3\n", i + 1);
+ pr_debug("bulk msg %u.4\n", i + 1);
+ pr_debug("bulk msg %u.5\n", i + 1);
+ pr_debug("bulk msg %u.6\n", i + 1);
+ pr_debug("bulk msg %u.7\n", i + 1);
+ pr_debug("bulk msg %u.8\n", i + 1);
+ pr_debug("bulk msg %u.9\n", i + 1);
+ cond_resched();
+ }
}
static int __init test_dynamic_debug_init(void)
{
pr_debug("init start\n");
- do_prints();
+ do_classes(1);
+ do_bulk(1);
pr_debug("init done\n");
return 0;
}
diff --git a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
index d759243a4cbe..3d8d2a2cfde6 100755
--- a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
+++ b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
@@ -178,6 +178,54 @@ function slice_and_hash_ddctrl {
echo "$slice" | tr -d '\r' | md5sum | cut -d' ' -f1
}
+# ==============================================================================
+
+function verify_modprobe_param_logging {
+ # $1 - parameter name (e.g. do_prints)
+ # $2 - parameter value (e.g. 1)
+ local param="$1"
+ local val="$2"
+
+ # Make sure both modules are completely unloaded to trigger a fresh load
+ ifrmmod test_dynamic_debug_submod
+ ifrmmod test_dynamic_debug
+
+ # Capture and verify the load-time (modprobe) dmesg logs
+ log_start
+ my_modprobe test_dynamic_debug "${param}=${val}"
+ my_modprobe test_dynamic_debug_submod
+
+ # If it is a state-controlling parameter, trigger the
+ # print-workload 'do_prints=1' inside the same syslog dmesg
+ # capture bookends to verify their actual pr_debug logging!
+
+ if [ "$param" = "p_disjoint_bits" ] || [ "$param" = "p_level_num" ]; then
+ set_param 1 /sys/module/test_dynamic_debug/parameters/do_classes
+ fi
+
+ log_stop
+
+ # Verify param write by direct readback
+ if [ "$param" = "p_disjoint_bits" ] || [ "$param" = "p_level_num" ]; then
+ local readback=$(cat "/sys/module/test_dynamic_debug/parameters/${param}")
+ if (( readback != val )); then
+ echo -e "${RED}: param readback failed: ${param} ${val} != ${readback}${NC}"
+ exit $ksft_fail
+ else
+ [ "$V" -ge 1 ] && \
+ echo -e "${GREEN}✔ Parameter Readback Verified: ${param}=${readback}${NC}"
+ fi
+ fi
+
+ # verify runtime unsetting
+ if [ "$param" = "p_disjoint_bits" ] || [ "$param" = "p_level_num" ]; then
+
+ set_param 0 "/sys/module/test_dynamic_debug/parameters/${param}"
+ verify_control_slice '\[test_dynamic_debug\]'
+
+ fi
+}
+
# ==============================================================================
# FEATURE TESTS (FT_*)
#
@@ -292,33 +340,38 @@ function FT_basic_queries {
ddcmd "file $f =_" "$f"
}
-function FT_classmap_inheritance {
- v_echo "${GREEN}# TEST_MOD_SUBMOD ${NC}"
+# testing classmap-based query enablers and class configurations
+function FT_test_classes {
+ v_echo "${GREEN}# TEST_CLASSES - classmap-based query enablers and class configs ${NC}"
ifrmmod test_dynamic_debug_submod
ifrmmod test_dynamic_debug
+ ddcmd =_
- # modprobe with plain-old +p & 3 class enablements
+ # 1. Verify initial multi-query enablement state via file slice
my_modprobe test_dynamic_debug \
- "dyndbg=+p;class D2_CORE +pf;class D2_KMS +pt;class D2_ATOMIC +pm"
+ dyndbg="class D2_CORE,+pf;class D2_KMS,+ps;class D2_ATOMIC +pm"
verify_control_slice '\[test_dynamic_debug\]'
- set_param 5 /sys/module/test_dynamic_debug/parameters/p_level_num
- verify_control_slice '\[test_dynamic_debug\]'
+ # 2. Verify state transition and live-printing end-to-end via ddcmd_load!
+ ddcmd_load "class D2_CORE +pmf;class D2_KMS +pls;class D2_ATOMIC +pml" \
+ '\[test_dynamic_debug\]' \
+ "/sys/module/test_dynamic_debug/parameters/do_classes" "1"
- my_modprobe test_dynamic_debug_submod
- verify_control_slice 'test_dynamic_debug_submod'
+ ifrmmod test_dynamic_debug
+}
+function FT_classmap_inheritance {
+ v_echo "${GREEN}# TEST_MOD_SUBMOD - Classmap state inheritance between supermod and submod ${NC}"
- # fresh start, to clear all above flags (test-fn limits)
ifrmmod test_dynamic_debug_submod
ifrmmod test_dynamic_debug
- # load submod, which loads supermod
+ # 1. Load submod directly (which auto-loads supermod with default parameters)
my_modprobe test_dynamic_debug_submod \
"dyndbg=+p;class D2_CORE +pfs;class D2_KMS +pts;class D2_ATOMIC +pmf"
verify_control_slice 'test_dynamic_debug'
- # runtime changes to both
+ # 2. Runtime parameter changes to supermod propagate to submod descriptors
set_param 0x57 /sys/module/test_dynamic_debug/parameters/p_disjoint_bits
set_param 4 /sys/module/test_dynamic_debug/parameters/p_level_num
verify_control_slice 'test_dynamic_debug'
@@ -326,19 +379,17 @@ function FT_classmap_inheritance {
ifrmmod test_dynamic_debug_submod
ifrmmod test_dynamic_debug
- # set super-mod params at load-time
+ # 3. Pre-initialize supermod parameter state at load-time
my_modprobe test_dynamic_debug p_disjoint_bits=0x16 p_level_num=5
verify_control_slice '\[test_dynamic_debug\]'
- # see them picked up by submod
+ # 4. Verify submod inherits pre-initialized supermod classmap parameter state upon load
my_modprobe test_dynamic_debug_submod
verify_control_slice 'test_dynamic_debug'
- # Real-time mathematical proof that load-time (modprobe) parameter parsing
- # and runtime (sysfs write) parameter configurations are perfectly equivalent!
+ # 5. Prove load-time (modprobe) and runtime (sysfs write) parameter equivalence
local hash_modprobe=$(slice_and_hash_ddctrl '\[test_dynamic_debug*\]')
- # Fresh load with default parameters, then configure them dynamically at runtime
ifrmmod test_dynamic_debug_submod
ifrmmod test_dynamic_debug
my_modprobe test_dynamic_debug
@@ -354,16 +405,43 @@ function FT_classmap_inheritance {
v_echo "${GREEN}: Proven: parameter load-time (modprobe) " \
"and runtime (sysfs write) are equivalent!${NC}"
fi
- # --- Live Content Fingerprinting Phase ---
+ # 6. End-to-end syslog content logging verification
log_start
- echo 1 > /sys/module/test_dynamic_debug/parameters/do_prints
- echo 1 > /sys/module/test_dynamic_debug_submod/parameters/do_prints
+ echo 1 > /sys/module/test_dynamic_debug/parameters/do_classes
+ echo 1 > /sys/module/test_dynamic_debug_submod/parameters/do_classes
log_stop
ifrmmod test_dynamic_debug_submod
ifrmmod test_dynamic_debug
}
+function FT_modprobe_w_param {
+ v_echo "${GREEN}# TEST_MODPROBES ${NC}"
+ local verbose
+
+ ifrmmod test_dynamic_debug_submod
+ ifrmmod test_dynamic_debug
+
+ for verbose in 1 2; do # 3 4 0; do
+ echo $verbose > /sys/module/dynamic_debug/parameters/verbose
+
+ # Verify each parameter load sequence with 100% DRY modularity
+ verify_modprobe_param_logging "do_classes" "1"
+ verify_modprobe_param_logging "do_bulk" "1"
+
+ # Sequence composite bitmasks to verify disjoint bit transitions
+ for mask in "0x05" "0x12" "0x1f" "0x00"; do
+ verify_modprobe_param_logging "p_disjoint_bits" "$mask"
+ done
+
+ # Sequence levels to verify both growing and shrinking verbose transitions
+ for lvl in "3" "5" "4" "0"; do
+ verify_modprobe_param_logging "p_level_num" "$lvl"
+ done
+ done
+ ddcmd =_
+}
+
# Built-in Feature Tests (Can run on any CONFIG_DYNAMIC_DEBUG kernel, modular or monolithic)
builtin_tests=(
FT_grammar_ok
@@ -373,7 +451,9 @@ builtin_tests=(
# Modular Feature Tests (Require CONFIG_MODULES=y and test_dynamic_debug*.ko available)
modular_tests=(
+ FT_test_classes
FT_classmap_inheritance
+ FT_modprobe_w_param
)
# ==============================================================================
@@ -457,14 +537,50 @@ function GOLDEN_RECORDS {
#K= 02e4fd94602e108cb89bfc70d47a5dad FT_basic_queries.5
#K= f03a7ca7316e8db4c0e16523dc41e75d FT_basic_queries.6
#K= c518a50ba30ba8099d0dc874a27ecf16 FT_basic_queries.7
-#K= fb294f02a4207b28b2a874524ef07afd FT_classmap_inheritance.1
-#K= 7a0b87016fdc237077dfe96bbbb3661b FT_classmap_inheritance.2
-#K= 2784d60f5056fc5cc03b3ceb854293f5 FT_classmap_inheritance.3
-#K= bf66aaf8ff612272c0cda29778ed2131 FT_classmap_inheritance.4
-#K= 49fdd29d91a4c1d16f8b59bb431e741b FT_classmap_inheritance.5
-#K= a8aa244285d048b5ebe33061fa99c424 FT_classmap_inheritance.6
-#K= 3060b86a0f553dd5a826bb7023284925 FT_classmap_inheritance.7
-#K= f43e0aff8a4b38435b73d90ed8100d1b FT_classmap_inheritance.8
+#K= 2b4b152bdb82e6e4a5be18ca26025895 FT_test_classes.1
+#K= 5516e3d13cba7ea4197a7fb6c033887a FT_test_classes.2
+#K= 37dc0919cb1c0ee8ba00ad2ad77ba7c3 FT_test_classes.3
+#K= 81b16613f8d444485e2bc5aa4d38d024 FT_classmap_inheritance.1
+#K= c14c8aa758e24046b3237d20e2189bf7 FT_classmap_inheritance.2
+#K= 5d0f3701517aa3a461c8887c332bdb42 FT_classmap_inheritance.3
+#K= f444ae312fcce32444c54da757d87c41 FT_classmap_inheritance.4
+#K= 7e92245008439ee79fe2460aeaa16a9b FT_classmap_inheritance.5
+#K= d2e8b8c5a5b4e7b9bbe1a29460a3c07d FT_modprobe_w_param.1
+#K= d2e8b8c5a5b4e7b9bbe1a29460a3c07d FT_modprobe_w_param.2
+#K= 11032ef17569bd151c3806527a2428be FT_modprobe_w_param.3
+#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.4
+#K= 942e62ca24809cad666c5725aeb14376 FT_modprobe_w_param.5
+#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.6
+#K= fe1aadca4b2b4165d8d5c98e973f9e4b FT_modprobe_w_param.7
+#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.8
+#K= 535ab526b24a7214de41d92e94bbd52c FT_modprobe_w_param.9
+#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.10
+#K= a71670fec42b1b0646f0317180bafcc7 FT_modprobe_w_param.11
+#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.12
+#K= aacdbab171b374f221f0196e6e415d09 FT_modprobe_w_param.13
+#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.14
+#K= c7eb8e25c780f58c78ed73dc1c187a02 FT_modprobe_w_param.15
+#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.16
+#K= d682c98ced7d31f1555ab474a9ebe253 FT_modprobe_w_param.17
+#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.18
+#K= 362ab2e7e5f5e3ede8b69645c64fb987 FT_modprobe_w_param.19
+#K= 362ab2e7e5f5e3ede8b69645c64fb987 FT_modprobe_w_param.20
+#K= 4f539816f9cc9fb9dd4a032138e3abde FT_modprobe_w_param.21
+#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.22
+#K= 20659d16ffb5b18475e83602223216d1 FT_modprobe_w_param.23
+#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.24
+#K= 0b24971fb1018c38353141f8fcb9cbdc FT_modprobe_w_param.25
+#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.26
+#K= 66eb387a95512f679eb5cad4168b0992 FT_modprobe_w_param.27
+#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.28
+#K= 2583cb4637bcc2ce1e93eea4222ec76c FT_modprobe_w_param.29
+#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.30
+#K= d592c5bf23312e705b39064c21ca68e4 FT_modprobe_w_param.31
+#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.32
+#K= b44d105d151123c93cfe953bacdb573f FT_modprobe_w_param.33
+#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.34
+#K= 4819f715ba485c493afb455542f7ab8c FT_modprobe_w_param.35
+#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.36
EOF
# Read the K-recs and skip those for tests that can't run
while read -r line; do
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 27/40] dyndbg-API: promote DYNAMIC_DEBUG_CLASSMAP_PARAM to API
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (25 preceding siblings ...)
2026-10-13 2:36 ` [PATCH v12 26/40] dyndbg-test: add do_bulk testpoint, rename do_prints to do_classes Jim Cromie via B4 Relay
@ 2026-10-13 2:36 ` Jim Cromie via B4 Relay
2026-10-13 2:36 ` [PATCH v12 28/40] dyndbg: control-parser: treat comma as a token separator Jim Cromie via B4 Relay
` (12 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:36 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie,
Louis Chauvet
From: Jim Cromie <jim.cromie@gmail.com>
move the DYNAMIC_DEBUG_CLASSMAP_PARAM macro from test-dynamic-debug.c into
the header, and refine it, by distinguishing the 2 use cases:
1.DYNAMIC_DEBUG_CLASSMAP_PARAM_REF
for DRM, to pass in extern __drm_debug by name.
dyndbg keeps bits in it, so drm can still use it as before
2.DYNAMIC_DEBUG_CLASSMAP_PARAM
new user (test_dynamic_debug) doesn't need to share state,
declares a u32 to store the bitvec.
__DYNAMIC_DEBUG_CLASSMAP_PARAM
bottom layer - allocate,init a ddebug-class-param, module-param-cb.
Also add stub macros, clean up and improve comments in test-code, and
add MODULE_DESCRIPTIONs.
cc: linux-doc@vger.kernel.org
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
---
v11:
. drop redundant _DPRINTK_CLASSBITS_INIT redefinition in #else block,
fixing -Wmacro-redefined warning.
Sashiko review complaint (patch 28):
"Does this redefine _DPRINTK_CLASSBITS_INIT when CONFIG_DYNAMIC_DEBUG
is disabled? The macro is already defined unconditionally earlier in
this file (just before the flags field of struct _ddebug), which
causes a -Wmacro-redefined compiler warning."
v10:
. define _DPRINTK_CLASSBITS_INIT and initialize static state bitvector.
. add module_param_named fallback for DYNAMIC_DEBUG_CLASSMAP_PARAM* in !CONFIG_DYNAMIC_DEBUG.
v9:
. fix 4-argument signature for DYNAMIC_DEBUG_CLASSMAP_PARAM_REF fallback macro stub.
. update format specifier from %d to %u for inrep in ddebug_class_param_clamp_input().
. drop duplicate v2pr_info() line in param_set_dyndbg_module_classes().
. drop unused CLASSMAP_BITMASK(width, base) define in test_dynamic_debug.c.
---
include/linux/dynamic_debug.h | 45 +++++++++++++
lib/dynamic_debug.c | 75 +++++++++++-----------
lib/test_dynamic_debug.c | 55 ++++++----------
lib/test_dynamic_debug_submod.c | 9 ++-
.../selftests/dynamic_debug/dyndbg_selftest.sh | 2 +-
5 files changed, 111 insertions(+), 75 deletions(-)
diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
index cd733f256b90..21feaef9fb23 100644
--- a/include/linux/dynamic_debug.h
+++ b/include/linux/dynamic_debug.h
@@ -52,6 +52,8 @@ struct _ddebug {
#else
#define _DPRINTK_FLAGS_DEFAULT 0
#endif
+#define _DPRINTK_CLASSBITS_INIT ((_DPRINTK_FLAGS_DEFAULT & _DPRINTK_FLAGS_PRINT) ? ~0U : 0U)
+
unsigned int flags:8;
#ifdef CONFIG_JUMP_LABEL
union {
@@ -278,6 +280,44 @@ struct ddebug_class_param {
.offset = _offset \
}
+/**
+ * DYNAMIC_DEBUG_CLASSMAP_PARAM - control a ddebug-classmap from a sys-param
+ * @_name: sysfs node name
+ * @_var: name of the classmap var defining the controlled classes/bits
+ * @_flags: flags to be toggled, typically just 'p'
+ *
+ * Creates a sysfs-param to control the classes defined by the
+ * exported classmap, with bits 0..N-1 mapped to the classes named.
+ * This version keeps class-state in a private long int.
+ */
+#define DYNAMIC_DEBUG_CLASSMAP_PARAM(_name, _var, _flags) \
+ static u32 _name##_bvec = _DPRINTK_CLASSBITS_INIT; \
+ __DYNAMIC_DEBUG_CLASSMAP_PARAM(_name, _name##_bvec, _var, _flags)
+
+/**
+ * DYNAMIC_DEBUG_CLASSMAP_PARAM_REF - wrap a classmap with a controlling sys-param
+ * @_name: sysfs node name
+ * @_bits: name of the module's u32 bit-vector, ex: __drm_debug
+ * @_var: name of the (exported) classmap var defining the classes/bits
+ * @_flags: flags to be toggled, typically just 'p'
+ *
+ * Creates a sysfs-param to control the classes defined by the
+ * exported clasmap, with bits 0..N-1 mapped to the classes named.
+ * This version keeps class-state in user @_bits. This lets drm check
+ * __drm_debug elsewhere too.
+ */
+#define DYNAMIC_DEBUG_CLASSMAP_PARAM_REF(_name, _bits, _var, _flags) \
+ __DYNAMIC_DEBUG_CLASSMAP_PARAM(_name, _bits, _var, _flags)
+
+#define __DYNAMIC_DEBUG_CLASSMAP_PARAM(_name, _bits, _var, _flags) \
+ static struct ddebug_class_param _name##_##_flags = { \
+ .bits = &(_bits), \
+ .flags = #_flags, \
+ .map = &(_var), \
+ }; \
+ module_param_cb(_name, ¶m_ops_dyndbg_classes, \
+ &_name##_##_flags, 0600)
+
extern __printf(2, 3)
void __dynamic_pr_debug(struct _ddebug *descriptor, const char *fmt, ...);
@@ -462,6 +502,11 @@ void __dynamic_ibdev_dbg(struct _ddebug *descriptor,
#define DYNAMIC_DEBUG_CLASSMAP_DEFINE(_var, _mapty, _base, ...)
#define DYNAMIC_DEBUG_CLASSMAP_USE(_var)
#define DYNAMIC_DEBUG_CLASSMAP_USE_(_var, _offset)
+#define DYNAMIC_DEBUG_CLASSMAP_PARAM(_name, _var, _flags) \
+ static u32 _name##_bvec = _DPRINTK_CLASSBITS_INIT; \
+ module_param_named(_name, _name##_bvec, uint, 0600)
+#define DYNAMIC_DEBUG_CLASSMAP_PARAM_REF(_name, _bits, _var, _flags) \
+ module_param_named(_name, _bits, uint, 0600)
#define DEFINE_DYNAMIC_DEBUG_METADATA(name, fmt)
#define DYNAMIC_DEBUG_BRANCH(descriptor) false
#define DECLARE_DYNDBG_CLASSMAP(...)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 64ad70738d95..8eef2e7387a9 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -698,9 +698,42 @@ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp,
#define CLASSMAP_BITMASK(width) ((width) >= 32 ? ~0U : (1U << (width)) - 1)
-/*
- * param-setter helper to validate numeric input, clamp its value by
- * the classmap type and size, and apply the bits.
+static void __maybe_unused ddebug_class_param_clamp_input(u32 *inrep, const struct kernel_param *kp)
+{
+ const struct ddebug_class_param *dcp = kp->arg;
+ const struct ddebug_class_map *map = dcp->map;
+
+ switch (map->map_type) {
+ case DD_CLASS_TYPE_DISJOINT_BITS:
+ /* expect bits. mask and warn if too many */
+ if (*inrep & ~CLASSMAP_BITMASK(map->length)) {
+ pr_warn("%s: input: 0x%x exceeds mask: 0x%x, masking\n",
+ KP_NAME(kp), *inrep, CLASSMAP_BITMASK(map->length));
+ *inrep &= CLASSMAP_BITMASK(map->length);
+ }
+ break;
+ case DD_CLASS_TYPE_LEVEL_NUM:
+ /* input is bitpos, of highest verbosity to be enabled */
+ if (*inrep > map->length) {
+ pr_warn("%s: level:%u exceeds max:%d, clamping\n",
+ KP_NAME(kp), *inrep, map->length);
+ *inrep = map->length;
+ }
+ break;
+ }
+}
+
+/**
+ * param_set_dyndbg_classes - class FOO >control
+ * @instr: string echo>d to sysfs, input depends on map_type
+ * @kp: kp->arg has state: bits/lvl, map, map_type
+ * @mod_name: module name or null for all modules with the classes
+ *
+ * Enable/disable prdbgs by their class, as given in the arguments to
+ * DECLARE_DYNDBG_CLASSMAP. For LEVEL map-types, enforce relative
+ * levels by bitpos.
+ *
+ * Returns: 0 or <0 if error.
*/
static int param_set_dyndbg_module_classes(const char *instr,
const struct kernel_param *kp,
@@ -719,27 +752,16 @@ static int param_set_dyndbg_module_classes(const char *instr,
len, instr, KP_NAME(kp));
return -EINVAL;
}
+ ddebug_class_param_clamp_input(&inrep, kp);
switch (map->map_type) {
case DD_CLASS_TYPE_DISJOINT_BITS:
- /* expect bits. mask and warn if too many */
- if (inrep & ~CLASSMAP_BITMASK(map->length)) {
- pr_warn("%s: input: 0x%x exceeds mask: 0x%x, masking\n",
- KP_NAME(kp), inrep, CLASSMAP_BITMASK(map->length));
- inrep &= CLASSMAP_BITMASK(map->length);
- }
old_val = READ_ONCE(*dcp->bits);
v2pr_info("bits:0x%x > %s.%s\n", inrep, mod_name ?: "*", KP_NAME(kp));
totct += ddebug_apply_class_bitmap(dcp, &inrep, old_val, mod_name);
WRITE_ONCE(*dcp->bits, inrep);
break;
case DD_CLASS_TYPE_LEVEL_NUM:
- /* input is bitpos, of highest verbosity to be enabled */
- if (inrep > map->length) {
- pr_warn("%s: level:%u exceeds max:%d, clamping\n",
- KP_NAME(kp), inrep, map->length);
- inrep = map->length;
- }
old_val = READ_ONCE(*dcp->lvl);
old_bits = CLASSMAP_BITMASK(old_val);
new_bits = CLASSMAP_BITMASK(inrep);
@@ -1237,30 +1259,7 @@ static inline u32 ddebug_class_param_to_bits(const struct ddebug_class_param *dc
}
}
-static void __maybe_unused ddebug_class_param_clamp_input(u32 *inrep, const struct kernel_param *kp)
-{
- const struct ddebug_class_param *dcp = kp->arg;
- const struct ddebug_class_map *map = dcp->map;
- switch (map->map_type) {
- case DD_CLASS_TYPE_DISJOINT_BITS:
- /* expect bits. mask and warn if too many */
- if (*inrep & ~CLASSMAP_BITMASK(map->length)) {
- pr_warn("%s: input: 0x%x exceeds mask: 0x%x, masking\n",
- KP_NAME(kp), *inrep, CLASSMAP_BITMASK(map->length));
- *inrep &= CLASSMAP_BITMASK(map->length);
- }
- break;
- case DD_CLASS_TYPE_LEVEL_NUM:
- /* input is bitpos, of highest verbosity to be enabled */
- if (*inrep > map->length) {
- pr_warn("%s: level:%d exceeds max:%d, clamping\n",
- KP_NAME(kp), *inrep, map->length);
- *inrep = map->length;
- }
- break;
- }
-}
/*
* Called for class-users and native classmaps during module load.
diff --git a/lib/test_dynamic_debug.c b/lib/test_dynamic_debug.c
index 19e27b5747ac..ea81c5158b13 100644
--- a/lib/test_dynamic_debug.c
+++ b/lib/test_dynamic_debug.c
@@ -1,6 +1,7 @@
// SPDX-License-Identifier: GPL-2.0-only
/*
- * Kernel module for testing dynamic_debug
+ * Kernel module to test/demonstrate dynamic_debug features,
+ * particularly classmaps and their support for subsystems like DRM.
*
* Authors:
* Jim Cromie <jim.cromie@gmail.com>
@@ -80,33 +81,6 @@ static const struct kernel_param_ops param_ops_do_repeats = {
module_param_cb(do_classes, ¶m_ops_do_repeats, do_classes, 0600);
module_param_cb(do_bulk, ¶m_ops_do_repeats, do_bulk, 0600);
-/*
- * Using the CLASSMAP api:
- * - classmaps must have corresponding enum
- * - enum symbols must match/correlate with class-name strings in the map.
- * - base must equal enum's 1st value
- * - multiple maps must set their base to share the 0-30 class_id space !!
- * (build-bug-on tips welcome)
- * Additionally, here:
- * - tie together sysname, mapname, bitsname, flagsname
- */
-#define DYNAMIC_DEBUG_CLASSMAP_PARAM_(_model, _flags, _init) \
- static u32 bits_##_model = _init; \
- static struct ddebug_class_param _flags##_##_model = { \
- .bits = &bits_##_model, \
- .flags = #_flags, \
- .map = &map_##_model, \
- }; \
- module_param_cb(_flags##_##_model, ¶m_ops_dyndbg_classes, \
- &_flags##_##_model, 0600)
-#ifdef DEBUG
-#define DYNAMIC_DEBUG_CLASSMAP_PARAM(_model, _flags) \
- DYNAMIC_DEBUG_CLASSMAP_PARAM_(_model, _flags, ~0)
-#else
-#define DYNAMIC_DEBUG_CLASSMAP_PARAM(_model, _flags) \
- DYNAMIC_DEBUG_CLASSMAP_PARAM_(_model, _flags, 0)
-#endif
-
/*
* Demonstrate/test DISJOINT & LEVEL typed classmaps with a sys-param.
*
@@ -140,12 +114,15 @@ enum cat_level_num { V1 = 16, V2, V3, V4, V5, V6, V7, V8 };
/* test _USE_ w offset */
enum cat_level_offset { Vu1 = V1 + 8, Vu2, Vu3, Vu4, Vu5, Vu6, Vu7, Vu8 };
-/* recapitulate DRM's multi-classmap setup */
+/*
+ * use/demonstrate multi-module-group classmaps, as for DRM
+ */
#if !defined(TEST_DYNAMIC_DEBUG_SUBMOD)
/*
- * In single user, or parent / coordinator (drm.ko) modules, define
- * classmaps on the client enums above, and then declares the PARAMS
- * ref'g the classmaps. Each is exported.
+ * For module-groups of 1+, define classmaps with names (stringified
+ * enum-symbols) copied from above. 1-to-1 mapping is recommended.
+ * The classmap is exported, so that other modules in the group can
+ * link to it and control their prdbgs.
*/
DYNAMIC_DEBUG_CLASSMAP_DEFINE(map_disjoint_bits, DD_CLASS_TYPE_DISJOINT_BITS,
D2_CORE,
@@ -163,6 +140,15 @@ DYNAMIC_DEBUG_CLASSMAP_DEFINE(map_disjoint_bits, DD_CLASS_TYPE_DISJOINT_BITS,
DYNAMIC_DEBUG_CLASSMAP_DEFINE(map_level_num, DD_CLASS_TYPE_LEVEL_NUM,
V1, "V1", "V2", "V3", "V4", "V5", "V6", "V7", "V8");
+/*
+ * for use-cases that want it, provide a sysfs-param to set the
+ * classes in the classmap. It is at this interface where the
+ * "v3>v2" property is applied to DD_CLASS_TYPE_LEVEL_NUM inputs.
+ */
+
+DYNAMIC_DEBUG_CLASSMAP_PARAM(p_disjoint_bits, map_disjoint_bits, p);
+DYNAMIC_DEBUG_CLASSMAP_PARAM(p_level_num, map_level_num, p);
+
#ifdef FORCE_CLASSID_CONFLICT
/*
* Enable with -Dflag on compile to test overlapping class-id range
@@ -171,6 +157,7 @@ DYNAMIC_DEBUG_CLASSMAP_DEFINE(map_level_num, DD_CLASS_TYPE_LEVEL_NUM,
DYNAMIC_DEBUG_CLASSMAP_DEFINE(classid_range_conflict, 0, D2_CORE + 1, "D3_CORE");
#endif
+
#if defined(DD_MACRO_ARGCHECK)
/*
* Exersize compile-time arg-checks in DYNAMIC_DEBUG_CLASSMAP_DEFINE.
@@ -204,8 +191,6 @@ DYNAMIC_DEBUG_CLASSMAP_USE_(fail_offset_big, 100);
/*
* now add the sysfs-params to both sub/super-mods
*/
-DYNAMIC_DEBUG_CLASSMAP_PARAM(disjoint_bits, p);
-DYNAMIC_DEBUG_CLASSMAP_PARAM(level_num, p);
/* stand-in for all pr_debug etc */
#define prdbg(SYM) __pr_debug_cls(SYM, #SYM " msg\n")
@@ -339,5 +324,5 @@ module_init(test_dynamic_debug_init);
module_exit(test_dynamic_debug_exit);
MODULE_AUTHOR("Jim Cromie <jim.cromie@gmail.com>");
-MODULE_DESCRIPTION("Kernel module for testing dynamic_debug");
+MODULE_DESCRIPTION("test/demonstrate dynamic-debug features");
MODULE_LICENSE("GPL");
diff --git a/lib/test_dynamic_debug_submod.c b/lib/test_dynamic_debug_submod.c
index 672aabf40160..3adf3925fb86 100644
--- a/lib/test_dynamic_debug_submod.c
+++ b/lib/test_dynamic_debug_submod.c
@@ -1,6 +1,9 @@
// SPDX-License-Identifier: GPL-2.0
/*
- * Kernel module for testing dynamic_debug
+ * Kernel module to test/demonstrate dynamic_debug features,
+ * particularly classmaps and their support for subsystems, like DRM,
+ * which defines its drm_debug classmap in drm module, and uses it in
+ * helpers & drivers.
*
* Authors:
* Jim Cromie <jim.cromie@gmail.com>
@@ -12,3 +15,7 @@
*/
#define TEST_DYNAMIC_DEBUG_SUBMOD
#include "test_dynamic_debug.c"
+
+MODULE_DESCRIPTION("test/demonstrate dynamic-debug subsystem support");
+MODULE_AUTHOR("Jim Cromie <jim.cromie@gmail.com>");
+MODULE_LICENSE("GPL");
diff --git a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
index 3d8d2a2cfde6..956f8a60a3b2 100755
--- a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
+++ b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
@@ -539,7 +539,7 @@ function GOLDEN_RECORDS {
#K= c518a50ba30ba8099d0dc874a27ecf16 FT_basic_queries.7
#K= 2b4b152bdb82e6e4a5be18ca26025895 FT_test_classes.1
#K= 5516e3d13cba7ea4197a7fb6c033887a FT_test_classes.2
-#K= 37dc0919cb1c0ee8ba00ad2ad77ba7c3 FT_test_classes.3
+#K= 2cee6842c9cdee5cb3bf50b2e3914813 FT_test_classes.3
#K= 81b16613f8d444485e2bc5aa4d38d024 FT_classmap_inheritance.1
#K= c14c8aa758e24046b3237d20e2189bf7 FT_classmap_inheritance.2
#K= 5d0f3701517aa3a461c8887c332bdb42 FT_classmap_inheritance.3
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 28/40] dyndbg: control-parser: treat comma as a token separator
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (26 preceding siblings ...)
2026-10-13 2:36 ` [PATCH v12 27/40] dyndbg-API: promote DYNAMIC_DEBUG_CLASSMAP_PARAM to API Jim Cromie via B4 Relay
@ 2026-10-13 2:36 ` Jim Cromie via B4 Relay
2026-10-13 2:37 ` [PATCH v12 29/40] selftests: enable comma-terminator tests Jim Cromie via B4 Relay
` (11 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:36 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie
From: Jim Cromie <jim.cromie@gmail.com>
Treat comma as a token terminator, just like a space. This allows a
user to avoid quoting hassles when spaces are otherwise needed:
:#> modprobe drm dyndbg=class,DRM_UT_CORE,+p\;class,DRM_UT_KMS,+p
Add corresponding Strategy 2 control-file fingerprinting checks to
verify the exact control-file state of kernel/params callsites after
commas-as-spaces, ignored-commas, and quoted-commas queries.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
Documentation/admin-guide/dynamic-debug-howto.rst | 4 +++-
lib/dynamic_debug.c | 17 +++++++++++++----
.../testing/selftests/dynamic_debug/dyndbg_selftest.sh | 4 ++--
3 files changed, 18 insertions(+), 7 deletions(-)
diff --git a/Documentation/admin-guide/dynamic-debug-howto.rst b/Documentation/admin-guide/dynamic-debug-howto.rst
index 9c2f096ed1d8..b9fbb2a12955 100644
--- a/Documentation/admin-guide/dynamic-debug-howto.rst
+++ b/Documentation/admin-guide/dynamic-debug-howto.rst
@@ -78,11 +78,12 @@ Command Language Reference
==========================
At the basic lexical level, a command is a sequence of words separated
-by spaces or tabs. So these are all equivalent::
+by spaces, tabs, or commas. So these are all equivalent::
:#> ddcmd file svcsock.c line 1603 +p
:#> ddcmd "file svcsock.c line 1603 +p"
:#> ddcmd ' file svcsock.c line 1603 +p '
+ :#> ddcmd file,svcsock.c,line,1603,+p
Command submissions are bounded by a write() system call.
Multiple commands can be written together, separated by ``;`` or ``\n``::
@@ -172,6 +173,7 @@ module
module sunrpc
module nfsd
module drm* # both drm, drm_kms_helper
+ module,sunrpc # with ',' as token separator
format
The given string is searched for in the dynamic debug format
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 8eef2e7387a9..6482fd28def4 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -323,6 +323,14 @@ static int ddebug_change(const struct ddebug_query *query, struct flag_settings
return nfound;
}
+static char *skip_spaces_and_commas(const char *str)
+{
+ str = skip_spaces(str);
+ while (*str == ',')
+ str = skip_spaces(++str);
+ return (char *)str;
+}
+
/*
* Split the buffer `buf' into space-separated words.
* Handles simple " and ' quoting, i.e. without nested,
@@ -336,8 +344,8 @@ static int ddebug_tokenize(char *buf, char *words[], int maxwords)
while (*buf) {
char *end;
- /* Skip leading whitespace */
- buf = skip_spaces(buf);
+ /* Skip leading whitespace and comma */
+ buf = skip_spaces_and_commas(buf);
if (!*buf)
break; /* oh, it was trailing whitespace */
if (*buf == '#')
@@ -353,7 +361,7 @@ static int ddebug_tokenize(char *buf, char *words[], int maxwords)
return -EINVAL; /* unclosed quote */
}
} else {
- for (end = buf; *end && !isspace(*end); end++)
+ for (end = buf; *end && !isspace(*end) && *end != ','; end++)
;
if (end == buf) {
pr_err("parse err after word:%d=%s\n", nwords,
@@ -628,7 +636,8 @@ static int ddebug_exec_queries(char *query, const char *modname)
if (split)
*split++ = '\0';
- query = skip_spaces(query);
+ query = skip_spaces_and_commas(query);
+
if (!query || !*query || *query == '#')
continue;
diff --git a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
index 956f8a60a3b2..88b56c807c42 100755
--- a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
+++ b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
@@ -537,8 +537,8 @@ function GOLDEN_RECORDS {
#K= 02e4fd94602e108cb89bfc70d47a5dad FT_basic_queries.5
#K= f03a7ca7316e8db4c0e16523dc41e75d FT_basic_queries.6
#K= c518a50ba30ba8099d0dc874a27ecf16 FT_basic_queries.7
-#K= 2b4b152bdb82e6e4a5be18ca26025895 FT_test_classes.1
-#K= 5516e3d13cba7ea4197a7fb6c033887a FT_test_classes.2
+#K= 91838b4012c50a1dc1d9e210ba8d68f8 FT_test_classes.1
+#K= a15ec4843acd721fbdfddc0b512c8032 FT_test_classes.2
#K= 2cee6842c9cdee5cb3bf50b2e3914813 FT_test_classes.3
#K= 81b16613f8d444485e2bc5aa4d38d024 FT_classmap_inheritance.1
#K= c14c8aa758e24046b3237d20e2189bf7 FT_classmap_inheritance.2
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 29/40] selftests: enable comma-terminator tests
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (27 preceding siblings ...)
2026-10-13 2:36 ` [PATCH v12 28/40] dyndbg: control-parser: treat comma as a token separator Jim Cromie via B4 Relay
@ 2026-10-13 2:37 ` Jim Cromie via B4 Relay
2026-10-13 2:37 ` [PATCH v12 30/40] dyndbg: split multi-query strings with @ Jim Cromie via B4 Relay
` (10 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:37 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie
From: Jim Cromie <jim.cromie@gmail.com>
Enable the FT_comma_terminators test block in dyndbg_selftest.sh to
verify control query parsing when queries are terminated by commas.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
v11:
. convert modprobe dyndbg parameters in FT_test_classes and
FT_classmap_inheritance to use comma separators
("class,D2_CORE,+pf;...").
Sashiko review complaint (patch 24):
"Are these load-time parameters truncated during module load due to
how the shell handles quotes? When bash evaluates and strips the
double quotes before executing modprobe, modprobe constructs the
kernel options string without adding quotes around the parameters.
The kernel's parse_args() function (using next_arg() in lib/cmdline.c)
splits module parameters at unquoted spaces... treats D2_CORE and +pf
as separate unknown parameters."
---
.../selftests/dynamic_debug/dyndbg_selftest.sh | 29 ++++++++++++++++++++--
1 file changed, 27 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
index 88b56c807c42..eb508c804782 100755
--- a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
+++ b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
@@ -340,6 +340,25 @@ function FT_basic_queries {
ddcmd "file $f =_" "$f"
}
+# test parsing on spaces, commas. testing against builtin file kernel/params.c
+function FT_comma_terminators {
+ v_echo "${GREEN}# COMMA_TERMINATOR_TESTS ${NC}"
+ if [ $LACK_DD_BUILTIN -eq 1 ]; then
+ echo "SKIP - test requires dynamic_debug built into kernel"
+ return
+ fi
+ local f='kernel/params.c'
+ ddcmd =_
+ ddcmd "file $f +p" "$f"
+
+ ddcmd "file,$f,=_" "$f"
+ ddcmd "file,$f,+mf" "$f"
+ # ignore empty tokens
+ ddcmd ",file ,, , $f, -p" "$f"
+ ddcmd " , file ,,, , $f, -m" "$f"
+
+ ddcmd =_
+}
# testing classmap-based query enablers and class configurations
function FT_test_classes {
v_echo "${GREEN}# TEST_CLASSES - classmap-based query enablers and class configs ${NC}"
@@ -350,7 +369,7 @@ function FT_test_classes {
# 1. Verify initial multi-query enablement state via file slice
my_modprobe test_dynamic_debug \
- dyndbg="class D2_CORE,+pf;class D2_KMS,+ps;class D2_ATOMIC +pm"
+ dyndbg="class,D2_CORE,+pf;class,D2_KMS,+ps;class,D2_ATOMIC,+pm"
verify_control_slice '\[test_dynamic_debug\]'
# 2. Verify state transition and live-printing end-to-end via ddcmd_load!
@@ -368,7 +387,7 @@ function FT_classmap_inheritance {
# 1. Load submod directly (which auto-loads supermod with default parameters)
my_modprobe test_dynamic_debug_submod \
- "dyndbg=+p;class D2_CORE +pfs;class D2_KMS +pts;class D2_ATOMIC +pmf"
+ "dyndbg=+p;class,D2_CORE,+pfs;class,D2_KMS,+pts;class,D2_ATOMIC,+pmf"
verify_control_slice 'test_dynamic_debug'
# 2. Runtime parameter changes to supermod propagate to submod descriptors
@@ -447,6 +466,7 @@ builtin_tests=(
FT_grammar_ok
FT_grammar_errs
FT_basic_queries
+ FT_comma_terminators
)
# Modular Feature Tests (Require CONFIG_MODULES=y and test_dynamic_debug*.ko available)
@@ -537,6 +557,11 @@ function GOLDEN_RECORDS {
#K= 02e4fd94602e108cb89bfc70d47a5dad FT_basic_queries.5
#K= f03a7ca7316e8db4c0e16523dc41e75d FT_basic_queries.6
#K= c518a50ba30ba8099d0dc874a27ecf16 FT_basic_queries.7
+#K= c8bbbac639f244ed9088208ebb7d83a6 FT_comma_terminators.1
+#K= bed6350f058f600910837dae83a12f56 FT_comma_terminators.2
+#K= 6e8599556a312200fb6d484565b6c52f FT_comma_terminators.3
+#K= 68b329da9893e34099c7d8ad5cb9c940 FT_comma_terminators.4
+#K= adc1ef04304c861c87fe294a8ba4e402 FT_comma_terminators.5
#K= 91838b4012c50a1dc1d9e210ba8d68f8 FT_test_classes.1
#K= a15ec4843acd721fbdfddc0b512c8032 FT_test_classes.2
#K= 2cee6842c9cdee5cb3bf50b2e3914813 FT_test_classes.3
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 30/40] dyndbg: split multi-query strings with @
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (28 preceding siblings ...)
2026-10-13 2:37 ` [PATCH v12 29/40] selftests: enable comma-terminator tests Jim Cromie via B4 Relay
@ 2026-10-13 2:37 ` Jim Cromie via B4 Relay
2026-10-13 2:37 ` [PATCH v12 31/40] dyndbg: resolve "protection" of class'd pr_debug Jim Cromie via B4 Relay
` (9 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:37 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie
From: Jim Cromie <jim.cromie@gmail.com>
Since
commit 85f7f6c0edb8 ("dynamic_debug: process multiple debug-queries on a line")
Multi-query commands have been allowed:
modprobe drm dyndbg="class DRM_UT_CORE +p; class DRM_UT_KMS +p"
modprobe drm dyndbg=<<EOX
class DRM_UT_CORE +p
class DRM_UT_KMS +p
EOX
More recently, the need for quoting was avoided by treating a comma
like a space/token-terminator:
modprobe drm dyndbg=class,DRM_UT_CORE,+p\;class,DRM_UT_KMS,+p
That works, but it needs the escaped semicolon, which is a shell
special-char (one of the bash control operators), so it is brittle
when passed in/down/around scripts.
So this patch adds '@' to the existing ';' and '\n' multi-command
separators, which is more shell-friendly, so you can more fully avoid
quoting and escaping hassles.
Update selftests script, adding a multi-query split on @
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
v10:
. replace strpbrk() with quote-aware ddebug_find_delimiter() to ignore '@' inside quotes.
v9:
. update FT_multi_query command in dyndbg_selftest.sh to actively test @ delimiter.
v5: avoid +t flag in content tests - pid is not predictable.
remove Reviewed-by: <louis.chauvet@bootlin.com> - too many changes
v2:
replace '%' with '@' as multi-query splitter, as it is:
- not a sshell special cahr
- allows matching on format strings with format specifiers
---
Documentation/admin-guide/dynamic-debug-howto.rst | 8 +++--
lib/dynamic_debug.c | 26 ++++++++++++++++-
.../selftests/dynamic_debug/dyndbg_selftest.sh | 34 +++++++++++++++-------
3 files changed, 53 insertions(+), 15 deletions(-)
diff --git a/Documentation/admin-guide/dynamic-debug-howto.rst b/Documentation/admin-guide/dynamic-debug-howto.rst
index b9fbb2a12955..a8962ab22aaf 100644
--- a/Documentation/admin-guide/dynamic-debug-howto.rst
+++ b/Documentation/admin-guide/dynamic-debug-howto.rst
@@ -85,10 +85,12 @@ by spaces, tabs, or commas. So these are all equivalent::
:#> ddcmd ' file svcsock.c line 1603 +p '
:#> ddcmd file,svcsock.c,line,1603,+p
-Command submissions are bounded by a write() system call.
-Multiple commands can be written together, separated by ``;`` or ``\n``::
+Command submissions are bounded by a write() system call. Multiple
+commands can be written together, separated by ``@``, ``;`` or ``\n``::
- :#> ddcmd "func pnpacpi_get_resources +p; func pnp_assign_mem +p"
+ :#> ddcmd func foo +p @ func bar +p
+ :#> ddcmd func foo +p \; func bar +p
+ :#> ddcmd "func foo +p ; func bar +p"
:#> ddcmd <<"EOC"
func pnpacpi_get_resources +p
func pnp_assign_mem +p
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 6482fd28def4..636a88994a77 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -622,6 +622,30 @@ static int ddebug_exec_query(char *query_string, const char *modname)
return nfound;
}
+/*
+ * Split multi-query string on delimiters (@, ;, \n), ignoring delimiters
+ * that appear inside single or double quoted strings.
+ */
+static char *ddebug_find_delimiter(char *str, const char *delims)
+{
+ bool in_quote = false;
+ char quote_char = 0;
+
+ for (; *str; str++) {
+ if (*str == '"' || *str == '\'') {
+ if (!in_quote) {
+ in_quote = true;
+ quote_char = *str;
+ } else if (*str == quote_char) {
+ in_quote = false;
+ }
+ } else if (!in_quote && strchr(delims, *str)) {
+ return str;
+ }
+ }
+ return NULL;
+}
+
/* handle multiple queries in query string, continue on error, return
last error or number of matching callsites. Module name is either
in the modname arg (for boot args) or perhaps in query string.
@@ -632,7 +656,7 @@ static int ddebug_exec_queries(char *query, const char *modname)
int i, errs = 0, exitcode = 0, rc, nfound = 0;
for (i = 0; query; query = split) {
- split = strpbrk(query, ";\n");
+ split = ddebug_find_delimiter(query, "@;\n");
if (split)
*split++ = '\0';
diff --git a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
index eb508c804782..6e5f23866ccc 100755
--- a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
+++ b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
@@ -131,7 +131,6 @@ function ddcmd_load () {
local val="$4"
# 1. Setup the control filters (using positional ddcmd range-check)
- echo "$query" "$range"
ddcmd "$query" "$range"
# 2. Execute the workload and capture syslog prints
@@ -325,9 +324,20 @@ function FT_basic_queries {
ddcmd "file $f +l" "$f"
ddcmd "file $f -m" "$f"
ddcmd "file $f =_" "$f"
+}
+
+function FT_multi_query {
+ v_echo "${GREEN}# MULTI_QUERY_TESTS ${NC}"
+ if [ $LACK_DD_BUILTIN -eq 1 ]; then
+ echo "SKIP - test requires dynamic_debug built into kernel"
+ return
+ fi
+ local f='kernel/params.c'
+ ddcmd =_ # zero everything
- # multi-query commands split on ; on a single line
+ # multi-query commands on a single line, split on ;/@ respectively
ddcmd "file $f +mf ; file $f func parse_args +sl" "$f"
+ ddcmd "file $f -f @ file $f func parse_args -l" "$f"
# verify multi-cmd input, newline separated, with embedded comments
ddcmd =_ # reset before multiline query to capture full transition
@@ -373,7 +383,7 @@ function FT_test_classes {
verify_control_slice '\[test_dynamic_debug\]'
# 2. Verify state transition and live-printing end-to-end via ddcmd_load!
- ddcmd_load "class D2_CORE +pmf;class D2_KMS +pls;class D2_ATOMIC +pml" \
+ ddcmd_load "class,D2_CORE,+pmf;class,D2_KMS,+pls;class,D2_ATOMIC,+pml" \
'\[test_dynamic_debug\]' \
"/sys/module/test_dynamic_debug/parameters/do_classes" "1"
@@ -467,6 +477,7 @@ builtin_tests=(
FT_grammar_errs
FT_basic_queries
FT_comma_terminators
+ FT_multi_query
)
# Modular Feature Tests (Require CONFIG_MODULES=y and test_dynamic_debug*.ko available)
@@ -489,8 +500,8 @@ modular_tests=(
#
# ==============================================================================
function GOLDEN_RECORDS {
- cat << 'EOF' | {
-#K= 26fd1565f209b383d9f2fbf0b54cd5fc FT_grammar_errs.1
+ cat << 'EO_DYNDBG_GOLDEN_REFS' | {
+#K= 95b249c7ec2cbd5a436f96060b2bee37 FT_grammar_errs.1
#K= 200c01632c52a63f6d186da1c6460740 FT_grammar_errs.2
#K= 7d7141900ce6e32f15c99202309c63a4 FT_grammar_errs.3
#K= 1bb798a5831d0119789d424ef6cb55c4 FT_grammar_errs.4
@@ -510,7 +521,7 @@ function GOLDEN_RECORDS {
#K= cb8288d607b0c5282125852f3ab05107 FT_grammar_errs.18
#K= b371c6ba52503d037dbc43da788af8be FT_grammar_errs.19
#K= 98e2bd3e4f3da58536496a38ec3e6238 FT_grammar_errs.20
-#K= 02b210b2646aceb68f3d6d2876a3d57a FT_grammar_errs.21
+#K= c4e8b7261811e9fdf0c80fa9e374a29e FT_grammar_errs.21
#K= 51030cd01ed601a68dd48356902954b1 FT_grammar_errs.22
#K= af8818de076407d4e7f4e384ba110ac5 FT_grammar_errs.23
#K= 023ba04ffced833b4776fb4fcaae7755 FT_grammar_errs.24
@@ -530,7 +541,7 @@ function GOLDEN_RECORDS {
#K= 130bf64b92a5e34d1c4cce98899084e1 FT_grammar_errs.38
#K= 9681a05658f1a50e3434aa991b5ce992 FT_grammar_errs.39
#K= 38506317363a188fbb7a417ff50457a9 FT_grammar_errs.40
-#K= 02b210b2646aceb68f3d6d2876a3d57a FT_grammar_errs.41
+#K= c4e8b7261811e9fdf0c80fa9e374a29e FT_grammar_errs.41
#K= 8c08a8b5cacbf885d022360ed856e7a1 FT_grammar_errs.42
#K= f0f4d894a49bd2c1856cf4f013f83e54 FT_grammar_errs.43
#K= 25b92d52cb299fa8d84c5584e490bd97 FT_grammar_errs.44
@@ -554,14 +565,15 @@ function GOLDEN_RECORDS {
#K= db17180b59444e5e34a8fc20c40e4530 FT_basic_queries.2
#K= f7bd56bd407ff255ef2e3b5fb093ae6a FT_basic_queries.3
#K= 4ce44468b3b5f80ae42ade1f261b952f FT_basic_queries.4
-#K= 02e4fd94602e108cb89bfc70d47a5dad FT_basic_queries.5
-#K= f03a7ca7316e8db4c0e16523dc41e75d FT_basic_queries.6
-#K= c518a50ba30ba8099d0dc874a27ecf16 FT_basic_queries.7
#K= c8bbbac639f244ed9088208ebb7d83a6 FT_comma_terminators.1
#K= bed6350f058f600910837dae83a12f56 FT_comma_terminators.2
#K= 6e8599556a312200fb6d484565b6c52f FT_comma_terminators.3
#K= 68b329da9893e34099c7d8ad5cb9c940 FT_comma_terminators.4
#K= adc1ef04304c861c87fe294a8ba4e402 FT_comma_terminators.5
+#K= 02e4fd94602e108cb89bfc70d47a5dad FT_multi_query.1
+#K= c0fc482bbf18b9d5ffd6743b18bc34f7 FT_multi_query.2
+#K= f03a7ca7316e8db4c0e16523dc41e75d FT_multi_query.3
+#K= c518a50ba30ba8099d0dc874a27ecf16 FT_multi_query.4
#K= 91838b4012c50a1dc1d9e210ba8d68f8 FT_test_classes.1
#K= a15ec4843acd721fbdfddc0b512c8032 FT_test_classes.2
#K= 2cee6842c9cdee5cb3bf50b2e3914813 FT_test_classes.3
@@ -606,7 +618,7 @@ function GOLDEN_RECORDS {
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.34
#K= 4819f715ba485c493afb455542f7ab8c FT_modprobe_w_param.35
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.36
-EOF
+EO_DYNDBG_GOLDEN_REFS
# Read the K-recs and skip those for tests that can't run
while read -r line; do
# Filter built-in if needed
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 31/40] dyndbg: resolve "protection" of class'd pr_debug
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (29 preceding siblings ...)
2026-10-13 2:37 ` [PATCH v12 30/40] dyndbg: split multi-query strings with @ Jim Cromie via B4 Relay
@ 2026-10-13 2:37 ` Jim Cromie via B4 Relay
2026-10-13 2:37 ` [PATCH v12 32/40] docs/dyndbg: add classmap info to howto Jim Cromie via B4 Relay
` (8 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:37 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie,
Louis Chauvet
From: Jim Cromie <jim.cromie@gmail.com>
classmap-v1 code protected class'd pr_debugs from unintended
changes by unclassed/_DFLT queries:
# - to declutter examples:
alias ddcmd='echo $* > /proc/dynamic_debug/control'
# IOW, this should NOT alter drm.debug settings
ddcmd -p
# Instead, you must name the class to change it.
# Protective but tedious
ddcmd class DRM_UT_CORE +p
# Or do it the (old school) subsystem way
# This is ABI !!
echo 1 > /sys/module/drm/parameters/debug
Since the debug sysfs-node is ABI, if dyndbg is going to implement it,
it must also honor its settings; it must at least protect against
accidental changes to its classes from legacy queries.
The protection allows all previously conceived queries to work the way
they always have; ie select the same set of pr_debugs, despite the
inclusion of whole new classes of pr_debugs.
But that choice has 2 downsides:
1. "name the class to change it" makes a tedious long-winded
interface, needing many commands to set DRM_UT_* one at a time.
2. It makes the class keyword special in some sense; the other
keywords skip only on query mismatch, otherwise the code falls thru to
adjust the pr-debug site.
Jason Baron didn't like v1 on point 2.
Louis Chauvet didn't like recent rev on point 1 tedium.
But that said: /sys/ is ABI, so this must be reliable:
#> echo 0x1f > /sys/module/drm/parameters/debug
It 'just works' without dyndbg underneath; we must deliver that same
stability. Convenience is secondary.
The new resolution:
If ABI is the blocking issue, then no ABI means no blocking issue.
IOW, if the classmap has no presence under /sys/*, ie no PARAM, there
is no ABI to guard, and no reason to enforce a tedious interface.
In the future, if DRM wants to alter this protection, that is
practical, but I think default-on is the correct mode.
So atm classes without a PARAM are unprotected at >control, allowing
admins their shortcuts. I think this could satisfy all viewpoints.
That said, theres also a possibility of wildcard classes:
#> ddcmd class '*' +p
Currently, the query-class is exact-matched against each module's
classmaps.names. This gives precise behavior, a good basis.
But class wildcards are possible, they just did'nt appear useful for
DRM, whose classmap names are a flat DRM_UT_* namespace.
IOW, theres no useful selectivity there:
#> ddcmd class "DRM_*" +p # these enable every DRM_* class
#> ddcmd class "DRM_UT_*" +p
#> ddcmd class "DRM_UT_V*" +p # finally select just 1: DRM_UT_VBL
#> ddcmd class "DRM_UT_D*" +p # but this gets 3
#> ddcmd class "D*V*" +p # here be dragons
But there is debatable utility in the feature.
#> ddcmd class __DEFAULT__ -p # what about this ?
#> ddcmd -p # thats what this does. automatically
Anyway, this patch does:
1. adds link field from _ddebug_class_map to the .controlling_param
2. sets it in ddebug_match_apply_kparam(), during modprobe/init,
when options like drm.debug=VAL are handled.
3. ddebug_class_has_param() now checks .controlling_param
4. ddebug_class_wants_protection() macro renames 3.
this frames it as a separable policy decision
5. ddebug_match_desc() gets the most attention:
a. move classmap consideration to the bottom
this insures all other constraints act 1st.
allows simpler 'final' decisions.
b. split class choices cleanly on query:
class FOO vs none, and class'd vs _DPRINTK_CLASS_DFLT site.
c. calls 4 when applying a class-less query to a class'd pr_debug
here we need a new fn to find the classmap with this .class_id
d. calls new ddebug_find_classmap_by_class_id().
when class-less query looks at a class'd pr_debug.
finds classmap, which can then decide, currently by PARAM existence.
NOTES:
protection is only against class-less queries, explicit "class FOO"
adjustments are allowed (that is the mechanism).
The drm.debug sysfs-node heavily under-specifies the class'd pr_debugs
it controls; none of the +mfls prefixing flags have any effect, and
each callsite remains individually controllable. drm.debug just
toggles the +p flag for all the modules' class'd pr_debugs.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
---
v11:
. bind controlling_param and enforce ABI protection for native
classmaps in ddebug_match_apply_kparam() and early in
param_set_dyndbg_module_classes(). Note that ddebug_apply_class_maps()
itself was hoisted to Patch 23 for lifecycle symmetry between definers
and users.
. drop const from struct ddebug_class_param.map and ddebug_class_map *cm
in ddebug_apply_params() to allow controlling_param binding.
v10:
. drop dead #if 0 ddebug_apply_class_maps() block.
v9:
. assign map->controlling_param = dcp in ddebug_match_apply_kparam()
to enforce protection on parameterized classmaps.
v2: RvB after SoB
old-v12
minor fixup after squashing subsequent commits to previous ones
---
include/linux/dynamic_debug.h | 16 +-
lib/dynamic_debug.c | 171 ++++++++++++++++-----
.../selftests/dynamic_debug/dyndbg_selftest.sh | 20 +--
3 files changed, 156 insertions(+), 51 deletions(-)
diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
index 21feaef9fb23..56ad8090d7b9 100644
--- a/include/linux/dynamic_debug.h
+++ b/include/linux/dynamic_debug.h
@@ -81,6 +81,7 @@ enum ddebug_class_map_type {
* map @class_names 0..N to consecutive constants starting at @base.
*/
struct ddebug_class_map {
+ struct ddebug_class_param *controlling_param;
const struct module *mod; /* NULL for builtins */
const char *mod_name; /* needed for builtins */
const char **class_names;
@@ -130,7 +131,7 @@ struct ddebug_class_param {
u32 *lvl;
};
char flags[8];
- const struct ddebug_class_map *map;
+ struct ddebug_class_map *map;
};
/*
@@ -288,7 +289,12 @@ struct ddebug_class_param {
*
* Creates a sysfs-param to control the classes defined by the
* exported classmap, with bits 0..N-1 mapped to the classes named.
- * This version keeps class-state in a private long int.
+ *
+ * Since sysfs-params are ABI, this also protects the classmap'd
+ * pr_debugs from un-class'd `echo -p > /proc/dynamic_debug/control`
+ * changes.
+ *
+ * This keeps class-state in a private long int.
*/
#define DYNAMIC_DEBUG_CLASSMAP_PARAM(_name, _var, _flags) \
static u32 _name##_bvec = _DPRINTK_CLASSBITS_INIT; \
@@ -301,10 +307,8 @@ struct ddebug_class_param {
* @_var: name of the (exported) classmap var defining the classes/bits
* @_flags: flags to be toggled, typically just 'p'
*
- * Creates a sysfs-param to control the classes defined by the
- * exported clasmap, with bits 0..N-1 mapped to the classes named.
- * This version keeps class-state in user @_bits. This lets drm check
- * __drm_debug elsewhere too.
+ * Like DYNAMIC_DEBUG_CLASSMAP_PARAM, but maintains param-state in
+ * extern @_bits. This lets DRM check __drm_debug elsewhere too.
*/
#define DYNAMIC_DEBUG_CLASSMAP_PARAM_REF(_name, _bits, _var, _flags) \
__DYNAMIC_DEBUG_CLASSMAP_PARAM(_name, _bits, _var, _flags)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 636a88994a77..f6e94a2ef346 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -71,6 +71,10 @@ struct flag_settings {
unsigned int mask;
};
+static bool ddebug_class_map_in_range(const int class_id,
+ const struct ddebug_class_map *map);
+static bool ddebug_class_user_in_range(const int class_id,
+ const struct ddebug_class_user *user);
static DEFINE_MUTEX(ddebug_lock);
static LIST_HEAD(ddebug_tables);
static int verbose;
@@ -200,14 +204,52 @@ static struct ddebug_class_map *ddebug_find_valid_class(struct _ddebug_info cons
return NULL;
}
-#define __outvar /* filled by callee */
+
+
+static struct ddebug_class_map *
+ddebug_find_map_by_class_id(struct _ddebug_info *di, int class_id)
+{
+ struct ddebug_class_map *map;
+ struct ddebug_class_user *cli;
+ int i;
+
+ for_subvec(i, map, di, maps)
+ if (ddebug_class_map_in_range(class_id, map))
+ return map;
+
+ for_subvec(i, cli, di, users)
+ if (ddebug_class_user_in_range(class_id, cli))
+ return cli->map;
+
+ return NULL;
+}
+
+/*
+ * classmaps-V1 protected classes from changes by legacy commands
+ * (those selecting _DPRINTK_CLASS_DFLT by omission). This had the
+ * downside that saying "class FOO" for every change can get tedious.
+ *
+ * V2 is smarter, it protects class-maps if the defining module also
+ * calls DYNAMIC_DEBUG_CLASSMAP_PARAM to create a sysfs parameter.
+ * Since the author wants the knob, we should assume they intend to
+ * use it (in preference to "class FOO +p" >control), and want to
+ * trust its settings. This gives protection when its useful, and not
+ * when its just tedious.
+ */
+static inline bool ddebug_class_has_param(const struct ddebug_class_map *map)
+{
+ return !!(map->controlling_param);
+}
+
+/* re-framed as a policy choice */
+#define ddebug_class_wants_protection(map) (ddebug_class_has_param(map))
+
static bool ddebug_match_desc(const struct ddebug_query *query,
struct _ddebug *dp,
- int valid_class)
+ struct _ddebug_info *di,
+ int selected_class)
{
- /* match site against query-class */
- if (dp->class_id != valid_class)
- return false;
+ struct ddebug_class_map *site_map;
if (!dp->format) {
pr_err_ratelimited("ddebug: NULL format string at %s:%s:%u\n",
@@ -252,7 +294,28 @@ static bool ddebug_match_desc(const struct ddebug_query *query,
dp->lineno > query->last_lineno)
return false;
- return true;
+ /*
+ * above are all satisfied, so we can make final decisions:
+ * 1- class FOO or implied class __DEFAULT__
+ * 2- site.is_classed or not
+ */
+ if (query->class_string) {
+ /* class FOO given, exact match required */
+ return (dp->class_id == selected_class);
+ }
+ /* query class __DEFAULT__ by omission. */
+ if (dp->class_id == _DPRINTK_CLASS_DFLT) {
+ /* un-classed site */
+ return true;
+ }
+ /* site is class'd */
+ site_map = ddebug_find_map_by_class_id(di, dp->class_id);
+ if (!site_map) {
+ WARN_ONCE(1, "unknown class_id %d, check %s's CLASSMAP definitions", dp->class_id, di->mod_name);
+ return false;
+ }
+ /* module(-param) decides protection */
+ return !ddebug_class_wants_protection(site_map);
}
/*
@@ -268,33 +331,31 @@ static int ddebug_change(const struct ddebug_query *query, struct flag_settings
unsigned int newflags;
unsigned int nfound = 0;
struct flagsbuf fbuf, nbuf;
- struct ddebug_class_map *map = NULL;
- int valid_class;
+ int selected_class;
/* search for matching ddebugs */
mutex_lock(&ddebug_lock);
list_for_each_entry(dt, &ddebug_tables, link) {
struct _ddebug_info *di = &dt->info;
+ struct ddebug_class_map *mods_map;
/* match against the module name */
if (query->module &&
!match_wildcard(query->module, di->mod_name))
continue;
+ selected_class = _DPRINTK_CLASS_DFLT;
if (query->class_string) {
- map = ddebug_find_valid_class(&dt->info, query->class_string,
- &valid_class);
- if (!map)
+ mods_map = ddebug_find_valid_class(di, query->class_string,
+ &selected_class);
+ if (!mods_map)
continue;
- } else {
- /* constrain query, do not touch class'd callsites */
- valid_class = _DPRINTK_CLASS_DFLT;
}
for (i = 0; i < di->descs.len; i++) {
struct _ddebug *dp = &di->descs.start[i];
- if (!ddebug_match_desc(query, dp, valid_class))
+ if (!ddebug_match_desc(query, dp, di, selected_class))
continue;
nfound++;
@@ -772,8 +833,8 @@ static int param_set_dyndbg_module_classes(const char *instr,
const struct kernel_param *kp,
const char *mod_name)
{
- const struct ddebug_class_param *dcp = kp->arg;
- const struct ddebug_class_map *map = dcp->map;
+ struct ddebug_class_param *dcp = kp->arg;
+ struct ddebug_class_map *map = dcp->map;
u32 inrep, new_bits, old_bits, old_val;
int rc, totct = 0;
@@ -1171,7 +1232,6 @@ static bool ddebug_class_user_in_range(const int class_id, const struct ddebug_c
return false;
return ddebug_class_map_in_range(class_id - user->offset, user->map);
}
-
static const char *ddebug_class_name(struct _ddebug_info *di, struct _ddebug *dp)
{
struct ddebug_class_map *map;
@@ -1332,44 +1392,80 @@ static void ddebug_sync_classbits(const struct kernel_param *kp, const char *mod
}
}
-static void ddebug_match_apply_kparam(const struct kernel_param *kp,
- const struct ddebug_class_map *map,
- const char *mod_name)
+static struct ddebug_class_param *
+ddebug_get_classmap_kparam(const struct kernel_param *kp,
+ const struct ddebug_class_map *map)
{
struct ddebug_class_param *dcp;
if (kp->ops != ¶m_ops_dyndbg_classes)
- return;
+ return NULL;
dcp = (struct ddebug_class_param *)kp->arg;
-
- if (dcp && dcp->map == map) {
- v2pr_info(" kp:%s.%s =0x%x", mod_name, kp->name, *dcp->bits);
- vpr_cm_info(map, " %s maps ", mod_name);
- ddebug_sync_classbits(kp, mod_name);
- }
+ return (map == dcp->map)
+ ? dcp : (struct ddebug_class_param *)NULL;
}
-static void ddebug_apply_params(const struct ddebug_class_map *cm, const char *mod_name)
+static const struct kernel_param *ddebug_find_class_kparam(const struct ddebug_class_map *cm)
{
const struct kernel_param *kp;
if (!cm)
- return;
+ return NULL;
#if IS_ENABLED(CONFIG_MODULES)
int i;
if (cm->mod) {
- vpr_cm_info(cm, "loaded classmap: %s ", mod_name);
- /* ifdef protects the cm->mod->kp deref */
for (i = 0, kp = cm->mod->kp; i < cm->mod->num_kp; i++, kp++)
- ddebug_match_apply_kparam(kp, cm, mod_name);
+ if (ddebug_get_classmap_kparam(kp, cm))
+ return kp;
}
#endif
if (!cm->mod) {
- vpr_cm_info(cm, "builtin classmap: %s ", mod_name);
for (kp = __start___param; kp < __stop___param; kp++)
- ddebug_match_apply_kparam(kp, cm, mod_name);
+ if (ddebug_get_classmap_kparam(kp, cm))
+ return kp;
+ }
+ return NULL;
+}
+
+static void ddebug_bind_param(struct ddebug_class_map *cm)
+{
+ const struct kernel_param *kp;
+
+ if (!cm || cm->controlling_param)
+ return;
+
+ kp = ddebug_find_class_kparam(cm);
+ if (kp)
+ cm->controlling_param = kp->arg;
+}
+
+static void ddebug_bind_class_params(const struct _ddebug_info *di)
+{
+ struct ddebug_class_map *cm;
+ struct ddebug_class_user *cli;
+ int i;
+
+ for_subvec(i, cm, di, maps)
+ ddebug_bind_param(cm);
+
+ for_subvec(i, cli, di, users)
+ ddebug_bind_param(cli->map);
+}
+
+static void ddebug_apply_params(struct ddebug_class_map *cm, const char *mod_name)
+{
+ const struct kernel_param *kp;
+
+ if (!cm || !cm->controlling_param)
+ return;
+
+ kp = ddebug_find_class_kparam(cm);
+ if (kp) {
+ v2pr_info(" kp:%s.%s =0x%x", mod_name, kp->name, *cm->controlling_param->bits);
+ vpr_cm_info(cm, " %s maps ", mod_name);
+ ddebug_sync_classbits(kp, mod_name);
}
}
@@ -1490,7 +1586,12 @@ static int ddebug_add_module(struct _ddebug_info *di)
goto cleanup;
/*
+ * Bind controlling_param before publishing dt to ddebug_tables so
+ * that class protection is active against concurrent wildcard queries
+ * the instant the table becomes visible.
*/
+ ddebug_bind_class_params(&dt->info);
+
mutex_lock(&ddebug_lock);
list_add_tail(&dt->link, &ddebug_tables);
mutex_unlock(&ddebug_lock);
diff --git a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
index 6e5f23866ccc..11142cc0aecb 100755
--- a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
+++ b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
@@ -600,23 +600,23 @@ function GOLDEN_RECORDS {
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.16
#K= d682c98ced7d31f1555ab474a9ebe253 FT_modprobe_w_param.17
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.18
-#K= 362ab2e7e5f5e3ede8b69645c64fb987 FT_modprobe_w_param.19
-#K= 362ab2e7e5f5e3ede8b69645c64fb987 FT_modprobe_w_param.20
-#K= 4f539816f9cc9fb9dd4a032138e3abde FT_modprobe_w_param.21
+#K= c468e49e8ce1f1aa25a3c6684f221fe5 FT_modprobe_w_param.19
+#K= c468e49e8ce1f1aa25a3c6684f221fe5 FT_modprobe_w_param.20
+#K= ef2408a036206c895d95061521f67906 FT_modprobe_w_param.21
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.22
-#K= 20659d16ffb5b18475e83602223216d1 FT_modprobe_w_param.23
+#K= 92c0174d5de412de82e3d5837b0690d0 FT_modprobe_w_param.23
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.24
-#K= 0b24971fb1018c38353141f8fcb9cbdc FT_modprobe_w_param.25
+#K= a563a79aeffbf3d8cf2e37ab93898ae9 FT_modprobe_w_param.25
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.26
-#K= 66eb387a95512f679eb5cad4168b0992 FT_modprobe_w_param.27
+#K= 8d2f4db3b7885064a56594e1d81deb26 FT_modprobe_w_param.27
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.28
-#K= 2583cb4637bcc2ce1e93eea4222ec76c FT_modprobe_w_param.29
+#K= 7185968287bbc0e5a72350ea4786e852 FT_modprobe_w_param.29
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.30
-#K= d592c5bf23312e705b39064c21ca68e4 FT_modprobe_w_param.31
+#K= b2514a7fda24f196fa87c0ace35f0b37 FT_modprobe_w_param.31
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.32
-#K= b44d105d151123c93cfe953bacdb573f FT_modprobe_w_param.33
+#K= 545c3efd767efbae33ee341df9008c52 FT_modprobe_w_param.33
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.34
-#K= 4819f715ba485c493afb455542f7ab8c FT_modprobe_w_param.35
+#K= 28ace93a95da7aaea5b9b54a8656a2cf FT_modprobe_w_param.35
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.36
EO_DYNDBG_GOLDEN_REFS
# Read the K-recs and skip those for tests that can't run
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 32/40] docs/dyndbg: add classmap info to howto
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (30 preceding siblings ...)
2026-10-13 2:37 ` [PATCH v12 31/40] dyndbg: resolve "protection" of class'd pr_debug Jim Cromie via B4 Relay
@ 2026-10-13 2:37 ` Jim Cromie via B4 Relay
2026-10-13 2:37 ` [PATCH v12 33/40] dyndbg: Ignore additional arguments from pr_fmt Jim Cromie via B4 Relay
` (7 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:37 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie,
Louis Chauvet
From: Jim Cromie <jim.cromie@gmail.com>
Describe the 3 API macros providing dynamic_debug's classmaps
DYNAMIC_DEBUG_CLASSMAP_DEFINE - create & export a classmap
DYNAMIC_DEBUG_CLASSMAP_USE - refer to exported map
DYNAMIC_DEBUG_CLASSMAP_PARAM - bind control param to the classmap
DYNAMIC_DEBUG_CLASSMAP_PARAM_REF + use module's storage - __drm_debug
NB: The _DEFINE & _USE model makes the user dependent on the definer,
just like EXPORT_SYMBOL(__drm_debug) already does.
cc: linux-doc@vger.kernel.org
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
---
v9:
. fix typo in class keyword documentation.
. document DYNAMIC_DEBUG_CLASSMAP_PARAM_REF.
v2: RvB after SoB
---
Documentation/admin-guide/dynamic-debug-howto.rst | 145 ++++++++++++++++++++--
1 file changed, 135 insertions(+), 10 deletions(-)
diff --git a/Documentation/admin-guide/dynamic-debug-howto.rst b/Documentation/admin-guide/dynamic-debug-howto.rst
index a8962ab22aaf..f5b1470a4b88 100644
--- a/Documentation/admin-guide/dynamic-debug-howto.rst
+++ b/Documentation/admin-guide/dynamic-debug-howto.rst
@@ -146,6 +146,9 @@ keywords are::
"1-30" is valid range but "1 - 30" is not.
+Keywords
+--------
+
The meanings of each keyword are:
func
@@ -193,16 +196,6 @@ format
format "nfsd: SETATTR" // a neater way to match a format with whitespace
format 'nfsd: SETATTR' // yet another way to match a format with whitespace
-class
- The given class_name is validated against each module, which may
- have declared a list of known class_names. If the class_name is
- found for a module, callsite & class matching and adjustment
- proceeds. Examples::
-
- class DRM_UT_KMS # a DRM.debug category
- class JUNK # silent non-match
- // class TLD_* # NOTICE: no wildcard in class names
-
line
The given line number or range of line numbers is compared
against the line number of each ``pr_debug()`` callsite. A single
@@ -217,6 +210,25 @@ line
line -1605 // the 1605 lines from line 1 to line 1605
line 1600- // all lines from line 1600 to the end of the file
+class
+
+ The given class_name is validated against each module, which may
+ have declared a list of class_names it accepts. If the class_name
+ is accepted by a module, callsite & class matching and adjustment
+ proceeds. Examples::
+
+ class DRM_UT_KMS # a drm.debug category
+ class JUNK # silent non-match
+ // class TLD_* # NOTICE: no wildcard in class names
+
+.. note::
+
+ Unlike other keywords, classes are "name-to-change", not
+ "omitting-constraint-allows-change". See Dynamic Debug Classmaps
+
+Flags
+-----
+
The flags specification comprises a change operation followed
by one or more flag characters. The change operation is one
of the characters::
@@ -238,6 +250,11 @@ The flags are::
l Include line number
d Include call trace
+.. note::
+
+ * To query without changing ``+_`` or ``-_``.
+ * To clear all flags ``=_`` or ``-fslmpt``.
+
For ``print_hex_dump_debug()`` and ``print_hex_dump_bytes()``, only
the ``p`` flag has meaning, other flags are ignored.
@@ -394,3 +411,111 @@ just a shortcut for ``print_hex_dump(KERN_DEBUG)``.
For ``print_hex_dump_debug()``/``print_hex_dump_bytes()``, format string is
its ``prefix_str`` argument, if it is constant string; or ``hexdump``
in case ``prefix_str`` is built dynamically.
+
+.. _dyndbg-classmaps:
+
+Dynamic Debug Classmaps
+=======================
+
+The "class" keyword selects prdbgs based on author supplied,
+domain-oriented names. This complements the nested-scope keywords:
+module, file, function, line.
+
+The main difference from the others: classes must be named to be
+changed. This protects them from unintended overwrite::
+
+ # IOW this cannot undo any drm.debug settings
+ :#> ddcmd -p
+
+This protection is needed; /sys/module/drm/parameters/debug is ABI.
+drm.debug is authoritative when dyndbg is not used, dyndbg-under-DRM
+is an implementation detail, and must not behave erratically, just
+because another admin fed >control something unrelated.
+
+So each class must be enabled individually (no wildcards)::
+
+ :#> ddcmd class DRM_UT_CORE +p
+ :#> ddcmd class DRM_UT_KMS +p
+ # or more selectively
+ :#> ddcmd class DRM_UT_CORE module drm +p
+
+That makes direct >control wordy and annoying, but it is a secondary
+interface; it is not intended to replace the ABI, just slide in
+underneath and reimplement the guaranteed behavior. So DRM would keep
+using the convenient way, and be able to trust it::
+
+ :#> echo 0x1ff > /sys/module/drm/parameters/debug
+
+That said, since the sysfs/kparam is the ABI, if the author omits the
+CLASSMAP_PARAM, theres no ABI to guard, and he probably wants a less
+pedantic >control interface. In this case, protection is dropped.
+
+Dynamic Debug Classmap API
+==========================
+
+DYNAMIC_DEBUG_CLASSMAP_DEFINE(clname,type,_base,classnames) - this maps
+classnames (a list of strings) onto class-ids consecutively, starting
+at _base.
+
+DYNAMIC_DEBUG_CLASSMAP_USE(clname) & _USE_(clname,_base) - modules
+call this to refer to the var _DEFINEd elsewhere (and exported).
+
+DYNAMIC_DEBUG_CLASSMAP_PARAM(clname) - creates the sysfs/kparam,
+maps/exposes bits 0..N as class-names.
+
+DYNAMIC_DEBUG_CLASSMAP_PARAM_REF(name,bits,var,flags) - connects an
+existing module parameter variable (e.g. __drm_debug) to a classmap.
+
+Classmaps are opt-in: modules invoke _DEFINE or _USE to authorize
+dyndbg to update those named classes. "class FOO" queries are
+validated against the classes defined or used by the module, this
+finds the classid to alter; classes are not directly selectable by
+their classid.
+
+Classnames are global in scope, so subsystems (module-groups) should
+prepend a subsystem name; unqualified names like "CORE" are discouraged.
+
+NB: It is an inherent API limitation (due to class_id's int type) that
+the following are possible:
+
+ // these errors should be caught in review
+ __pr_debug_cls(0, "fake DRM_UT_CORE msg"); // this works
+ __pr_debug_cls(62, "un-known classid msg"); // this compiles, does nothing
+
+There are 2 types of classmaps:
+
+* DD_CLASS_TYPE_DISJOINT_BITS: classes are independent, like drm.debug
+* DD_CLASS_TYPE_LEVEL_NUM: classes are relative, ordered (V3 > V2)
+
+DYNAMIC_DEBUG_CLASSMAP_PARAM - modelled after module_param_cb, it
+refers to a DEFINEd classmap, and associates it to the param's
+data-store. This state is then applied to DEFINEr and USEr modules
+when they're modprobed.
+
+The PARAM interface also enforces the DD_CLASS_TYPE_LEVEL_NUM relation
+amongst the contained classnames; all classes are independent in the
+control parser itself. There is no implied meaning in names like "V4"
+or "PL_ERROR" vs "PL_WARNING".
+
+Modules or subsystems (drm & drivers) can define multiple classmaps,
+as long as they (all the classmaps) share the limited 0..62
+per-module-group _class_id range, without overlap.
+
+If a module encounters a conflict between 2 classmaps it is _USEing or
+_DEFINEing, it can invoke the extended _USE_(name,_base) macro to
+de-conflict the respective ranges.
+
+``#define DEBUG`` will enable all pr_debugs in scope, including any
+class'd ones. This won't be reflected in the PARAM readback value,
+but the class'd pr_debug callsites can be forced off by toggling the
+classmap-kparam all-on then all-off.
+
+Self-Testing and Validation
+===========================
+
+Dynamic debug includes a regression test script in kselftest::
+
+ :#> make -C tools/testing/selftests TARGETS=dynamic_debug run_tests
+ # Or run directly on a running kernel:
+ :#> ./tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
+
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 33/40] dyndbg: Ignore additional arguments from pr_fmt
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (31 preceding siblings ...)
2026-10-13 2:37 ` [PATCH v12 32/40] docs/dyndbg: add classmap info to howto Jim Cromie via B4 Relay
@ 2026-10-13 2:37 ` Jim Cromie via B4 Relay
2026-10-13 11:33 ` Petr Mladek
2026-10-13 2:37 ` [PATCH v12 34/40] dyndbg: add epilogue to dynamic_debug/control file Jim Cromie via B4 Relay
` (6 subsequent siblings)
39 siblings, 1 reply; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:37 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie,
Philipp Hahn
From: Philipp Hahn <phahn-oss@avm.de>
pr_fmt can be used to add a common prefix to any output from a module:
#define pr_fmt(fmt) KBUILD_MODNAME ".%s " fmt, __func__
But adding additional arguments breaks dynamic debug:
> error: macro "DEFINE_DYNAMIC_DEBUG_METADATA_CLS" passed 4 arguments, but takes just 3
> | pr_debug_ratelimited("%s", "Hello world!");
> | ^
> note: macro "DEFINE_DYNAMIC_DEBUG_METADATA_CLS" defined here
> | #define DEFINE_DYNAMIC_DEBUG_METADATA_CLS(name, cls, fmt) \
> |
> error: ‘DEFINE_DYNAMIC_DEBUG_METADATA_CLS’ undeclared (first use in this function)
> | DEFINE_DYNAMIC_DEBUG_METADATA_CLS(name, _DPRINTK_CLASS_DFLT, fmt)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> note: in expansion of macro ‘DEFINE_DYNAMIC_DEBUG_METADATA’
> | DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, pr_fmt(fmt)); \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> note: in expansion of macro ‘pr_debug_ratelimited’
> | pr_debug_ratelimited("%s", "Hello world!");
> | ^~~~~~~~~~~~~~~~~~~~
Add an additional ', ...' to DEFINE_DYNAMIC_DEBUG_METADATA_CLS to slurp
any additional argument, which `pr_fmt` might add.
Signed-off-by: Philipp Hahn <phahn-oss@avm.de>
[pr_fmt change on test_dynamic_debug_submod instead of parent]
Reviewed-by: Jim Cromie <jim.cromie@gmail.com>
---
v11:
. update golden record hashes for FT_modprobe_w_param tests after
comma-token and native classmap attachment fixes.
v10:
. pass raw fmt to DEFINE_DYNAMIC_DEBUG_METADATA in pr_debug_ratelimited().
---
include/linux/dynamic_debug.h | 2 +-
include/linux/printk.h | 2 +-
lib/test_dynamic_debug.c | 4 ++--
.../selftests/dynamic_debug/dyndbg_selftest.sh | 26 +++++++++++-----------
4 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
index 56ad8090d7b9..dc755a24f1d6 100644
--- a/include/linux/dynamic_debug.h
+++ b/include/linux/dynamic_debug.h
@@ -351,7 +351,7 @@ void __dynamic_ibdev_dbg(struct _ddebug *descriptor,
dump_stack(); \
}
-#define DEFINE_DYNAMIC_DEBUG_METADATA_CLS(name, cls, fmt) \
+#define DEFINE_DYNAMIC_DEBUG_METADATA_CLS(name, cls, fmt, ...) \
static struct _ddebug __aligned(8) \
__section("__dyndbg_descs") name = { \
.modname = KBUILD_MODNAME, \
diff --git a/include/linux/printk.h b/include/linux/printk.h
index f594c1266bfd..5d701952e739 100644
--- a/include/linux/printk.h
+++ b/include/linux/printk.h
@@ -742,7 +742,7 @@ do { \
static DEFINE_RATELIMIT_STATE(_rs, \
DEFAULT_RATELIMIT_INTERVAL, \
DEFAULT_RATELIMIT_BURST); \
- DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, pr_fmt(fmt)); \
+ DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
if (DYNAMIC_DEBUG_BRANCH(descriptor) && \
__ratelimit(&_rs)) \
__dynamic_pr_debug(&descriptor, pr_fmt(fmt), ##__VA_ARGS__); \
diff --git a/lib/test_dynamic_debug.c b/lib/test_dynamic_debug.c
index ea81c5158b13..35bb411c48d8 100644
--- a/lib/test_dynamic_debug.c
+++ b/lib/test_dynamic_debug.c
@@ -23,7 +23,7 @@
* the usage clearer.
*/
#if defined(TEST_DYNAMIC_DEBUG_SUBMOD)
- #define pr_fmt(fmt) "test_dd_submod: " fmt
+ #define pr_fmt(fmt) "test_dd_submod: %s " fmt, __func__
#else
#define pr_fmt(fmt) "test_dd: " fmt
#endif
@@ -317,7 +317,7 @@ static int __init test_dynamic_debug_init(void)
static void __exit test_dynamic_debug_exit(void)
{
- pr_debug("exited\n");
+ pr_debug_ratelimited("exited\n");
}
module_init(test_dynamic_debug_init);
diff --git a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
index 11142cc0aecb..e439f367386c 100755
--- a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
+++ b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
@@ -581,40 +581,40 @@ function GOLDEN_RECORDS {
#K= c14c8aa758e24046b3237d20e2189bf7 FT_classmap_inheritance.2
#K= 5d0f3701517aa3a461c8887c332bdb42 FT_classmap_inheritance.3
#K= f444ae312fcce32444c54da757d87c41 FT_classmap_inheritance.4
-#K= 7e92245008439ee79fe2460aeaa16a9b FT_classmap_inheritance.5
+#K= 0266e8d60659058ec589283022bf078c FT_classmap_inheritance.5
#K= d2e8b8c5a5b4e7b9bbe1a29460a3c07d FT_modprobe_w_param.1
#K= d2e8b8c5a5b4e7b9bbe1a29460a3c07d FT_modprobe_w_param.2
-#K= 11032ef17569bd151c3806527a2428be FT_modprobe_w_param.3
+#K= 20d8a1fac0330f1b5cc582ce93792d58 FT_modprobe_w_param.3
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.4
-#K= 942e62ca24809cad666c5725aeb14376 FT_modprobe_w_param.5
+#K= 3c19dd83b330a9d59901281aaa3bacf8 FT_modprobe_w_param.5
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.6
-#K= fe1aadca4b2b4165d8d5c98e973f9e4b FT_modprobe_w_param.7
+#K= 86b7a18d7a692187aa0b7cc0b6886e77 FT_modprobe_w_param.7
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.8
#K= 535ab526b24a7214de41d92e94bbd52c FT_modprobe_w_param.9
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.10
-#K= a71670fec42b1b0646f0317180bafcc7 FT_modprobe_w_param.11
+#K= 4f96e9cd2c92ab099cd35dad83c35e86 FT_modprobe_w_param.11
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.12
-#K= aacdbab171b374f221f0196e6e415d09 FT_modprobe_w_param.13
+#K= 80ca4d681dcd4c0046a4daa01e9b168a FT_modprobe_w_param.13
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.14
-#K= c7eb8e25c780f58c78ed73dc1c187a02 FT_modprobe_w_param.15
+#K= e0cdc3a8471acf34201539231b2b2110 FT_modprobe_w_param.15
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.16
#K= d682c98ced7d31f1555ab474a9ebe253 FT_modprobe_w_param.17
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.18
#K= c468e49e8ce1f1aa25a3c6684f221fe5 FT_modprobe_w_param.19
#K= c468e49e8ce1f1aa25a3c6684f221fe5 FT_modprobe_w_param.20
-#K= ef2408a036206c895d95061521f67906 FT_modprobe_w_param.21
+#K= 2b31c44bc2eb5b5d666dc1887c38b8dd FT_modprobe_w_param.21
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.22
-#K= 92c0174d5de412de82e3d5837b0690d0 FT_modprobe_w_param.23
+#K= 3bba1f526e669807407d9be380117564 FT_modprobe_w_param.23
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.24
-#K= a563a79aeffbf3d8cf2e37ab93898ae9 FT_modprobe_w_param.25
+#K= 1dc9fbf8e7ce91929308a441e3707915 FT_modprobe_w_param.25
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.26
#K= 8d2f4db3b7885064a56594e1d81deb26 FT_modprobe_w_param.27
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.28
-#K= 7185968287bbc0e5a72350ea4786e852 FT_modprobe_w_param.29
+#K= b76a644b8d3c99bfd8df9220f4509828 FT_modprobe_w_param.29
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.30
-#K= b2514a7fda24f196fa87c0ace35f0b37 FT_modprobe_w_param.31
+#K= dfc272b2a1f7a075e3a37dc491396adf FT_modprobe_w_param.31
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.32
-#K= 545c3efd767efbae33ee341df9008c52 FT_modprobe_w_param.33
+#K= 24629bcce166addffcaae1232ef6a5a9 FT_modprobe_w_param.33
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.34
#K= 28ace93a95da7aaea5b9b54a8656a2cf FT_modprobe_w_param.35
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.36
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* Re: [PATCH v12 33/40] dyndbg: Ignore additional arguments from pr_fmt
2026-10-13 2:37 ` [PATCH v12 33/40] dyndbg: Ignore additional arguments from pr_fmt Jim Cromie via B4 Relay
@ 2026-10-13 11:33 ` Petr Mladek
0 siblings, 0 replies; 42+ messages in thread
From: Petr Mladek @ 2026-10-13 11:33 UTC (permalink / raw)
To: jim.cromie
Cc: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh, linux-kernel, linux-kselftest, dri-devel,
linux-arch, linux-modules, linux-doc, linux-kbuild, linux-pm,
Philipp Hahn
On Mon 2026-10-12 20:37:04, Jim Cromie via B4 Relay wrote:
> From: Philipp Hahn <phahn-oss@avm.de>
>
> pr_fmt can be used to add a common prefix to any output from a module:
> #define pr_fmt(fmt) KBUILD_MODNAME ".%s " fmt, __func__
>
> But adding additional arguments breaks dynamic debug:
> > error: macro "DEFINE_DYNAMIC_DEBUG_METADATA_CLS" passed 4 arguments, but takes just 3
> > | pr_debug_ratelimited("%s", "Hello world!");
> > | ^
> > note: macro "DEFINE_DYNAMIC_DEBUG_METADATA_CLS" defined here
> > | #define DEFINE_DYNAMIC_DEBUG_METADATA_CLS(name, cls, fmt) \
> > |
> > error: ‘DEFINE_DYNAMIC_DEBUG_METADATA_CLS’ undeclared (first use in this function)
> > | DEFINE_DYNAMIC_DEBUG_METADATA_CLS(name, _DPRINTK_CLASS_DFLT, fmt)
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
I wonder what this error about undeclared macro means.
> > note: in expansion of macro ‘DEFINE_DYNAMIC_DEBUG_METADATA’
> > | DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, pr_fmt(fmt)); \
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > note: in expansion of macro ‘pr_debug_ratelimited’
> > | pr_debug_ratelimited("%s", "Hello world!");
> > | ^~~~~~~~~~~~~~~~~~~~
>
> Add an additional ', ...' to DEFINE_DYNAMIC_DEBUG_METADATA_CLS to slurp
> any additional argument, which `pr_fmt` might add.
>
> --- a/include/linux/dynamic_debug.h
> +++ b/include/linux/dynamic_debug.h
> @@ -351,7 +351,7 @@ void __dynamic_ibdev_dbg(struct _ddebug *descriptor,
> dump_stack(); \
> }
>
> -#define DEFINE_DYNAMIC_DEBUG_METADATA_CLS(name, cls, fmt) \
> +#define DEFINE_DYNAMIC_DEBUG_METADATA_CLS(name, cls, fmt, ...) \
> static struct _ddebug __aligned(8) \
> __section("__dyndbg_descs") name = { \
> .modname = KBUILD_MODNAME, \
> diff --git a/include/linux/printk.h b/include/linux/printk.h
> index f594c1266bfd..5d701952e739 100644
> --- a/include/linux/printk.h
> +++ b/include/linux/printk.h
> @@ -742,7 +742,7 @@ do { \
> static DEFINE_RATELIMIT_STATE(_rs, \
> DEFAULT_RATELIMIT_INTERVAL, \
> DEFAULT_RATELIMIT_BURST); \
> - DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, pr_fmt(fmt)); \
> + DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \
IMHO, this changes the existing behavior. The prefix added by
pr_fmt() will no longer be stored in DEFINE_DYNAMIC_DEBUG_METADATA().
Is this intentional, please?
Anyway, if we do not longer pass pr_fmt(fmt) then we should not
need to add "..." into DEFINE_DYNAMIC_DEBUG_METADATA_CLS().
By other words, we newly pass just the format "fmt" without the parametes.
The 4th parameter was added by pr_fmt().
IMHO, the right solution is to keep pr_fmt(fmt) here and extend both
BEFINE_DYNAMIC_DEBUG_METADATA() and
DEFINE_DYNAMIC_DEBUG_METADATA_CLS()
to accept var args. I would expect something like:
#define DEFINE_DYNAMIC_DEBUG_METADATA_CLS(name, cls, fmt, ...) \
...
#define DEFINE_DYNAMIC_DEBUG_METADATA(name, fmt, ...) \
DEFINE_DYNAMIC_DEBUG_METADATA_CLS(name, _DPRINTK_CLASS_DFLT, fmt, ##__VA_ARGS__)
or maybe, we could "eat" the extra parameters in
DEFINE_DYNAMIC_DEBUG_METADATA. It would mean to keep
DEFINE_DYNAMIC_DEBUG_METADATA_CLS() as is and just add the "..." into
DEFINE_DYNAMIC_DEBUG_METADATA(), aka
#define DEFINE_DYNAMIC_DEBUG_METADATA(name, fmt, ...) \
DEFINE_DYNAMIC_DEBUG_METADATA_CLS(name, _DPRINTK_CLASS_DFLT, fmt)
Or do I miss something, please?
It is possible that the macros work another way. Or this depends
on another change. I checked only this patch...
Best Regards,
Petr
PS: I was curious what Sashiko says about this change and it seems
that it does not review this patchset from some reasons.
> if (DYNAMIC_DEBUG_BRANCH(descriptor) && \
> __ratelimit(&_rs)) \
> __dynamic_pr_debug(&descriptor, pr_fmt(fmt), ##__VA_ARGS__); \
^ permalink raw reply [flat|nested] 42+ messages in thread
* [PATCH v12 34/40] dyndbg: add epilogue to dynamic_debug/control file
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (32 preceding siblings ...)
2026-10-13 2:37 ` [PATCH v12 33/40] dyndbg: Ignore additional arguments from pr_fmt Jim Cromie via B4 Relay
@ 2026-10-13 2:37 ` Jim Cromie via B4 Relay
2026-10-13 2:37 ` [PATCH v12 35/40] dyndbg: fix attempt to modify an RO string Jim Cromie via B4 Relay
` (5 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:37 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie
From: Jim Cromie <jim.cromie@gmail.com>
Add an epilogue to the control-file, to allow display of statistics
etc, without disturbing the header.
NB: epilogue lines should start with "#: " to distinguish them from
lines describing pr_debugs (and from the header line). No new lines
are added here, only the place to do so.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
v9:
. update ddebug_proc_start() to return EPILOGUE_TOKEN when seeking directly to epilogue.
---
lib/dynamic_debug.c | 23 ++++++++++++++++++++---
1 file changed, 20 insertions(+), 3 deletions(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index f6e94a2ef346..efde85c7a9c1 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -1182,6 +1182,9 @@ static struct _ddebug *ddebug_iter_next(struct ddebug_iter *iter)
* read() call from userspace. Takes the ddebug_lock and
* seeks the seq_file's iterator to the given position.
*/
+static char ddebug_epilogue_token;
+#define EPILOGUE_TOKEN (&ddebug_epilogue_token)
+
static void *ddebug_proc_start(struct seq_file *m, loff_t *pos)
{
struct ddebug_iter *iter = m->private;
@@ -1197,7 +1200,9 @@ static void *ddebug_proc_start(struct seq_file *m, loff_t *pos)
dp = ddebug_iter_first(iter);
while (dp != NULL && --n > 0)
dp = ddebug_iter_next(iter);
- return dp;
+ if (dp)
+ return dp;
+ return n <= 1 ? EPILOGUE_TOKEN : NULL;
}
/*
@@ -1210,12 +1215,20 @@ static void *ddebug_proc_next(struct seq_file *m, void *p, loff_t *pos)
struct ddebug_iter *iter = m->private;
struct _ddebug *dp;
+ (*pos)++;
+
+ if (p == EPILOGUE_TOKEN)
+ return NULL;
+
if (p == SEQ_START_TOKEN)
dp = ddebug_iter_first(iter);
else
dp = ddebug_iter_next(iter);
- ++*pos;
- return dp;
+
+ if (dp)
+ return dp;
+
+ return EPILOGUE_TOKEN;
}
static bool ddebug_class_map_in_range(const int class_id, const struct ddebug_class_map *map)
@@ -1267,6 +1280,10 @@ static int ddebug_proc_show(struct seq_file *m, void *p)
"# filename:lineno [module]function flags format\n");
return 0;
}
+ if (p == EPILOGUE_TOKEN) {
+ /* use this soon */
+ return 0;
+ }
seq_printf(m, "%s:%u [%s]%s =%s \"",
trim_prefix(dp->filename), dp->lineno,
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 35/40] dyndbg: fix attempt to modify an RO string
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (33 preceding siblings ...)
2026-10-13 2:37 ` [PATCH v12 34/40] dyndbg: add epilogue to dynamic_debug/control file Jim Cromie via B4 Relay
@ 2026-10-13 2:37 ` Jim Cromie via B4 Relay
2026-10-13 2:37 ` [PATCH v12 36/40] dyndbg: add +c flag to count pr_debug calls without printing Jim Cromie via B4 Relay
` (4 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:37 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie
From: Jim Cromie <jim.cromie@gmail.com>
ddebug_dyndbg_param_cb() passes an RO flags string "+p" to
ddebug_exec_queries() when no explicit param value is given, but
callee may attempt to modify it. Fix by adding a local mutable var,
init'd with that value, and passing it instead.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
lib/dynamic_debug.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index efde85c7a9c1..023784dcdc80 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -1634,8 +1634,9 @@ static int ddebug_add_module(struct _ddebug_info *di)
/* helper for ddebug_dyndbg_(boot|module)_param_cb */
static int ddebug_dyndbg_param_cb(char *param, char *val,
- const char *modname, int on_err)
+ const char *modname, int on_err)
{
+ char dflt_flags[] = "+p";
char *sep;
sep = strchr(param, '.');
@@ -1648,7 +1649,7 @@ static int ddebug_dyndbg_param_cb(char *param, char *val,
if (strcmp(param, "dyndbg"))
return on_err; /* determined by caller */
- ddebug_exec_queries((val ? val : "+p"), modname);
+ ddebug_exec_queries((val ? val : dflt_flags), modname);
return 0; /* query failure shouldn't stop module load */
}
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 36/40] dyndbg: add +c flag to count pr_debug calls without printing
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (34 preceding siblings ...)
2026-10-13 2:37 ` [PATCH v12 35/40] dyndbg: fix attempt to modify an RO string Jim Cromie via B4 Relay
@ 2026-10-13 2:37 ` Jim Cromie via B4 Relay
2026-10-13 2:37 ` [PATCH v12 37/40] dyndbg: add DEBUG-biased fallback stubs for _dynamic_func_call_cls Jim Cromie via B4 Relay
` (3 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:37 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie
From: Jim Cromie <jim.cromie@gmail.com>
Introduce a +c flag, to increment a per-cpu counter: ddebug_count
when a flagged pr_debug() is called.
Reset the counter with:
echo reset_stats > /proc/dynamic_debug/control
and see the count value with:
tail -n1 /proc/dynamic_debug/control
#: total count: 2295401
This counter lets us count callrates of arbitrary sets of "enabled"
pr_debugs, over user defined intervals, without actually doing the
printk work. Each increment represents a fetch from main memory and a
bit test, which are now elided because the pr_debug is backed by a
static-key.
CONFIG_DRM_USE_DYNAMIC_DEBUG=y gives drm a per callsite static-key to
avoid the cache-line insult of actually reading __drm_debug. On my
amdgpu + nvidia laptop, thats ~3200 callsites.
The benchmarks below are from a recent build running on my asus
amdgpu + nouveau laptop, using scripts from below the snip.
#> count_hits 30 hammer_vk --
Banging on: hammer_vk (&)
[1] 100847
[1]+ Done hammer_vk
#: total hits: 2295401
#> count_hits 30 hammer_vk -- DRM_UT_CORE
Banging on: hammer_vk (&)
[1] 99910
[1]+ Done hammer_vk
#: total hits: 2204406
Notably, the DRM_UT_CORE category dominates the call traffic, not
DRM_UT_VBL or any others, which contribute little extra to the above.
To see the distribution of debug categories (for vkcube load)
#> isolate_drm_hits 2> /dev/null
Starting isolation study: 10s per class using vkcube
----------------------------------------------------------
DRM CLASS | TOTAL HITS
----------------------------------------------------------
DRM_UT_CORE | 85305
DRM_UT_DRIVER | 0
DRM_UT_KMS | 1435
DRM_UT_PRIME | 0
DRM_UT_ATOMIC | 13645
DRM_UT_VBL | 4071
DRM_UT_STATE | 1780
DRM_UT_LEASE | 0
DRM_UT_DP | 0
DRM_UT_DRMRES | 0
FOO | 0
REVIEW:
In every minute, 12 vkcubes issue ~4.6M drm_debug_enabled(__drm_debug)
macro-calls. To test the bits, they all *may* go out to main memory,
though __drm_debug is ro-mostly. Still, theres significant cache-line
eviction, and potentially meaningful costs we can avoid.
With CONFIG_DRM_USE_DYNAMIC_DEBUG=y, each pr_debug call-site is
replaced by a static-key, with the off-cost of few NOOPs, avoiding all
the cache-line thrashing.
NOTES:
The +c flag invokes the callsite, but avoids the heavy syslog writing.
It is currently independent of +p, but it could be compressed into a
state-machine, and the bit recovered, but not til we need to do so.
The +c flag has no predictive quality; to count usr_dbg() callsites,
you must have reimplemnted them already with pr_debug. This just
gives DRM folks some numbers to consider, to balance against the work
needed to test this series.
Assisted-by: Gemini-CLI:gemini-2.5-pro
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
v11:
. only print counted_calls in control epilogue when count > 0.
v10:
. add __DYNAMIC_DEBUG_BRANCH() checking _ENABLED while DYNAMIC_DEBUG_BRANCH() checks _ACTIVE.
. add early return guards in __dynamic_*_dbg() helpers checking _ACTIVE.
. add __DYNAMIC_DEBUG_BRANCH() checking _ENABLED while DYNAMIC_DEBUG_BRANCH() checks _ACTIVE.
. add early return guards in __dynamic_*_dbg() helpers checking _ACTIVE.
v9:
. add missing kfree(tmpbuf) in reset_stats handler before early return.
. sum across for_each_possible_cpu() in get_ddebug_call_count() for hotplug stability.
. update !CONFIG_JUMP_LABEL branch check to check _DPRINTK_FLAGS_ENABLED.
function ddcmd () {
local cmd="$*"
# Direct write - assume the parent script is run with 'sudo' or as root
[ -f /proc/dynamic_debug/control ] || return 1;
if ! echo "$cmd" > /proc/dynamic_debug/control 2>/tmp/dd_err; then
local ret=$?
echo "ERROR ($ret): $(cat /tmp/dd_err)" #>&2
# Check dmesg for the "!" syntax error on wk-baseline
dmesg | grep -i "dyndbg" | tail -n 2 #>&2
return $ret
fi
}
function _get_cal_count() {
if [ ! -f /proc/interrupts ]; then
echo 0
return
fi
# sum all CPU columns for any line starting with CAL:
# the awk starts at $2 to skip the label (CAL:)
# NF-2 skips the trailing text "Function call interrupts"
grep "^ *CAL:" /proc/interrupts | \
awk '{ for(i=2; i<=NF-2; i++) sum+=$i } END { print sum+0 }'
}
function wrap_cal_count() {
local cal_before
cal_before=$(_get_cal_count)
printf " wrapping: %s\n" "$*" #>&2
#time \
"$@" || return 1
local cal_after
cal_after=$(_get_cal_count)
local delta=$(( ${cal_after:-0} - ${cal_before:-0} ))
printf "Delta-CAL (IPI): %d\n" "$delta" #>&2
}
TEST_CLASSES_LIST="D2_CORE D2_DRIVER D2_KMS D2_PRIME D2_ATOMIC D2_VBL D2_STATE D2_LEASE D2_DP D2_DRMRES V0 V1 V2 V3 V4 V5 V6 V7"
DRM_CLASSES_LIST="DRM_UT_CORE DRM_UT_DRIVER DRM_UT_KMS DRM_UT_PRIME DRM_UT_ATOMIC DRM_UT_VBL DRM_UT_STATE DRM_UT_LEASE DRM_UT_DP DRM_UT_DRMRES"
function dd_setup_() {
local flags="${1:-+p}"
# Use $2 if provided, otherwise fallback to the full list
local CLASSES_LIST="$2"
local q=""
local C
# Safeguard: if list is empty, don't do anything
[[ -z "$CLASSES_LIST" ]] && echo "no classes!" && return 0
for C in $CLASSES_LIST; do
q+="class $C $flags ; "
done
#echo "sending: $q"
ddcmd "$q"
}
function dd_setup_test() {
modprobe test_dynamic_debug || return 1
dd_setup_ $1 "${2:-$TEST_CLASSES_LIST}"
}
function dd_setup_drm() {
dd_setup_ $1 "${2:-$DRM_CLASSES_LIST}"
}
function count_hits() {
local duration=60
[[ "$1" =~ ^[0-9]+$ ]] && { duration=$1; shift; }
local cmd_to_run=()
local custom_classes=""
while [[ $# -gt 0 ]]; do
if [[ "$1" == "--" ]]; then
shift
custom_classes="$*"
break
fi
cmd_to_run+=("$1")
shift
done
ddcmd reset_stats
dd_setup_drm "+c" "$custom_classes"
if [[ ${#cmd_to_run[@]} -gt 0 ]]; then
echo "Banging on: ${cmd_to_run[*]} (&)"
# Use eval so bash functions work
eval "${cmd_to_run[*]} &"
local cmd_pid=$!
sleep "$duration"
killall vkcube 2>/dev/null
kill "$cmd_pid" 2>/dev/null
else
sleep "$duration"
fi
dd_setup_drm "-c" "$custom_classes"
tail -n1 /proc/dynamic_debug/control
}
function hammer_vk() {
for i in {1..12}; do vkcube >/dev/null 2>&1 & done
}
function isolate_drm_hits() {
local duration=${1:-10}
local cmd=${2:-vkcube}
echo "Starting isolation study: ${duration}s per class using ${cmd}"
echo "----------------------------------------------------------"
printf "%-20s | %-10s\n" "DRM CLASS" "TOTAL HITS"
echo "----------------------------------------------------------"
for class in $DRM_CLASSES_LIST FOO; do
# Run count_hits for the specific class
# Use 'capture' logic to grab only the hit count from the tail output
result=$(count_hits "$duration" "$cmd" -- "$class" | grep "total hits" | awk '{print $NF}')
printf "%-20s | %-10s\n" "$class" "$result"
done
#result=$(count_hits "$duration" "$cmd" -- "FOO" | grep "total hits" | awk '{print $NF}')
#printf "%-20s | %-10s\n" "$class" "$result"
}
[ $SHLVL == 2 -a -n "$*" ] && echo " doing: $* in $PWD" #>&2
if [ $SHLVL == 2 ]; then
# run args as cmd
$@
fi
---
include/linux/dynamic_debug.h | 40 +++++++++++++++++++++++++++----------
lib/dynamic_debug.c | 46 +++++++++++++++++++++++++++++++++++++++----
2 files changed, 72 insertions(+), 14 deletions(-)
diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
index dc755a24f1d6..d228b4a852c3 100644
--- a/include/linux/dynamic_debug.h
+++ b/include/linux/dynamic_debug.h
@@ -41,6 +41,9 @@ struct _ddebug {
#define _DPRINTK_FLAGS_INCL_TID (1<<4)
#define _DPRINTK_FLAGS_INCL_SOURCENAME (1<<5)
#define _DPRINTK_FLAGS_INCL_STACK (1<<6)
+#define _DPRINTK_FLAGS_COUNT (1<<7)
+
+#define _DPRINTK_FLAGS_BRANCH (_DPRINTK_FLAGS_PRINT | _DPRINTK_FLAGS_COUNT)
#define _DPRINTK_FLAGS_INCL_ANY \
(_DPRINTK_FLAGS_INCL_MODNAME | _DPRINTK_FLAGS_INCL_FUNCNAME |\
@@ -375,13 +378,13 @@ void __dynamic_ibdev_dbg(struct _ddebug *descriptor,
#define _DPRINTK_KEY_INIT .key.dd_key_true = (STATIC_KEY_TRUE_INIT)
-#define DYNAMIC_DEBUG_BRANCH(descriptor) \
- static_branch_likely(&descriptor.key.dd_key_true)
+#define __DYNAMIC_DEBUG_BRANCH(descriptor) \
+ static_branch_likely(&(descriptor).key.dd_key_true)
#else
#define _DPRINTK_KEY_INIT .key.dd_key_false = (STATIC_KEY_FALSE_INIT)
-#define DYNAMIC_DEBUG_BRANCH(descriptor) \
- static_branch_unlikely(&descriptor.key.dd_key_false)
+#define __DYNAMIC_DEBUG_BRANCH(descriptor) \
+ static_branch_unlikely(&(descriptor).key.dd_key_false)
#endif
#else /* !CONFIG_JUMP_LABEL */
@@ -389,15 +392,30 @@ void __dynamic_ibdev_dbg(struct _ddebug *descriptor,
#define _DPRINTK_KEY_INIT
#ifdef DEBUG
-#define DYNAMIC_DEBUG_BRANCH(descriptor) \
- likely(descriptor.flags & _DPRINTK_FLAGS_PRINT)
+#define __DYNAMIC_DEBUG_BRANCH(descriptor) \
+ likely((descriptor).flags & _DPRINTK_FLAGS_BRANCH)
#else
-#define DYNAMIC_DEBUG_BRANCH(descriptor) \
- unlikely(descriptor.flags & _DPRINTK_FLAGS_PRINT)
+#define __DYNAMIC_DEBUG_BRANCH(descriptor) \
+ unlikely((descriptor).flags & _DPRINTK_FLAGS_BRANCH)
#endif
#endif /* CONFIG_JUMP_LABEL */
+void ddebug_increment_call_count(void);
+#define DYNAMIC_DEBUG_COUNT(descriptor) do { \
+ if (unlikely((descriptor).flags & _DPRINTK_FLAGS_COUNT)) \
+ ddebug_increment_call_count(); \
+} while (0)
+
+#define DYNAMIC_DEBUG_BRANCH(descriptor) ({ \
+ bool __dd_print = false; \
+ if (__DYNAMIC_DEBUG_BRANCH(descriptor)) { \
+ DYNAMIC_DEBUG_COUNT(descriptor); \
+ __dd_print = !!((descriptor).flags & _DPRINTK_FLAGS_PRINT); \
+ } \
+ __dd_print; \
+})
+
/*
* Factory macros: ($prefix)dynamic_func_call($suffix)
*
@@ -409,6 +427,7 @@ void __dynamic_ibdev_dbg(struct _ddebug *descriptor,
* (|_cls): adds in _DPRINT_CLASS_DFLT as needed
* (|_no_desc): former gets callsite descriptor as 1st arg (for prdbgs)
*/
+
#define __dynamic_func_call_cls(id, cls, fmt, func, ...) do { \
DEFINE_DYNAMIC_DEBUG_METADATA_CLS(id, cls, fmt); \
if (DYNAMIC_DEBUG_BRANCH(id)) { \
@@ -423,8 +442,8 @@ void __dynamic_ibdev_dbg(struct _ddebug *descriptor,
#define __dynamic_func_call_cls_no_desc(id, cls, fmt, func, ...) do { \
DEFINE_DYNAMIC_DEBUG_METADATA_CLS(id, cls, fmt); \
if (DYNAMIC_DEBUG_BRANCH(id)) { \
- func(__VA_ARGS__); \
- __dynamic_dump_stack(id); \
+ func(__VA_ARGS__); \
+ __dynamic_dump_stack(id); \
} \
} while (0)
#define __dynamic_func_call_no_desc(id, fmt, func, ...) \
@@ -512,6 +531,7 @@ void __dynamic_ibdev_dbg(struct _ddebug *descriptor,
#define DYNAMIC_DEBUG_CLASSMAP_PARAM_REF(_name, _bits, _var, _flags) \
module_param_named(_name, _bits, uint, 0600)
#define DEFINE_DYNAMIC_DEBUG_METADATA(name, fmt)
+#define __DYNAMIC_DEBUG_BRANCH(descriptor) false
#define DYNAMIC_DEBUG_BRANCH(descriptor) false
#define DECLARE_DYNDBG_CLASSMAP(...)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 023784dcdc80..47a830dbd564 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -19,12 +19,14 @@
#include <linux/kallsyms.h>
#include <linux/types.h>
#include <linux/mutex.h>
+#include <linux/percpu.h>
#include <linux/proc_fs.h>
#include <linux/seq_file.h>
#include <linux/list.h>
#include <linux/sysctl.h>
#include <linux/ctype.h>
#include <linux/string.h>
+
#include <linux/parser.h>
#include <linux/string_helpers.h>
#include <linux/uaccess.h>
@@ -71,6 +73,21 @@ struct flag_settings {
unsigned int mask;
};
+static DEFINE_PER_CPU(unsigned long, ddebug_call_count);
+void ddebug_increment_call_count(void)
+{
+ this_cpu_inc(ddebug_call_count);
+}
+EXPORT_SYMBOL(ddebug_increment_call_count);
+
+static void reset_ddebug_call_count(void)
+{
+ int cpu;
+
+ for_each_possible_cpu(cpu)
+ per_cpu(ddebug_call_count, cpu) = 0;
+}
+
static bool ddebug_class_map_in_range(const int class_id,
const struct ddebug_class_map *map);
static bool ddebug_class_user_in_range(const int class_id,
@@ -101,6 +118,7 @@ static const struct { unsigned flag:8; char opt_char; } opt_array[] = {
{ _DPRINTK_FLAGS_INCL_LINENO, 'l' },
{ _DPRINTK_FLAGS_INCL_TID, 't' },
{ _DPRINTK_FLAGS_INCL_STACK, 'd' },
+ { _DPRINTK_FLAGS_COUNT, 'c' },
{ _DPRINTK_FLAGS_NONE, '_' },
};
@@ -364,10 +382,10 @@ static int ddebug_change(const struct ddebug_query *query, struct flag_settings
if (newflags == dp->flags)
continue;
#ifdef CONFIG_JUMP_LABEL
- if (dp->flags & _DPRINTK_FLAGS_PRINT) {
- if (!(newflags & _DPRINTK_FLAGS_PRINT))
+ if (dp->flags & _DPRINTK_FLAGS_BRANCH) {
+ if (!(newflags & _DPRINTK_FLAGS_BRANCH))
static_branch_disable(&dp->key.dd_key_true);
- } else if (newflags & _DPRINTK_FLAGS_PRINT) {
+ } else if (newflags & _DPRINTK_FLAGS_BRANCH) {
static_branch_enable(&dp->key.dd_key_true);
}
#endif
@@ -726,6 +744,12 @@ static int ddebug_exec_queries(char *query, const char *modname)
if (!query || !*query || *query == '#')
continue;
+ if (!strncmp(query, "reset_stats", 11) &&
+ !*skip_spaces_and_commas(query + 11)) {
+ reset_ddebug_call_count();
+ continue;
+ }
+
if (modname)
v2pr_info("query %d: module %s \"%s\"\n", i, modname, query);
else
@@ -1105,6 +1129,7 @@ static __init int dyndbg_setup(char *str)
__setup("dyndbg=", dyndbg_setup);
+
/*
* File_ops->write method for <debugfs>/dynamic_debug/control. Gathers the
* command text from userspace, parses and executes it.
@@ -1262,6 +1287,16 @@ static const char *ddebug_class_name(struct _ddebug_info *di, struct _ddebug *dp
return NULL;
}
+static unsigned long get_ddebug_call_count(void)
+{
+ unsigned long total = 0;
+ int cpu;
+
+ for_each_possible_cpu(cpu)
+ total += per_cpu(ddebug_call_count, cpu);
+ return total;
+}
+
/*
* Seq_ops show method. Called several times within a read()
* call from userspace, with ddebug_lock held. Formats the
@@ -1281,7 +1316,10 @@ static int ddebug_proc_show(struct seq_file *m, void *p)
return 0;
}
if (p == EPILOGUE_TOKEN) {
- /* use this soon */
+ unsigned long count = get_ddebug_call_count();
+
+ if (count)
+ seq_printf(m, "#: counted_calls: %lu\n", count);
return 0;
}
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 37/40] dyndbg: add DEBUG-biased fallback stubs for _dynamic_func_call_cls
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (35 preceding siblings ...)
2026-10-13 2:37 ` [PATCH v12 36/40] dyndbg: add +c flag to count pr_debug calls without printing Jim Cromie via B4 Relay
@ 2026-10-13 2:37 ` Jim Cromie via B4 Relay
2026-10-13 2:37 ` [PATCH v12 38/40] dyndbg: harden classmap and descriptor validation Jim Cromie via B4 Relay
` (2 subsequent siblings)
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:37 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie,
kernel test robot
From: Jim Cromie <jim.cromie@gmail.com>
When the dynamic debug core is enabled (CONFIG_DYNAMIC_DEBUG_CORE=y) but
the global CONFIG_DYNAMIC_DEBUG is disabled, subsystems can opt-in to
dynamic debug by defining DYNAMIC_DEBUG_MODULE.
However, for built-in code (like DRM core) where DYNAMIC_DEBUG_MODULE
is not defined, the macros fall back to the disabled #else block in
include/linux/dynamic_debug.h.
In this block, the family of _dynamic_func_call_cls macros were
completely undefined. This caused build failures (implicit declarations)
in subsystems (like DRM) that attempt to use these macros to wrap their
own debug functions even when dynamic debug is disabled.
Add stub definitions that mirror the enabled behavior and respect the
DEBUG macro, similar to pr_debug. If DEBUG is defined, they inject NULL
as the first argument (to satisfy the expected descriptor pointer) and
pass the arguments through, allowing the wrapped function's own slow-path
fallback logic to execute. If DEBUG is not defined, they use an if (0)
statement-expression to compile out the call while returning 0, achieving
zero overhead while maintaining compile-time argument checking.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202605201408.x1sHT6fx-lkp@intel.com/
Assisted-by: Gemini-CLI:gemini-2.5-pro
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
include/linux/dynamic_debug.h | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
index d228b4a852c3..2bd464f1081d 100644
--- a/include/linux/dynamic_debug.h
+++ b/include/linux/dynamic_debug.h
@@ -535,6 +535,23 @@ void ddebug_increment_call_count(void);
#define DYNAMIC_DEBUG_BRANCH(descriptor) false
#define DECLARE_DYNDBG_CLASSMAP(...)
+#if defined(DEBUG)
+#define _dynamic_func_call_cls(cls, fmt, func, ...) \
+ do { func(NULL, ##__VA_ARGS__); } while (0)
+#define _dynamic_func_call_cls_no_desc(cls, fmt, func, ...) \
+ do { func(__VA_ARGS__); } while (0)
+#else
+#define _dynamic_func_call_cls(cls, fmt, func, ...) \
+ do { if (0) func(NULL, ##__VA_ARGS__); } while (0)
+#define _dynamic_func_call_cls_no_desc(cls, fmt, func, ...) \
+ do { if (0) func(__VA_ARGS__); } while (0)
+#endif
+
+#define _dynamic_func_call(fmt, func, ...) \
+ _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
+#define _dynamic_func_call_no_desc(fmt, func, ...) \
+ _dynamic_func_call_cls_no_desc(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
+
#define dynamic_pr_debug(fmt, ...) \
no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
#define dynamic_dev_dbg(dev, fmt, ...) \
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 38/40] dyndbg: harden classmap and descriptor validation
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (36 preceding siblings ...)
2026-10-13 2:37 ` [PATCH v12 37/40] dyndbg: add DEBUG-biased fallback stubs for _dynamic_func_call_cls Jim Cromie via B4 Relay
@ 2026-10-13 2:37 ` Jim Cromie via B4 Relay
2026-10-13 2:37 ` [PATCH v12 39/40] selftests/dyndbg: Add FT_count_calls to test +c flag Jim Cromie via B4 Relay
2026-10-13 2:37 ` [PATCH v12 40/40] drm: Mark __drm_debug as __read_mostly Jim Cromie via B4 Relay
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:37 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie
From: Jim Cromie <jim.cromie@gmail.com>
Dynamic debug classmaps allow modules to _DEFINE and/or _USE multiple
classmaps, but this requires coordination amongst the classmaps.
Previously, class validation done by DYNAMIC_DEBUG_CLASSMAP_DEFINE at
compile-time, and ddebug_class_range_overlap() at modprobe-time, was
incomplete, and DYNAMIC_DEBUG_CLASSMAP_USE_ had no validation. This
could allow broken classmaps, making them harder to use well.
This commit improves classmap and descriptor validation:
- Unify runtime overlap and bounds checking across _DEFINE'd and _USE'd
classmaps in ddebug_validate_class_range(), enforcing symmetry and the
<= 62 upper bound for both.
- Split runtime validation out of ddebug_add_module() into dedicated
helpers: ddebug_validate_classmaps() (fatal, returns boolean pass/fail)
and ddebug_validate_descs() (scans callsites and emits an advisory
warning once per unknown class_id).
- Downgrade the global WARN_ONCE in ddebug_match_desc() to a
pr_warn_ratelimited, since orphaned class IDs are now tracked and
warned about early at module load.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
v11:
. factor runtime classmap validation out of ddebug_add_module() into
ddebug_validate_classmaps() and ddebug_validate_descs().
. unify overlap and bounds checking across maps and users in
ddebug_validate_class_range().
v10:
. fix pr_warn_ratelimited() line wrap in ddebug_match_desc().
---
lib/dynamic_debug.c | 92 ++++++++++++++++++----
lib/test_dynamic_debug.c | 16 ++--
.../selftests/dynamic_debug/dyndbg_selftest.sh | 22 +++---
3 files changed, 99 insertions(+), 31 deletions(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 47a830dbd564..0b90ea198499 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -329,7 +329,8 @@ static bool ddebug_match_desc(const struct ddebug_query *query,
/* site is class'd */
site_map = ddebug_find_map_by_class_id(di, dp->class_id);
if (!site_map) {
- WARN_ONCE(1, "unknown class_id %d, check %s's CLASSMAP definitions", dp->class_id, di->mod_name);
+ pr_warn_ratelimited("unknown class_id %d, check %s's CLASSMAP definitions\n",
+ dp->class_id, di->mod_name);
return false;
}
/* module(-param) decides protection */
@@ -1580,18 +1581,80 @@ static void ddebug_apply_class_users(const struct _ddebug_info *di)
__di->_vec.start = __start; \
})
-static int ddebug_class_range_overlap(struct ddebug_class_map *cm, u64 *reserved_ids)
+static bool ddebug_validate_class_range(const char *modname,
+ const char *name,
+ int base, int length,
+ u64 *reserved_ids)
{
- u64 range = (((1ULL << cm->length) - 1) << cm->base);
+ u64 range;
+ if (base < 0 || length <= 0 ||
+ base + length > _DPRINTK_CLASS_DFLT) {
+ pr_err("module %s: base:%d len:%d (from %s) exceeds class_id limit %d\n",
+ modname, base, length, name, _DPRINTK_CLASS_DFLT);
+ return false;
+ }
+ range = (((1ULL << length) - 1) << base);
if (range & *reserved_ids) {
- pr_err("[%d..%d] on %s conflicts with %llx\n", cm->base,
- cm->base + cm->length - 1, cm->class_names[0],
- *reserved_ids);
- return -EINVAL;
+ pr_err("module %s: [%d..%d] (from %s) conflicts with 0x%llx\n",
+ modname, base, base + length - 1, name, *reserved_ids);
+ return false;
}
*reserved_ids |= range;
- return 0;
+ return true;
+}
+
+static bool ddebug_validate_classmaps(struct _ddebug_info *di)
+{
+ struct ddebug_class_map *cm;
+ struct ddebug_class_user *cli;
+ u64 reserved_ids = 0;
+ bool valid = true;
+ int i;
+
+ for_subvec(i, cm, di, maps)
+ if (!ddebug_validate_class_range(di->mod_name,
+ cm->class_names[0],
+ cm->base, cm->length,
+ &reserved_ids))
+ valid = false;
+
+ for_subvec(i, cli, di, users) {
+ if (!cli->map) {
+ pr_err("module %s: classmap not found for user\n",
+ di->mod_name);
+ valid = false;
+ continue;
+ }
+ if (!ddebug_validate_class_range(di->mod_name,
+ cli->map->class_names[0],
+ cli->map->base + cli->offset,
+ cli->map->length,
+ &reserved_ids))
+ valid = false;
+ }
+ return valid;
+}
+
+static void ddebug_validate_descs(struct _ddebug_info *di)
+{
+ struct _ddebug *dp;
+ u64 bad_ids = 0;
+ int i;
+
+ for (i = 0; i < di->descs.len; i++) {
+ dp = &di->descs.start[i];
+
+ if (dp->class_id == _DPRINTK_CLASS_DFLT)
+ continue;
+ if (bad_ids & (1ULL << dp->class_id))
+ continue;
+ if (!ddebug_find_map_by_class_id(di, dp->class_id)) {
+ pr_warn("module %s uses unknown class_id %d\n",
+ di->mod_name, dp->class_id);
+ bad_ids |= (1ULL << dp->class_id);
+ }
+ }
}
/*
@@ -1603,7 +1666,6 @@ static int ddebug_add_module(struct _ddebug_info *di)
struct ddebug_table *dt;
struct ddebug_class_map *cm;
struct ddebug_class_user *cli;
- u64 reserved_ids = 0;
int i;
if (!di->descs.len)
@@ -1635,10 +1697,10 @@ static int ddebug_add_module(struct _ddebug_info *di)
dd_set_module_subrange(i, cm, &dt->info, maps);
dd_set_module_subrange(i, cli, &dt->info, users);
- /* insure 2+ classmaps share the per-module 0..62 class_id space */
- for_subvec(i, cm, &dt->info, maps)
- if (ddebug_class_range_overlap(cm, &reserved_ids))
- goto cleanup;
+ if (!ddebug_validate_classmaps(&dt->info))
+ goto cleanup;
+
+ ddebug_validate_descs(&dt->info);
/*
* Bind controlling_param before publishing dt to ddebug_tables so
@@ -1665,7 +1727,7 @@ static int ddebug_add_module(struct _ddebug_info *di)
dt->info.descs.len, dt->info.mod_name);
return 0;
cleanup:
- WARN_ONCE(1, "dyndbg multi-classmap conflict in %s\n", di->mod_name);
+ pr_err("dyndbg multi-classmap conflict in %s\n", di->mod_name);
kfree(dt);
return -EINVAL;
}
@@ -1753,7 +1815,7 @@ static int ddebug_module_notify(struct notifier_block *self, unsigned long val,
mod->dyndbg_info.mod_name = mod->name;
ret = ddebug_add_module(&mod->dyndbg_info);
if (ret)
- WARN(1, "Failed to allocate memory: dyndbg may not work properly.\n");
+ pr_err("dyndbg: failed to add module %s: %d\n", mod->name, ret);
break;
case MODULE_STATE_GOING:
ddebug_remove_module(mod->name);
diff --git a/lib/test_dynamic_debug.c b/lib/test_dynamic_debug.c
index 35bb411c48d8..aaf8aad481a0 100644
--- a/lib/test_dynamic_debug.c
+++ b/lib/test_dynamic_debug.c
@@ -173,14 +173,20 @@ DYNAMIC_DEBUG_CLASSMAP_DEFINE(fail_base_len, 0, 60,
#endif
#else /* TEST_DYNAMIC_DEBUG_SUBMOD */
-
/*
- * in submod/drm-drivers, use the classmaps defined in top/parent
- * module above.
+ * In submod (drm-drivers/helpers) use the classmaps defined in
+ * top/parent module above. We _USE_() with offset, to test the
+ * non-zero case.
*/
-
DYNAMIC_DEBUG_CLASSMAP_USE(map_disjoint_bits);
-DYNAMIC_DEBUG_CLASSMAP_USE_(map_level_num, 7);
+/*
+ * maybe force failure of runtime sanity test of classmap.length + offset < 63
+ */
+#if !defined(DD_RUNTIME_CLASS_CHECK)
+DYNAMIC_DEBUG_CLASSMAP_USE_(map_level_num, 8);
+#else
+DYNAMIC_DEBUG_CLASSMAP_USE_(map_level_num, 55);
+#endif
#if defined(DD_MACRO_ARGCHECK)
DYNAMIC_DEBUG_CLASSMAP_USE_(fail_offset_big, 100);
diff --git a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
index e439f367386c..109f11b2649e 100755
--- a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
+++ b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
@@ -576,12 +576,12 @@ function GOLDEN_RECORDS {
#K= c518a50ba30ba8099d0dc874a27ecf16 FT_multi_query.4
#K= 91838b4012c50a1dc1d9e210ba8d68f8 FT_test_classes.1
#K= a15ec4843acd721fbdfddc0b512c8032 FT_test_classes.2
-#K= 2cee6842c9cdee5cb3bf50b2e3914813 FT_test_classes.3
-#K= 81b16613f8d444485e2bc5aa4d38d024 FT_classmap_inheritance.1
-#K= c14c8aa758e24046b3237d20e2189bf7 FT_classmap_inheritance.2
+#K= c03cd07445ca93358176130f04320ee7 FT_test_classes.3
+#K= 1489b3b72dbdfdb553cc0c6594c4face FT_classmap_inheritance.1
+#K= e11c22649735cedb6c30321378100e11 FT_classmap_inheritance.2
#K= 5d0f3701517aa3a461c8887c332bdb42 FT_classmap_inheritance.3
-#K= f444ae312fcce32444c54da757d87c41 FT_classmap_inheritance.4
-#K= 0266e8d60659058ec589283022bf078c FT_classmap_inheritance.5
+#K= d39188ded831453d90d77390546b314d FT_classmap_inheritance.4
+#K= 62b6803edf43519186d6185bebf34352 FT_classmap_inheritance.5
#K= d2e8b8c5a5b4e7b9bbe1a29460a3c07d FT_modprobe_w_param.1
#K= d2e8b8c5a5b4e7b9bbe1a29460a3c07d FT_modprobe_w_param.2
#K= 20d8a1fac0330f1b5cc582ce93792d58 FT_modprobe_w_param.3
@@ -592,11 +592,11 @@ function GOLDEN_RECORDS {
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.8
#K= 535ab526b24a7214de41d92e94bbd52c FT_modprobe_w_param.9
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.10
-#K= 4f96e9cd2c92ab099cd35dad83c35e86 FT_modprobe_w_param.11
+#K= 64f91218760ca86d28a4b9b2d23849fb FT_modprobe_w_param.11
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.12
-#K= 80ca4d681dcd4c0046a4daa01e9b168a FT_modprobe_w_param.13
+#K= 03bad8f76b3587c2e8bdb9df43110a5e FT_modprobe_w_param.13
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.14
-#K= e0cdc3a8471acf34201539231b2b2110 FT_modprobe_w_param.15
+#K= 04b59fe2db45bc6bb314e9102b92dd64 FT_modprobe_w_param.15
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.16
#K= d682c98ced7d31f1555ab474a9ebe253 FT_modprobe_w_param.17
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.18
@@ -610,11 +610,11 @@ function GOLDEN_RECORDS {
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.26
#K= 8d2f4db3b7885064a56594e1d81deb26 FT_modprobe_w_param.27
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.28
-#K= b76a644b8d3c99bfd8df9220f4509828 FT_modprobe_w_param.29
+#K= 0658c273db527fb4fcaadbb142bf0565 FT_modprobe_w_param.29
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.30
-#K= dfc272b2a1f7a075e3a37dc491396adf FT_modprobe_w_param.31
+#K= 20cac1fd02b4615b337e84aa87892afc FT_modprobe_w_param.31
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.32
-#K= 24629bcce166addffcaae1232ef6a5a9 FT_modprobe_w_param.33
+#K= 8eb7924c66978d844e97bee9f91b981e FT_modprobe_w_param.33
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.34
#K= 28ace93a95da7aaea5b9b54a8656a2cf FT_modprobe_w_param.35
#K= 0239d8c0808eef396782362613f675b0 FT_modprobe_w_param.36
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 39/40] selftests/dyndbg: Add FT_count_calls to test +c flag
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (37 preceding siblings ...)
2026-10-13 2:37 ` [PATCH v12 38/40] dyndbg: harden classmap and descriptor validation Jim Cromie via B4 Relay
@ 2026-10-13 2:37 ` Jim Cromie via B4 Relay
2026-10-13 2:37 ` [PATCH v12 40/40] drm: Mark __drm_debug as __read_mostly Jim Cromie via B4 Relay
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:37 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie
From: Jim Cromie <jim.cromie@gmail.com>
Commit a2dafb8fcfc6 ("dyndbg: add +c flag to count pr_debug calls
without printing") introduced the +c call-counting flag and
reset_stats command, and commit 3b77a5088910 ("dyndbg: add epilogue
to dynamic_debug/control file") added the counted_calls epilogue.
However, neither was covered by the selftest script, leaving call
counting, scaling, zeroing, and print suppression unverified.
Add FT_count_calls to dyndbg_selftest.sh to exercise the full
lifecycle (baseline -> change -> verify):
0. Baseline reset: verify reset_stats clears the counted_calls epilogue.
1. Unenabled baseline: verify unflagged callsites yield 0 counts/prints.
2. Pure counting (+c): verify 11 calls counted with 0 syslog prints.
3. Scaling: verify count reaches 32 after additional repeat workload.
4. Zeroing: verify reset_stats drops count to 0 and clears epilogue.
5. Classmap-scoped: verify class D2_CORE +c increments count by 1.
6. Tandem mode (+pc): verify count is 11 and 11 syslog prints appear.
7. Flag clearing (-c): verify count stops while +p logging persists.
8. Teardown: clear flags, zero stats, and unload test_dynamic_debug.
Register FT_count_calls in modular_tests and update the LACK_TMOD
filter to skip it gracefully when modular dependencies are absent.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
.../selftests/dynamic_debug/dyndbg_selftest.sh | 146 ++++++++++++++++++++-
1 file changed, 145 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
index 109f11b2649e..c763949499eb 100755
--- a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
+++ b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh
@@ -471,6 +471,148 @@ function FT_modprobe_w_param {
ddcmd =_
}
+function FT_count_calls {
+ v_echo "${GREEN}# TEST_COUNT_CALLS - verify +c, -c, reset_stats${NC}"
+
+ if [ "${LACK_TMOD:-0}" -eq 1 ]; then
+ echo "SKIP - test requires test_dynamic_debug module"
+ return
+ fi
+
+ ifrmmod test_dynamic_debug_submod
+ ifrmmod test_dynamic_debug
+ my_modprobe test_dynamic_debug
+ ddcmd =_
+
+ local marker cnt hits
+
+ # 0. Baseline verification: reset_stats clears counter and epilogue
+ ddcmd reset_stats
+ cnt=$(awk '/^#: counted_calls:/ { print $3 }' /proc/dynamic_debug/control)
+ cnt=${cnt:-0}
+ if [ "$cnt" -ne 0 ]; then
+ echo -e "${RED}: baseline count expected 0, got $cnt${NC}"
+ exit $ksft_fail
+ fi
+
+ # 1. Baseline execution: unenabled callsites produce 0 counts and 0 prints
+ marker="FT_CNT_BASE_$$"
+ echo "$marker" > /dev/kmsg
+ set_param 1 /sys/module/test_dynamic_debug/parameters/do_bulk
+ cnt=$(awk '/^#: counted_calls:/ { print $3 }' /proc/dynamic_debug/control)
+ cnt=${cnt:-0}
+ hits=$(dmesg | sed -n "/$marker/,\$p" | grep -v "$marker" | \
+ grep -c "test_dd: ")
+ if [ "$cnt" -ne 0 ] || [ "$hits" -ne 0 ]; then
+ echo -e "${RED}: unenabled callsite counted ($cnt)" \
+ "or logged ($hits)${NC}"
+ exit $ksft_fail
+ fi
+ v_echo "${GREEN}: Baseline: 0 counts, 0 prints on unenabled callsites${NC}"
+
+ # 2. Pure counting (+c): counts call executions without syslog printing
+ ddcmd "module test_dynamic_debug func do_bulk +c"
+ marker="FT_CNT_PURE_$$"
+ echo "$marker" > /dev/kmsg
+ set_param 1 /sys/module/test_dynamic_debug/parameters/do_bulk
+ cnt=$(awk '/^#: counted_calls:/ { print $3 }' /proc/dynamic_debug/control)
+ cnt=${cnt:-0}
+ hits=$(dmesg | sed -n "/$marker/,\$p" | grep -v "$marker" | \
+ grep -c "test_dd: ")
+ # do_bulk(1) executes 1 header + 10 bulk prints = 11 calls
+ if [ "$cnt" -ne 11 ]; then
+ echo -e "${RED}: pure +c count mismatch: expected 11, got $cnt${NC}"
+ exit $ksft_fail
+ fi
+ if [ "$hits" -ne 0 ]; then
+ echo -e "${RED}: pure +c leaked $hits prints to dmesg!${NC}"
+ exit $ksft_fail
+ fi
+ v_echo "${GREEN}: Proven: +c counted exactly $cnt calls with 0 prints${NC}"
+
+ # 3. Scaling verification: additional iterations accumulate accurately
+ set_param 2 /sys/module/test_dynamic_debug/parameters/do_bulk
+ cnt=$(awk '/^#: counted_calls:/ { print $3 }' /proc/dynamic_debug/control)
+ cnt=${cnt:-0}
+ # previous 11 + (1 header + 20 bulk prints = 21) = 32 calls
+ if [ "$cnt" -ne 32 ]; then
+ echo -e "${RED}: accumulated count mismatch: expected 32, got $cnt${NC}"
+ exit $ksft_fail
+ fi
+ v_echo "${GREEN}: Proven: accumulated count scaled to $cnt calls${NC}"
+
+ # 4. reset_stats clears active counter
+ ddcmd reset_stats
+ cnt=$(awk '/^#: counted_calls:/ { print $3 }' /proc/dynamic_debug/control)
+ cnt=${cnt:-0}
+ if [ "$cnt" -ne 0 ]; then
+ echo -e "${RED}: reset_stats failed: expected 0, got $cnt${NC}"
+ exit $ksft_fail
+ fi
+ v_echo "${GREEN}: Proven: reset_stats zeroed counter and epilogue${NC}"
+
+ # 5. Class-mapped call counting: verify +c on class-specific callsites
+ ddcmd =_
+ ddcmd "class D2_CORE +c"
+ set_param 1 /sys/module/test_dynamic_debug/parameters/do_classes
+ cnt=$(awk '/^#: counted_calls:/ { print $3 }' /proc/dynamic_debug/control)
+ cnt=${cnt:-0}
+ # do_classes(1) triggers do_cats() which calls D2_CORE once
+ if [ "$cnt" -ne 1 ]; then
+ echo -e "${RED}: class +c count mismatch: expected 1, got $cnt${NC}"
+ exit $ksft_fail
+ fi
+ v_echo "${GREEN}: Proven: class D2_CORE +c counted exactly $cnt call${NC}"
+
+ # 6. Simultaneous print and count (+pc): both operate in tandem
+ ddcmd reset_stats
+ ddcmd =_
+ ddcmd "module test_dynamic_debug func do_bulk +pc"
+ marker="FT_CNT_PC_$$"
+ echo "$marker" > /dev/kmsg
+ set_param 1 /sys/module/test_dynamic_debug/parameters/do_bulk
+ cnt=$(awk '/^#: counted_calls:/ { print $3 }' /proc/dynamic_debug/control)
+ cnt=${cnt:-0}
+ hits=$(dmesg | sed -n "/$marker/,\$p" | grep -v "$marker" | \
+ grep -c "test_dd: ")
+ if [ "$cnt" -ne 11 ]; then
+ echo -e "${RED}: +pc count mismatch: expected 11, got $cnt${NC}"
+ exit $ksft_fail
+ fi
+ if [ "$hits" -ne 11 ]; then
+ echo -e "${RED}: +pc print mismatch: expected 11, got $hits${NC}"
+ exit $ksft_fail
+ fi
+ v_echo "${GREEN}: Proven: +pc counted $cnt calls" \
+ "and logged $hits prints${NC}"
+
+ # 7. Disabling counter (-c): preserves printing (+p), stops count
+ ddcmd reset_stats
+ ddcmd "module test_dynamic_debug func do_bulk -c"
+ marker="FT_CNT_NOC_$$"
+ echo "$marker" > /dev/kmsg
+ set_param 1 /sys/module/test_dynamic_debug/parameters/do_bulk
+ cnt=$(awk '/^#: counted_calls:/ { print $3 }' /proc/dynamic_debug/control)
+ cnt=${cnt:-0}
+ hits=$(dmesg | sed -n "/$marker/,\$p" | grep -v "$marker" | \
+ grep -c "test_dd: ")
+ if [ "$cnt" -ne 0 ]; then
+ echo -e "${RED}: -c unsetting failed: expected 0, got $cnt${NC}"
+ exit $ksft_fail
+ fi
+ if [ "$hits" -ne 11 ]; then
+ echo -e "${RED}: -c print mismatch: expected 11, got $hits${NC}"
+ exit $ksft_fail
+ fi
+ v_echo "${GREEN}: Proven: -c stopped count accumulation" \
+ "while retaining +p${NC}"
+
+ # Teardown
+ ddcmd =_
+ ddcmd reset_stats
+ ifrmmod test_dynamic_debug
+}
+
# Built-in Feature Tests (Can run on any CONFIG_DYNAMIC_DEBUG kernel, modular or monolithic)
builtin_tests=(
FT_grammar_ok
@@ -485,6 +627,7 @@ modular_tests=(
FT_test_classes
FT_classmap_inheritance
FT_modprobe_w_param
+ FT_count_calls
)
# ==============================================================================
@@ -637,7 +780,8 @@ EO_DYNDBG_GOLDEN_REFS
local label=$(echo "$line" | awk '{print $3}')
if [[ "$label" == FT_test_classes* \
|| "$label" == FT_classmap_inheritance* \
- || "$label" == FT_modprobe_w_param* ]]; then
+ || "$label" == FT_modprobe_w_param* \
+ || "$label" == FT_count_calls* ]]; then
continue
fi
fi
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread* [PATCH v12 40/40] drm: Mark __drm_debug as __read_mostly
2026-10-13 2:36 [PATCH v12 00/40] dyndbg: Fix classmaps API for subsystems, query extensions, selftests Jim Cromie via B4 Relay
` (38 preceding siblings ...)
2026-10-13 2:37 ` [PATCH v12 39/40] selftests/dyndbg: Add FT_count_calls to test +c flag Jim Cromie via B4 Relay
@ 2026-10-13 2:37 ` Jim Cromie via B4 Relay
39 siblings, 0 replies; 42+ messages in thread
From: Jim Cromie via B4 Relay @ 2026-10-13 2:37 UTC (permalink / raw)
To: Jason Baron, Shuah Khan, Andrew Morton, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Arnd Bergmann, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, Jonathan Corbet, Greg Kroah-Hartman,
Nathan Chancellor, Nicolas Schier, Shuah Khan, Randy Dunlap,
Rafael J. Wysocki, Pavel Machek, Len Brown, Jonathan Corbet,
Petr Mladek, Steven Rostedt, John Ogness, Sergey Senozhatsky,
Thomas Weißschuh
Cc: linux-kernel, linux-kselftest, dri-devel, linux-arch,
linux-modules, linux-doc, linux-kbuild, linux-pm, Jim Cromie
From: Jim Cromie <jim.cromie@gmail.com>
Dyndbg classmaps converts ~5,700 DRM debug callsites into static keys,
yielding 0-off-cost NOOPs that never touch memory. However, several
call patterns do not fit the direct drm_dbg() macro model; notably
open-coded drm_debug_enabled() guard blocks, drm_dbg_printer(), and
ratelimited helpers.
In upstream, the linker places __drm_debug in the same 64-byte
cacheline as hot writers: drm_lease_idr_object, drm_global_mutex.
Writes to those locks issue Request-For-Ownership (RFO) invalidations
across cores, leaving those residual bit-tests to suffer 7
false-sharing hazards and continuous cache bouncing during active
rendering (e.g. 12 concurrent vkcube clients). In contrast, writes to
__drm_debug occur almost never, only when userspace updates
"/sys/module/drm/parameters/debug".
So mark __drm_debug with __read_mostly. This isolates it from the 7
writable symbols it currently shares a cache-line with, eliminating
those invalidations.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
drivers/gpu/drm/drm_print.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_print.c b/drivers/gpu/drm/drm_print.c
index 794417c62097..1ec139c8f06f 100644
--- a/drivers/gpu/drm/drm_print.c
+++ b/drivers/gpu/drm/drm_print.c
@@ -40,7 +40,7 @@
* __drm_debug: Enable debug output.
* Bitmask of DRM_UT_x. See include/drm/drm_print.h for details.
*/
-u32 __drm_debug;
+u32 __drm_debug __read_mostly;
EXPORT_SYMBOL(__drm_debug);
MODULE_PARM_DESC(debug, "Enable debug output, where each bit enables a debug category.\n"
--
2.56.0
^ permalink raw reply related [flat|nested] 42+ messages in thread