From: jg1.han@samsung.com (Jingoo Han)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/7] drivers/pci/host: don't check resource with devm_ioremap_resource
Date: Wed, 15 Jan 2014 07:32:01 +0900 [thread overview]
Message-ID: <001701cf1178$7191ec10$54b5c430$%han@samsung.com> (raw)
In-Reply-To: <201401141417.03349.marex@denx.de>
On Tuesday, January 14, 2014 10:17 PM, Marek Vasut wrote:
> On Tuesday, January 14, 2014 at 12:58:55 PM, Wolfram Sang wrote:
> > devm_ioremap_resource does sanity checks on the given resource. No need to
> > duplicate this in the driver.
> >
> > Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
>
> True that,
>
> Acked-by: Marek Vasut <marex@denx.de>
(+cc Fabio Estevam)
Hi all,
The same patch was already sent by Fabio Estevam a month ago.[1]
Also, it was applied to pci/next tree.[2]
[1] http://www.spinics.net/lists/linux-pci/msg26873.html
[2] http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=next&id=ebb034a4ce9fc37877b3df2b85b9c33d43349586
Best regards,
Jingoo Han
>
> > ---
> >
> > Should go via subsystem tree
> >
> > drivers/pci/host/pci-imx6.c | 5 -----
> > 1 file changed, 5 deletions(-)
> >
> > diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c
> > index bd70af8..5002e23 100644
> > --- a/drivers/pci/host/pci-imx6.c
> > +++ b/drivers/pci/host/pci-imx6.c
> > @@ -426,11 +426,6 @@ static int __init imx6_pcie_probe(struct
> > platform_device *pdev) "imprecise external abort");
> >
> > dbi_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > - if (!dbi_base) {
> > - dev_err(&pdev->dev, "dbi_base memory resource not found\n");
> > - return -ENODEV;
> > - }
> > -
> > pp->dbi_base = devm_ioremap_resource(&pdev->dev, dbi_base);
> > if (IS_ERR(pp->dbi_base)) {
> > ret = PTR_ERR(pp->dbi_base);
>
> Best regards,
> Marek Vasut
prev parent reply other threads:[~2014-01-14 22:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1389700739-3696-1-git-send-email-wsa@the-dreams.de>
2014-01-14 11:58 ` [PATCH 4/7] drivers/pci/host: don't check resource with devm_ioremap_resource Wolfram Sang
2014-01-14 13:17 ` Marek Vasut
2014-01-14 22:32 ` Jingoo Han [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001701cf1178$7191ec10$54b5c430$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox