* [PATCH 4/7] drivers/pci/host: don't check resource with devm_ioremap_resource [not found] <1389700739-3696-1-git-send-email-wsa@the-dreams.de> @ 2014-01-14 11:58 ` Wolfram Sang 2014-01-14 13:17 ` Marek Vasut 0 siblings, 1 reply; 3+ messages in thread From: Wolfram Sang @ 2014-01-14 11:58 UTC (permalink / raw) To: linux-arm-kernel devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang <wsa@the-dreams.de> --- Should go via subsystem tree drivers/pci/host/pci-imx6.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c index bd70af8..5002e23 100644 --- a/drivers/pci/host/pci-imx6.c +++ b/drivers/pci/host/pci-imx6.c @@ -426,11 +426,6 @@ static int __init imx6_pcie_probe(struct platform_device *pdev) "imprecise external abort"); dbi_base = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!dbi_base) { - dev_err(&pdev->dev, "dbi_base memory resource not found\n"); - return -ENODEV; - } - pp->dbi_base = devm_ioremap_resource(&pdev->dev, dbi_base); if (IS_ERR(pp->dbi_base)) { ret = PTR_ERR(pp->dbi_base); -- 1.8.5.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 4/7] drivers/pci/host: don't check resource with devm_ioremap_resource 2014-01-14 11:58 ` [PATCH 4/7] drivers/pci/host: don't check resource with devm_ioremap_resource Wolfram Sang @ 2014-01-14 13:17 ` Marek Vasut 2014-01-14 22:32 ` Jingoo Han 0 siblings, 1 reply; 3+ messages in thread From: Marek Vasut @ 2014-01-14 13:17 UTC (permalink / raw) To: linux-arm-kernel On Tuesday, January 14, 2014 at 12:58:55 PM, Wolfram Sang wrote: > devm_ioremap_resource does sanity checks on the given resource. No need to > duplicate this in the driver. > > Signed-off-by: Wolfram Sang <wsa@the-dreams.de> True that, Acked-by: Marek Vasut <marex@denx.de> > --- > > Should go via subsystem tree > > drivers/pci/host/pci-imx6.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c > index bd70af8..5002e23 100644 > --- a/drivers/pci/host/pci-imx6.c > +++ b/drivers/pci/host/pci-imx6.c > @@ -426,11 +426,6 @@ static int __init imx6_pcie_probe(struct > platform_device *pdev) "imprecise external abort"); > > dbi_base = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!dbi_base) { > - dev_err(&pdev->dev, "dbi_base memory resource not found\n"); > - return -ENODEV; > - } > - > pp->dbi_base = devm_ioremap_resource(&pdev->dev, dbi_base); > if (IS_ERR(pp->dbi_base)) { > ret = PTR_ERR(pp->dbi_base); Best regards, Marek Vasut ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 4/7] drivers/pci/host: don't check resource with devm_ioremap_resource 2014-01-14 13:17 ` Marek Vasut @ 2014-01-14 22:32 ` Jingoo Han 0 siblings, 0 replies; 3+ messages in thread From: Jingoo Han @ 2014-01-14 22:32 UTC (permalink / raw) To: linux-arm-kernel On Tuesday, January 14, 2014 10:17 PM, Marek Vasut wrote: > On Tuesday, January 14, 2014 at 12:58:55 PM, Wolfram Sang wrote: > > devm_ioremap_resource does sanity checks on the given resource. No need to > > duplicate this in the driver. > > > > Signed-off-by: Wolfram Sang <wsa@the-dreams.de> > > True that, > > Acked-by: Marek Vasut <marex@denx.de> (+cc Fabio Estevam) Hi all, The same patch was already sent by Fabio Estevam a month ago.[1] Also, it was applied to pci/next tree.[2] [1] http://www.spinics.net/lists/linux-pci/msg26873.html [2] http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=next&id=ebb034a4ce9fc37877b3df2b85b9c33d43349586 Best regards, Jingoo Han > > > --- > > > > Should go via subsystem tree > > > > drivers/pci/host/pci-imx6.c | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c > > index bd70af8..5002e23 100644 > > --- a/drivers/pci/host/pci-imx6.c > > +++ b/drivers/pci/host/pci-imx6.c > > @@ -426,11 +426,6 @@ static int __init imx6_pcie_probe(struct > > platform_device *pdev) "imprecise external abort"); > > > > dbi_base = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > - if (!dbi_base) { > > - dev_err(&pdev->dev, "dbi_base memory resource not found\n"); > > - return -ENODEV; > > - } > > - > > pp->dbi_base = devm_ioremap_resource(&pdev->dev, dbi_base); > > if (IS_ERR(pp->dbi_base)) { > > ret = PTR_ERR(pp->dbi_base); > > Best regards, > Marek Vasut ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-14 22:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1389700739-3696-1-git-send-email-wsa@the-dreams.de>
2014-01-14 11:58 ` [PATCH 4/7] drivers/pci/host: don't check resource with devm_ioremap_resource Wolfram Sang
2014-01-14 13:17 ` Marek Vasut
2014-01-14 22:32 ` Jingoo Han
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox