From: Hari Prasath G E <gehariprasath@ti.com>
To: Pan Chuang <panchuang@vivo.com>, Nishanth Menon <nm@ti.com>,
"Santosh Shilimkar" <ssantosh@kernel.org>,
"open list:TI KEYSTONE MULTICORE NAVIGATOR DRIVERS"
<linux-kernel@vger.kernel.org>,
"moderated list:TI KEYSTONE MULTICORE NAVIGATOR DRIVERS"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 6/7] soc: ti: wkup_m3_ipc: Remove redundant dev_err()
Date: Mon, 20 Jul 2026 19:47:47 +0530 [thread overview]
Message-ID: <098cd973-3773-4ba1-b2ed-22545acc22bb@ti.com> (raw)
In-Reply-To: <20260720095920.542801-7-panchuang@vivo.com>
On 7/20/2026 3:29 PM, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
Thanks for the patch
Reviewed-by: Hari Prasath Gujulan Elango <gehariprasath@ti.com>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> ---
> drivers/soc/ti/wkup_m3_ipc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
> index 5845fc652adc..f8640cdc2a21 100644
> --- a/drivers/soc/ti/wkup_m3_ipc.c
> +++ b/drivers/soc/ti/wkup_m3_ipc.c
> @@ -630,10 +630,8 @@ static int wkup_m3_ipc_probe(struct platform_device *pdev)
>
> ret = devm_request_irq(dev, irq, wkup_m3_txev_handler,
> 0, "wkup_m3_txev", m3_ipc);
> - if (ret) {
> - dev_err(dev, "request_irq failed\n");
> + if (ret)
> return ret;
> - }
>
> m3_ipc->mbox_client.dev = dev;
> m3_ipc->mbox_client.tx_done = NULL;
next prev parent reply other threads:[~2026-07-20 14:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 9:59 [PATCH 0/7] soc: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-20 9:59 ` [PATCH 1/7] soc: fsl: dpio: Remove redundant dev_err() Pan Chuang
2026-07-20 9:59 ` [PATCH 2/7] soc: ixp4xx: " Pan Chuang
2026-07-20 9:59 ` [PATCH 3/7] soc: mediatek: mtk-svs: Remove redundant dev_err_probe() Pan Chuang
2026-07-20 9:59 ` [PATCH 6/7] soc: ti: wkup_m3_ipc: Remove redundant dev_err() Pan Chuang
2026-07-20 14:17 ` Hari Prasath G E [this message]
2026-07-20 9:59 ` [PATCH 7/7] soc: xilinx: " Pan Chuang
2026-07-20 15:50 ` Pandey, Radhey Shyam
2026-07-21 5:49 ` Michal Simek
2026-07-22 2:23 ` Pan Chuang
2026-07-24 16:38 ` (subset) [PATCH 0/7] soc: Remove redundant error messages on IRQ request failure Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=098cd973-3773-4ba1-b2ed-22545acc22bb@ti.com \
--to=gehariprasath@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=panchuang@vivo.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox