From: Pan Chuang <panchuang@vivo.com>
To: Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-kernel@vger.kernel.org (open list:ARM/Mediatek SoC support),
linux-arm-kernel@lists.infradead.org (moderated
list:ARM/Mediatek SoC support),
linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek
SoC support)
Cc: Pan Chuang <panchuang@vivo.com>
Subject: [PATCH 3/7] soc: mediatek: mtk-svs: Remove redundant dev_err_probe()
Date: Mon, 20 Jul 2026 17:59:09 +0800 [thread overview]
Message-ID: <20260720095920.542801-4-panchuang@vivo.com> (raw)
In-Reply-To: <20260720095920.542801-1-panchuang@vivo.com>
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err_probe() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/soc/mediatek/mtk-svs.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
index 99edecb204f2..39af0728ce61 100644
--- a/drivers/soc/mediatek/mtk-svs.c
+++ b/drivers/soc/mediatek/mtk-svs.c
@@ -2908,10 +2908,8 @@ static int svs_probe(struct platform_device *pdev)
ret = devm_request_threaded_irq(svsp->dev, svsp_irq, NULL, svs_isr,
IRQF_ONESHOT, svsp_data->name, svsp);
- if (ret) {
- dev_err_probe(svsp->dev, ret, "register irq(%d) failed\n", svsp_irq);
+ if (ret)
goto svs_probe_iounmap;
- }
ret = svs_start(svsp);
if (ret) {
--
2.34.1
next prev parent reply other threads:[~2026-07-20 10:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 9:59 [PATCH 0/7] soc: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-20 9:59 ` [PATCH 1/7] soc: fsl: dpio: Remove redundant dev_err() Pan Chuang
2026-07-20 9:59 ` [PATCH 2/7] soc: ixp4xx: " Pan Chuang
2026-07-20 9:59 ` Pan Chuang [this message]
2026-07-20 9:59 ` [PATCH 6/7] soc: ti: wkup_m3_ipc: " Pan Chuang
2026-07-20 14:17 ` Hari Prasath G E
2026-07-20 9:59 ` [PATCH 7/7] soc: xilinx: " Pan Chuang
2026-07-20 15:50 ` Pandey, Radhey Shyam
2026-07-21 5:49 ` Michal Simek
2026-07-22 2:23 ` Pan Chuang
2026-07-24 16:38 ` (subset) [PATCH 0/7] soc: Remove redundant error messages on IRQ request failure Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720095920.542801-4-panchuang@vivo.com \
--to=panchuang@vivo.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox