Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Horgan <ben.horgan@arm.com>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: james.morse@arm.com, fenghuay@nvidia.com,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, tglx@linutronix.de,
	mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
	hpa@zytor.com, corbet@lwn.net, x86@kernel.org,
	linux-doc@vger.kernel.org, dave.martin@arm.com
Subject: Re: [PATCH v4 2/3] arm_mpam: resctrl: Add pass-through resctrl_arch_preconvert_bw()
Date: Thu, 9 Jul 2026 10:25:54 +0100	[thread overview]
Message-ID: <0aa3bbbc-c0f0-404c-b03b-9113a1e91ce5@arm.com> (raw)
In-Reply-To: <8d5d9c98-54df-44fe-8795-189554ea2399@intel.com>

Hi Reinette,

On 7/7/26 15:51, Reinette Chatre wrote:
> Hi Ben,
> 
> On 7/7/26 1:35 AM, Ben Horgan wrote:
>> Hi Reinette,
>>
>> On 7/6/26 22:33, Reinette Chatre wrote:
>>> Hi Ben,
>>>
>>> On 7/6/26 9:06 AM, Ben Horgan wrote:
>>>> resctrl rounds up the percentage value of the MBA based on the bw_gran. As
>>>> MPAM uses a binary fixed point fraction format for MBA rather than a
>>>> decimal percentage, this introduces rounding errors.
>>>>
>>>> Without this additional rounding, if the user reads the value in an MB
>>>> schema and then writes it back to the schema, the value in hardware won't
>>>> change. However, with this additional rounding, this guarantee is broken
>>>> for systems with mbw_wd < 7.
>>>>
>>>> resctrl is introducing resctrl_arch_preconvert_bw() to allow the arch code
>>>> to specify the conversion resctrl does to the user-provided bandwidth
>>>> value. Add the MPAM version of resctrl_arch_preconvert_bw(). This does no
>>>> conversion.
>>>>
>>>> Signed-off-by: Ben Horgan <ben.horgan@arm.com>
>>>> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
>>>>
>>>
>>> Unfortunately the "---" separator is missing here.
>>
>> Another silly mistake.. sorry about that. I've corrected locally and
>> will send a respin in a day or two.
> No problem. 
> 
> When you respin, could you please add a snippet to the cover about expectations
> how this series should be merged? This will be the first piece of work that
> touches the x86 and Arm driver as well as resctrl fs code. So far I assumed it
> will go in via tip but I think it will help to state this from Arm side.

Yes, I was assuming that too. I'll make it explicit in the cover letter.

> We still need a plan for if/when the Arm side touches the same code though. Thankfully
> this work is small.

I'm open to whatever works best for you and the others involved.

Thanks,

Ben

> 
> Reinette



  reply	other threads:[~2026-07-09 10:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-06 16:06 [PATCH v4 0/3] x86,fs/resctrl,arm_mpam: Factor MBA parse-time conversion to be per-arch Ben Horgan
2026-07-06 16:06 ` [PATCH v4 1/3] x86,fs/resctrl: Add resctrl_arch_preconvert_bw() Ben Horgan
2026-07-06 21:33   ` Reinette Chatre
2026-07-07  8:33     ` Ben Horgan
2026-07-06 16:06 ` [PATCH v4 2/3] arm_mpam: resctrl: Add pass-through resctrl_arch_preconvert_bw() Ben Horgan
2026-07-06 21:33   ` Reinette Chatre
2026-07-07  8:35     ` Ben Horgan
2026-07-07 14:51       ` Reinette Chatre
2026-07-09  9:25         ` Ben Horgan [this message]
2026-07-06 16:06 ` [PATCH v4 3/3] fs/resctrl: Factor MBA parse-time conversion to be per-arch Ben Horgan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0aa3bbbc-c0f0-404c-b03b-9113a1e91ce5@arm.com \
    --to=ben.horgan@arm.com \
    --cc=bp@alien8.de \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=dave.martin@arm.com \
    --cc=fenghuay@nvidia.com \
    --cc=hpa@zytor.com \
    --cc=james.morse@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=reinette.chatre@intel.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox