public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: exynos4: Use drive strength 3 for SD pins
Date: Tue, 20 Nov 2012 18:18:44 +0900	[thread overview]
Message-ID: <0c2f01cdc700$09c204d0$1d460e70$%kim@samsung.com> (raw)
In-Reply-To: <21831256.UCkQ5RyKd5@amdc1227>

Tomasz Figa wrote:
> 
> This patch modifies pin control groups of SD pins on Exynos4210 and
> Exynos4x12 to use drive strength 3, which corresponds to
> S5P_GPIO_DRVSTR_LV4 in legacy non-DT code.
> 
Well, the value of drive strength depends on board not SoC. So if required,
it should be moved to board DT stuff.

BTW, we can use the value as a default...I need to think about that again
for exynos4210 and 4x12.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.


> This is needed at least on Origen board for sdhci2 to work.
> 
> Signed-off-by: Tomasz Figa <t.figa@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>  arch/arm/boot/dts/exynos4210-pinctrl.dtsi | 56 +++++++++++++++-----------
> -----
>  arch/arm/boot/dts/exynos4x12-pinctrl.dtsi | 56 +++++++++++++++-----------
> -----
>  2 files changed, 56 insertions(+), 56 deletions(-)

  reply	other threads:[~2012-11-20  9:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-19 14:52 [PATCH] ARM: dts: exynos4: Use drive strength 3 for SD pins Tomasz Figa
2012-11-20  9:18 ` Kukjin Kim [this message]
2012-11-20  9:35   ` Tomasz Figa
2012-11-20 11:10     ` Kukjin Kim
2012-11-21 10:35       ` Tomasz Figa
2012-11-21 12:10         ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='0c2f01cdc700$09c204d0$1d460e70$%kim@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox