From: t.figa@samsung.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: exynos4: Use drive strength 3 for SD pins
Date: Tue, 20 Nov 2012 10:35:30 +0100 [thread overview]
Message-ID: <1961860.xzxk1Exu2U@amdc1227> (raw)
In-Reply-To: <0c2f01cdc700$09c204d0$1d460e70$%kim@samsung.com>
Hi Kgene,
On Tuesday 20 of November 2012 18:18:44 Kukjin Kim wrote:
> Tomasz Figa wrote:
> > This patch modifies pin control groups of SD pins on Exynos4210 and
> > Exynos4x12 to use drive strength 3, which corresponds to
> > S5P_GPIO_DRVSTR_LV4 in legacy non-DT code.
>
> Well, the value of drive strength depends on board not SoC. So if
> required, it should be moved to board DT stuff.
Yes, I fully agree.
I've been thinking whether to change the defaults or just override them
for Origen, but I came to a conclusion that 3 (LV4) was the default in
non-DT code, so it probably should be also the default in DT variant.
> BTW, we can use the value as a default...I need to think about that
> again for exynos4210 and 4x12.
I wonder which default value is more appropriate, 0 or 3?
Best regards,
--
Tomasz Figa
Samsung Poland R&D Center
SW Solution Development, Linux Platform
next prev parent reply other threads:[~2012-11-20 9:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 14:52 [PATCH] ARM: dts: exynos4: Use drive strength 3 for SD pins Tomasz Figa
2012-11-20 9:18 ` Kukjin Kim
2012-11-20 9:35 ` Tomasz Figa [this message]
2012-11-20 11:10 ` Kukjin Kim
2012-11-21 10:35 ` Tomasz Figa
2012-11-21 12:10 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1961860.xzxk1Exu2U@amdc1227 \
--to=t.figa@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox