* [PATCH] remoteproc: avoid stack overflow in debugfs file
@ 2015-11-20 17:26 Arnd Bergmann
2015-11-26 8:14 ` Ohad Ben-Cohen
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2015-11-20 17:26 UTC (permalink / raw)
To: linux-arm-kernel
Recent gcc versions warn about reading from a negative offset of
an on-stack array:
drivers/remoteproc/remoteproc_debugfs.c: In function 'rproc_recovery_write':
drivers/remoteproc/remoteproc_debugfs.c:167:9: warning: 'buf[4294967295u]' may be used uninitialized in this function [-Wmaybe-uninitialized]
I don't see anything in sys_write() that prevents us from
being called with a zero 'count' argument, so we should
add an extra check in rproc_recovery_write() to prevent the
access and avoid the warning.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 2e37abb89a2e ("remoteproc: create a 'recovery' debugfs entry")
diff --git a/drivers/remoteproc/remoteproc_debugfs.c b/drivers/remoteproc/remoteproc_debugfs.c
index 9d30809bb407..916af5096f57 100644
--- a/drivers/remoteproc/remoteproc_debugfs.c
+++ b/drivers/remoteproc/remoteproc_debugfs.c
@@ -156,7 +156,7 @@ rproc_recovery_write(struct file *filp, const char __user *user_buf,
char buf[10];
int ret;
- if (count > sizeof(buf))
+ if (count < 1 || count > sizeof(buf))
return count;
ret = copy_from_user(buf, user_buf, count);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] remoteproc: avoid stack overflow in debugfs file
2015-11-20 17:26 [PATCH] remoteproc: avoid stack overflow in debugfs file Arnd Bergmann
@ 2015-11-26 8:14 ` Ohad Ben-Cohen
0 siblings, 0 replies; 2+ messages in thread
From: Ohad Ben-Cohen @ 2015-11-26 8:14 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Nov 20, 2015 at 7:26 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> Recent gcc versions warn about reading from a negative offset of
> an on-stack array:
>
> drivers/remoteproc/remoteproc_debugfs.c: In function 'rproc_recovery_write':
> drivers/remoteproc/remoteproc_debugfs.c:167:9: warning: 'buf[4294967295u]' may be used uninitialized in this function [-Wmaybe-uninitialized]
>
> I don't see anything in sys_write() that prevents us from
> being called with a zero 'count' argument, so we should
> add an extra check in rproc_recovery_write() to prevent the
> access and avoid the warning.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 2e37abb89a2e ("remoteproc: create a 'recovery' debugfs entry")
Applied to remoteproc-fixes, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-26 8:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-20 17:26 [PATCH] remoteproc: avoid stack overflow in debugfs file Arnd Bergmann
2015-11-26 8:14 ` Ohad Ben-Cohen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox