public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] staging: etnaviv: fix platform_no_drv_owner.cocci warnings
Date: Fri, 06 Nov 2015 10:17:18 +0100	[thread overview]
Message-ID: <10294857.4Rufm0mRi7@wuerfel> (raw)
In-Reply-To: <alpine.DEB.2.02.1511060746260.2054@localhost6.localdomain6>

On Friday 06 November 2015 07:47:58 Julia Lawall wrote:
> No need to set .owner here. The core will do it.
> 
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> 
> CC: Christian Gmeiner <christian.gmeiner@gmail.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>

Patch looks good of course.

It looks like the conversion is stagnating, probably as we seem to have some
unmaintained drivers, slow maintainers, or cases that
platform_no_drv_owner.cocci doesn't catch:

for i in v3.18 v3.19 v4.0 v4.1 v4.2 v4.3 next/master ; do
	echo $i `git grep -A15 -w platform_driver $i  | grep owner.*THIS_MODULE  | wc -l`
done

v3.18 1798
v3.19 112
v4.0 98
v4.1 94
v4.2 98
v4.3 80
next/master 85

(this includes some false positives)

Is there any way we can prevent new ones from creeping in after we remove
the remaining ones? A compile-time check would be best, but I can't think
of one as there are other subsystems that still set .owner. Maybe add a
WARN_ON to platform_driver_register() and add that to linux-next on top of
a patch (or series of patches) that removes the remaining ones?

	Arnd

      reply	other threads:[~2015-11-06  9:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-06  6:47 [PATCH] staging: etnaviv: fix platform_no_drv_owner.cocci warnings Julia Lawall
2015-11-06  9:17 ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10294857.4Rufm0mRi7@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox