public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH v2 1/1] phy: freescale: phy-fsl-imx8-mipi-dphy: Fix alias name to use dashes
@ 2024-01-10  9:33 Alexander Stein
  2024-02-06  8:02 ` Alexander Stein
  2024-02-07 14:01 ` Vinod Koul
  0 siblings, 2 replies; 3+ messages in thread
From: Alexander Stein @ 2024-01-10  9:33 UTC (permalink / raw)
  To: Vinod Koul, Kishon Vijay Abraham I, Shawn Guo, Sascha Hauer,
	Fabio Estevam, Ying Liu
  Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team,
	linux-phy, linux-arm-kernel

Devicetree spec lists only dashes as valid characters for alias names.
Table 3.2: Valid characters for alias names, Devicee Specification,
Release v0.4

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Fixes: 3fbae284887de ("phy: freescale: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support")
---
Changes in v2:
* Added Fixes tag as suggested by Liu Ying

 drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c
index e625b32889bfc..0928a526e2ab3 100644
--- a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c
+++ b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c
@@ -706,7 +706,7 @@ static int mixel_dphy_probe(struct platform_device *pdev)
 			return ret;
 		}
 
-		priv->id = of_alias_get_id(np, "mipi_dphy");
+		priv->id = of_alias_get_id(np, "mipi-dphy");
 		if (priv->id < 0) {
 			dev_err(dev, "Failed to get phy node alias id: %d\n",
 				priv->id);
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 1/1] phy: freescale: phy-fsl-imx8-mipi-dphy: Fix alias name to use dashes
  2024-01-10  9:33 [PATCH v2 1/1] phy: freescale: phy-fsl-imx8-mipi-dphy: Fix alias name to use dashes Alexander Stein
@ 2024-02-06  8:02 ` Alexander Stein
  2024-02-07 14:01 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Alexander Stein @ 2024-02-06  8:02 UTC (permalink / raw)
  To: Vinod Koul, Kishon Vijay Abraham I, Shawn Guo, Sascha Hauer,
	Fabio Estevam, Ying Liu
  Cc: Pengutronix Kernel Team, NXP Linux Team, linux-phy,
	linux-arm-kernel

Hi everyone,

Am Mittwoch, 10. Januar 2024, 10:33:43 CET schrieb Alexander Stein:
> Devicetree spec lists only dashes as valid characters for alias names.
> Table 3.2: Valid characters for alias names, Devicee Specification,
> Release v0.4
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> Fixes: 3fbae284887de ("phy: freescale: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp
> LVDS PHY mode support")
> ---
> Changes in v2:
> * Added Fixes tag as suggested by Liu Ying

Any feedback on this?

Thanks and best regards,
Alexander

>  drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c
> b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c index
> e625b32889bfc..0928a526e2ab3 100644
> --- a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c
> +++ b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c
> @@ -706,7 +706,7 @@ static int mixel_dphy_probe(struct platform_device
> *pdev) return ret;
>  		}
> 
> -		priv->id = of_alias_get_id(np, "mipi_dphy");
> +		priv->id = of_alias_get_id(np, "mipi-dphy");
>  		if (priv->id < 0) {
>  			dev_err(dev, "Failed to get phy node alias id: 
%d\n",
>  				priv->id);


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 1/1] phy: freescale: phy-fsl-imx8-mipi-dphy: Fix alias name to use dashes
  2024-01-10  9:33 [PATCH v2 1/1] phy: freescale: phy-fsl-imx8-mipi-dphy: Fix alias name to use dashes Alexander Stein
  2024-02-06  8:02 ` Alexander Stein
@ 2024-02-07 14:01 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2024-02-07 14:01 UTC (permalink / raw)
  To: Kishon Vijay Abraham I, Shawn Guo, Sascha Hauer, Fabio Estevam,
	Ying Liu, Alexander Stein
  Cc: Pengutronix Kernel Team, NXP Linux Team, linux-phy,
	linux-arm-kernel


On Wed, 10 Jan 2024 10:33:43 +0100, Alexander Stein wrote:
> Devicetree spec lists only dashes as valid characters for alias names.
> Table 3.2: Valid characters for alias names, Devicee Specification,
> Release v0.4
> 
> 

Applied, thanks!

[1/1] phy: freescale: phy-fsl-imx8-mipi-dphy: Fix alias name to use dashes
      commit: 7936378cb6d87073163130e1e1fc1e5f76a597cf

Best regards,
-- 
~Vinod



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-02-07 14:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-10  9:33 [PATCH v2 1/1] phy: freescale: phy-fsl-imx8-mipi-dphy: Fix alias name to use dashes Alexander Stein
2024-02-06  8:02 ` Alexander Stein
2024-02-07 14:01 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox