Re: [PATCH 01/30] pwm: atmel-hlcdc: Convert to platform remove callback returning void

[<Claudiu.Beznea@microchip.com>]

On 03.03.2023 20:54, Uwe Kleine-König wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>


> ---
>  drivers/pwm/pwm-atmel-hlcdc.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pwm/pwm-atmel-hlcdc.c b/drivers/pwm/pwm-atmel-hlcdc.c
> index a43b2babc809..96a709a9d49a 100644
> --- a/drivers/pwm/pwm-atmel-hlcdc.c
> +++ b/drivers/pwm/pwm-atmel-hlcdc.c
> @@ -278,15 +278,13 @@ static int atmel_hlcdc_pwm_probe(struct platform_device *pdev)
>         return 0;
>  }
> 
> -static int atmel_hlcdc_pwm_remove(struct platform_device *pdev)
> +static void atmel_hlcdc_pwm_remove(struct platform_device *pdev)
>  {
>         struct atmel_hlcdc_pwm *chip = platform_get_drvdata(pdev);
> 
>         pwmchip_remove(&chip->chip);
> 
>         clk_disable_unprepare(chip->hlcdc->periph_clk);
> -
> -       return 0;
>  }
> 
>  static const struct of_device_id atmel_hlcdc_pwm_dt_ids[] = {
> @@ -301,7 +299,7 @@ static struct platform_driver atmel_hlcdc_pwm_driver = {
>                 .pm = &atmel_hlcdc_pwm_pm_ops,
>         },
>         .probe = atmel_hlcdc_pwm_probe,
> -       .remove = atmel_hlcdc_pwm_remove,
> +       .remove_new = atmel_hlcdc_pwm_remove,
>  };
>  module_platform_driver(atmel_hlcdc_pwm_driver);
> 
> --
> 2.39.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel