Re: [PATCH 30/30] pwm: xilinx: Convert to platform remove callback returning void

[Sean Anderson <sean.anderson@seco.com>]

On 3/3/23 13:54, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/pwm/pwm-xilinx.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pwm/pwm-xilinx.c b/drivers/pwm/pwm-xilinx.c
> index f7a50fdcd9a5..85153ee90809 100644
> --- a/drivers/pwm/pwm-xilinx.c
> +++ b/drivers/pwm/pwm-xilinx.c
> @@ -292,14 +292,13 @@ static int xilinx_pwm_probe(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -static int xilinx_pwm_remove(struct platform_device *pdev)
> +static void xilinx_pwm_remove(struct platform_device *pdev)
>  {
>  	struct xilinx_pwm_device *xilinx_pwm = platform_get_drvdata(pdev);
>  
>  	pwmchip_remove(&xilinx_pwm->chip);
>  	clk_rate_exclusive_put(xilinx_pwm->priv.clk);
>  	clk_disable_unprepare(xilinx_pwm->priv.clk);
> -	return 0;
>  }
>  
>  static const struct of_device_id xilinx_pwm_of_match[] = {
> @@ -310,7 +309,7 @@ MODULE_DEVICE_TABLE(of, xilinx_pwm_of_match);
>  
>  static struct platform_driver xilinx_pwm_driver = {
>  	.probe = xilinx_pwm_probe,
> -	.remove = xilinx_pwm_remove,
> +	.remove_new = xilinx_pwm_remove,
>  	.driver = {
>  		.name = "xilinx-pwm",
>  		.of_match_table = of_match_ptr(xilinx_pwm_of_match),

Reviewed-by: Sean Anderson <sean.anderson@seco.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel