From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] ASoC: samsung: wm8994 depends on mfd_wm8994
Date: Mon, 03 Oct 2011 15:43:10 +0200 [thread overview]
Message-ID: <11174515.ANsqIhx0NX@wuerfel> (raw)
In-Reply-To: <20111003120741.GD23811@sirena.org.uk>
Any driver that selects SND_SOC_WM8994 should also make sure that
MFD_WM8994 is set, since the codec relies on the mfd code:
sound/built-in.o: In function `wm8994_read':
last.c:(.text+0x20160): undefined reference to `wm8994_reg_read'
sound/built-in.o: In function `wm8994_write':
last.c:(.text+0x20e68): undefined reference to `wm8994_reg_write'
This adds the missing 'depends' statements to Kconfig, as found
during ARM randconfig tests.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
sound/soc/samsung/Kconfig | 3 +++
1 file changed, 3 insertions(+)
On Monday 03 October 2011 13:07:41 Mark Brown wrote:
> On Mon, Oct 03, 2011 at 01:50:08PM +0200, Arnd Bergmann wrote:
>
> > the patch. The other problem in this patch is still there, with
> > CONFIG_SND_SOC_SMDK_WM8994_PCM=y and CONFIG_MFD_WM8994=n:
>
> You've not sent a seprate patch for that one yet...
I wasn't sure any more which version you wanted. Is this this right one?
--- a/sound/soc/samsung/Kconfig
+++ b/sound/soc/samsung/Kconfig
@@ -65,6 +65,7 @@ config SND_SOC_SAMSUNG_SMDK_WM8580
config SND_SOC_SAMSUNG_SMDK_WM8994
tristate "SoC I2S Audio support for WM8994 on SMDK"
depends on SND_SOC_SAMSUNG && (MACH_SMDKV310 || MACH_SMDKC210)
+ depends on MFD_WM8994
select SND_SOC_WM8994
select SND_SAMSUNG_I2S
help
@@ -152,6 +153,7 @@ config SND_SOC_GONI_AQUILA_WM8994
tristate "SoC I2S Audio support for AQUILA/GONI - WM8994"
depends on SND_SOC_SAMSUNG && (MACH_GONI || MACH_AQUILA)
select SND_SAMSUNG_I2S
+ depends on MFD_WM8994
select SND_SOC_WM8994
help
Say Y if you want to add support for SoC audio on goni or aquila
@@ -175,6 +177,7 @@ config SND_SOC_SMDK_WM8580_PCM
config SND_SOC_SMDK_WM8994_PCM
tristate "SoC PCM Audio support for WM8994 on SMDK"
depends on SND_SOC_SAMSUNG && (MACH_SMDKC210 || MACH_SMDKV310)
+ depends on MFD_WM8994
select SND_SOC_WM8994
select SND_SAMSUNG_PCM
help
next prev parent reply other threads:[~2011-10-03 13:43 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-02 20:27 [PATCH 0/6] ASoC fixes from ARM randconfig builds Arnd Bergmann
2011-10-02 20:27 ` [PATCH 1/6] ASoC: codecs/wm8682: use __devexit_p Arnd Bergmann
2011-10-02 20:36 ` Mark Brown
2011-10-02 20:28 ` [PATCH 2/6] ASoC: codecs: AK4641 depends on GPIOLIB Arnd Bergmann
2011-10-02 20:41 ` Mark Brown
2011-10-02 20:53 ` Arnd Bergmann
2011-10-02 21:27 ` Mark Brown
2011-10-03 10:59 ` Arnd Bergmann
2011-10-03 13:45 ` Russell King - ARM Linux
2011-10-03 14:35 ` [alsa-devel] " Mark Brown
2011-10-03 14:47 ` Arnd Bergmann
2011-10-03 15:20 ` Mark Brown
2011-10-03 16:19 ` Arnd Bergmann
2011-10-03 16:34 ` Mark Brown
2011-10-02 20:28 ` [PATCH 3/6] ASoC: imx: eukrea_tlv320 needs i2c Arnd Bergmann
2011-10-02 20:49 ` Mark Brown
2011-10-02 20:28 ` [PATCH 4/6] ASoC: sh: use correct __iomem annotations Arnd Bergmann
2011-10-02 20:50 ` Mark Brown
2011-10-02 21:20 ` Arnd Bergmann
2011-10-02 20:28 ` [PATCH 5/6] ASoC: samsung: fix Kconfig dependencies Arnd Bergmann
2011-10-02 20:47 ` Mark Brown
2011-10-02 21:14 ` Arnd Bergmann
2011-10-02 21:29 ` Mark Brown
2011-10-03 6:48 ` [alsa-devel] " Sangbeom Kim
2011-10-03 11:50 ` Arnd Bergmann
2011-10-03 12:07 ` Mark Brown
2011-10-03 13:43 ` Arnd Bergmann [this message]
2011-10-03 14:08 ` [PATCH 5/6] ASoC: samsung: wm8994 depends on mfd_wm8994 Mark Brown
2011-10-03 14:35 ` [PATCH v3] " Arnd Bergmann
2011-10-03 14:40 ` Mark Brown
2011-10-02 20:28 ` [PATCH 6/6] ASoC: samsung: add missing __devexit_p() annotations Arnd Bergmann
2011-10-02 20:48 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11174515.ANsqIhx0NX@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox