From: gores@marvell.com (Siddarth Gore)
To: linux-arm-kernel@lists.infradead.org
Subject: adding pxa3xx_nand_flash to platform data
Date: Mon, 10 May 2010 10:13:29 +0530 [thread overview]
Message-ID: <1273466610.6926.5.camel@pe-dt434> (raw)
In-Reply-To: <p2u771cded01005060220vd3e9e3d6i4ecd581ef3ef12d4@mail.gmail.com>
On Thu, 2010-05-06 at 02:20 -0700, Haojian Zhuang wrote:
> On Wed, May 5, 2010 at 4:56 AM, Eric Miao <eric.y.miao@gmail.com> wrote:
> > On Wed, May 5, 2010 at 4:56 PM, Eric Miao <eric.y.miao@gmail.com> wrote:
> >> On Wed, May 5, 2010 at 3:58 PM, Siddarth Gore <gores@marvell.com> wrote:
> >>> Hello Eric,
> >>>
> >>> Currently I need to enable the deprecated MTD_NAND_PXA3xx_BUILTIN
> >>> support for Aspenite DB board (pxa168). I have a patch ready to add
> >>> pxa3xx_nand_flash in aspenite.c but I was wondering about the cmdset
> >>> field in it.
> >>> Looks like it is the same for all boards (depending upon the page size).
> >>> So should I add it to the board specific setup file or remove it from
> >>> pxa3xx_nand_platform_data (and put it in say, pxa3xx_nand_info)?
> >>>
> >>> If there are boards which require a different cmdset then we have to go
> >>> with first option, if not, we can use option two and save some code
> >>> duplication.
> >>>
> >>
> >> There are normally two sets of commands, yet the code derived from some
> >> previous work that there were several subtle different command sets.
> >>
>
> We already formated the patches of removing the duplication. Now it's
> put into mailist. Try these patches.
>
Thanks a lot Haojian. I have tried the whole patchset and it is working
fine on my Aspenite DB board. Did not get a chance to check individual
patches though.
Also, some patches did not get applied with git-am. I had to manually
apply them.
-siddarth
> Thanks
> Haojian
next prev parent reply other threads:[~2010-05-10 4:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 7:58 adding pxa3xx_nand_flash to platform data Siddarth Gore
2010-05-05 8:56 ` Eric Miao
2010-05-05 8:56 ` Eric Miao
2010-05-06 9:20 ` Haojian Zhuang
2010-05-10 4:43 ` Siddarth Gore [this message]
2010-05-10 11:15 ` Lei Wen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273466610.6926.5.camel@pe-dt434 \
--to=gores@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox