From: vinod.koul@intel.com (Koul, Vinod)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] dmaengine: add ep93xx DMA support
Date: Wed, 25 May 2011 13:49:53 +0530 [thread overview]
Message-ID: <1306311593.30236.103.camel@vkoul-udesk3> (raw)
In-Reply-To: <BANLkTi=3z3kO5VEe2up8Mfm+bNXkY3baUw@mail.gmail.com>
On Wed, 2011-05-25 at 10:39 +0200, Linus Walleij wrote:
> 2011/5/22 Mika Westerberg <mika.westerberg@iki.fi>:
>
> > The ep93xx DMA controller has 10 independent memory to peripheral (M2P)
> > channels, and 2 dedicated memory to memory (M2M) channels. M2M channels can
> > also be used by SPI and IDE to perform DMA transfers to/from their memory
> > mapped FIFOs.
>
> No so much a review comment as an observation: I opposed the merge of the
> EP93xx SPI driver in drivers/spi/ep93xx_spi.c on the grounds that it was close
> enough to amba-pl022.c that it could use that driver instead.
>
> One of the arguments against was that you were going to do custom DMA
> and stuff. Now you're using the DMAengine, so can you please reconsider
> refactoring amba-pl022.c to suit your needs and you'll get DMA support for
> free mor or less.
Linus is the dma IP same as existing ones?
In that case we shouldn't have a new driver for same IP.
--
~Vinod
next prev parent reply other threads:[~2011-05-25 8:19 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-22 17:03 [PATCH 0/5] ep93xx DMA patches Mika Westerberg
2011-05-22 17:03 ` [PATCH 1/5] dmaengine: add ep93xx DMA support Mika Westerberg
2011-05-25 8:00 ` Koul, Vinod
2011-05-25 19:00 ` Mika Westerberg
2011-05-26 4:38 ` Koul, Vinod
2011-05-26 18:15 ` Mika Westerberg
2011-05-26 18:42 ` H Hartley Sweeten
2011-05-25 8:39 ` Linus Walleij
2011-05-25 8:19 ` Koul, Vinod [this message]
2011-05-25 9:09 ` Linus Walleij
2011-05-25 19:54 ` Mika Westerberg
2011-05-25 20:47 ` Linus Walleij
2011-05-26 4:33 ` Mika Westerberg
2011-05-26 5:26 ` Ryan Mallon
2011-05-26 7:15 ` Linus Walleij
2011-05-26 18:38 ` Mika Westerberg
2011-05-26 18:48 ` H Hartley Sweeten
2011-05-26 21:53 ` Russell King - ARM Linux
2011-05-26 22:58 ` Linus Walleij
2011-05-27 1:38 ` H Hartley Sweeten
2011-05-28 10:33 ` Mika Westerberg
2011-05-22 17:03 ` [PATCH 2/5] ep93xx: add dmaengine platform code Mika Westerberg
2011-05-27 1:44 ` H Hartley Sweeten
2011-05-22 17:03 ` [PATCH 3/5] ASoC: ep93xx: convert to use the DMA engine API Mika Westerberg
2011-05-23 5:11 ` Mark Brown
2011-05-23 9:38 ` Liam Girdwood
2011-05-27 1:43 ` H Hartley Sweeten
2011-05-22 17:03 ` [PATCH 4/5] ep93xx: remove the old M2P DMA code Mika Westerberg
2011-05-27 1:42 ` H Hartley Sweeten
2011-05-22 17:03 ` [PATCH 5/5] spi/ep93xx: add DMA support Mika Westerberg
2011-05-27 1:47 ` H Hartley Sweeten
2011-05-23 17:34 ` [PATCH 0/5] ep93xx DMA patches H Hartley Sweeten
2011-05-23 20:10 ` Ryan Mallon
2011-05-24 14:42 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306311593.30236.103.camel@vkoul-udesk3 \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox