[PATCH] pinctrl: Fix "warning: 'struct pinctrl_dev' declared inside parameter list"

[PATCH] pinctrl: Fix "warning: 'struct pinctrl_dev' declared inside parameter list"

[Barry Song]

From: Barry Song <Baohua.Song@csr.com>

when pinctl subsystem is not selected, when compiling drivers including
the include/linux/pinctrl/pinctrl.h, we will get the warning as below:
In file included from include/linux/pinctrl/pinmux.h:17,
                 from drivers/tty/serial/sirfsoc_uart.c:25:
include/linux/pinctrl/pinctrl.h:126: warning: 'struct pinctrl_dev'
		declared inside parameter list
include/linux/pinctrl/pinctrl.h:126: warning: its scope is only this
      definition or declaration, which is probably not what you want

Signed-off-by: Barry Song <Baohua.Song@csr.com>
---
 include/linux/pinctrl/pinctrl.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/pinctrl/pinctrl.h b/include/linux/pinctrl/pinctrl.h
index 3605e94..04c0110 100644
--- a/include/linux/pinctrl/pinctrl.h
+++ b/include/linux/pinctrl/pinctrl.h
@@ -121,6 +121,7 @@ extern const char *pinctrl_dev_get_name(struct pinctrl_dev *pctldev);
 extern void *pinctrl_dev_get_drvdata(struct pinctrl_dev *pctldev);
 #else
 
+struct pinctrl_dev;
 
 /* Sufficiently stupid default function when pinctrl is not in use */
 static inline bool pin_is_valid(struct pinctrl_dev *pctldev, int pin)
-- 
1.7.1



Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
More information can be found at www.csr.com. Follow CSR on Twitter at http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog

[PATCH] pinctrl: Fix "warning: 'struct pinctrl_dev' declared inside parameter list"

[Linus Walleij]

On Fri, Oct 28, 2011 at 5:38 AM, Barry Song <Barry.Song@csr.com> wrote:

> From: Barry Song <Baohua.Song@csr.com>
>
> when pinctl subsystem is not selected, when compiling drivers including
> the include/linux/pinctrl/pinctrl.h, we will get the warning as below:
> In file included from include/linux/pinctrl/pinmux.h:17,
> ? ? ? ? ? ? ? ? from drivers/tty/serial/sirfsoc_uart.c:25:
> include/linux/pinctrl/pinctrl.h:126: warning: 'struct pinctrl_dev'
> ? ? ? ? ? ? ? ?declared inside parameter list
> include/linux/pinctrl/pinctrl.h:126: warning: its scope is only this
> ? ? ?definition or declaration, which is probably not what you want
>
> Signed-off-by: Barry Song <Baohua.Song@csr.com>

OK applied.

Thanks,
Linus Walleij