From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: sa1100: refactor sa1100 serial driver
Date: Sun, 20 Nov 2011 12:47:48 -0800 [thread overview]
Message-ID: <1321822068.17619.3.camel@Joe-Laptop> (raw)
In-Reply-To: <1321821127-32231-1-git-send-email-jochen@scram.de>
On Sun, 2011-11-20 at 21:32 +0100, Jochen Friedrich wrote:
> - move pin initialization into board files
> - make use of resources in platform device
> rather than hardcoding them in the driver
> - add DT support
trivia:
> diff --git a/arch/arm/mach-sa1100/generic.c b/arch/arm/mach-sa1100/generic.c
[]
> @@ -166,7 +166,7 @@ static struct platform_device sa11x0udc_device = {
> static struct resource sa11x0uart1_resources[] = {
> [0] = {
> .start = __PREG(Ser1UTCR0),
> - .end = __PREG(Ser1UTCR0) + 0xffff,
> + .end = __PREG(Ser1UTCR0) + 0x24,
#define for 0x24? or is it really 0x23?
(start + size - 1)
> @@ -178,15 +178,35 @@ static struct resource sa11x0uart1_resources[] = {
[]
> +static struct resource sa11x0uart2_resources[] = {
> + [0] = {
> + .start = __PREG(Ser2UTCR0),
> + .end = __PREG(Ser2UTCR0) + 0x24,
here too
> +static struct platform_device sa11x0uart2_device = {
> + .name = "sa11x0-uart",
> + .id = -1,
> + .num_resources = ARRAY_SIZE(sa11x0uart2_resources),
> + .resource = sa11x0uart2_resources,
> +};
> +
> static struct resource sa11x0uart3_resources[] = {
> [0] = {
> .start = __PREG(Ser3UTCR0),
> - .end = __PREG(Ser3UTCR0) + 0xffff,
> + .end = __PREG(Ser3UTCR0) + 0x24,
etc
next prev parent reply other threads:[~2011-11-20 20:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-20 20:32 [PATCH] ARM: sa1100: refactor sa1100 serial driver Jochen Friedrich
2011-11-20 20:47 ` Joe Perches [this message]
2011-11-20 20:59 ` Joe Perches
2011-11-21 14:44 ` Jochen Friedrich
2011-11-21 14:37 ` Jochen Friedrich
2011-11-21 14:43 ` Jamie Iles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321822068.17619.3.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox