From: jamie@jamieiles.com (Jamie Iles)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: sa1100: refactor sa1100 serial driver
Date: Mon, 21 Nov 2011 14:43:33 +0000 [thread overview]
Message-ID: <20111121144333.GA25627@totoro> (raw)
In-Reply-To: <4ECA6235.4030108@scram.de>
On Mon, Nov 21, 2011 at 03:37:41PM +0100, Jochen Friedrich wrote:
> Hi Joe,
>
> >trivia:
> >
> >>diff --git a/arch/arm/mach-sa1100/generic.c b/arch/arm/mach-sa1100/generic.c
> >[]
> >>@@ -166,7 +166,7 @@ static struct platform_device sa11x0udc_device = {
> >> static struct resource sa11x0uart1_resources[] = {
> >> [0] = {
> >> .start = __PREG(Ser1UTCR0),
> >>- .end = __PREG(Ser1UTCR0) + 0xffff,
> >>+ .end = __PREG(Ser1UTCR0) + 0x24,
> >
> >#define for 0x24? or is it really 0x23?
> >(start + size - 1)
>
> Thanks, I'll fix this.
It may even be worth looking at the DEFINE_RES_MEM() type macros in
include/linux/ioport.h, but I'm not sure that's essential!
Jamie
prev parent reply other threads:[~2011-11-21 14:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-20 20:32 [PATCH] ARM: sa1100: refactor sa1100 serial driver Jochen Friedrich
2011-11-20 20:47 ` Joe Perches
2011-11-20 20:59 ` Joe Perches
2011-11-21 14:44 ` Jochen Friedrich
2011-11-21 14:37 ` Jochen Friedrich
2011-11-21 14:43 ` Jamie Iles [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111121144333.GA25627@totoro \
--to=jamie@jamieiles.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox