Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] EHCI: Fix clk_enable/clk_disable for ehci-mxc usb clock
@ 2012-02-08  0:12 Marek Vasut
  2012-02-08  0:17 ` Fabio Estevam
  0 siblings, 1 reply; 2+ messages in thread
From: Marek Vasut @ 2012-02-08  0:12 UTC (permalink / raw)
  To: linux-arm-kernel

The clock weren't enabled without the following change.

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Cc: Shawn Guo <shawn.guo@freescale.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/usb/host/ehci-mxc.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c
index 55978fc..f3faf0e 100644
--- a/drivers/usb/host/ehci-mxc.c
+++ b/drivers/usb/host/ehci-mxc.c
@@ -171,7 +171,7 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev)
 		ret = PTR_ERR(priv->usbclk);
 		goto err_clk;
 	}
-	clk_enable(priv->usbclk);
+	clk_prepare_enable(priv->usbclk);
 
 	if (!cpu_is_mx35() && !cpu_is_mx25()) {
 		priv->ahbclk = clk_get(dev, "usb_ahb");
@@ -273,7 +273,7 @@ err_clk_phy:
 		clk_put(priv->ahbclk);
 	}
 err_clk_ahb:
-	clk_disable(priv->usbclk);
+	clk_disable_unprepare(priv->usbclk);
 	clk_put(priv->usbclk);
 err_clk:
 	iounmap(hcd->regs);
@@ -305,7 +305,7 @@ static int __exit ehci_mxc_drv_remove(struct platform_device *pdev)
 	usb_put_hcd(hcd);
 	platform_set_drvdata(pdev, NULL);
 
-	clk_disable(priv->usbclk);
+	clk_disable_unprepare(priv->usbclk);
 	clk_put(priv->usbclk);
 	if (priv->ahbclk) {
 		clk_disable(priv->ahbclk);
-- 
1.7.8.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] EHCI: Fix clk_enable/clk_disable for ehci-mxc usb clock
  2012-02-08  0:12 [PATCH] EHCI: Fix clk_enable/clk_disable for ehci-mxc usb clock Marek Vasut
@ 2012-02-08  0:17 ` Fabio Estevam
  0 siblings, 0 replies; 2+ messages in thread
From: Fabio Estevam @ 2012-02-08  0:17 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Feb 7, 2012 at 10:12 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
> The clock weren't enabled without the following change.
>
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> Cc: Shawn Guo <shawn.guo@freescale.com>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>

You forgot to Cc linux-usb.

Regards,

Fabio Estevam

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-02-08  0:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-08  0:12 [PATCH] EHCI: Fix clk_enable/clk_disable for ehci-mxc usb clock Marek Vasut
2012-02-08  0:17 ` Fabio Estevam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox