* [PATCH 1/3] dmaengine: sirf: fix a typo in dma_prep_interleaved
@ 2012-09-27 8:35 Barry Song
2012-10-11 1:55 ` Barry Song
2012-10-24 11:03 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Barry Song @ 2012-09-27 8:35 UTC (permalink / raw)
To: linux-arm-kernel
From: Barry Song <Baohua.Song@csr.com>
either DEV_TO_MEM or MEM_TO_DEV is supported, so change
OR to AND.
Signed-off-by: Barry Song <Baohua.Song@csr.com>
---
drivers/dma/sirf-dma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/dma/sirf-dma.c b/drivers/dma/sirf-dma.c
index 434ad31..35a329d 100644
--- a/drivers/dma/sirf-dma.c
+++ b/drivers/dma/sirf-dma.c
@@ -428,7 +428,7 @@ static struct dma_async_tx_descriptor *sirfsoc_dma_prep_interleaved(
unsigned long iflags;
int ret;
- if ((xt->dir != DMA_MEM_TO_DEV) || (xt->dir != DMA_DEV_TO_MEM)) {
+ if ((xt->dir != DMA_MEM_TO_DEV) && (xt->dir != DMA_DEV_TO_MEM)) {
ret = -EINVAL;
goto err_dir;
}
--
1.7.0.4
Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
More information can be found at www.csr.com. Follow CSR on Twitter at http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH 1/3] dmaengine: sirf: fix a typo in dma_prep_interleaved
2012-09-27 8:35 [PATCH 1/3] dmaengine: sirf: fix a typo in dma_prep_interleaved Barry Song
@ 2012-10-11 1:55 ` Barry Song
2012-10-24 11:03 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Barry Song @ 2012-10-11 1:55 UTC (permalink / raw)
To: linux-arm-kernel
ping
2012/9/27 Barry Song <Barry.Song@csr.com>:
> From: Barry Song <Baohua.Song@csr.com>
>
> either DEV_TO_MEM or MEM_TO_DEV is supported, so change
> OR to AND.
>
> Signed-off-by: Barry Song <Baohua.Song@csr.com>
> ---
> drivers/dma/sirf-dma.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/dma/sirf-dma.c b/drivers/dma/sirf-dma.c
> index 434ad31..35a329d 100644
> --- a/drivers/dma/sirf-dma.c
> +++ b/drivers/dma/sirf-dma.c
> @@ -428,7 +428,7 @@ static struct dma_async_tx_descriptor *sirfsoc_dma_prep_interleaved(
> unsigned long iflags;
> int ret;
>
> - if ((xt->dir != DMA_MEM_TO_DEV) || (xt->dir != DMA_DEV_TO_MEM)) {
> + if ((xt->dir != DMA_MEM_TO_DEV) && (xt->dir != DMA_DEV_TO_MEM)) {
> ret = -EINVAL;
> goto err_dir;
> }
> --
> 1.7.0.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH 1/3] dmaengine: sirf: fix a typo in dma_prep_interleaved
2012-09-27 8:35 [PATCH 1/3] dmaengine: sirf: fix a typo in dma_prep_interleaved Barry Song
2012-10-11 1:55 ` Barry Song
@ 2012-10-24 11:03 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2012-10-24 11:03 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, 2012-09-27 at 16:35 +0800, Barry Song wrote:
> From: Barry Song <Baohua.Song@csr.com>
>
> either DEV_TO_MEM or MEM_TO_DEV is supported, so change
> OR to AND.
>
> Signed-off-by: Barry Song <Baohua.Song@csr.com>
> ---
> drivers/dma/sirf-dma.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/dma/sirf-dma.c b/drivers/dma/sirf-dma.c
> index 434ad31..35a329d 100644
> --- a/drivers/dma/sirf-dma.c
> +++ b/drivers/dma/sirf-dma.c
> @@ -428,7 +428,7 @@ static struct dma_async_tx_descriptor *sirfsoc_dma_prep_interleaved(
> unsigned long iflags;
> int ret;
>
> - if ((xt->dir != DMA_MEM_TO_DEV) || (xt->dir != DMA_DEV_TO_MEM)) {
> + if ((xt->dir != DMA_MEM_TO_DEV) && (xt->dir != DMA_DEV_TO_MEM)) {
> ret = -EINVAL;
> goto err_dir;
> }
applied thanks
--
Vinod Koul
Intel Corp.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-24 11:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-27 8:35 [PATCH 1/3] dmaengine: sirf: fix a typo in dma_prep_interleaved Barry Song
2012-10-11 1:55 ` Barry Song
2012-10-24 11:03 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox