Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: mach-bcm: drop "select GENERIC_TIME"
@ 2013-03-06  9:52 Paul Bolle
  2013-03-08  3:18 ` Christian Daudt
  0 siblings, 1 reply; 3+ messages in thread
From: Paul Bolle @ 2013-03-06  9:52 UTC (permalink / raw)
  To: linux-arm-kernel

The Kconfig symbol GENERIC_TIME was removed from the kernel in v2.6.36,
with commit 592913ecb87a9e06f98ddb55b298f1a66bf94c6b ("time: Kill off
CONFIG_GENERIC_TIME"). Somehow this select statement still popped up
recently. It's a nop so we can drop it.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Tested with "git grep" only.

 arch/arm/mach-bcm/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
index bf02471..be4a0a1 100644
--- a/arch/arm/mach-bcm/Kconfig
+++ b/arch/arm/mach-bcm/Kconfig
@@ -7,7 +7,6 @@ config ARCH_BCM
 	select ARM_GIC
 	select CPU_V7
 	select GENERIC_CLOCKEVENTS
-	select GENERIC_TIME
 	select GPIO_BCM
 	select SPARSE_IRQ
 	select TICK_ONESHOT
-- 
1.7.11.7

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] ARM: mach-bcm: drop "select GENERIC_TIME"
  2013-03-06  9:52 [PATCH] ARM: mach-bcm: drop "select GENERIC_TIME" Paul Bolle
@ 2013-03-08  3:18 ` Christian Daudt
  2013-03-08 12:39   ` Paul Bolle
  0 siblings, 1 reply; 3+ messages in thread
From: Christian Daudt @ 2013-03-08  3:18 UTC (permalink / raw)
  To: linux-arm-kernel

My bad. Thanks for the fix !

Reviewed-by: Christian Daudt <csd@broadcom.com>


 Thanks,
   csd


On Wed, Mar 6, 2013 at 1:52 AM, Paul Bolle <pebolle@tiscali.nl> wrote:
> The Kconfig symbol GENERIC_TIME was removed from the kernel in v2.6.36,
> with commit 592913ecb87a9e06f98ddb55b298f1a66bf94c6b ("time: Kill off
> CONFIG_GENERIC_TIME"). Somehow this select statement still popped up
> recently. It's a nop so we can drop it.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Tested with "git grep" only.
>
>  arch/arm/mach-bcm/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
> index bf02471..be4a0a1 100644
> --- a/arch/arm/mach-bcm/Kconfig
> +++ b/arch/arm/mach-bcm/Kconfig
> @@ -7,7 +7,6 @@ config ARCH_BCM
>         select ARM_GIC
>         select CPU_V7
>         select GENERIC_CLOCKEVENTS
> -       select GENERIC_TIME
>         select GPIO_BCM
>         select SPARSE_IRQ
>         select TICK_ONESHOT
> --
> 1.7.11.7
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] ARM: mach-bcm: drop "select GENERIC_TIME"
  2013-03-08  3:18 ` Christian Daudt
@ 2013-03-08 12:39   ` Paul Bolle
  0 siblings, 0 replies; 3+ messages in thread
From: Paul Bolle @ 2013-03-08 12:39 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, 2013-03-07 at 19:18 -0800, Christian Daudt wrote:
> My bad. Thanks for the fix !
> 
> Reviewed-by: Christian Daudt <csd@broadcom.com>

In the same commit, 8ac49e0485bb79223a111b366a3b1f5ec9148729 ("Add
support for generic BCM SoC chipsets"), you also added
    select GPIO_BCM

There's currently no Kconfig symbol by that name. Is it perhaps needed
for future enhancements?


Paul Bolle

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-03-08 12:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-06  9:52 [PATCH] ARM: mach-bcm: drop "select GENERIC_TIME" Paul Bolle
2013-03-08  3:18 ` Christian Daudt
2013-03-08 12:39   ` Paul Bolle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox