From: shc_work@mail.ru (Alexander Shiyan)
To: linux-arm-kernel@lists.infradead.org
Subject: Re[3]: [PATCH] ARM: iomux-mx51: Always define PU E for pins used as GPIO
Date: Wed, 22 May 2013 11:17:36 +0400 [thread overview]
Message-ID: <1369207056.596630214@f96.mail.ru> (raw)
In-Reply-To: <20892.28064.82907.942799@ipc1.ka-ro>
> Alexander Shiyan writes:
> > > On Tue, May 21, 2013 at 12:27:25PM +0400, Alexander Shiyan wrote:
> > > > This patch adds a PUE bit for pins which used as GPIO. This allow
> > > > to use the GPIOs correctly as inputs when source is open-drain with
> > > > external pullup resistor (IRQ open-drain outputs for example).
> > >
> > > I don't understand. If there's an external pullup why do you want to
> > > turn on the internal one?
> >
> > It is just switch off keeper circuit.
> >
> If you want to switch the keeper circuit off why don't you do that by
> removing PAD_CTL_PKE rather than adding PAD_CTL_PUE?
Again, I do not know which the solution here is better. If we remove
the PKE bit, for some pins it will be removed the default pullup/pulldown (PUS = 0),
so it may affect the some running configuration.
---
next prev parent reply other threads:[~2013-05-22 7:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 8:27 [PATCH] ARM: iomux-mx51: Always define PUE for pins used as GPIO Alexander Shiyan
2013-05-21 19:24 ` Sascha Hauer
2013-05-22 6:19 ` Alexander Shiyan
2013-05-22 7:02 ` [PATCH] ARM: iomux-mx51: Always define PU E " Lothar Waßmann
2013-05-22 7:17 ` Alexander Shiyan [this message]
2013-05-22 8:36 ` Lothar Waßmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369207056.596630214@f96.mail.ru \
--to=shc_work@mail.ru \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox