From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [ath9k-devel] [PATCH 1/3] ath9k: Fix build error on ARM
Date: Wed, 05 Feb 2014 06:03:13 -0800 [thread overview]
Message-ID: <1391608993.2538.74.camel@joe-AO722> (raw)
In-Reply-To: <20140205133956.GQ26684@n2100.arm.linux.org.uk>
On Wed, 2014-02-05 at 13:39 +0000, Russell King - ARM Linux wrote:
> On Wed, Feb 05, 2014 at 05:04:54AM -0800, Joe Perches wrote:
> > On Wed, 2014-02-05 at 12:41 +0000, Russell King - ARM Linux wrote:
> > > On Wed, Feb 05, 2014 at 04:32:46AM -0800, Joe Perches wrote:
> > > > Apparently, people just convert stupidly large udelay()s
> > > > to mdelay and not be bothered.
> > >
> > > And that's the correct answer. Having udelay(10000) rather than mdelay(10)
> > > is a sign that they weren't paying that much attention when writing the
> > > code.
> >
> > Not really.
[]
> > It's not so much not paying attention as not
> > knowing ARM is broken for large udelay().
>
> And now read my suggestion about how to avoid the "not knowing" problem. :)
I'd read it already. I didn't and don't disagree.
I still think adding a #warning on large static udelay()s
would be sensible. Maybe adding another option like
#define UDELAY_TOO_BIG_I_KNOW_ALREADY_DONT_BOTHER_ME
guard to avoid seeing the #warning when there's no other
option.
next prev parent reply other threads:[~2014-02-05 14:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1391483274-20331-1-git-send-email-sujith@msujith.org>
[not found] ` <1391483274-20331-2-git-send-email-sujith@msujith.org>
[not found] ` <1391484878.2538.11.camel@joe-AO722>
[not found] ` <21232.24855.201543.400943@gargle.gargle.HOWL>
[not found] ` <CAOpc7mFQZ3efZda0cC28BLATqRDJ99BRNu=ezQq8wa+dyFyOvA@mail.gmail.com>
2014-02-04 16:36 ` [ath9k-devel] [PATCH 1/3] ath9k: Fix build error on ARM Joe Perches
2014-02-04 18:40 ` Arnd Bergmann
2014-02-04 19:43 ` Joe Perches
2014-02-05 11:50 ` Russell King - ARM Linux
2014-02-05 12:32 ` Joe Perches
2014-02-05 12:41 ` Russell King - ARM Linux
2014-02-05 13:04 ` Joe Perches
2014-02-05 13:39 ` Russell King - ARM Linux
2014-02-05 14:03 ` Joe Perches [this message]
2014-02-05 14:21 ` Russell King - ARM Linux
2014-02-05 15:05 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391608993.2538.74.camel@joe-AO722 \
--to=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox