From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [ath9k-devel] [PATCH 1/3] ath9k: Fix build error on ARM
Date: Tue, 04 Feb 2014 19:40:18 +0100 [thread overview]
Message-ID: <3469296.SINb5BZOG8@wuerfel> (raw)
In-Reply-To: <1391531796.2538.21.camel@joe-AO722>
On Tuesday 04 February 2014 08:36:36 Joe Perches wrote:
> On Tue, 2014-02-04 at 08:03 +0100, Holger Schurig wrote:
> > Joe, look in linux/arch/arm/include/asm/delay.h. The macro udelay
> > cannot handle large values because of lost-of-precision.
> >
> > IMHO udelay on ARM is broken, because it also cannot work with fast
> > ARM processors (where bogomips >= 3355, which is in sight now). It's
> > just not broken enought that someone did something against it ... so
> > the current kludge is good enought.
>
> Maybe something like this would be better?
>
I actually like the fact that we get link errors for insane 'udelay'
times. In most cases it's a driver bug because we shouldn't keep
the CPU busy for an eternity in the kernel (and call msleep() instead).
For the rare cases where mdelay makes sense, we also want to add
a comment to the code explaining why msleep cannot be used.
Arnd
next prev parent reply other threads:[~2014-02-04 18:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1391483274-20331-1-git-send-email-sujith@msujith.org>
[not found] ` <1391483274-20331-2-git-send-email-sujith@msujith.org>
[not found] ` <1391484878.2538.11.camel@joe-AO722>
[not found] ` <21232.24855.201543.400943@gargle.gargle.HOWL>
[not found] ` <CAOpc7mFQZ3efZda0cC28BLATqRDJ99BRNu=ezQq8wa+dyFyOvA@mail.gmail.com>
2014-02-04 16:36 ` [ath9k-devel] [PATCH 1/3] ath9k: Fix build error on ARM Joe Perches
2014-02-04 18:40 ` Arnd Bergmann [this message]
2014-02-04 19:43 ` Joe Perches
2014-02-05 11:50 ` Russell King - ARM Linux
2014-02-05 12:32 ` Joe Perches
2014-02-05 12:41 ` Russell King - ARM Linux
2014-02-05 13:04 ` Joe Perches
2014-02-05 13:39 ` Russell King - ARM Linux
2014-02-05 14:03 ` Joe Perches
2014-02-05 14:21 ` Russell King - ARM Linux
2014-02-05 15:05 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3469296.SINb5BZOG8@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox