From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 08/15] mfd: max77836: Add max77836 support to max14577 driver
Date: Fri, 07 Feb 2014 11:54:02 +0100 [thread overview]
Message-ID: <1391770442.12119.4.camel@AMDC1943> (raw)
In-Reply-To: <20140207104912.GJ14727@lee--X1>
On Fri, 2014-02-07 at 10:49 +0000, Lee Jones wrote:
> > Add Maxim 77836 support to max14577 driver. The chipsets have same MUIC
> > component so the extcon, charger and regulators are almost the same. The
> > max77836 however has also PMIC and Fuel Gauge.
> >
> > The MAX77836 uses three I2C slave addresses and has additional interrupts
> > (related to PMIC and Fuel Gauge). It has also Interrupt Source register,
> > just like MAX77686 and MAX77693.
> >
> > The MAX77836 PMIC's TOPSYS and INTSRC interrupts are reported in the
> > PMIC block. The PMIC block has different I2C slave address and uses own
> > regmap so another regmap_irq_chip is needed.
> >
> > Since we have two regmap_irq_chip, use shared interrupts on MAX77836.
> >
> > This patch adds additional defines and functions to the max14577 MFD core
> > driver so the driver will handle both chipsets. Also this patch replaces
> > "0x1 << N" with BIT(N) in defines for register masks.
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>
> My Ack is missing from this patch too.
>
> ... and probably all the others? How will I know which ones I've
> already Acked without reviewing them all again?
I already added your ACK-s to patches which got them. Unfortunately the
numbering of patches changed because 4 of them were applied and 1 was
dropped.
This particular patch (previously: 13/18) haven't got you ACK because
you've pointed some issues to fix.
Best regards,
Krzysztof
next prev parent reply other threads:[~2014-02-07 10:54 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 10:04 [PATCH v2 00/15] mfd: max14577: Add support for MAX77836 Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 01/15] extcon: max14577: Change extcon name instead of static name according to device type Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 02/15] mfd: max14577: Rename and add MAX14577 symbols to prepare for max77836 Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 03/15] mfd: max14577: Rename state container to maxim_core Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 04/15] mfd: max14577: Add "muic" suffix to regmap and irq_chip Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 05/15] mfd: max14577: Add detection of device type Krzysztof Kozlowski
2014-02-07 10:53 ` Lee Jones
2014-02-07 10:04 ` [PATCH v2 06/15] extcon: max14577: Add max14577 prefix to muic_irqs Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 07/15] extcon: max14577: Choose muic_irqs according to device type Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 08/15] mfd: max77836: Add max77836 support to max14577 driver Krzysztof Kozlowski
2014-02-07 10:48 ` Lee Jones
2014-02-07 10:49 ` Lee Jones
2014-02-07 10:54 ` Krzysztof Kozlowski [this message]
2014-02-10 12:02 ` Lee Jones
2014-02-07 10:04 ` [PATCH v2 09/15] extcon: max14577: Add support for max77836 Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 10/15] regulator: max14577: Add support for max77836 regulators Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 11/15] charger: max14577: Add support for MAX77836 charger Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 12/15] power: max17040: Add ID for max77836 Fuel Gauge block Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 13/15] regulator/mfd: max14577: Export symbols for calculating charger current Krzysztof Kozlowski
2014-02-07 16:34 ` Mark Brown
2014-02-10 11:59 ` Lee Jones
2014-02-10 14:24 ` Lee Jones
2014-02-07 10:04 ` [PATCH v2 14/15] charger: max14577: Configure battery-dependent settings from DTS Krzysztof Kozlowski
2014-02-07 10:42 ` Lee Jones
2014-02-07 10:46 ` Krzysztof Kozlowski
2014-02-10 12:14 ` Lee Jones
2014-02-10 15:06 ` Krzysztof Kozlowski
2014-02-07 10:04 ` [PATCH v2 15/15] mfd: max14577: Add device tree bindings document Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391770442.12119.4.camel@AMDC1943 \
--to=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox