From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 5/5] ACPI: Replace printk with pr_* in tables.c
Date: Tue, 18 Feb 2014 06:06:13 -0800 [thread overview]
Message-ID: <1392732373.22752.22.camel@joe-AO722> (raw)
In-Reply-To: <1392731700-10992-6-git-send-email-hanjun.guo@linaro.org>
On Tue, 2014-02-18 at 21:55 +0800, Hanjun Guo wrote:
> This patch just do some clean up to replace printk with pr_*,
> no functional change.
trivial note:
> diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
[]
> @@ -55,8 +55,7 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header)
> {
> struct acpi_madt_local_apic *p =
> (struct acpi_madt_local_apic *)header;
> - printk(KERN_INFO PREFIX
> - "LAPIC (acpi_id[0x%02x] lapic_id[0x%02x] %s)\n",
> + pr_info(PREFIX "LAPIC (acpi_id[0x%02x] lapic_id[0x%02x] %s)\n",
> p->processor_id, p->id,
> (p->lapic_flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled");
It'd be nice to realign the additional lines to the open
parenthesis, here and everywhere else in this patch
pr_info(PREFIX "LAPIC (acpi_id[0x%02x] lapic_id[0x%02x] %s)\n",
p->processor_id, p->id,
(p->lapic_flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled");
next prev parent reply other threads:[~2014-02-18 14:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 13:54 [PATCH v4 0/5] Prepare for running ACPI on !x86 and !ia64 Hanjun Guo
2014-02-18 13:54 ` [PATCH v4 1/5] ACPI / idle: Make idle_boot_override depend on x86 and ia64 Hanjun Guo
2014-02-18 13:54 ` [PATCH v4 2/5] ACPI / processor_core: Rework _PDC related stuff to make it more arch-independent Hanjun Guo
2014-02-18 13:54 ` [PATCH v4 3/5] ACPI / processor: Introduce map_gic_id() to get apic id from MADT or _MAT method Hanjun Guo
2014-02-18 13:54 ` [PATCH v4 4/5] ACPI: Move BAD_MADT_ENTRY() to linux/acpi.h Hanjun Guo
2014-02-18 13:55 ` [PATCH v4 5/5] ACPI: Replace printk with pr_* in tables.c Hanjun Guo
2014-02-18 14:06 ` Joe Perches [this message]
2014-02-18 14:37 ` Hanjun Guo
2014-02-19 16:32 ` [Linaro-acpi] " Sudeep Holla
2014-02-19 16:49 ` Rafael J. Wysocki
2014-02-19 16:46 ` Sudeep Holla
2014-02-20 0:37 ` Rafael J. Wysocki
2014-02-20 2:10 ` Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392732373.22752.22.camel@joe-AO722 \
--to=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox