From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 1/3] net: phy: prevent linking breakage
Date: Tue, 04 Jun 2013 18:01:07 +0200 [thread overview]
Message-ID: <1394174.ONngHnHYKL@wuerfel> (raw)
In-Reply-To: <CAGVrzcbRS3x5fgD1BfOk4-oTUsAY9FA2V621OvZLJQNZ01brCg@mail.gmail.com>
On Tuesday 04 June 2013 16:36:50 Florian Fainelli wrote:
> It seems to me that what David proposes is to have say an
> arch/arm/mach-foo/phy-fixups.c file which is only enabled when
> CONFIG_PHYLIB is set (obj-$(CONFIG_PHYLIB) += phy-fixup.o), such that
> it does not need to have any conditionnals when calling
> phy_register_fixup. This sounds a little unusual, but why not.
I don't think it would actually help us, because then we still need
to declare a local function that gets called from the board init
code. Instead of doing
if (IS_ENABLED(CONFIG_PHYLIB))
phy_register_fixup_for_uid(phy_id, foo_phy_fixup);
we would then do
if (IS_ENABLED(CONFIG_PHYLIB))
foo_phy_fixup_register();
which is not much different at all.
Arnd
next prev parent reply other threads:[~2013-06-04 16:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 11:43 [PATCHv2 0/3] net: phy: prevent linking breakage Alexandre Belloni
2013-05-28 11:43 ` [PATCHv2 1/3] " Alexandre Belloni
2013-05-28 20:09 ` David Miller
2013-05-29 8:21 ` Alexandre Belloni
2013-05-30 9:42 ` David Miller
2013-06-04 15:07 ` Arnd Bergmann
2013-06-04 15:36 ` Florian Fainelli
2013-06-04 16:01 ` Arnd Bergmann [this message]
2013-06-04 16:09 ` Florian Fainelli
2013-06-04 17:17 ` Arnd Bergmann
2013-06-05 9:23 ` Alexandre Belloni
2013-06-05 11:21 ` Arnd Bergmann
2013-05-28 11:43 ` [PATCHv2 2/3] arm: mxs: don't check for CONFIG_PHYLIB as builtin Alexandre Belloni
2013-05-28 11:43 ` [PATCHv2 3/3] arm: imx: " Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394174.ONngHnHYKL@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox