From: florian@openwrt.org (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/8] gpio: 74x164: Use devm_kzalloc
Date: Wed, 05 Sep 2012 10:46:50 +0200 [thread overview]
Message-ID: <1395490.g7fi05sBYN@flexo> (raw)
In-Reply-To: <1346834457-6257-2-git-send-email-maxime.ripard@free-electrons.com>
On Wednesday 05 September 2012 10:40:51 Maxime Ripard wrote:
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Acked-by: Florian Fainelli <florian@openwrt.org>
> ---
> drivers/gpio/gpio-74x164.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpio/gpio-74x164.c b/drivers/gpio/gpio-74x164.c
> index 2975036..604b998 100644
> --- a/drivers/gpio/gpio-74x164.c
> +++ b/drivers/gpio/gpio-74x164.c
> @@ -90,7 +90,7 @@ static int __devinit gen_74x164_probe(struct spi_device
*spi)
> if (ret < 0)
> return ret;
>
> - chip = kzalloc(sizeof(*chip), GFP_KERNEL);
> + chip = devm_kzalloc(&spi->dev, sizeof(*chip), GFP_KERNEL);
> if (!chip)
> return -ENOMEM;
>
> @@ -125,7 +125,6 @@ static int __devinit gen_74x164_probe(struct spi_device
*spi)
> exit_destroy:
> dev_set_drvdata(&spi->dev, NULL);
> mutex_destroy(&chip->lock);
> - kfree(chip);
> return ret;
> }
>
> @@ -141,10 +140,9 @@ static int __devexit gen_74x164_remove(struct
spi_device *spi)
> dev_set_drvdata(&spi->dev, NULL);
>
> ret = gpiochip_remove(&chip->gpio_chip);
> - if (!ret) {
> + if (!ret)
> mutex_destroy(&chip->lock);
> - kfree(chip);
> - } else
> + else
> dev_err(&spi->dev, "Failed to remove the GPIO controller: %d\n",
> ret);
>
> --
> 1.7.9.5
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2012-09-05 8:46 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 8:40 [PATCH 1/8] gpio: 74x164: Use module_spi_driver boiler plate function Maxime Ripard
2012-09-05 8:40 ` [PATCH 2/8] gpio: 74x164: Use devm_kzalloc Maxime Ripard
2012-09-05 8:46 ` Florian Fainelli [this message]
2012-09-05 9:16 ` Thomas Petazzoni
2012-09-06 7:22 ` Linus Walleij
2012-09-07 21:02 ` Linus Walleij
2012-09-05 8:40 ` [PATCH 3/8] gpio: 74x164: Remove platform data and use dynamic gpio number assignment Maxime Ripard
2012-09-05 8:48 ` Florian Fainelli
2012-09-05 9:15 ` Thomas Petazzoni
2012-09-05 9:17 ` Thomas Petazzoni
2012-09-05 8:40 ` [PATCH 4/8] gpio: 74x164: Add device tree support Maxime Ripard
2012-09-05 8:50 ` Florian Fainelli
2012-09-05 9:17 ` Thomas Petazzoni
2012-09-06 7:22 ` Linus Walleij
2012-09-05 8:40 ` [PATCH 5/8] gpio: 74x164: Add output pin support Maxime Ripard
2012-09-05 9:20 ` Thomas Petazzoni
2012-09-05 9:46 ` Eric Bénard
2012-09-05 10:09 ` Thomas Petazzoni
2012-09-05 10:26 ` Eric Bénard
2012-09-05 11:56 ` Thomas Petazzoni
2012-09-05 12:22 ` Eric Bénard
2012-09-05 12:29 ` Thomas Petazzoni
2012-09-05 12:54 ` Eric Bénard
2012-09-05 13:02 ` Maxime Ripard
2012-09-05 13:27 ` Eric Bénard
2012-09-05 8:40 ` [PATCH 6/8] gpio: 74x164: Add support for daisy-chaining Maxime Ripard
2012-09-05 8:56 ` Thomas Petazzoni
2012-09-05 8:40 ` [PATCH 7/8] gpio: 74x164: dts: Add documentation for the dt binding Maxime Ripard
2012-09-05 8:40 ` [PATCH 8/8] ARM: dts: cfa10049: Add the 74HC595 gpio expanders Maxime Ripard
2012-09-05 8:46 ` [PATCH 1/8] gpio: 74x164: Use module_spi_driver boiler plate function Florian Fainelli
2012-09-05 9:16 ` Thomas Petazzoni
2012-09-06 7:21 ` Linus Walleij
2012-09-06 14:10 ` Maxime Ripard
2012-09-07 21:09 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395490.g7fi05sBYN@flexo \
--to=florian@openwrt.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox