From: florian@openwrt.org (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/8] gpio: 74x164: Remove platform data and use dynamic gpio number assignment
Date: Wed, 05 Sep 2012 10:48:14 +0200 [thread overview]
Message-ID: <9763805.kende5OlsI@flexo> (raw)
In-Reply-To: <1346834457-6257-3-git-send-email-maxime.ripard@free-electrons.com>
On Wednesday 05 September 2012 10:40:52 Maxime Ripard wrote:
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
No, please don't do it that way, rather check if the platform_data pointer is
null, and if it is, fall-back to dynamic gpio base assignment. There is a
currently out of tree user of this for which it matters to be able to set a
specific gpio base numbering.
> ---
> drivers/gpio/gpio-74x164.c | 10 +---------
> include/linux/spi/74x164.h | 9 ---------
> 2 files changed, 1 insertion(+), 18 deletions(-)
> delete mode 100644 include/linux/spi/74x164.h
>
> diff --git a/drivers/gpio/gpio-74x164.c b/drivers/gpio/gpio-74x164.c
> index 604b998..24cfe4c 100644
> --- a/drivers/gpio/gpio-74x164.c
> +++ b/drivers/gpio/gpio-74x164.c
> @@ -12,7 +12,6 @@
> #include <linux/init.h>
> #include <linux/mutex.h>
> #include <linux/spi/spi.h>
> -#include <linux/spi/74x164.h>
> #include <linux/gpio.h>
> #include <linux/slab.h>
> #include <linux/module.h>
> @@ -72,15 +71,8 @@ static int gen_74x164_direction_output(struct gpio_chip
*gc,
> static int __devinit gen_74x164_probe(struct spi_device *spi)
> {
> struct gen_74x164_chip *chip;
> - struct gen_74x164_chip_platform_data *pdata;
> int ret;
>
> - pdata = spi->dev.platform_data;
> - if (!pdata || !pdata->base) {
> - dev_dbg(&spi->dev, "incorrect or missing platform data\n");
> - return -EINVAL;
> - }
> -
> /*
> * bits_per_word cannot be configured in platform data
> */
> @@ -104,7 +96,7 @@ static int __devinit gen_74x164_probe(struct spi_device
*spi)
> chip->gpio_chip.direction_output = gen_74x164_direction_output;
> chip->gpio_chip.get = gen_74x164_get_value;
> chip->gpio_chip.set = gen_74x164_set_value;
> - chip->gpio_chip.base = pdata->base;
> + chip->gpio_chip.base = -1;
> chip->gpio_chip.ngpio = 8;
> chip->gpio_chip.can_sleep = 1;
> chip->gpio_chip.dev = &spi->dev;
> diff --git a/include/linux/spi/74x164.h b/include/linux/spi/74x164.h
> deleted file mode 100644
> index 0aa6acc..0000000
> --- a/include/linux/spi/74x164.h
> +++ /dev/null
> @@ -1,9 +0,0 @@
> -#ifndef LINUX_SPI_74X164_H
> -#define LINUX_SPI_74X164_H
> -
> -struct gen_74x164_chip_platform_data {
> - /* number assigned to the first GPIO */
> - unsigned base;
> -};
> -
> -#endif
> --
> 1.7.9.5
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2012-09-05 8:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 8:40 [PATCH 1/8] gpio: 74x164: Use module_spi_driver boiler plate function Maxime Ripard
2012-09-05 8:40 ` [PATCH 2/8] gpio: 74x164: Use devm_kzalloc Maxime Ripard
2012-09-05 8:46 ` Florian Fainelli
2012-09-05 9:16 ` Thomas Petazzoni
2012-09-06 7:22 ` Linus Walleij
2012-09-07 21:02 ` Linus Walleij
2012-09-05 8:40 ` [PATCH 3/8] gpio: 74x164: Remove platform data and use dynamic gpio number assignment Maxime Ripard
2012-09-05 8:48 ` Florian Fainelli [this message]
2012-09-05 9:15 ` Thomas Petazzoni
2012-09-05 9:17 ` Thomas Petazzoni
2012-09-05 8:40 ` [PATCH 4/8] gpio: 74x164: Add device tree support Maxime Ripard
2012-09-05 8:50 ` Florian Fainelli
2012-09-05 9:17 ` Thomas Petazzoni
2012-09-06 7:22 ` Linus Walleij
2012-09-05 8:40 ` [PATCH 5/8] gpio: 74x164: Add output pin support Maxime Ripard
2012-09-05 9:20 ` Thomas Petazzoni
2012-09-05 9:46 ` Eric Bénard
2012-09-05 10:09 ` Thomas Petazzoni
2012-09-05 10:26 ` Eric Bénard
2012-09-05 11:56 ` Thomas Petazzoni
2012-09-05 12:22 ` Eric Bénard
2012-09-05 12:29 ` Thomas Petazzoni
2012-09-05 12:54 ` Eric Bénard
2012-09-05 13:02 ` Maxime Ripard
2012-09-05 13:27 ` Eric Bénard
2012-09-05 8:40 ` [PATCH 6/8] gpio: 74x164: Add support for daisy-chaining Maxime Ripard
2012-09-05 8:56 ` Thomas Petazzoni
2012-09-05 8:40 ` [PATCH 7/8] gpio: 74x164: dts: Add documentation for the dt binding Maxime Ripard
2012-09-05 8:40 ` [PATCH 8/8] ARM: dts: cfa10049: Add the 74HC595 gpio expanders Maxime Ripard
2012-09-05 8:46 ` [PATCH 1/8] gpio: 74x164: Use module_spi_driver boiler plate function Florian Fainelli
2012-09-05 9:16 ` Thomas Petazzoni
2012-09-06 7:21 ` Linus Walleij
2012-09-06 14:10 ` Maxime Ripard
2012-09-07 21:09 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9763805.kende5OlsI@flexo \
--to=florian@openwrt.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox