* [PATCH] ARM: remove check for CONFIG_DEBUG_LL_SER3 @ 2014-05-14 8:12 Paul Bolle 2014-05-14 10:28 ` Arnd Bergmann 0 siblings, 1 reply; 6+ messages in thread From: Paul Bolle @ 2014-05-14 8:12 UTC (permalink / raw) To: linux-arm-kernel A check for CONFIG_DEBUG_LL_SER3 was added in v2.5.43. But the related symbol DEBUG_LL_SER3 was already removed in v2.5.8. This check has always evaluated to false. Remove it. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> --- Untested. arch/arm/boot/compressed/head.S | 4 ---- 1 file changed, 4 deletions(-) diff --git a/arch/arm/boot/compressed/head.S b/arch/arm/boot/compressed/head.S index 066b03480b63..c16e8bf31e0b 100644 --- a/arch/arm/boot/compressed/head.S +++ b/arch/arm/boot/compressed/head.S @@ -54,11 +54,7 @@ #if defined(CONFIG_ARCH_SA1100) .macro loadsp, rb, tmp mov \rb, #0x80000000 @ physical base address -#ifdef CONFIG_DEBUG_LL_SER3 - add \rb, \rb, #0x00050000 @ Ser3 -#else add \rb, \rb, #0x00010000 @ Ser1 -#endif .endm #elif defined(CONFIG_ARCH_S3C24XX) .macro loadsp, rb, tmp -- 1.9.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: remove check for CONFIG_DEBUG_LL_SER3 2014-05-14 8:12 [PATCH] ARM: remove check for CONFIG_DEBUG_LL_SER3 Paul Bolle @ 2014-05-14 10:28 ` Arnd Bergmann 0 siblings, 0 replies; 6+ messages in thread From: Arnd Bergmann @ 2014-05-14 10:28 UTC (permalink / raw) To: linux-arm-kernel On Wednesday 14 May 2014 10:12:07 Paul Bolle wrote: > #if defined(CONFIG_ARCH_SA1100) > .macro loadsp, rb, tmp > mov \rb, #0x80000000 @ physical base address > -#ifdef CONFIG_DEBUG_LL_SER3 > - add \rb, \rb, #0x00050000 @ Ser3 > -#else > add \rb, \rb, #0x00010000 @ Ser1 > -#endif > .endm > #elif defined(CONFIG_ARCH_S3C24XX) > .macro loadsp, rb, tmp I wonder if the entire CONFIG_ARCH_SA1100 section here is actually needed at all, or if it should just use the #else path that calls addruart, which is defined as .macro addruart, rp, rv, tmp mrc p15, 0, \rp, c1, c0 tst \rp, #1 @ MMU enabled? moveq \rp, #0x80000000 @ physical base address movne \rp, #0xf8000000 @ virtual address @ We probe for the active serial port here, coherently with @ the comment in arch/arm/mach-sa1100/include/mach/uncompress.h. @ We assume r1 can be clobbered. @ see if Ser3 is active add \rp, \rp, #0x00050000 ldr \rv, [\rp, #UTCR3] tst \rv, #UTCR3_TXE @ if Ser3 is inactive, then try Ser1 addeq \rp, \rp, #(0x00010000 - 0x00050000) ldreq \rv, [\rp, #UTCR3] tsteq \rv, #UTCR3_TXE @ if Ser1 is inactive, then try Ser2 addeq \rp, \rp, #(0x00030000 - 0x00010000) ldreq \rv, [\rp, #UTCR3] tsteq \rv, #UTCR3_TXE @ clear top bits, and generate both phys and virt addresses lsl \rp, \rp, #8 lsr \rp, \rp, #8 orr \rv, \rp, #0xf8000000 @ virtual orr \rp, \rp, #0x80000000 @ physical .endm There is a CONFIG_ARCH_S3C24XX case just below it, and I'm pretty sure that one can be removed, because the loadsp implementation for s3c24xx is basically the same as the addruart code. Russell removed most of the other cases in 5cd0c3442021 "ARM: decompressor: use platform debug macros", but I can't find an explanation for why s3c24xx, sa1100 and iop331 were left at the time. Arnd ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: remove check for CONFIG_DEBUG_LL_SER3 @ 2022-09-28 6:42 Geert Uytterhoeven 2022-10-04 7:44 ` Linus Walleij 0 siblings, 1 reply; 6+ messages in thread From: Geert Uytterhoeven @ 2022-09-28 6:42 UTC (permalink / raw) To: Arnd Bergmann Cc: Russell King, Ard Biesheuvel, Russell King, Linus Walleij, Paul Bolle, linux-arm-kernel, linux-kernel, Geert Uytterhoeven From: Paul Bolle <pebolle@tiscali.nl> A check for CONFIG_DEBUG_LL_SER3 was added in v2.5.43. But the related symbol DEBUG_LL_SER3 was already removed in v2.5.8. This check has always evaluated to false. Remove it. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- Still valid after 8 years... Link: https://lore.kernel.org/r/1400055127.31197.1.camel@x220 --- arch/arm/boot/compressed/head.S | 4 ---- 1 file changed, 4 deletions(-) diff --git a/arch/arm/boot/compressed/head.S b/arch/arm/boot/compressed/head.S index bf79f2f78d232306..9f406e9c0ea6f74b 100644 --- a/arch/arm/boot/compressed/head.S +++ b/arch/arm/boot/compressed/head.S @@ -67,11 +67,7 @@ #if defined(CONFIG_ARCH_SA1100) .macro loadsp, rb, tmp1, tmp2 mov \rb, #0x80000000 @ physical base address -#ifdef CONFIG_DEBUG_LL_SER3 - add \rb, \rb, #0x00050000 @ Ser3 -#else add \rb, \rb, #0x00010000 @ Ser1 -#endif .endm #else .macro loadsp, rb, tmp1, tmp2 -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: remove check for CONFIG_DEBUG_LL_SER3 2022-09-28 6:42 Geert Uytterhoeven @ 2022-10-04 7:44 ` Linus Walleij 2022-10-04 7:48 ` Geert Uytterhoeven 0 siblings, 1 reply; 6+ messages in thread From: Linus Walleij @ 2022-10-04 7:44 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Arnd Bergmann, Russell King, Ard Biesheuvel, Russell King, Paul Bolle, linux-arm-kernel, linux-kernel On Wed, Sep 28, 2022 at 12:14 PM Geert Uytterhoeven <geert+renesas@glider.be> wrote: > From: Paul Bolle <pebolle@tiscali.nl> > > A check for CONFIG_DEBUG_LL_SER3 was added in v2.5.43. But the related > symbol DEBUG_LL_SER3 was already removed in v2.5.8. This check has > always evaluated to false. Remove it. > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > Still valid after 8 years... > Link: https://lore.kernel.org/r/1400055127.31197.1.camel@x220 :D Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Please put this into Russell's patch tracker. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: remove check for CONFIG_DEBUG_LL_SER3 2022-10-04 7:44 ` Linus Walleij @ 2022-10-04 7:48 ` Geert Uytterhoeven 2022-10-04 18:55 ` Paul Bolle 0 siblings, 1 reply; 6+ messages in thread From: Geert Uytterhoeven @ 2022-10-04 7:48 UTC (permalink / raw) To: Linus Walleij Cc: Arnd Bergmann, Russell King, Ard Biesheuvel, Russell King, Paul Bolle, linux-arm-kernel, linux-kernel Hi Linus, On Tue, Oct 4, 2022 at 9:44 AM Linus Walleij <linus.walleij@linaro.org> wrote: > On Wed, Sep 28, 2022 at 12:14 PM Geert Uytterhoeven > <geert+renesas@glider.be> wrote: > > From: Paul Bolle <pebolle@tiscali.nl> > > > > A check for CONFIG_DEBUG_LL_SER3 was added in v2.5.43. But the related > > symbol DEBUG_LL_SER3 was already removed in v2.5.8. This check has > > always evaluated to false. Remove it. > > > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > --- > > Still valid after 8 years... > > Link: https://lore.kernel.org/r/1400055127.31197.1.camel@x220 > > :D > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Thanks! > Please put this into Russell's patch tracker. Arnd took it into soc/for-next as commit 4413794917ba3ff4 ("ARM: remove check for CONFIG_DEBUG_LL_SER3"). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: remove check for CONFIG_DEBUG_LL_SER3 2022-10-04 7:48 ` Geert Uytterhoeven @ 2022-10-04 18:55 ` Paul Bolle 0 siblings, 0 replies; 6+ messages in thread From: Paul Bolle @ 2022-10-04 18:55 UTC (permalink / raw) To: Geert Uytterhoeven, Linus Walleij Cc: Arnd Bergmann, Russell King, Ard Biesheuvel, Russell King, linux-arm-kernel, linux-kernel Geert Uytterhoeven schreef op di 04-10-2022 om 09:48 [+0200]: > Arnd took it into soc/for-next as commit 4413794917ba3ff4 ("ARM: > remove check for CONFIG_DEBUG_LL_SER3"). This is really nice! One of the few of the commits that I'm actually proud of is e5a7286b5f1b ("x86, boot: Remove ancient, unconditionally #ifdef'd out dead code"). That commit removed code that was dead for sixteen years. This patch - if it crosses the finish line - will remove code that's been dead for twenty years. Yay Geert! I'm so glad this patch was hibernated for eight years, promoting code dead for twelve years to code dead for twenty years. But there must be even older dead code in the tree. So let's make this a contest! I'll ship some Dutch treats to the author of a patch that removes code that has been dead for the longest time when committed by Linus no later than December 5th, 2022. (Wikipedia can explain this odd deadline.) Grave diggers: on your mark! Paul Bolle _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-10-04 18:56 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-05-14 8:12 [PATCH] ARM: remove check for CONFIG_DEBUG_LL_SER3 Paul Bolle 2014-05-14 10:28 ` Arnd Bergmann -- strict thread matches above, loose matches on Subject: below -- 2022-09-28 6:42 Geert Uytterhoeven 2022-10-04 7:44 ` Linus Walleij 2022-10-04 7:48 ` Geert Uytterhoeven 2022-10-04 18:55 ` Paul Bolle
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox