From: stephanolbrich@gmx.de (Stephan Olbrich)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] spi: bcm2835aux: fix bitmask defines
Date: Wed, 10 Feb 2016 21:08:55 +0100 [thread overview]
Message-ID: <14130392.6x8cIOuJmD@chaos-desktop> (raw)
In-Reply-To: <56BA43DB.7030209@lategoodbye.de>
Hi Stefan
Am Tuesday 09 February 2016, 20:54:03 schrieb Stefan Wahren:
> Hi Stephan,
>
> Am 09.02.2016 um 19:10 schrieb stephanolbrich at gmx.de:
> > From: Stephan Olbrich <stephanolbrich@gmx.de>
> >
> > The bitmasks for txempty and idle interrupts were interchanged.
> >
> > Signed-off-by: Stephan Olbrich <stephanolbrich@gmx.de>
> > ---
> >
> > drivers/spi/spi-bcm2835aux.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/spi/spi-bcm2835aux.c b/drivers/spi/spi-bcm2835aux.c
> > index 7de6f84..ecc73c0 100644
> > --- a/drivers/spi/spi-bcm2835aux.c
> > +++ b/drivers/spi/spi-bcm2835aux.c
> > @@ -73,8 +73,8 @@
> >
> > /* Bitfields in CNTL1 */
> > #define BCM2835_AUX_SPI_CNTL1_CSHIGH 0x00000700
> >
> > -#define BCM2835_AUX_SPI_CNTL1_IDLE 0x00000080
> > -#define BCM2835_AUX_SPI_CNTL1_TXEMPTY 0x00000040
>
> according to a comment in this file these values are from
> brcm_usrlib/dag/vmcsx/vcinclude/bcm2708_chip/aux_io.h.
>
> So you want to say that at least these 2 are wrong and you took the
> values from BCM2835-ARM-Peripherals.pdf [1]?
>
> I think it's worth to mention it.
Actually I stumbled across this while writing the second patch in this series
and the wrong interrupt got disabled but BCM2835-ARM-Peripherals.pdf did
confirm my findings.
As Mark has already applied this patch I can't add any comment to it anymore,
right?
> [1] -
> https://www.raspberrypi.org/wp-content/uploads/2012/02/BCM2835-ARM-Periphera
> ls.pdf
> > +#define BCM2835_AUX_SPI_CNTL1_TXEMPTY 0x00000080
> > +#define BCM2835_AUX_SPI_CNTL1_IDLE 0x00000040
> >
> > #define BCM2835_AUX_SPI_CNTL1_MSBF_IN 0x00000002
> > #define BCM2835_AUX_SPI_CNTL1_KEEP_IN 0x00000001
>
> _______________________________________________
> linux-rpi-kernel mailing list
> linux-rpi-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rpi-kernel
next prev parent reply other threads:[~2016-02-10 20:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 18:10 [PATCH 0/4] spi: bcm2835aux: auxiliary spi improvements stephanolbrich at gmx.de
2016-02-09 18:10 ` [PATCH 1/4] spi: bcm2835aux: fix bitmask defines stephanolbrich at gmx.de
2016-02-09 19:54 ` Stefan Wahren
2016-02-10 20:08 ` Stephan Olbrich [this message]
2016-02-09 23:44 ` Eric Anholt
2016-02-09 18:10 ` [PATCH 2/4] spi: bcm2835aux: disable tx fifo empty irq stephanolbrich at gmx.de
2016-02-09 23:45 ` Eric Anholt
2016-02-09 18:10 ` [PATCH 3/4] spi: bcm2835aux: set up spi-mode before asserting cs-gpio stephanolbrich at gmx.de
2016-02-09 23:49 ` Eric Anholt
2016-02-10 8:01 ` Mark Brown
2016-02-10 18:59 ` Eric Anholt
2016-02-10 19:02 ` Mark Brown
2016-02-10 20:26 ` Stephan Olbrich
2016-02-10 23:19 ` Martin Sperl
2016-02-11 12:27 ` Mark Brown
2016-02-11 18:06 ` Martin Sperl
2016-02-09 18:10 ` [PATCH 4/4] spi: bcm2835aux: fix CPOL/CPHA setting stephanolbrich at gmx.de
2016-02-09 20:21 ` Stefan Wahren
2016-02-10 0:13 ` Eric Anholt
2016-02-10 20:45 ` Stephan Olbrich
2016-02-10 21:24 ` Eric Anholt
2016-02-11 15:25 ` Martin Sperl
2016-02-11 16:05 ` Stephan Olbrich
2016-02-11 16:19 ` Martin Sperl
2016-02-11 18:44 ` Martin Sperl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14130392.6x8cIOuJmD@chaos-desktop \
--to=stephanolbrich@gmx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox