From: stephanolbrich@gmx.de (Stephan Olbrich)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] spi: bcm2835aux: set up spi-mode before asserting cs-gpio
Date: Wed, 10 Feb 2016 21:26:05 +0100 [thread overview]
Message-ID: <2743238.b2UJKq0efN@chaos-desktop> (raw)
In-Reply-To: <20160210190204.GD13270@sirena.org.uk>
Am Wednesday 10 February 2016, 19:02:04 schrieb Mark Brown:
> On Wed, Feb 10, 2016 at 10:59:29AM -0800, Eric Anholt wrote:
> > Oops, this makes more sense now. Subject even mentioned gpio, and a
> > GPIO CS must be getting set around the transfer_one call. I'll be ready
> > to send an r-b for a v2 with the speed update bug fixed (unless transfer
> > speeds are guaranteed to be constant between a prepare and unprepare).
>
> No guarantee that they'll not change, especially in a situation where we
> have two devices on different speeds on a bus working at the same time.
Are you saying, that between a prepare and unprepare there could be transfers
for another device? Then all the clock setting couldn't be done in prepare
either.
Apart from that, if two transfers in the same message are not guarantied to
have the same speed, this still needs to be fixed. I'll roll a v2.
next prev parent reply other threads:[~2016-02-10 20:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 18:10 [PATCH 0/4] spi: bcm2835aux: auxiliary spi improvements stephanolbrich at gmx.de
2016-02-09 18:10 ` [PATCH 1/4] spi: bcm2835aux: fix bitmask defines stephanolbrich at gmx.de
2016-02-09 19:54 ` Stefan Wahren
2016-02-10 20:08 ` Stephan Olbrich
2016-02-09 23:44 ` Eric Anholt
2016-02-09 18:10 ` [PATCH 2/4] spi: bcm2835aux: disable tx fifo empty irq stephanolbrich at gmx.de
2016-02-09 23:45 ` Eric Anholt
2016-02-09 18:10 ` [PATCH 3/4] spi: bcm2835aux: set up spi-mode before asserting cs-gpio stephanolbrich at gmx.de
2016-02-09 23:49 ` Eric Anholt
2016-02-10 8:01 ` Mark Brown
2016-02-10 18:59 ` Eric Anholt
2016-02-10 19:02 ` Mark Brown
2016-02-10 20:26 ` Stephan Olbrich [this message]
2016-02-10 23:19 ` Martin Sperl
2016-02-11 12:27 ` Mark Brown
2016-02-11 18:06 ` Martin Sperl
2016-02-09 18:10 ` [PATCH 4/4] spi: bcm2835aux: fix CPOL/CPHA setting stephanolbrich at gmx.de
2016-02-09 20:21 ` Stefan Wahren
2016-02-10 0:13 ` Eric Anholt
2016-02-10 20:45 ` Stephan Olbrich
2016-02-10 21:24 ` Eric Anholt
2016-02-11 15:25 ` Martin Sperl
2016-02-11 16:05 ` Stephan Olbrich
2016-02-11 16:19 ` Martin Sperl
2016-02-11 18:44 ` Martin Sperl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2743238.b2UJKq0efN@chaos-desktop \
--to=stephanolbrich@gmx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox