* [PATCH] mtd: nand: gpmi: remove deprecated comment
@ 2014-12-02 18:37 Boris Brezillon
2014-12-03 0:30 ` Huang Shijie
2014-12-17 1:27 ` Brian Norris
0 siblings, 2 replies; 3+ messages in thread
From: Boris Brezillon @ 2014-12-02 18:37 UTC (permalink / raw)
To: linux-arm-kernel
Now that we have raw functions properly implemented we can remove this
FIXME.
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
---
drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
index 4f3851a..5d2cc9e 100644
--- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
+++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
@@ -1294,14 +1294,6 @@ exit_auxiliary:
* ecc.read_page or ecc.read_page_raw function. Thus, the fact that MTD wants an
* ECC-based or raw view of the page is implicit in which function it calls
* (there is a similar pair of ECC-based/raw functions for writing).
- *
- * FIXME: The following paragraph is incorrect, now that there exist
- * ecc.read_oob_raw and ecc.write_oob_raw functions.
- *
- * Since MTD assumes the OOB is not covered by ECC, there is no pair of
- * ECC-based/raw functions for reading or or writing the OOB. The fact that the
- * caller wants an ECC-based or raw view of the page is not propagated down to
- * this driver.
*/
static int gpmi_ecc_read_oob(struct mtd_info *mtd, struct nand_chip *chip,
int page)
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] mtd: nand: gpmi: remove deprecated comment
2014-12-02 18:37 [PATCH] mtd: nand: gpmi: remove deprecated comment Boris Brezillon
@ 2014-12-03 0:30 ` Huang Shijie
2014-12-17 1:27 ` Brian Norris
1 sibling, 0 replies; 3+ messages in thread
From: Huang Shijie @ 2014-12-03 0:30 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Dec 02, 2014 at 07:37:09PM +0100, Boris Brezillon wrote:
> Now that we have raw functions properly implemented we can remove this
> FIXME.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> index 4f3851a..5d2cc9e 100644
> --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> @@ -1294,14 +1294,6 @@ exit_auxiliary:
> * ecc.read_page or ecc.read_page_raw function. Thus, the fact that MTD wants an
> * ECC-based or raw view of the page is implicit in which function it calls
> * (there is a similar pair of ECC-based/raw functions for writing).
> - *
> - * FIXME: The following paragraph is incorrect, now that there exist
> - * ecc.read_oob_raw and ecc.write_oob_raw functions.
> - *
> - * Since MTD assumes the OOB is not covered by ECC, there is no pair of
> - * ECC-based/raw functions for reading or or writing the OOB. The fact that the
> - * caller wants an ECC-based or raw view of the page is not propagated down to
> - * this driver.
> */
> static int gpmi_ecc_read_oob(struct mtd_info *mtd, struct nand_chip *chip,
> int page)
Acked-by: Huang Shijie <shijie.huang@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] mtd: nand: gpmi: remove deprecated comment
2014-12-02 18:37 [PATCH] mtd: nand: gpmi: remove deprecated comment Boris Brezillon
2014-12-03 0:30 ` Huang Shijie
@ 2014-12-17 1:27 ` Brian Norris
1 sibling, 0 replies; 3+ messages in thread
From: Brian Norris @ 2014-12-17 1:27 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Dec 02, 2014 at 07:37:09PM +0100, Boris Brezillon wrote:
> Now that we have raw functions properly implemented we can remove this
> FIXME.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Pushed to l2-mtd.git/next. Thanks!
Brian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-17 1:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-02 18:37 [PATCH] mtd: nand: gpmi: remove deprecated comment Boris Brezillon
2014-12-03 0:30 ` Huang Shijie
2014-12-17 1:27 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox