public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: yingjoe.chen@mediatek.com (Yingjoe Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] arm64: mediatek: Add config option for mt8173.
Date: Wed, 4 Mar 2015 18:01:29 +0800	[thread overview]
Message-ID: <1425463289.21342.41.camel@mtksdaap41> (raw)
In-Reply-To: <2108883.zjHYNOn4mC@wuerfel>

On Wed, 2015-03-04 at 10:53 +0100, Arnd Bergmann wrote:
> On Wednesday 04 March 2015 10:31:07 Yingjoe Chen wrote:
> > Hi,
> > 
> > Since we support devicetree, we don't need MACH_* to build a working
> > kernel. This is true even for our v7 soc. We intend to use it to reduce
> > numbers of drivers in product kernel binary.
> > Most drivers are shared among the same SoCs family, but some are not.
> > Currently for pinctrl driver, we are doing this so user don't need to
> > select them one by one:
> > 
> > config PINCTRL_MT8173
> >         def_bool MACH_MT8173
> >         select PINCTRL_MTK_COMMON
> > 
> > Alternatively, we could add these MACH_* to some other places, eg,
> > drivers/soc/mediatek. Or we don't add MACH_* at all, and have all
> > drivers export their own Kconfig option. User will need to select each
> > of them one-by-one.
> > 
> > What do you think?
> 
> I would rather see these as user-selectable options, which has the
> other benefit of giving compile-time coverage. For your example,
> I'd suggest doing
> 
> config PINCTRL_MT8173
>         bool "Mediatek MT8173 pin control"
> 	depends on ARCH_MEDIATEK || COMPILE_TEST
>         select PINCTRL_MTK_COMMON
> 	help
> 	   ... a useful description ...
> 

OK, I'll send a new patch to do this.
Thanks.

Joe.C

  reply	other threads:[~2015-03-04 10:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-27  7:13 Add Mediatek SoC Pinctrl/GPIO/EINT driver for MT8173 Hongzhou Yang
2015-01-27  7:13 ` [PATCH 1/3] arm64: mediatek: Add config option for mt8173 Hongzhou Yang
2015-02-10  8:21   ` Linus Walleij
2015-02-25  9:07   ` Yingjoe Chen
2015-02-25 10:51     ` Arnd Bergmann
2015-02-25 11:11       ` Catalin Marinas
2015-03-04  2:31         ` Yingjoe Chen
2015-03-04  9:53           ` Arnd Bergmann
2015-03-04 10:01             ` Yingjoe Chen [this message]
2015-01-27  7:13 ` [PATCH 2/3] arm64: mediatek: Add Pinctrl/GPIO/EINT driver " Hongzhou Yang
2015-02-10  8:20   ` Linus Walleij
2015-01-27  7:13 ` [PATCH 3/3] arm64: dts: mt8173: Add pinctrl/GPIO/EINT node " Hongzhou Yang
2015-02-10  8:22   ` Linus Walleij
2015-03-06 13:21   ` Matthias Brugger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425463289.21342.41.camel@mtksdaap41 \
    --to=yingjoe.chen@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox