Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 07/12] usb: chipidea: add a usb2 driver for ci13xxx
Date: Thu, 17 Jul 2014 13:34:38 +0200	[thread overview]
Message-ID: <14435027.UvktXyQjy4@wuerfel> (raw)
In-Reply-To: <20140717111912.GA16025@shlinux1.ap.freescale.net>

On Thursday 17 July 2014 19:19:15 Peter Chen wrote:
> 
> Currently, we are designing a generic driver, we don't know what's the
> hardware architecture, we are trying to find a solution how to set
> dma mask for all possible devices which will use this driver, Antoine's
> this patch is trying to cover this feature.
> 
> For example, 
> 
> Marvell Berlin doesn't need to set dma mask specific.
> http://marc.info/?l=linux-arm-kernel&m=140205228507045&w=2
> http://www.spinics.net/lists/linux-usb/msg110598.html
> 
> Xilinx zynq needs to set dma mask as 0xFFFFFFF0
> http://marc.info/?l=linux-usb&m=140384129921706&w=2
> 
> FSL i.mx needs to set dma mask as DMA_BIT_MASK(32)
> https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/tree/drivers/usb/chipidea/ci_hdrc_imx.c?h=usb-next

Ok, I see now. I think we can safely drop it completely then:

- Berlin was only recently added and doesn't need to set the
  mask because the common code handles it just fine now.

- i.mx was added earlier, at a time where it was still necessary

- zynq just made a mistake, 0xFFFFFFF0 was never a valid mask
  and just happened to work by accident.

In summary, the 32-bit default mask will work on all of them,
and we need no special code or DT properties for it.

	Arnd

  reply	other threads:[~2014-07-17 11:34 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-16  8:25 [PATCH v3 00/12] ARM: berlin: USB support Antoine Ténart
2014-07-16  8:25 ` [PATCH v3 01/12] reset: add the Berlin reset controller driver Antoine Ténart
2014-07-16 16:39   ` Andrew Lunn
2014-07-16  8:25 ` [PATCH v3 02/12] Documentation: bindings: add reset bindings docs for Marvell Berlin SoCs Antoine Ténart
2014-07-16  8:25 ` [PATCH v3 03/12] ARM: Berlin: select the reset controller Antoine Ténart
2014-07-16  8:25 ` [PATCH v3 04/12] ARM: dts: berlin: add a required reset property in the chip controller node Antoine Ténart
2014-07-16  8:25 ` [PATCH v3 05/12] phy: add the Berlin USB PHY driver Antoine Ténart
2014-07-16  9:19   ` Varka Bhadram
2014-07-16  9:25     ` Antoine Ténart
2014-07-16  9:33       ` Varka Bhadram
2014-07-16  9:47         ` Antoine Ténart
2014-07-16  9:50           ` Varka Bhadram
2014-07-16  8:26 ` [PATCH v3 06/12] Documentation: bindings: add doc for the Berlin USB PHY Antoine Ténart
2014-07-16  8:26 ` [PATCH v3 07/12] usb: chipidea: add a usb2 driver for ci13xxx Antoine Ténart
2014-07-16  8:41   ` Arnd Bergmann
2014-07-16  9:15     ` Antoine Ténart
2014-07-16 10:14       ` Arnd Bergmann
2014-07-16 11:58         ` Peter Chen
2014-07-16 12:12           ` Arnd Bergmann
2014-07-17  1:20             ` Peter Chen
2014-07-17 10:21               ` Arnd Bergmann
2014-07-17 11:19                 ` Peter Chen
2014-07-17 11:34                   ` Arnd Bergmann [this message]
2014-07-17 12:20                   ` Russell King - ARM Linux
2014-07-25  2:18   ` Peter Chen
2014-07-25  8:07     ` Antoine Ténart
2014-07-25  8:22       ` Peter Chen
2014-07-16  8:26 ` [PATCH v3 08/12] Documentation: bindings: add doc for the USB2 ChipIdea USB driver Antoine Ténart
2014-07-16  8:39   ` Arnd Bergmann
2014-07-16  8:59     ` Antoine Ténart
2014-07-16  8:26 ` [PATCH v3 09/12] ARM: dts: berlin: add BG2Q nodes for USB support Antoine Ténart
2014-07-16  8:26 ` [PATCH v3 10/12] ARM: dts: Berlin: enable USB on the BG2Q DMP Antoine Ténart
2014-07-16  8:26 ` [PATCH v3 11/12] ARM: dts: berlin: add BG2CD nodes for USB support Antoine Ténart
2014-07-16  8:26 ` [PATCH v3 12/12] ARM: dts: berlin: enable USB on the Google Chromecast Antoine Ténart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14435027.UvktXyQjy4@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox