public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 08/12] Documentation: bindings: add doc for the USB2 ChipIdea USB driver
Date: Wed, 16 Jul 2014 10:39:36 +0200	[thread overview]
Message-ID: <23972141.94aiK9jz66@wuerfel> (raw)
In-Reply-To: <1405499166-6726-9-git-send-email-antoine.tenart@free-electrons.com>

On Wednesday 16 July 2014 10:26:02 Antoine T?nart wrote:
> +
> +Required properties:
> +- compatible: should be "chipidea,usb2"
> +- reg: base address and length of the registers
> +- interrupts: interrupt for the USB controller
> +
> +Optional properties:
> +- clocks: reference to the USB clock
> +- usb-phy: reference to the USB PHY

I think the phy reference should use the standard phy binding, using
"phys" property to refer to a node that has a "#phy-cells" property.

It seems the code gets this right, but just the documentation is wrong.

> +- vbus-supply: reference to the VBUS regulator
> +- dma-mask: DMA bit mask

No. Do not use "dma-mask" as a property, that is a pure Linux specific
concept. The DT way to express this is to use the 'dma-ranges' property
in the device's parent to describe any bus-related restrictions, and
for the driver to ask for a mask that matches what the hardware is
capable of (which may be smaller or larger than what the bus supports).

	Arnd

  reply	other threads:[~2014-07-16  8:39 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-16  8:25 [PATCH v3 00/12] ARM: berlin: USB support Antoine Ténart
2014-07-16  8:25 ` [PATCH v3 01/12] reset: add the Berlin reset controller driver Antoine Ténart
2014-07-16 16:39   ` Andrew Lunn
2014-07-16  8:25 ` [PATCH v3 02/12] Documentation: bindings: add reset bindings docs for Marvell Berlin SoCs Antoine Ténart
2014-07-16  8:25 ` [PATCH v3 03/12] ARM: Berlin: select the reset controller Antoine Ténart
2014-07-16  8:25 ` [PATCH v3 04/12] ARM: dts: berlin: add a required reset property in the chip controller node Antoine Ténart
2014-07-16  8:25 ` [PATCH v3 05/12] phy: add the Berlin USB PHY driver Antoine Ténart
2014-07-16  9:19   ` Varka Bhadram
2014-07-16  9:25     ` Antoine Ténart
2014-07-16  9:33       ` Varka Bhadram
2014-07-16  9:47         ` Antoine Ténart
2014-07-16  9:50           ` Varka Bhadram
2014-07-16  8:26 ` [PATCH v3 06/12] Documentation: bindings: add doc for the Berlin USB PHY Antoine Ténart
2014-07-16  8:26 ` [PATCH v3 07/12] usb: chipidea: add a usb2 driver for ci13xxx Antoine Ténart
2014-07-16  8:41   ` Arnd Bergmann
2014-07-16  9:15     ` Antoine Ténart
2014-07-16 10:14       ` Arnd Bergmann
2014-07-16 11:58         ` Peter Chen
2014-07-16 12:12           ` Arnd Bergmann
2014-07-17  1:20             ` Peter Chen
2014-07-17 10:21               ` Arnd Bergmann
2014-07-17 11:19                 ` Peter Chen
2014-07-17 11:34                   ` Arnd Bergmann
2014-07-17 12:20                   ` Russell King - ARM Linux
2014-07-25  2:18   ` Peter Chen
2014-07-25  8:07     ` Antoine Ténart
2014-07-25  8:22       ` Peter Chen
2014-07-16  8:26 ` [PATCH v3 08/12] Documentation: bindings: add doc for the USB2 ChipIdea USB driver Antoine Ténart
2014-07-16  8:39   ` Arnd Bergmann [this message]
2014-07-16  8:59     ` Antoine Ténart
2014-07-16  8:26 ` [PATCH v3 09/12] ARM: dts: berlin: add BG2Q nodes for USB support Antoine Ténart
2014-07-16  8:26 ` [PATCH v3 10/12] ARM: dts: Berlin: enable USB on the BG2Q DMP Antoine Ténart
2014-07-16  8:26 ` [PATCH v3 11/12] ARM: dts: berlin: add BG2CD nodes for USB support Antoine Ténart
2014-07-16  8:26 ` [PATCH v3 12/12] ARM: dts: berlin: enable USB on the Google Chromecast Antoine Ténart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23972141.94aiK9jz66@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox