Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Liviu.Dudau@arm.com (Liviu Dudau)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v2 0/4] drm: Cleanup probe function for component based masters.
Date: Mon, 19 Oct 2015 13:21:49 +0100	[thread overview]
Message-ID: <1445257313-7147-1-git-send-email-Liviu.Dudau@arm.com> (raw)

Changelog:
v2: Rebased the patchset on top of drm-next rather than Linus' latest -rc

A few drivers in drivers/gpu/drm are component-enabled and use quite similar
code sequences to probe for their encoder slaves at the remote end of the ports.
Move the code into a "generic" function and remove it from the drivers.

The end results is that drivers get a reference count fix (imx), more thorough
error checking (imx again), setting the DMA coherent mask (armada) plus a decrease
in the overall count of LoC.

I'm looking for comments and testing of the patchset (only compile tested from my
end as I don't have access to all the devices touched by the changes). My main
interest is in finding out if -EINVAL is the correct code to return if
dev->of_node == NULL (handy now, as it is different from the other possible error
codes and used in armada to trigger old platform_data support. Also looking for
thoughts on the correctness of the patch and if it possible to co-opt more drivers
into using the function.

Best regards,
Liviu

Liviu Dudau (4):
  drm: Introduce generic probe function for component based masters.
  drm/imx: Convert the probe function to the generic drm_of_component_probe()
  drm/rockchip: Convert the probe function to the generic drm_of_component_probe()
  drm/armada: Convert the probe function to the generic drm_of_component_probe()

 drivers/gpu/drm/armada/armada_drv.c         | 73 +++++++----------------
 drivers/gpu/drm/drm_of.c                    | 92 +++++++++++++++++++++++++++++
 drivers/gpu/drm/imx/imx-drm-core.c          | 54 +----------------
 drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 86 ++-------------------------
 include/drm/drm_of.h                        | 12 ++++
 5 files changed, 133 insertions(+), 184 deletions(-)

-- 
2.6.0

             reply	other threads:[~2015-10-19 12:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-19 12:21 Liviu Dudau [this message]
2015-10-19 12:21 ` [RFC PATCH v2 1/4] drm: Introduce generic probe function for component based masters Liviu Dudau
2015-10-19 12:25   ` Russell King - ARM Linux
2015-10-19 13:02     ` Liviu Dudau
2015-10-19 13:26       ` Russell King - ARM Linux
2015-10-19 13:32         ` Liviu Dudau
2015-10-19 13:38           ` Russell King - ARM Linux
2015-10-19 14:42         ` Daniel Vetter
2015-10-19 14:50           ` Russell King - ARM Linux
2015-10-19 15:04             ` Emil Velikov
2015-10-19 15:21               ` Russell King - ARM Linux
2015-10-19 15:07             ` Liviu Dudau
2015-10-19 12:21 ` [RFC PATCH v2 2/4] drm/imx: Convert the probe function to the generic drm_of_component_probe() Liviu Dudau
2015-10-19 12:21 ` [RFC PATCH v2 3/4] drm/rockchip: " Liviu Dudau
2015-10-19 12:21 ` [RFC PATCH v2 4/4] drm/armada: " Liviu Dudau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445257313-7147-1-git-send-email-Liviu.Dudau@arm.com \
    --to=liviu.dudau@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox