* [PATCH] ARM: pxa: palm: Fix typos in PWM lookup table code
@ 2015-11-03 13:05 Thierry Reding
2015-11-03 16:24 ` Arnd Bergmann
0 siblings, 1 reply; 2+ messages in thread
From: Thierry Reding @ 2015-11-03 13:05 UTC (permalink / raw)
To: linux-arm-kernel
The patches that were applied to add PWM lookup tables for legacy boards
were from v1 of the series instead of the revised v2 where the resulting
build errors had already been fixed.
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
---
arch/arm/mach-pxa/palm27x.c | 2 +-
arch/arm/mach-pxa/palmtc.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-pxa/palm27x.c b/arch/arm/mach-pxa/palm27x.c
index 13eba2b26e0a..8fbfb10047ec 100644
--- a/arch/arm/mach-pxa/palm27x.c
+++ b/arch/arm/mach-pxa/palm27x.c
@@ -344,7 +344,7 @@ void __init palm27x_pwm_init(int bl, int lcd)
{
palm_bl_power = bl;
palm_lcd_power = lcd;
- pwm_add_lookup(palm27x_pwm_lookup, ARRAY_SIZE(palm27x_pwm_lookup));
+ pwm_add_table(palm27x_pwm_lookup, ARRAY_SIZE(palm27x_pwm_lookup));
platform_device_register(&palm27x_backlight);
}
#endif
diff --git a/arch/arm/mach-pxa/palmtc.c b/arch/arm/mach-pxa/palmtc.c
index aebf6de62468..0b5c3876720c 100644
--- a/arch/arm/mach-pxa/palmtc.c
+++ b/arch/arm/mach-pxa/palmtc.c
@@ -169,7 +169,7 @@ static inline void palmtc_keys_init(void) {}
#if defined(CONFIG_BACKLIGHT_PWM) || defined(CONFIG_BACKLIGHT_PWM_MODULE)
static struct pwm_lookup palmtc_pwm_lookup[] = {
PWM_LOOKUP("pxa25x-pwm.1", 0, "pwm-backlight.0", NULL, PALMTC_PERIOD_NS,
- PWM_PERIOD_NORMAL),
+ PWM_POLARITY_NORMAL),
};
static struct platform_pwm_backlight_data palmtc_backlight_data = {
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] ARM: pxa: palm: Fix typos in PWM lookup table code
2015-11-03 13:05 [PATCH] ARM: pxa: palm: Fix typos in PWM lookup table code Thierry Reding
@ 2015-11-03 16:24 ` Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2015-11-03 16:24 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday 03 November 2015 14:05:57 Thierry Reding wrote:
> The patches that were applied to add PWM lookup tables for legacy boards
> were from v1 of the series instead of the revised v2 where the resulting
> build errors had already been fixed.
>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
I've applied it directly on next/cleanup to fix the build errors.
Thanks for fixing it up so quickly!
Arnd
> arch/arm/mach-pxa/palm27x.c | 2 +-
> arch/arm/mach-pxa/palmtc.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/palm27x.c b/arch/arm/mach-pxa/palm27x.c
> index 13eba2b26e0a..8fbfb10047ec 100644
> --- a/arch/arm/mach-pxa/palm27x.c
> +++ b/arch/arm/mach-pxa/palm27x.c
> @@ -344,7 +344,7 @@ void __init palm27x_pwm_init(int bl, int lcd)
> {
> palm_bl_power = bl;
> palm_lcd_power = lcd;
> - pwm_add_lookup(palm27x_pwm_lookup, ARRAY_SIZE(palm27x_pwm_lookup));
> + pwm_add_table(palm27x_pwm_lookup, ARRAY_SIZE(palm27x_pwm_lookup));
> platform_device_register(&palm27x_backlight);
> }
> #endif
> diff --git a/arch/arm/mach-pxa/palmtc.c b/arch/arm/mach-pxa/palmtc.c
> index aebf6de62468..0b5c3876720c 100644
> --- a/arch/arm/mach-pxa/palmtc.c
> +++ b/arch/arm/mach-pxa/palmtc.c
> @@ -169,7 +169,7 @@ static inline void palmtc_keys_init(void) {}
> #if defined(CONFIG_BACKLIGHT_PWM) || defined(CONFIG_BACKLIGHT_PWM_MODULE)
> static struct pwm_lookup palmtc_pwm_lookup[] = {
> PWM_LOOKUP("pxa25x-pwm.1", 0, "pwm-backlight.0", NULL, PALMTC_PERIOD_NS,
> - PWM_PERIOD_NORMAL),
> + PWM_POLARITY_NORMAL),
> };
>
> static struct platform_pwm_backlight_data palmtc_backlight_data = {
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-03 16:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-03 13:05 [PATCH] ARM: pxa: palm: Fix typos in PWM lookup table code Thierry Reding
2015-11-03 16:24 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox