* [PATCH v2] cpufreq: scpi: Depend on SCPI clk driver
@ 2015-11-18 13:52 Punit Agrawal
2015-11-18 14:05 ` Viresh Kumar
0 siblings, 1 reply; 3+ messages in thread
From: Punit Agrawal @ 2015-11-18 13:52 UTC (permalink / raw)
To: linux-arm-kernel
The SCPI clk driver registers the virtual cpufreq device that kicks off
initialisation of the SCPI cpufreq driver. Also, clk_get() will fail for
the cpufreq driver if the scpi clk driver is missing.
Fix this by making the scpi cpufreq driver explicitly depend on the scpi
clk driver.
Fixes: 8def31034d03 ("cpufreq: arm_big_little: add SCPI interface driver")
Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/cpufreq/Kconfig.arm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
index 1582c1c..dadfdd4 100644
--- a/drivers/cpufreq/Kconfig.arm
+++ b/drivers/cpufreq/Kconfig.arm
@@ -201,7 +201,7 @@ config ARM_SA1110_CPUFREQ
config ARM_SCPI_CPUFREQ
tristate "SCPI based CPUfreq driver"
- depends on ARM_BIG_LITTLE_CPUFREQ && ARM_SCPI_PROTOCOL
+ depends on ARM_BIG_LITTLE_CPUFREQ && ARM_SCPI_PROTOCOL && COMMON_CLK_SCPI
help
This adds the CPUfreq driver support for ARM big.LITTLE platforms
using SCPI protocol for CPU power management.
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH v2] cpufreq: scpi: Depend on SCPI clk driver
2015-11-18 13:52 [PATCH v2] cpufreq: scpi: Depend on SCPI clk driver Punit Agrawal
@ 2015-11-18 14:05 ` Viresh Kumar
2015-11-23 23:21 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Viresh Kumar @ 2015-11-18 14:05 UTC (permalink / raw)
To: linux-arm-kernel
On 18-11-15, 13:52, Punit Agrawal wrote:
> The SCPI clk driver registers the virtual cpufreq device that kicks off
> initialisation of the SCPI cpufreq driver. Also, clk_get() will fail for
> the cpufreq driver if the scpi clk driver is missing.
>
> Fix this by making the scpi cpufreq driver explicitly depend on the scpi
> clk driver.
>
> Fixes: 8def31034d03 ("cpufreq: arm_big_little: add SCPI interface driver")
> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
> Cc: Sudeep Holla <sudeep.holla@arm.com>
> Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/cpufreq/Kconfig.arm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index 1582c1c..dadfdd4 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -201,7 +201,7 @@ config ARM_SA1110_CPUFREQ
>
> config ARM_SCPI_CPUFREQ
> tristate "SCPI based CPUfreq driver"
> - depends on ARM_BIG_LITTLE_CPUFREQ && ARM_SCPI_PROTOCOL
> + depends on ARM_BIG_LITTLE_CPUFREQ && ARM_SCPI_PROTOCOL && COMMON_CLK_SCPI
> help
> This adds the CPUfreq driver support for ARM big.LITTLE platforms
> using SCPI protocol for CPU power management.
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH v2] cpufreq: scpi: Depend on SCPI clk driver
2015-11-18 14:05 ` Viresh Kumar
@ 2015-11-23 23:21 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2015-11-23 23:21 UTC (permalink / raw)
To: linux-arm-kernel
On Wednesday, November 18, 2015 07:35:04 PM Viresh Kumar wrote:
> On 18-11-15, 13:52, Punit Agrawal wrote:
> > The SCPI clk driver registers the virtual cpufreq device that kicks off
> > initialisation of the SCPI cpufreq driver. Also, clk_get() will fail for
> > the cpufreq driver if the scpi clk driver is missing.
> >
> > Fix this by making the scpi cpufreq driver explicitly depend on the scpi
> > clk driver.
> >
> > Fixes: 8def31034d03 ("cpufreq: arm_big_little: add SCPI interface driver")
> > Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
> > Cc: Sudeep Holla <sudeep.holla@arm.com>
> > Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> > Cc: Viresh Kumar <viresh.kumar@linaro.org>
> > ---
> > drivers/cpufreq/Kconfig.arm | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> > index 1582c1c..dadfdd4 100644
> > --- a/drivers/cpufreq/Kconfig.arm
> > +++ b/drivers/cpufreq/Kconfig.arm
> > @@ -201,7 +201,7 @@ config ARM_SA1110_CPUFREQ
> >
> > config ARM_SCPI_CPUFREQ
> > tristate "SCPI based CPUfreq driver"
> > - depends on ARM_BIG_LITTLE_CPUFREQ && ARM_SCPI_PROTOCOL
> > + depends on ARM_BIG_LITTLE_CPUFREQ && ARM_SCPI_PROTOCOL && COMMON_CLK_SCPI
> > help
> > This adds the CPUfreq driver support for ARM big.LITTLE platforms
> > using SCPI protocol for CPU power management.
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Applied, thanks!
Rafael
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-23 23:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-18 13:52 [PATCH v2] cpufreq: scpi: Depend on SCPI clk driver Punit Agrawal
2015-11-18 14:05 ` Viresh Kumar
2015-11-23 23:21 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox