* [PATCH] ARM: imx6: fix static declaration in include/soc/imx/cpuidle.h
@ 2016-06-17 14:47 Ben Dooks
2016-06-17 14:52 ` Ben Dooks
0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks @ 2016-06-17 14:47 UTC (permalink / raw)
To: linux-arm-kernel
If both CONFIG_CPU_IDLE or CONFIG_SOC_IMX6Q are not set
then the imx6q_cpuidle_fec_irqs_used() and other functions
should be marked static inline to avoid the following
warnings whilst building drivers/net/ethernet/freescale:
include/soc/imx/cpuidle.h:21:6: warning: symbol 'imx6q_cpuidle_fec_irqs_used' was not declared. Should it be static?
include/soc/imx/cpuidle.h:22:6: warning: symbol 'imx6q_cpuidle_fec_irqs_unused' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
Cc: linux-arm-kernel at lists.infradead.org
---
include/soc/imx/cpuidle.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/soc/imx/cpuidle.h b/include/soc/imx/cpuidle.h
index 986a482..8d393cd 100644
--- a/include/soc/imx/cpuidle.h
+++ b/include/soc/imx/cpuidle.h
@@ -18,8 +18,8 @@
void imx6q_cpuidle_fec_irqs_used(void);
void imx6q_cpuidle_fec_irqs_unused(void);
#else
-void imx6q_cpuidle_fec_irqs_used(void) { }
-void imx6q_cpuidle_fec_irqs_unused(void) { }
+static void imx6q_cpuidle_fec_irqs_used(void) { }
+static void imx6q_cpuidle_fec_irqs_unused(void) { }
#endif
#endif /* __SOC_IMX_CPUIDLE_H__ */
--
2.8.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] ARM: imx6: fix static declaration in include/soc/imx/cpuidle.h
2016-06-17 14:47 [PATCH] ARM: imx6: fix static declaration in include/soc/imx/cpuidle.h Ben Dooks
@ 2016-06-17 14:52 ` Ben Dooks
0 siblings, 0 replies; 2+ messages in thread
From: Ben Dooks @ 2016-06-17 14:52 UTC (permalink / raw)
To: linux-arm-kernel
On 17/06/16 15:47, Ben Dooks wrote:
> If both CONFIG_CPU_IDLE or CONFIG_SOC_IMX6Q are not set
> then the imx6q_cpuidle_fec_irqs_used() and other functions
> should be marked static inline to avoid the following
> warnings whilst building drivers/net/ethernet/freescale:
>
> include/soc/imx/cpuidle.h:21:6: warning: symbol 'imx6q_cpuidle_fec_irqs_used' was not declared. Should it be static?
> include/soc/imx/cpuidle.h:22:6: warning: symbol 'imx6q_cpuidle_fec_irqs_unused' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Apologies, failed to properly merge the inline fix in.
Resend as V2.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-17 14:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-17 14:47 [PATCH] ARM: imx6: fix static declaration in include/soc/imx/cpuidle.h Ben Dooks
2016-06-17 14:52 ` Ben Dooks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox