From: noralf@tronnes.org (Noralf Trønnes)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/8] i2c: bcm2835: Use ratelimited logging on transfer errors
Date: Tue, 27 Sep 2016 13:57:01 +0200 [thread overview]
Message-ID: <1474977426-3272-4-git-send-email-noralf@tronnes.org> (raw)
In-Reply-To: <1474977426-3272-1-git-send-email-noralf@tronnes.org>
Writing to an AT24C32 generates on average 2x i2c transfer errors per
32-byte page write. Which amounts to a lot for a 4k write. This is due
to the fact that the chip doesn't respond during it's internal write
cycle when the at24 driver tries and retries the next write.
Reduce this flooding of the log by using dev_err_ratelimited().
Signed-off-by: Noralf Tr?nnes <noralf@tronnes.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
---
drivers/i2c/busses/i2c-bcm2835.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c
index df036ed..370a322 100644
--- a/drivers/i2c/busses/i2c-bcm2835.c
+++ b/drivers/i2c/busses/i2c-bcm2835.c
@@ -207,7 +207,8 @@ static int bcm2835_i2c_xfer_msg(struct bcm2835_i2c_dev *i2c_dev,
(msg->flags & I2C_M_IGNORE_NAK))
return 0;
- dev_err(i2c_dev->dev, "i2c transfer failed: %x\n", i2c_dev->msg_err);
+ dev_err_ratelimited(i2c_dev->dev, "i2c transfer failed: %x\n",
+ i2c_dev->msg_err);
if (i2c_dev->msg_err & BCM2835_I2C_S_ERR)
return -EREMOTEIO;
--
2.8.2
next prev parent reply other threads:[~2016-09-27 11:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 11:56 [PATCH v2 0/8] i2c: bcm2835: Bring in changes from downstream Noralf Trønnes
2016-09-27 11:56 ` [PATCH v2 1/8] i2c: bcm2835: Fix hang for writing messages larger than 16 bytes Noralf Trønnes
2016-09-27 11:57 ` [PATCH v2 2/8] i2c: bcm2835: Protect against unexpected TXW/RXR interrupts Noralf Trønnes
2016-09-27 11:57 ` Noralf Trønnes [this message]
2016-09-27 13:01 ` [PATCH v2 3/8] i2c: bcm2835: Use ratelimited logging on transfer errors Martin Sperl
2016-09-27 19:27 ` Noralf Trønnes
2016-09-27 11:57 ` [PATCH v2 4/8] i2c: bcm2835: Can't support I2C_M_IGNORE_NAK Noralf Trønnes
2016-09-27 11:57 ` [PATCH v2 5/8] i2c: bcm2835: Add support for Repeated Start Condition Noralf Trønnes
2016-09-27 11:57 ` [PATCH v2 6/8] i2c: bcm2835: Support i2c-dev ioctl I2C_TIMEOUT Noralf Trønnes
2016-09-27 11:57 ` [PATCH v2 7/8] i2c: bcm2835: Add support for dynamic clock Noralf Trønnes
2016-09-27 11:57 ` [PATCH v2 8/8] ARM: bcm2835: Disable i2c2 in the Device Tree Noralf Trønnes
2016-09-27 17:25 ` Stefan Wahren
2016-09-27 18:53 ` Jan Kandziora
2016-09-27 19:23 ` Noralf Trønnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474977426-3272-4-git-send-email-noralf@tronnes.org \
--to=noralf@tronnes.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox