From: noralf@tronnes.org (Noralf Trønnes)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/8] i2c: bcm2835: Can't support I2C_M_IGNORE_NAK
Date: Tue, 27 Sep 2016 13:57:02 +0200 [thread overview]
Message-ID: <1474977426-3272-5-git-send-email-noralf@tronnes.org> (raw)
In-Reply-To: <1474977426-3272-1-git-send-email-noralf@tronnes.org>
The controller can't support this flag, so remove it.
Documentation/i2c/i2c-protocol states that all of the message is sent:
I2C_M_IGNORE_NAK:
Normally message is interrupted immediately if there is [NA] from the
client. Setting this flag treats any [NA] as [A], and all of
message is sent.
>From the BCM2835 ARM Peripherals datasheet:
The ERR field is set when the slave fails to acknowledge either
its address or a data byte written to it.
So when the controller doesn't receive an ack, it sets ERR and raises
an interrupt. In other words, the whole message is not sent.
Signed-off-by: Noralf Tr?nnes <noralf@tronnes.org>
---
drivers/i2c/busses/i2c-bcm2835.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c
index 370a322..4e08add 100644
--- a/drivers/i2c/busses/i2c-bcm2835.c
+++ b/drivers/i2c/busses/i2c-bcm2835.c
@@ -203,10 +203,6 @@ static int bcm2835_i2c_xfer_msg(struct bcm2835_i2c_dev *i2c_dev,
if (likely(!i2c_dev->msg_err))
return 0;
- if ((i2c_dev->msg_err & BCM2835_I2C_S_ERR) &&
- (msg->flags & I2C_M_IGNORE_NAK))
- return 0;
-
dev_err_ratelimited(i2c_dev->dev, "i2c transfer failed: %x\n",
i2c_dev->msg_err);
--
2.8.2
next prev parent reply other threads:[~2016-09-27 11:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 11:56 [PATCH v2 0/8] i2c: bcm2835: Bring in changes from downstream Noralf Trønnes
2016-09-27 11:56 ` [PATCH v2 1/8] i2c: bcm2835: Fix hang for writing messages larger than 16 bytes Noralf Trønnes
2016-09-27 11:57 ` [PATCH v2 2/8] i2c: bcm2835: Protect against unexpected TXW/RXR interrupts Noralf Trønnes
2016-09-27 11:57 ` [PATCH v2 3/8] i2c: bcm2835: Use ratelimited logging on transfer errors Noralf Trønnes
2016-09-27 13:01 ` Martin Sperl
2016-09-27 19:27 ` Noralf Trønnes
2016-09-27 11:57 ` Noralf Trønnes [this message]
2016-09-27 11:57 ` [PATCH v2 5/8] i2c: bcm2835: Add support for Repeated Start Condition Noralf Trønnes
2016-09-27 11:57 ` [PATCH v2 6/8] i2c: bcm2835: Support i2c-dev ioctl I2C_TIMEOUT Noralf Trønnes
2016-09-27 11:57 ` [PATCH v2 7/8] i2c: bcm2835: Add support for dynamic clock Noralf Trønnes
2016-09-27 11:57 ` [PATCH v2 8/8] ARM: bcm2835: Disable i2c2 in the Device Tree Noralf Trønnes
2016-09-27 17:25 ` Stefan Wahren
2016-09-27 18:53 ` Jan Kandziora
2016-09-27 19:23 ` Noralf Trønnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474977426-3272-5-git-send-email-noralf@tronnes.org \
--to=noralf@tronnes.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox