* [PATCH 0/2] fix issue: vblank interrupts are never disabled
@ 2016-09-29 3:29 Bibby Hsieh
2016-09-29 3:29 ` [PATCH 1/2] drm/mediatek: set vblank_disable_allowed to true Bibby Hsieh
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Bibby Hsieh @ 2016-09-29 3:29 UTC (permalink / raw)
To: linux-arm-kernel
Clean the interrupt status before enable interrupt
and set the vblank_disable_allowed to fix the issue.
Bibby Hsieh (2):
drm/mediatek: set vblank_disable_allowed to true
drm/mediatek: clear IRQ status before enable OVL interrupt
drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 1 +
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 +
2 files changed, 2 insertions(+)
--
1.7.9.5
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/2] drm/mediatek: set vblank_disable_allowed to true
2016-09-29 3:29 [PATCH 0/2] fix issue: vblank interrupts are never disabled Bibby Hsieh
@ 2016-09-29 3:29 ` Bibby Hsieh
2016-09-29 5:36 ` CK Hu
2016-09-29 3:29 ` [PATCH 2/2] drm/mediatek: clear IRQ status before enable OVL interrupt Bibby Hsieh
2016-10-07 10:37 ` [PATCH 0/2] fix issue: vblank interrupts are never disabled Daniel Kurtz
2 siblings, 1 reply; 6+ messages in thread
From: Bibby Hsieh @ 2016-09-29 3:29 UTC (permalink / raw)
To: linux-arm-kernel
MTK DRM driver didn't set the vblank_disable_allowed to
true, it cause that the irq_handler is called every
16.6 ms (every vblank) when the display didn't be updated.
Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index eebb7d8..941ec5f 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -200,6 +200,7 @@ static int mtk_drm_kms_init(struct drm_device *drm)
if (ret < 0)
goto err_component_unbind;
+ drm->vblank_disable_allowed = true;
drm_kms_helper_poll_init(drm);
drm_mode_config_reset(drm);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 1/2] drm/mediatek: set vblank_disable_allowed to true
2016-09-29 3:29 ` [PATCH 1/2] drm/mediatek: set vblank_disable_allowed to true Bibby Hsieh
@ 2016-09-29 5:36 ` CK Hu
0 siblings, 0 replies; 6+ messages in thread
From: CK Hu @ 2016-09-29 5:36 UTC (permalink / raw)
To: linux-arm-kernel
Acked-by: CK Hu <ck.hu@mediatek.com>
On Thu, 2016-09-29 at 11:29 +0800, Bibby Hsieh wrote:
> MTK DRM driver didn't set the vblank_disable_allowed to
> true, it cause that the irq_handler is called every
> 16.6 ms (every vblank) when the display didn't be updated.
>
> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index eebb7d8..941ec5f 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -200,6 +200,7 @@ static int mtk_drm_kms_init(struct drm_device *drm)
> if (ret < 0)
> goto err_component_unbind;
>
> + drm->vblank_disable_allowed = true;
> drm_kms_helper_poll_init(drm);
> drm_mode_config_reset(drm);
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] drm/mediatek: clear IRQ status before enable OVL interrupt
2016-09-29 3:29 [PATCH 0/2] fix issue: vblank interrupts are never disabled Bibby Hsieh
2016-09-29 3:29 ` [PATCH 1/2] drm/mediatek: set vblank_disable_allowed to true Bibby Hsieh
@ 2016-09-29 3:29 ` Bibby Hsieh
2016-09-29 5:37 ` CK Hu
2016-10-07 10:37 ` [PATCH 0/2] fix issue: vblank interrupts are never disabled Daniel Kurtz
2 siblings, 1 reply; 6+ messages in thread
From: Bibby Hsieh @ 2016-09-29 3:29 UTC (permalink / raw)
To: linux-arm-kernel
To make sure that the first vblank IRQ after enabling
vblank isn't too short or immediate, we have to clear
the IRQ status before enable OVL interrupt.
Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
---
drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
index 019b7ca..f75c5b5 100644
--- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
+++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
@@ -80,6 +80,7 @@ static void mtk_ovl_enable_vblank(struct mtk_ddp_comp *comp,
ddp_comp);
priv->crtc = crtc;
+ writel(0x0, comp->regs + DISP_REG_OVL_INTSTA);
writel_relaxed(OVL_FME_CPL_INT, comp->regs + DISP_REG_OVL_INTEN);
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] drm/mediatek: clear IRQ status before enable OVL interrupt
2016-09-29 3:29 ` [PATCH 2/2] drm/mediatek: clear IRQ status before enable OVL interrupt Bibby Hsieh
@ 2016-09-29 5:37 ` CK Hu
0 siblings, 0 replies; 6+ messages in thread
From: CK Hu @ 2016-09-29 5:37 UTC (permalink / raw)
To: linux-arm-kernel
Acked-by: CK Hu <ck.hu@mediatek.com>
On Thu, 2016-09-29 at 11:29 +0800, Bibby Hsieh wrote:
> To make sure that the first vblank IRQ after enabling
> vblank isn't too short or immediate, we have to clear
> the IRQ status before enable OVL interrupt.
>
> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> index 019b7ca..f75c5b5 100644
> --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> @@ -80,6 +80,7 @@ static void mtk_ovl_enable_vblank(struct mtk_ddp_comp *comp,
> ddp_comp);
>
> priv->crtc = crtc;
> + writel(0x0, comp->regs + DISP_REG_OVL_INTSTA);
> writel_relaxed(OVL_FME_CPL_INT, comp->regs + DISP_REG_OVL_INTEN);
> }
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 0/2] fix issue: vblank interrupts are never disabled
2016-09-29 3:29 [PATCH 0/2] fix issue: vblank interrupts are never disabled Bibby Hsieh
2016-09-29 3:29 ` [PATCH 1/2] drm/mediatek: set vblank_disable_allowed to true Bibby Hsieh
2016-09-29 3:29 ` [PATCH 2/2] drm/mediatek: clear IRQ status before enable OVL interrupt Bibby Hsieh
@ 2016-10-07 10:37 ` Daniel Kurtz
2 siblings, 0 replies; 6+ messages in thread
From: Daniel Kurtz @ 2016-10-07 10:37 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 29, 2016 at 11:29 AM, Bibby Hsieh <bibby.hsieh@mediatek.com> wrote:
>
> Clean the interrupt status before enable interrupt
> and set the vblank_disable_allowed to fix the issue.
For the series:
Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
>
> Bibby Hsieh (2):
> drm/mediatek: set vblank_disable_allowed to true
> drm/mediatek: clear IRQ status before enable OVL interrupt
>
> drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 1 +
> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 +
> 2 files changed, 2 insertions(+)
>
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-07 10:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-29 3:29 [PATCH 0/2] fix issue: vblank interrupts are never disabled Bibby Hsieh
2016-09-29 3:29 ` [PATCH 1/2] drm/mediatek: set vblank_disable_allowed to true Bibby Hsieh
2016-09-29 5:36 ` CK Hu
2016-09-29 3:29 ` [PATCH 2/2] drm/mediatek: clear IRQ status before enable OVL interrupt Bibby Hsieh
2016-09-29 5:37 ` CK Hu
2016-10-07 10:37 ` [PATCH 0/2] fix issue: vblank interrupts are never disabled Daniel Kurtz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox