* [PATCH 1/3] drivers: iommu: arm-smmu: constify iommu_gather_ops structures
2016-10-25 18:06 [PATCH 0/3] drivers: iommu: declare iommu_gather_ops structures as const Bhumika Goyal
@ 2016-10-25 18:06 ` Bhumika Goyal
2016-10-25 20:21 ` Julia Lawall
2016-10-25 18:06 ` [PATCH 2/3] drivers: iommu: arm-smmu-v3: " Bhumika Goyal
2016-10-25 18:06 ` [PATCH 3/3] drivers: iommu: io-pgtable-arm: use const and __initconst for " Bhumika Goyal
2 siblings, 1 reply; 7+ messages in thread
From: Bhumika Goyal @ 2016-10-25 18:06 UTC (permalink / raw)
To: linux-arm-kernel
Check for iommu_gather_ops structures that are only stored in the tlb
field of an io_pgtable_cfg structure. The tlb field is of type
const struct iommu_gather_ops *, so iommu_gather_ops structures
having this property can be declared as const.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
drivers/iommu/arm-smmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
index c841eb7..a5bc8fb 100644
--- a/drivers/iommu/arm-smmu.c
+++ b/drivers/iommu/arm-smmu.c
@@ -640,7 +640,7 @@ static void arm_smmu_tlb_inv_range_nosync(unsigned long iova, size_t size,
}
}
-static struct iommu_gather_ops arm_smmu_gather_ops = {
+static const struct iommu_gather_ops arm_smmu_gather_ops = {
.tlb_flush_all = arm_smmu_tlb_inv_context,
.tlb_add_flush = arm_smmu_tlb_inv_range_nosync,
.tlb_sync = arm_smmu_tlb_sync,
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 1/3] drivers: iommu: arm-smmu: constify iommu_gather_ops structures
2016-10-25 18:06 ` [PATCH 1/3] drivers: iommu: arm-smmu: constify iommu_gather_ops structures Bhumika Goyal
@ 2016-10-25 20:21 ` Julia Lawall
0 siblings, 0 replies; 7+ messages in thread
From: Julia Lawall @ 2016-10-25 20:21 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 25 Oct 2016, Bhumika Goyal wrote:
> Check for iommu_gather_ops structures that are only stored in the tlb
> field of an io_pgtable_cfg structure. The tlb field is of type
> const struct iommu_gather_ops *, so iommu_gather_ops structures
> having this property can be declared as const.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> drivers/iommu/arm-smmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> index c841eb7..a5bc8fb 100644
> --- a/drivers/iommu/arm-smmu.c
> +++ b/drivers/iommu/arm-smmu.c
> @@ -640,7 +640,7 @@ static void arm_smmu_tlb_inv_range_nosync(unsigned long iova, size_t size,
> }
> }
>
> -static struct iommu_gather_ops arm_smmu_gather_ops = {
> +static const struct iommu_gather_ops arm_smmu_gather_ops = {
> .tlb_flush_all = arm_smmu_tlb_inv_context,
> .tlb_add_flush = arm_smmu_tlb_inv_range_nosync,
> .tlb_sync = arm_smmu_tlb_sync,
> --
> 1.9.1
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/3] drivers: iommu: arm-smmu-v3: constify iommu_gather_ops structures
2016-10-25 18:06 [PATCH 0/3] drivers: iommu: declare iommu_gather_ops structures as const Bhumika Goyal
2016-10-25 18:06 ` [PATCH 1/3] drivers: iommu: arm-smmu: constify iommu_gather_ops structures Bhumika Goyal
@ 2016-10-25 18:06 ` Bhumika Goyal
2016-10-25 20:20 ` Julia Lawall
2016-10-25 18:06 ` [PATCH 3/3] drivers: iommu: io-pgtable-arm: use const and __initconst for " Bhumika Goyal
2 siblings, 1 reply; 7+ messages in thread
From: Bhumika Goyal @ 2016-10-25 18:06 UTC (permalink / raw)
To: linux-arm-kernel
Check for iommu_gather_ops structures that are only stored in the tlb
field of an io_pgtable_cfg structure. The tlb field is of type
const struct iommu_gather_ops *, so iommu_gather_ops structures
having this property can be declared as const.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
drivers/iommu/arm-smmu-v3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c
index 15c01c3..51d8be4 100644
--- a/drivers/iommu/arm-smmu-v3.c
+++ b/drivers/iommu/arm-smmu-v3.c
@@ -1358,7 +1358,7 @@ static void arm_smmu_tlb_inv_range_nosync(unsigned long iova, size_t size,
} while (size -= granule);
}
-static struct iommu_gather_ops arm_smmu_gather_ops = {
+static const struct iommu_gather_ops arm_smmu_gather_ops = {
.tlb_flush_all = arm_smmu_tlb_inv_context,
.tlb_add_flush = arm_smmu_tlb_inv_range_nosync,
.tlb_sync = arm_smmu_tlb_sync,
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 2/3] drivers: iommu: arm-smmu-v3: constify iommu_gather_ops structures
2016-10-25 18:06 ` [PATCH 2/3] drivers: iommu: arm-smmu-v3: " Bhumika Goyal
@ 2016-10-25 20:20 ` Julia Lawall
0 siblings, 0 replies; 7+ messages in thread
From: Julia Lawall @ 2016-10-25 20:20 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 25 Oct 2016, Bhumika Goyal wrote:
> Check for iommu_gather_ops structures that are only stored in the tlb
> field of an io_pgtable_cfg structure. The tlb field is of type
> const struct iommu_gather_ops *, so iommu_gather_ops structures
> having this property can be declared as const.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> drivers/iommu/arm-smmu-v3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c
> index 15c01c3..51d8be4 100644
> --- a/drivers/iommu/arm-smmu-v3.c
> +++ b/drivers/iommu/arm-smmu-v3.c
> @@ -1358,7 +1358,7 @@ static void arm_smmu_tlb_inv_range_nosync(unsigned long iova, size_t size,
> } while (size -= granule);
> }
>
> -static struct iommu_gather_ops arm_smmu_gather_ops = {
> +static const struct iommu_gather_ops arm_smmu_gather_ops = {
> .tlb_flush_all = arm_smmu_tlb_inv_context,
> .tlb_add_flush = arm_smmu_tlb_inv_range_nosync,
> .tlb_sync = arm_smmu_tlb_sync,
> --
> 1.9.1
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 3/3] drivers: iommu: io-pgtable-arm: use const and __initconst for iommu_gather_ops structures
2016-10-25 18:06 [PATCH 0/3] drivers: iommu: declare iommu_gather_ops structures as const Bhumika Goyal
2016-10-25 18:06 ` [PATCH 1/3] drivers: iommu: arm-smmu: constify iommu_gather_ops structures Bhumika Goyal
2016-10-25 18:06 ` [PATCH 2/3] drivers: iommu: arm-smmu-v3: " Bhumika Goyal
@ 2016-10-25 18:06 ` Bhumika Goyal
2016-10-25 20:18 ` Julia Lawall
2 siblings, 1 reply; 7+ messages in thread
From: Bhumika Goyal @ 2016-10-25 18:06 UTC (permalink / raw)
To: linux-arm-kernel
Check for iommu_gather_ops structures that are only stored in the tlb
field of an io_pgtable_cfg structure. The tlb field is of type
const struct iommu_gather_ops *, so iommu_gather_ops structures
having this property can be declared as const. Also, replace __initdata
with __initconst.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
drivers/iommu/io-pgtable-arm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/io-pgtable-arm.c b/drivers/iommu/io-pgtable-arm.c
index f5c90e1..412e21d 100644
--- a/drivers/iommu/io-pgtable-arm.c
+++ b/drivers/iommu/io-pgtable-arm.c
@@ -916,7 +916,7 @@ static void dummy_tlb_sync(void *cookie)
WARN_ON(cookie != cfg_cookie);
}
-static struct iommu_gather_ops dummy_tlb_ops __initdata = {
+static const struct iommu_gather_ops dummy_tlb_ops __initconst = {
.tlb_flush_all = dummy_tlb_flush_all,
.tlb_add_flush = dummy_tlb_add_flush,
.tlb_sync = dummy_tlb_sync,
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 3/3] drivers: iommu: io-pgtable-arm: use const and __initconst for iommu_gather_ops structures
2016-10-25 18:06 ` [PATCH 3/3] drivers: iommu: io-pgtable-arm: use const and __initconst for " Bhumika Goyal
@ 2016-10-25 20:18 ` Julia Lawall
0 siblings, 0 replies; 7+ messages in thread
From: Julia Lawall @ 2016-10-25 20:18 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 25 Oct 2016, Bhumika Goyal wrote:
> Check for iommu_gather_ops structures that are only stored in the tlb
> field of an io_pgtable_cfg structure. The tlb field is of type
> const struct iommu_gather_ops *, so iommu_gather_ops structures
> having this property can be declared as const. Also, replace __initdata
> with __initconst.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> drivers/iommu/io-pgtable-arm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/io-pgtable-arm.c b/drivers/iommu/io-pgtable-arm.c
> index f5c90e1..412e21d 100644
> --- a/drivers/iommu/io-pgtable-arm.c
> +++ b/drivers/iommu/io-pgtable-arm.c
> @@ -916,7 +916,7 @@ static void dummy_tlb_sync(void *cookie)
> WARN_ON(cookie != cfg_cookie);
> }
>
> -static struct iommu_gather_ops dummy_tlb_ops __initdata = {
> +static const struct iommu_gather_ops dummy_tlb_ops __initconst = {
> .tlb_flush_all = dummy_tlb_flush_all,
> .tlb_add_flush = dummy_tlb_add_flush,
> .tlb_sync = dummy_tlb_sync,
> --
> 1.9.1
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread