* [PATCH] mfd: stm32-timers: fix driver removal
@ 2017-02-01 16:41 Fabrice Gasnier
2017-02-06 10:07 ` Benjamin Gaignard
2017-02-08 12:19 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Gasnier @ 2017-02-01 16:41 UTC (permalink / raw)
To: linux-arm-kernel
Add missing of_platform_depopulate() upon driver removal.
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
---
drivers/mfd/stm32-timers.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/mfd/stm32-timers.c b/drivers/mfd/stm32-timers.c
index 41bd901..192cbb6 100644
--- a/drivers/mfd/stm32-timers.c
+++ b/drivers/mfd/stm32-timers.c
@@ -61,6 +61,13 @@ static int stm32_timers_probe(struct platform_device *pdev)
return of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev);
}
+static int stm32_timers_remove(struct platform_device *pdev)
+{
+ of_platform_depopulate(&pdev->dev);
+
+ return 0;
+}
+
static const struct of_device_id stm32_timers_of_match[] = {
{ .compatible = "st,stm32-timers", },
{ /* end node */ },
@@ -69,6 +76,7 @@ static int stm32_timers_probe(struct platform_device *pdev)
static struct platform_driver stm32_timers_driver = {
.probe = stm32_timers_probe,
+ .remove = stm32_timers_remove,
.driver = {
.name = "stm32-timers",
.of_match_table = stm32_timers_of_match,
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] mfd: stm32-timers: fix driver removal
2017-02-01 16:41 [PATCH] mfd: stm32-timers: fix driver removal Fabrice Gasnier
@ 2017-02-06 10:07 ` Benjamin Gaignard
2017-02-08 12:19 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Benjamin Gaignard @ 2017-02-06 10:07 UTC (permalink / raw)
To: linux-arm-kernel
2017-02-01 17:41 GMT+01:00 Fabrice Gasnier <fabrice.gasnier@st.com>:
> Add missing of_platform_depopulate() upon driver removal.
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> ---
> drivers/mfd/stm32-timers.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/mfd/stm32-timers.c b/drivers/mfd/stm32-timers.c
> index 41bd901..192cbb6 100644
> --- a/drivers/mfd/stm32-timers.c
> +++ b/drivers/mfd/stm32-timers.c
> @@ -61,6 +61,13 @@ static int stm32_timers_probe(struct platform_device *pdev)
> return of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev);
> }
>
> +static int stm32_timers_remove(struct platform_device *pdev)
> +{
> + of_platform_depopulate(&pdev->dev);
> +
> + return 0;
> +}
> +
> static const struct of_device_id stm32_timers_of_match[] = {
> { .compatible = "st,stm32-timers", },
> { /* end node */ },
> @@ -69,6 +76,7 @@ static int stm32_timers_probe(struct platform_device *pdev)
>
> static struct platform_driver stm32_timers_driver = {
> .probe = stm32_timers_probe,
> + .remove = stm32_timers_remove,
> .driver = {
> .name = "stm32-timers",
> .of_match_table = stm32_timers_of_match,
> --
> 1.9.1
>
Acked-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] mfd: stm32-timers: fix driver removal
2017-02-01 16:41 [PATCH] mfd: stm32-timers: fix driver removal Fabrice Gasnier
2017-02-06 10:07 ` Benjamin Gaignard
@ 2017-02-08 12:19 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2017-02-08 12:19 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, 01 Feb 2017, Fabrice Gasnier wrote:
> Add missing of_platform_depopulate() upon driver removal.
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> ---
> drivers/mfd/stm32-timers.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
Applied, thanks.
> diff --git a/drivers/mfd/stm32-timers.c b/drivers/mfd/stm32-timers.c
> index 41bd901..192cbb6 100644
> --- a/drivers/mfd/stm32-timers.c
> +++ b/drivers/mfd/stm32-timers.c
> @@ -61,6 +61,13 @@ static int stm32_timers_probe(struct platform_device *pdev)
> return of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev);
> }
>
> +static int stm32_timers_remove(struct platform_device *pdev)
> +{
> + of_platform_depopulate(&pdev->dev);
> +
> + return 0;
> +}
> +
> static const struct of_device_id stm32_timers_of_match[] = {
> { .compatible = "st,stm32-timers", },
> { /* end node */ },
> @@ -69,6 +76,7 @@ static int stm32_timers_probe(struct platform_device *pdev)
>
> static struct platform_driver stm32_timers_driver = {
> .probe = stm32_timers_probe,
> + .remove = stm32_timers_remove,
> .driver = {
> .name = "stm32-timers",
> .of_match_table = stm32_timers_of_match,
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-08 12:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-01 16:41 [PATCH] mfd: stm32-timers: fix driver removal Fabrice Gasnier
2017-02-06 10:07 ` Benjamin Gaignard
2017-02-08 12:19 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).