From: weiyongjun1@huawei.com (Wei Yongjun)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH -next] IIO: ADC: fix return value check in stm32_dfsdm_adc_probe()
Date: Thu, 11 Jan 2018 11:12:41 +0000 [thread overview]
Message-ID: <1515669161-125426-1-git-send-email-weiyongjun1@huawei.com> (raw)
In case of error, the function devm_iio_device_alloc() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.
Fixes: e2e6771c6462 ("IIO: ADC: add STM32 DFSDM sigma delta ADC support")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/iio/adc/stm32-dfsdm-adc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
index e628d04..5e87140 100644
--- a/drivers/iio/adc/stm32-dfsdm-adc.c
+++ b/drivers/iio/adc/stm32-dfsdm-adc.c
@@ -1100,9 +1100,9 @@ static int stm32_dfsdm_adc_probe(struct platform_device *pdev)
dev_data = (const struct stm32_dfsdm_dev_data *)of_id->data;
iio = devm_iio_device_alloc(dev, sizeof(*adc));
- if (IS_ERR(iio)) {
+ if (!iio) {
dev_err(dev, "%s: Failed to allocate IIO\n", __func__);
- return PTR_ERR(iio);
+ return -ENOMEM;
}
adc = iio_priv(iio);
next reply other threads:[~2018-01-11 11:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 11:12 Wei Yongjun [this message]
2018-01-11 21:28 ` [PATCH -next] IIO: ADC: fix return value check in stm32_dfsdm_adc_probe() Dan Carpenter
2018-01-12 1:37 ` weiyongjun (A)
2018-01-12 9:37 ` Arnaud Pouliquen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515669161-125426-1-git-send-email-weiyongjun1@huawei.com \
--to=weiyongjun1@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox