* [PATCH 05/12] arm64: dts: mt7622: add PMIC MT6380 related nodes [not found] <CAOFm3uHnUk8BwDVR0F+5VqTB+8qFKz23ooX3o9G_RCbVqpbQPw@mail.gmail.com> @ 2018-01-23 18:44 ` Sean Wang 0 siblings, 0 replies; 6+ messages in thread From: Sean Wang @ 2018-01-23 18:44 UTC (permalink / raw) To: linux-arm-kernel Hi, Philippe Really appreciate your info and detailed explanation. it's clear how correct way to add GPDX license identifier. I will have a follow-up. Sean On Tue, 2018-01-23 at 11:46 +0100, Philippe Ombredanne wrote: > Sean, > sorry for the late reply and thanks you for this research. > > On Fri, Jan 12, 2018 at 4:33 AM, Sean Wang <sean.wang@mediatek.com> wrote: > > Currently, I'm really confused about what usage STYLE of SPDX license > > identifier I should use for each type of file. > > > > could you point me where I can find the related document describing SPDX > > usage style for those files expected by the community in the future? > > The doc is in this patchset [1] > > [1] https://lkml.org/lkml/2017/12/28/326 > > > > I found more than one way STYLE of SPDX present at current code, for > > example as below. If there's no absolute definition for them, and then > > which way that is better? > > 1) > > for *.dts, applied with "// " at head or within " /* */ " not at head > > such as > > > > arch/arm/boot/dts/bcm953012hr.dts:2: * SPDX-License-Identifier: > > BSD-3-Clause > > This is a "style bug". The comment style for .dts should be // > > > 2) > > for *.c, applied with "// " at head or within " /* */ " not at head > > such as > > drivers/soc/xilinx/zynqmp/pm.c:10: * SPDX-License-Identifier: GPL-2.0+ > > This is a "style bug". The comment style for .c should be // > > > 3) > > for *.h, applied with "// " at head or within " /* */ " at head > > such as > > drivers/usb/dwc3/gadget.h:1:// SPDX-License-Identifier: GPL-2.0 > > This is a "style bug". The comment style for .h should be /**/ > > > 4) > > no issue, Makefile, or Kconfig, definitely applied with "# " at head > > That's the correct way. > > So the net-net is that these "style bugs" should be fixed. > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 00/12] add dts nodes to MT7622 SoC @ 2018-01-04 9:40 sean.wang at mediatek.com 2018-01-04 9:40 ` [PATCH 05/12] arm64: dts: mt7622: add PMIC MT6380 related nodes sean.wang at mediatek.com 0 siblings, 1 reply; 6+ messages in thread From: sean.wang at mediatek.com @ 2018-01-04 9:40 UTC (permalink / raw) To: linux-arm-kernel From: Sean Wang <sean.wang@mediatek.com> add dts nodes to MT7622 SoC and related rfb1 board Ryder Lee (2): arm64: dts: mt7622: add PCIe device nodes arm64: dts: mt7622: add SATA device nodes Sean Wang (10): dt-bindings: clock: mediatek: add missing required #reset-cells arm64: dts: mt7622: add clock controller device nodes arm64: dts: mt7622: add power domain controller device nodes arm64: dts: mt7622: add pinctrl related device nodes arm64: dts: mt7622: add PMIC MT6380 related nodes arm64: dts: mt7622: add cpufreq related device nodes arm64: dts: mt7622: turn uart0 clock to real ones arm64: dts: mt7622: add SoC and peripheral related device nodes arm64: dts: mt7622: add flash related device nodes arm64: dts: mt7622: add ethernet device nodes .../bindings/arm/mediatek/mediatek,ethsys.txt | 2 + .../bindings/arm/mediatek/mediatek,pciesys.txt | 2 + .../bindings/arm/mediatek/mediatek,ssusbsys.txt | 2 + arch/arm64/boot/dts/mediatek/mt6380.dtsi | 91 ++++ arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts | 337 +++++++++++++ arch/arm64/boot/dts/mediatek/mt7622.dtsi | 533 ++++++++++++++++++++- 6 files changed, 962 insertions(+), 5 deletions(-) create mode 100644 arch/arm64/boot/dts/mediatek/mt6380.dtsi -- 2.7.4 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 05/12] arm64: dts: mt7622: add PMIC MT6380 related nodes 2018-01-04 9:40 [PATCH 00/12] add dts nodes to MT7622 SoC sean.wang at mediatek.com @ 2018-01-04 9:40 ` sean.wang at mediatek.com 2018-01-04 10:27 ` Philippe Ombredanne 0 siblings, 1 reply; 6+ messages in thread From: sean.wang at mediatek.com @ 2018-01-04 9:40 UTC (permalink / raw) To: linux-arm-kernel From: Sean Wang <sean.wang@mediatek.com> Enable pwrap and MT6380 on mt7622-rfb1 board. Also add all mt6380 regulator nodes in an alone file to allow similar boards using MT6380 able to resue the configuration. Signed-off-by: Sean Wang <sean.wang@mediatek.com> Cc: Mark Brown <broonie@kernel.org> Cc: Matthias Brugger <matthias.bgg@gmail.com> --- arch/arm64/boot/dts/mediatek/mt6380.dtsi | 91 ++++++++++++++++++++++++++++ arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts | 8 +++ arch/arm64/boot/dts/mediatek/mt7622.dtsi | 12 ++++ 3 files changed, 111 insertions(+) create mode 100644 arch/arm64/boot/dts/mediatek/mt6380.dtsi diff --git a/arch/arm64/boot/dts/mediatek/mt6380.dtsi b/arch/arm64/boot/dts/mediatek/mt6380.dtsi new file mode 100644 index 0000000..7eb7dc2 --- /dev/null +++ b/arch/arm64/boot/dts/mediatek/mt6380.dtsi @@ -0,0 +1,91 @@ +/* + * Copyright (c) 2018 MediaTek Inc. + * Author: Chenglin Xu <chenglin.xu@mediatek.com> + * Sean Wang <sean.wang@mediatek.com> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +&pwrap { + regulators { + compatible = "mediatek,mt6380-regulator"; + + mt6380_vcpu_reg: buck-vcore1 { + regulator-name = "vcore1"; + regulator-min-microvolt = < 600000>; + regulator-max-microvolt = <1393750>; + regulator-ramp-delay = <6250>; + regulator-always-on; + regulator-boot-on; + }; + + mt6380_vcore_reg: buck-vcore { + regulator-name = "vcore"; + regulator-min-microvolt = <600000>; + regulator-max-microvolt = <1393750>; + regulator-ramp-delay = <6250>; + regulator-always-on; + regulator-boot-on; + }; + + mt6380_vrf_reg: buck-vrf { + regulator-name = "vrf"; + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1575000>; + regulator-ramp-delay = <0>; + regulator-always-on; + regulator-boot-on; + }; + + mt6380_vm_reg: ldo-vm { + regulator-name = "vm"; + regulator-min-microvolt = <1050000>; + regulator-max-microvolt = <1400000>; + regulator-ramp-delay = <0>; + regulator-always-on; + regulator-boot-on; + }; + + mt6380_va_reg: ldo-va { + regulator-name = "va"; + regulator-min-microvolt = <2200000>; + regulator-max-microvolt = <3300000>; + regulator-ramp-delay = <0>; + regulator-always-on; + regulator-boot-on; + }; + + mt6380_vphy_reg: ldo-vphy { + regulator-name = "vphy"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-ramp-delay = <0>; + regulator-always-on; + regulator-boot-on; + }; + + mt6380_vddr_reg: ldo-vddr { + regulator-name = "vddr"; + regulator-min-microvolt = <1240000>; + regulator-max-microvolt = <1840000>; + regulator-ramp-delay = <0>; + regulator-always-on; + regulator-boot-on; + }; + + mt6380_vt_reg: ldo-vt { + regulator-name = "vt"; + regulator-min-microvolt = <2200000>; + regulator-max-microvolt = <3300000>; + regulator-ramp-delay = <0>; + regulator-always-on; + regulator-boot-on; + }; + }; +}; diff --git a/arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts b/arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts index c77e77a..f72f1f5 100644 --- a/arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts +++ b/arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts @@ -10,6 +10,7 @@ #include <dt-bindings/input/input.h> #include "mt7622.dtsi" +#include "mt6380.dtsi" / { model = "MediaTek MT7622 RFB1 board"; @@ -222,6 +223,13 @@ }; }; +&pwrap { + pinctrl-names = "default"; + pinctrl-0 = <&pmic_bus_pins>; + + status = "okay"; +}; + &uart0 { status = "okay"; }; diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi index a531278..5b7f0a3 100644 --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi @@ -102,6 +102,18 @@ #reset-cells = <1>; }; + pwrap: pwrap at 10001000 { + compatible = "mediatek,mt7622-pwrap"; + reg = <0 0x10001000 0 0x250>; + reg-names = "pwrap"; + clocks = <&infracfg CLK_INFRA_PMIC_PD>,<&pwrap_clk>; + clock-names = "spi","wrap"; + resets = <&infracfg MT7622_INFRA_PMIC_WRAP_RST>; + reset-names = "pwrap"; + interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>; + status = "disabled"; + }; + pericfg: pericfg at 10002000 { compatible = "mediatek,mt7622-pericfg", "syscon"; -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 05/12] arm64: dts: mt7622: add PMIC MT6380 related nodes 2018-01-04 9:40 ` [PATCH 05/12] arm64: dts: mt7622: add PMIC MT6380 related nodes sean.wang at mediatek.com @ 2018-01-04 10:27 ` Philippe Ombredanne 2018-01-05 3:42 ` Sean Wang 0 siblings, 1 reply; 6+ messages in thread From: Philippe Ombredanne @ 2018-01-04 10:27 UTC (permalink / raw) To: linux-arm-kernel Sean, On Thu, Jan 4, 2018 at 10:40 AM, <sean.wang@mediatek.com> wrote: > From: Sean Wang <sean.wang@mediatek.com> > > Enable pwrap and MT6380 on mt7622-rfb1 board. Also add all mt6380 > regulator nodes in an alone file to allow similar boards using MT6380 > able to resue the configuration. > > Signed-off-by: Sean Wang <sean.wang@mediatek.com> > Cc: Mark Brown <broonie@kernel.org> > Cc: Matthias Brugger <matthias.bgg@gmail.com> > --- > arch/arm64/boot/dts/mediatek/mt6380.dtsi | 91 ++++++++++++++++++++++++++++ > arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts | 8 +++ > arch/arm64/boot/dts/mediatek/mt7622.dtsi | 12 ++++ > 3 files changed, 111 insertions(+) > create mode 100644 arch/arm64/boot/dts/mediatek/mt6380.dtsi > > diff --git a/arch/arm64/boot/dts/mediatek/mt6380.dtsi b/arch/arm64/boot/dts/mediatek/mt6380.dtsi > new file mode 100644 > index 0000000..7eb7dc2 > --- /dev/null > +++ b/arch/arm64/boot/dts/mediatek/mt6380.dtsi > @@ -0,0 +1,91 @@ > +/* > + * Copyright (c) 2018 MediaTek Inc. > + * Author: Chenglin Xu <chenglin.xu@mediatek.com> > + * Sean Wang <sean.wang@mediatek.com> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ Would you mind using SPDX tags instead of this fine but long legalese? This is documented in Thomas patches [1]. Also if you could spread the word in your team, this would earn you good karma points. Thank you! [1] https://lkml.org/lkml/2017/12/28/323 -- Cordially Philippe Ombredanne ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 05/12] arm64: dts: mt7622: add PMIC MT6380 related nodes 2018-01-04 10:27 ` Philippe Ombredanne @ 2018-01-05 3:42 ` Sean Wang 2018-01-05 8:21 ` Philippe Ombredanne 0 siblings, 1 reply; 6+ messages in thread From: Sean Wang @ 2018-01-05 3:42 UTC (permalink / raw) To: linux-arm-kernel On Thu, 2018-01-04 at 11:27 +0100, Philippe Ombredanne wrote: > Sean, > > On Thu, Jan 4, 2018 at 10:40 AM, <sean.wang@mediatek.com> wrote: > > From: Sean Wang <sean.wang@mediatek.com> > > > > Enable pwrap and MT6380 on mt7622-rfb1 board. Also add all mt6380 > > regulator nodes in an alone file to allow similar boards using MT6380 > > able to resue the configuration. > > > > Signed-off-by: Sean Wang <sean.wang@mediatek.com> > > Cc: Mark Brown <broonie@kernel.org> > > Cc: Matthias Brugger <matthias.bgg@gmail.com> > > --- > > arch/arm64/boot/dts/mediatek/mt6380.dtsi | 91 ++++++++++++++++++++++++++++ > > arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts | 8 +++ > > arch/arm64/boot/dts/mediatek/mt7622.dtsi | 12 ++++ > > 3 files changed, 111 insertions(+) > > create mode 100644 arch/arm64/boot/dts/mediatek/mt6380.dtsi > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt6380.dtsi b/arch/arm64/boot/dts/mediatek/mt6380.dtsi > > new file mode 100644 > > index 0000000..7eb7dc2 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/mediatek/mt6380.dtsi > > @@ -0,0 +1,91 @@ > > +/* > > + * Copyright (c) 2018 MediaTek Inc. > > + * Author: Chenglin Xu <chenglin.xu@mediatek.com> > > + * Sean Wang <sean.wang@mediatek.com> > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + */ > > Would you mind using SPDX tags instead of this fine but long legalese? > This is documented in Thomas patches [1]. > Also if you could spread the word in your team, this would earn you > good karma points. > Thank you! > > [1] https://lkml.org/lkml/2017/12/28/323 Hi, Philippe thanks for your suggestion Certainly, this can be replaced with SPDX-License-Identifier: GPL-2.0 most drivers from MediaTek use the similar disclaimer, it should be fine to use SPDX tags instead. Sean ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 05/12] arm64: dts: mt7622: add PMIC MT6380 related nodes 2018-01-05 3:42 ` Sean Wang @ 2018-01-05 8:21 ` Philippe Ombredanne 2018-01-12 3:33 ` Sean Wang 0 siblings, 1 reply; 6+ messages in thread From: Philippe Ombredanne @ 2018-01-05 8:21 UTC (permalink / raw) To: linux-arm-kernel Sean, On Fri, Jan 5, 2018 at 4:42 AM, Sean Wang <sean.wang@mediatek.com> wrote: > On Thu, 2018-01-04 at 11:27 +0100, Philippe Ombredanne wrote: >> Sean, >> >> On Thu, Jan 4, 2018 at 10:40 AM, <sean.wang@mediatek.com> wrote: >> > From: Sean Wang <sean.wang@mediatek.com> >> > >> > Enable pwrap and MT6380 on mt7622-rfb1 board. Also add all mt6380 >> > regulator nodes in an alone file to allow similar boards using MT6380 >> > able to resue the configuration. >> > >> > Signed-off-by: Sean Wang <sean.wang@mediatek.com> >> > Cc: Mark Brown <broonie@kernel.org> >> > Cc: Matthias Brugger <matthias.bgg@gmail.com> >> > --- >> > arch/arm64/boot/dts/mediatek/mt6380.dtsi | 91 ++++++++++++++++++++++++++++ >> > arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts | 8 +++ >> > arch/arm64/boot/dts/mediatek/mt7622.dtsi | 12 ++++ >> > 3 files changed, 111 insertions(+) >> > create mode 100644 arch/arm64/boot/dts/mediatek/mt6380.dtsi >> > >> > diff --git a/arch/arm64/boot/dts/mediatek/mt6380.dtsi b/arch/arm64/boot/dts/mediatek/mt6380.dtsi >> > new file mode 100644 >> > index 0000000..7eb7dc2 >> > --- /dev/null >> > +++ b/arch/arm64/boot/dts/mediatek/mt6380.dtsi >> > @@ -0,0 +1,91 @@ >> > +/* >> > + * Copyright (c) 2018 MediaTek Inc. >> > + * Author: Chenglin Xu <chenglin.xu@mediatek.com> >> > + * Sean Wang <sean.wang@mediatek.com> >> > + * >> > + * This program is free software; you can redistribute it and/or modify >> > + * it under the terms of the GNU General Public License version 2 as >> > + * published by the Free Software Foundation. >> > + * >> > + * This program is distributed in the hope that it will be useful, >> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> > + * GNU General Public License for more details. >> > + */ >> >> Would you mind using SPDX tags instead of this fine but long legalese? >> This is documented in Thomas patches [1]. > >> Also if you could spread the word in your team, this would earn you >> good karma points. >> Thank you! >> >> [1] https://lkml.org/lkml/2017/12/28/323 > > > Hi, Philippe > > thanks for your suggestion > > Certainly, this can be replaced with > > SPDX-License-Identifier: GPL-2.0 > > most drivers from MediaTek use the similar disclaimer, it should be fine > to use SPDX tags instead. > > Sean > Thank you! that's great. -- Cordially Philippe Ombredanne ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 05/12] arm64: dts: mt7622: add PMIC MT6380 related nodes 2018-01-05 8:21 ` Philippe Ombredanne @ 2018-01-12 3:33 ` Sean Wang 0 siblings, 0 replies; 6+ messages in thread From: Sean Wang @ 2018-01-12 3:33 UTC (permalink / raw) To: linux-arm-kernel Hi, Philippe Currently, I'm really confused about what usage STYLE of SPDX license identifier I should use for each type of file. could you point me where I can find the related document describing SPDX usage style for those files expected by the community in the future? I found more than one way STYLE of SPDX present at current code, for example as below. If there's no absolute definition for them, and then which way that is better? 1) for *.dts, applied with "// " at head or within " /* */ " not at head such as arch/arm/boot/dts/bcm953012hr.dts:2: * SPDX-License-Identifier: BSD-3-Clause arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts:4: * SPDX-License-Identifier: (GPL-2.0+ OR MIT) arch/arm/boot/dts/uniphier-ld6b-ref.dts:7: * SPDX-License-Identifier: (GPL-2.0+ OR MIT) arch/arm/boot/dts/owl-s500-guitar-bb-rev-b.dts:4: * SPDX-License-Identifier: (GPL-2.0+ OR MIT) arch/arm/boot/dts/keystone-k2g-ice.dts:6: * SPDX-License-Identifier: GPL-2.0 arch/arm/boot/dts/uniphier-pro4-sanji.dts:7: * SPDX-License-Identifier: (GPL-2.0+ OR MIT) arch/arm/boot/dts/owl-s500-cubieboard6.dts:6: * SPDX-License-Identifier: (GPL-2.0+ OR MIT) arch/arm/boot/dts/uniphier-pro4-ace.dts:7: * SPDX-License-Identifier: (GPL-2.0+ OR MIT) arch/arm/boot/dts/uniphier-sld8-ref.dts:7: * SPDX-License-Identifier: (GPL-2.0+ OR MIT) arch/arm/boot/dts/uniphier-pro4-ref.dts:7: * SPDX-License-Identifier: (GPL-2.0+ OR MIT) arch/arm/boot/dts/uniphier-pxs2-gentil.dts:7: * SPDX-License-Identifier: (GPL-2.0+ OR MIT) arch/arm/boot/dts/uniphier-pxs2-vodka.dts:7: * SPDX-License-Identifier: (GPL-2.0+ OR MIT) arch/arm/boot/dts/uniphier-ld4-ref.dts:7: * SPDX-License-Identifier: (GPL-2.0+ OR MIT) arch/arm64/boot/dts/nvidia/tegra132-norrin.dts:1:// SPDX-License-Identifier: GPL-2.0 arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts:1:// SPDX-License-Identifier: GPL-2.0 arch/arm64/boot/dts/nvidia/tegra210-smaug.dts:1:// SPDX-License-Identifier: GPL-2.0 arch/arm64/boot/dts/arm/vexpress-v2f-1xv7-ca53x2.dts:1:// SPDX-License-Identifier: GPL-2.0 arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts:1:// SPDX-License-Identifier: GPL-2.0 arch/arm64/boot/dts/arm/foundation-v8.dts:1:// SPDX-License-Identifier: GPL-2.0 arch/arm64/boot/dts/arm/foundation-v8-gicv3.dts:1:// SPDX-License-Identifier: GPL-2.0 arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts:1:// SPDX-License-Identifier: GPL-2.0 2) for *.c, applied with "// " at head or within " /* */ " not at head such as drivers/base/memory.c:1:// SPDX-License-Identifier: GPL-2.0 drivers/base/devtmpfs.c:1:// SPDX-License-Identifier: GPL-2.0 drivers/base/node.c:1:// SPDX-License-Identifier: GPL-2.0 drivers/base/dma-coherent.c:1:// SPDX-License-Identifier: GPL-2.0 drivers/cpuidle/cpuidle-pseries.c:1:// SPDX-License-Identifier: GPL-2.0 drivers/cpuidle/cpuidle-powernv.c:1:// SPDX-License-Identifier: GPL-2.0 drivers/mtd/maps/tsunami_flash.c:1:// SPDX-License-Identifier: GPL-2.0 drivers/mtd/maps/physmap_of_gemini.c:1:// SPDX-License-Identifier: GPL-2.0 drivers/mtd/tests/mtd_test.c:1:// SPDX-License-Identifier: GPL-2.0 drivers/mtd/onenand/onenand_bbt.c:1:// SPDX-License-Identifier: GPL-2.0 drivers/media/common/b2c2/flexcop-i2c.c:1:// SPDX-License-Identifier: GPL-2.0 drivers/soc/xilinx/zynqmp/pm.c:10: * SPDX-License-Identifier: GPL-2.0+ drivers/soc/amlogic/meson-gx-pwrc-vpu.c:5: * SPDX-License-Identifier: GPL-2.0+ drivers/soc/amlogic/meson-gx-socinfo.c:5: * SPDX-License-Identifier: GPL-2.0+ drivers/soc/amlogic/meson-mx-socinfo.c:4: * SPDX-License-Identifier: GPL-2.0+ drivers/i2c/busses/i2c-sprd.c:4: * SPDX-License-Identifier: (GPL-2.0+ OR MIT) drivers/spi/spi-meson-spicc.c:7: * SPDX-License-Identifier: GPL-2.0+ drivers/spi/spi-sprd-adi.c:4: * SPDX-License-Identifier: GPL-2.0 drivers/dma/sprd-dma.c:4: * SPDX-License-Identifier: GPL-2.0 3) for *.h, applied with "// " at head or within " /* */ " at head such as drivers/usb/dwc3/gadget.h:1:// SPDX-License-Identifier: GPL-2.0 drivers/usb/dwc3/io.h:1:// SPDX-License-Identifier: GPL-2.0 drivers/usb/dwc3/debug.h:1:// SPDX-License-Identifier: GPL-2.0 drivers/usb/dwc3/core.h:1:// SPDX-License-Identifier: GPL-2.0 drivers/usb/atm/usbatm.h:1:// SPDX-License-Identifier: GPL-2.0+ drivers/usb/misc/rio500_usb.h:1:// SPDX-License-Identifier: GPL-2.0+ drivers/usb/misc/sisusbvga/sisusb.h:1:// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) drivers/usb/misc/sisusbvga/sisusb_init.h:1:// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) drivers/usb/misc/sisusbvga/sisusb_struct.h:1:// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) drivers/usb/misc/usb_u132.h:1:// SPDX-License-Identifier: GPL-2.0 drivers/tty/serial/dz.h:1:/* SPDX-License-Identifier: GPL-2.0 */ drivers/tty/serial/apbuart.h:1:/* SPDX-License-Identifier: GPL-2.0 */ drivers/tty/serial/sunzilog.h:1:/* SPDX-License-Identifier: GPL-2.0 */ drivers/tty/serial/zs.h:1:/* SPDX-License-Identifier: GPL-2.0 */ drivers/tty/serial/sh-sci.h:1:/* SPDX-License-Identifier: GPL-2.0 */ drivers/tty/serial/cpm_uart/cpm_uart_cpm1.h:1:/* SPDX-License-Identifier: GPL-2.0 */ drivers/tty/serial/cpm_uart/cpm_uart_cpm2.h:1:/* SPDX-License-Identifier: GPL-2.0 */ drivers/tty/serial/sunsab.h:1:/* SPDX-License-Identifier: GPL-2.0 */ drivers/tty/serial/amba-pl011.h:1:/* SPDX-License-Identifier: GPL-2.0 */ drivers/tty/serial/crisv10.h:1:/* SPDX-License-Identifier: GPL-2.0 */ 4) no issue, Makefile, or Kconfig, definitely applied with "# " at head Sean On Fri, 2018-01-05 at 09:21 +0100, Philippe Ombredanne wrote: > Sean, > > On Fri, Jan 5, 2018 at 4:42 AM, Sean Wang <sean.wang@mediatek.com> wrote: > > On Thu, 2018-01-04 at 11:27 +0100, Philippe Ombredanne wrote: > >> Sean, > >> > >> On Thu, Jan 4, 2018 at 10:40 AM, <sean.wang@mediatek.com> wrote: > >> > From: Sean Wang <sean.wang@mediatek.com> > >> > > >> > Enable pwrap and MT6380 on mt7622-rfb1 board. Also add all mt6380 > >> > regulator nodes in an alone file to allow similar boards using MT6380 > >> > able to resue the configuration. > >> > > >> > Signed-off-by: Sean Wang <sean.wang@mediatek.com> > >> > Cc: Mark Brown <broonie@kernel.org> > >> > Cc: Matthias Brugger <matthias.bgg@gmail.com> > >> > --- > >> > arch/arm64/boot/dts/mediatek/mt6380.dtsi | 91 ++++++++++++++++++++++++++++ > >> > arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts | 8 +++ > >> > arch/arm64/boot/dts/mediatek/mt7622.dtsi | 12 ++++ > >> > 3 files changed, 111 insertions(+) > >> > create mode 100644 arch/arm64/boot/dts/mediatek/mt6380.dtsi > >> > > >> > diff --git a/arch/arm64/boot/dts/mediatek/mt6380.dtsi b/arch/arm64/boot/dts/mediatek/mt6380.dtsi > >> > new file mode 100644 > >> > index 0000000..7eb7dc2 > >> > --- /dev/null > >> > +++ b/arch/arm64/boot/dts/mediatek/mt6380.dtsi > >> > @@ -0,0 +1,91 @@ > >> > +/* > >> > + * Copyright (c) 2018 MediaTek Inc. > >> > + * Author: Chenglin Xu <chenglin.xu@mediatek.com> > >> > + * Sean Wang <sean.wang@mediatek.com> > >> > + * > >> > + * This program is free software; you can redistribute it and/or modify > >> > + * it under the terms of the GNU General Public License version 2 as > >> > + * published by the Free Software Foundation. > >> > + * > >> > + * This program is distributed in the hope that it will be useful, > >> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > >> > + * GNU General Public License for more details. > >> > + */ > >> > >> Would you mind using SPDX tags instead of this fine but long legalese? > >> This is documented in Thomas patches [1]. > > > >> Also if you could spread the word in your team, this would earn you > >> good karma points. > >> Thank you! > >> > >> [1] https://lkml.org/lkml/2017/12/28/323 > > > > > > Hi, Philippe > > > > thanks for your suggestion > > > > Certainly, this can be replaced with > > > > SPDX-License-Identifier: GPL-2.0 > > > > most drivers from MediaTek use the similar disclaimer, it should be fine > > to use SPDX tags instead. > > > > Sean > > > > Thank you! that's great. > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-01-23 18:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CAOFm3uHnUk8BwDVR0F+5VqTB+8qFKz23ooX3o9G_RCbVqpbQPw@mail.gmail.com>
2018-01-23 18:44 ` [PATCH 05/12] arm64: dts: mt7622: add PMIC MT6380 related nodes Sean Wang
2018-01-04 9:40 [PATCH 00/12] add dts nodes to MT7622 SoC sean.wang at mediatek.com
2018-01-04 9:40 ` [PATCH 05/12] arm64: dts: mt7622: add PMIC MT6380 related nodes sean.wang at mediatek.com
2018-01-04 10:27 ` Philippe Ombredanne
2018-01-05 3:42 ` Sean Wang
2018-01-05 8:21 ` Philippe Ombredanne
2018-01-12 3:33 ` Sean Wang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox