* [PATCH v2] arm64: dts: r8a77965: Add SDHI device nodes @ 2018-05-09 12:38 Yoshihiro Kaneko 2018-05-09 13:39 ` Geert Uytterhoeven 0 siblings, 1 reply; 3+ messages in thread From: Yoshihiro Kaneko @ 2018-05-09 12:38 UTC (permalink / raw) To: linux-arm-kernel From: Takeshi Kihara <takeshi.kihara.df@renesas.com> Add SDHI nodes to the DT of the r8a77965 SoC. Based on several similar patches of the R8A7796 device tree by Simon Horman <horms+renesas@verge.net.au>. Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com> --- This patch is based on the devel branch of Simon Horman's renesas tree. v2 [Yoshihiro Kaneko] * As suggested by Simon Horman Rebased on top of the devel branch of the renesas tree. arch/arm64/boot/dts/renesas/r8a77965.dtsi | 36 +++++++++++++++++++++++++++---- 1 file changed, 32 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi index ba0edda..510815e 100644 --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi @@ -978,23 +978,51 @@ }; sdhi0: sd at ee100000 { + compatible = "renesas,sdhi-r8a77965", + "renesas,rcar-gen3-sdhi"; reg = <0 0xee100000 0 0x2000>; - /* placeholder */ + interrupts = <GIC_SPI 165 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 314>; + max-frequency = <200000000>; + power-domains = <&sysc 32>; + resets = <&cpg 314>; + status = "disabled"; }; sdhi1: sd at ee120000 { + compatible = "renesas,sdhi-r8a77965", + "renesas,rcar-gen3-sdhi"; reg = <0 0xee120000 0 0x2000>; - /* placeholder */ + interrupts = <GIC_SPI 166 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 313>; + max-frequency = <200000000>; + power-domains = <&sysc 32>; + resets = <&cpg 313>; + status = "disabled"; }; sdhi2: sd at ee140000 { + compatible = "renesas,sdhi-r8a77965", + "renesas,rcar-gen3-sdhi"; reg = <0 0xee140000 0 0x2000>; - /* placeholder */ + interrupts = <GIC_SPI 167 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 312>; + max-frequency = <200000000>; + power-domains = <&sysc 32>; + resets = <&cpg 312>; + status = "disabled"; }; sdhi3: sd at ee160000 { + compatible = "renesas,sdhi-r8a77965", + "renesas,rcar-gen3-sdhi"; reg = <0 0xee160000 0 0x2000>; - /* placeholder */ + interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 311>; + max-frequency = <200000000>; + power-domains = <&sysc 32>; + resets = <&cpg 311>; + status = "disabled"; }; gic: interrupt-controller at f1010000 { -- 1.9.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2] arm64: dts: r8a77965: Add SDHI device nodes 2018-05-09 12:38 [PATCH v2] arm64: dts: r8a77965: Add SDHI device nodes Yoshihiro Kaneko @ 2018-05-09 13:39 ` Geert Uytterhoeven 2018-05-09 17:46 ` Simon Horman 0 siblings, 1 reply; 3+ messages in thread From: Geert Uytterhoeven @ 2018-05-09 13:39 UTC (permalink / raw) To: linux-arm-kernel Hi Kaneko-san, On Wed, May 9, 2018 at 2:38 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote: > From: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > Add SDHI nodes to the DT of the r8a77965 SoC. > > Based on several similar patches of the R8A7796 device tree > by Simon Horman <horms+renesas@verge.net.au>. > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com> > --- > > This patch is based on the devel branch of Simon Horman's renesas tree. > > v2 [Yoshihiro Kaneko] > * As suggested by Simon Horman > Rebased on top of the devel branch of the renesas tree. Thanks for the update! > arch/arm64/boot/dts/renesas/r8a77965.dtsi | 36 +++++++++++++++++++++++++++---- > 1 file changed, 32 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi > index ba0edda..510815e 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi > @@ -978,23 +978,51 @@ > }; > > sdhi0: sd at ee100000 { > + compatible = "renesas,sdhi-r8a77965", > + "renesas,rcar-gen3-sdhi"; > reg = <0 0xee100000 0 0x2000>; > - /* placeholder */ > + interrupts = <GIC_SPI 165 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 314>; > + max-frequency = <200000000>; > + power-domains = <&sysc 32>; In the mean time, <dt-bindings/power/r8a77965-sysc.h> has landed upstream, so please use R8A77965_PD_ALWAYS_ON. With the above fixed: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] arm64: dts: r8a77965: Add SDHI device nodes 2018-05-09 13:39 ` Geert Uytterhoeven @ 2018-05-09 17:46 ` Simon Horman 0 siblings, 0 replies; 3+ messages in thread From: Simon Horman @ 2018-05-09 17:46 UTC (permalink / raw) To: linux-arm-kernel On Wed, May 09, 2018 at 03:39:45PM +0200, Geert Uytterhoeven wrote: > Hi Kaneko-san, > > On Wed, May 9, 2018 at 2:38 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote: > > From: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > > > Add SDHI nodes to the DT of the r8a77965 SoC. > > > > Based on several similar patches of the R8A7796 device tree > > by Simon Horman <horms+renesas@verge.net.au>. > > > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com> > > --- > > > > This patch is based on the devel branch of Simon Horman's renesas tree. > > > > v2 [Yoshihiro Kaneko] > > * As suggested by Simon Horman > > Rebased on top of the devel branch of the renesas tree. > > Thanks for the update! > > > arch/arm64/boot/dts/renesas/r8a77965.dtsi | 36 +++++++++++++++++++++++++++---- > > 1 file changed, 32 insertions(+), 4 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi > > index ba0edda..510815e 100644 > > --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi > > @@ -978,23 +978,51 @@ > > }; > > > > sdhi0: sd at ee100000 { > > + compatible = "renesas,sdhi-r8a77965", > > + "renesas,rcar-gen3-sdhi"; > > reg = <0 0xee100000 0 0x2000>; > > - /* placeholder */ > > + interrupts = <GIC_SPI 165 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&cpg CPG_MOD 314>; > > + max-frequency = <200000000>; > > + power-domains = <&sysc 32>; > > In the mean time, <dt-bindings/power/r8a77965-sysc.h> has landed > upstream, so please use R8A77965_PD_ALWAYS_ON. > > With the above fixed: > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Thanks, I have applied the patch with that fix. The result is as follows: From: Takeshi Kihara <takeshi.kihara.df@renesas.com> Subject: [PATCH] arm64: dts: r8a77965: Add SDHI device nodes Add SDHI nodes to the DT of the r8a77965 SoC. Based on several similar patches of the R8A7796 device tree by Simon Horman <horms+renesas@verge.net.au>. Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- arch/arm64/boot/dts/renesas/r8a77965.dtsi | 36 +++++++++++++++++++++++++++---- 1 file changed, 32 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi index ba0edda431a5..f51c1b2cbae4 100644 --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi @@ -978,23 +978,51 @@ }; sdhi0: sd at ee100000 { + compatible = "renesas,sdhi-r8a77965", + "renesas,rcar-gen3-sdhi"; reg = <0 0xee100000 0 0x2000>; - /* placeholder */ + interrupts = <GIC_SPI 165 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 314>; + max-frequency = <200000000>; + power-domains = <&sysc R8A77965_PD_ALWAYS_ON>; + resets = <&cpg 314>; + status = "disabled"; }; sdhi1: sd at ee120000 { + compatible = "renesas,sdhi-r8a77965", + "renesas,rcar-gen3-sdhi"; reg = <0 0xee120000 0 0x2000>; - /* placeholder */ + interrupts = <GIC_SPI 166 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 313>; + max-frequency = <200000000>; + power-domains = <&sysc R8A77965_PD_ALWAYS_ON>; + resets = <&cpg 313>; + status = "disabled"; }; sdhi2: sd at ee140000 { + compatible = "renesas,sdhi-r8a77965", + "renesas,rcar-gen3-sdhi"; reg = <0 0xee140000 0 0x2000>; - /* placeholder */ + interrupts = <GIC_SPI 167 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 312>; + max-frequency = <200000000>; + power-domains = <&sysc R8A77965_PD_ALWAYS_ON>; + resets = <&cpg 312>; + status = "disabled"; }; sdhi3: sd at ee160000 { + compatible = "renesas,sdhi-r8a77965", + "renesas,rcar-gen3-sdhi"; reg = <0 0xee160000 0 0x2000>; - /* placeholder */ + interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 311>; + max-frequency = <200000000>; + power-domains = <&sysc R8A77965_PD_ALWAYS_ON>; + resets = <&cpg 311>; + status = "disabled"; }; gic: interrupt-controller at f1010000 { -- 2.11.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-09 17:46 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-05-09 12:38 [PATCH v2] arm64: dts: r8a77965: Add SDHI device nodes Yoshihiro Kaneko 2018-05-09 13:39 ` Geert Uytterhoeven 2018-05-09 17:46 ` Simon Horman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox