[PATCH] [dts] fix green/blue pio-led on bananapi-r2

public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed

* [PATCH] [dts] fix green/blue pio-led on bananapi-r2
       [not found] <trinity-ae29ad25-a4fb-47f3-8d68-f6e58c875a0e-1529682447976@3c-app-gmx-bs42>
@ 2018-06-22 15:53 ` Frank Wunderlich
  2018-06-25  9:17   ` Sean Wang
  0 siblings, 1 reply; 4+ messages in thread
From: Frank Wunderlich @ 2018-06-22 15:53 UTC (permalink / raw)
  To: linux-arm-kernel

From: Frank Wunderlich <frank-w@public-files.de>
Date: Sun, 17 Jun 2018 19:11:58 +0200
Subject: [PATCH] [dts] fix green/blue pio-led
?green/blue pio-leds (near GPIO-Header) are swapped and LOW-active
?this patch restore this expected behaviour
?red cannot be switched afaik
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
?arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 14 +++++++-------
?1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
index 531d905d924ff..3e8a0ffe8b13e 100644
--- a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
+++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
@@ -89,21 +89,21 @@
??? ??? ?pinctrl-names = "default";
??? ??? ?pinctrl-0 = <&led_pins_a>;
?
-?? ??? ?blue {
-?? ??? ??? ?label = "bpi-r2:pio:blue";
-?? ??? ??? ?gpios = <&pio 241 GPIO_ACTIVE_HIGH>;
+?? ??? ?green {
+?? ??? ??? ?label = "bpi-r2:pio:green";
+?? ??? ??? ?gpios = <&pio 241 GPIO_ACTIVE_LOW>;
??? ??? ??? ?default-state = "off";
??? ??? ?};
?
-?? ??? ?green {
-?? ??? ??? ?label = "bpi-r2:pio:green";
-?? ??? ??? ?gpios = <&pio 240 GPIO_ACTIVE_HIGH>;
+?? ??? ?blue {
+?? ??? ??? ?label = "bpi-r2:pio:blue";
+?? ??? ??? ?gpios = <&pio 240 GPIO_ACTIVE_LOW>;
??? ??? ??? ?default-state = "off";
??? ??? ?};
?
??? ??? ?red {
??? ??? ??? ?label = "bpi-r2:pio:red";
-?? ??? ??? ?gpios = <&pio 239 GPIO_ACTIVE_HIGH>;
+?? ??? ??? ?gpios = <&pio 239 GPIO_ACTIVE_LOW>;
??? ??? ??? ?default-state = "off";
??? ??? ?};
??? ?};
?
?
?

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] [dts] fix green/blue pio-led on bananapi-r2
  2018-06-22 15:53 ` [PATCH] [dts] fix green/blue pio-led on bananapi-r2 Frank Wunderlich
@ 2018-06-25  9:17   ` Sean Wang
       [not found]     ` <trinity-28694d63-092a-48be-aade-ba680b5c4e70-1529921159405@3c-app-gmx-bs16>
  0 siblings, 1 reply; 4+ messages in thread
From: Sean Wang @ 2018-06-25  9:17 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, 2018-06-22 at 17:53 +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
> Date: Sun, 17 Jun 2018 19:11:58 +0200
> Subject: [PATCH] [dts] fix green/blue pio-led
>  green/blue pio-leds (near GPIO-Header) are swapped and LOW-active
>  this patch restore this expected behaviour
>  red cannot be switched afaik
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
>  arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> index 531d905d924ff..3e8a0ffe8b13e 100644
> --- a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> +++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> @@ -89,21 +89,21 @@
>          pinctrl-names = "default";
>          pinctrl-0 = <&led_pins_a>;
>  
> -        blue {
> -            label = "bpi-r2:pio:blue";
> -            gpios = <&pio 241 GPIO_ACTIVE_HIGH>;
> +        green {
> +            label = "bpi-r2:pio:green";
> +            gpios = <&pio 241 GPIO_ACTIVE_LOW>;
>              default-state = "off";
>          };
>  
> -        green {
> -            label = "bpi-r2:pio:green";
> -            gpios = <&pio 240 GPIO_ACTIVE_HIGH>;
> +        blue {
> +            label = "bpi-r2:pio:blue";
> +            gpios = <&pio 240 GPIO_ACTIVE_LOW>;
>              default-state = "off";
>          };
>  
>          red {
>              label = "bpi-r2:pio:red";
> -            gpios = <&pio 239 GPIO_ACTIVE_HIGH>;
> +            gpios = <&pio 239 GPIO_ACTIVE_LOW>;
>              default-state = "off";
>          };
>      };
>  

Hi, Frank

Node name should be listed in alphabetic order that means you should
keep the order and only have the fixes for its content.

Apart from that
	Reviewed-by: Sean Wang <sean.wang@mediatek.com>
	
>  
>  
> 
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 4+ messages in thread

[parent not found: <trinity-28694d63-092a-48be-aade-ba680b5c4e70-1529921159405@3c-app-gmx-bs16>]

* [dts] [v2] fix green/blue pio-led on bananapi-r2
       [not found]     ` <trinity-28694d63-092a-48be-aade-ba680b5c4e70-1529921159405@3c-app-gmx-bs16>
@ 2018-06-27  5:54       ` Sean Wang
  2018-07-16  9:16       ` Matthias Brugger
  1 sibling, 0 replies; 4+ messages in thread
From: Sean Wang @ 2018-06-27  5:54 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, 2018-06-25 at 12:05 +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
> Date: Mon, 25 Jun 2018 11:57:13 +0200
> Subject: [PATCH] [dts] [v2] fix green/blue pio-led
>  pio-leds (near GPIO-Header) are swapped and LOW-active 
>  patch restore this expected behaviour
>  red cannot be switched afaik
> 
> v2: alphabetic order
> 
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
>  arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> index 531d905d924ff..2b760f90f38c8 100644
> --- a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> +++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> @@ -91,19 +91,19 @@
>  
>  		blue {
>  			label = "bpi-r2:pio:blue";
> -			gpios = <&pio 241 GPIO_ACTIVE_HIGH>;
> +			gpios = <&pio 240 GPIO_ACTIVE_LOW>;
>  			default-state = "off";
>  		};
>  
>  		green {
>  			label = "bpi-r2:pio:green";
> -			gpios = <&pio 240 GPIO_ACTIVE_HIGH>;
> +			gpios = <&pio 241 GPIO_ACTIVE_LOW>;
>  			default-state = "off";
>  		};
>  
>  		red {
>  			label = "bpi-r2:pio:red";
> -			gpios = <&pio 239 GPIO_ACTIVE_HIGH>;
> +			gpios = <&pio 239 GPIO_ACTIVE_LOW>;
>  			default-state = "off";
>  		};
>  	};
> 
>  

Reviewed-by: Sean Wang <sean.wang@mediatek.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts] [v2] fix green/blue pio-led on bananapi-r2
       [not found]     ` <trinity-28694d63-092a-48be-aade-ba680b5c4e70-1529921159405@3c-app-gmx-bs16>
  2018-06-27  5:54       ` [dts] [v2] " Sean Wang
@ 2018-07-16  9:16       ` Matthias Brugger
  1 sibling, 0 replies; 4+ messages in thread
From: Matthias Brugger @ 2018-07-16  9:16 UTC (permalink / raw)
  To: linux-arm-kernel



On 25/06/18 12:05, Frank Wunderlich wrote:
> 
> From: Frank Wunderlich <frank-w@public-files.de>
> Date: Mon, 25 Jun 2018 11:57:13 +0200
> Subject: [PATCH] [dts] [v2] fix green/blue pio-led
>  pio-leds (near GPIO-Header) are swapped and LOW-active 
>  patch restore this expected behaviour
>  red cannot be switched afaik
> 
> v2: alphabetic order
> 

I fixed the commit message and pushed it to v4.18-next/dts32

> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
>  arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> index 531d905d924ff..2b760f90f38c8 100644
> --- a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> +++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> @@ -91,19 +91,19 @@
>  
>  		blue {
>  			label = "bpi-r2:pio:blue";
> -			gpios = <&pio 241 GPIO_ACTIVE_HIGH>;
> +			gpios = <&pio 240 GPIO_ACTIVE_LOW>;
>  			default-state = "off";
>  		};
>  
>  		green {
>  			label = "bpi-r2:pio:green";
> -			gpios = <&pio 240 GPIO_ACTIVE_HIGH>;
> +			gpios = <&pio 241 GPIO_ACTIVE_LOW>;
>  			default-state = "off";
>  		};
>  
>  		red {
>  			label = "bpi-r2:pio:red";
> -			gpios = <&pio 239 GPIO_ACTIVE_HIGH>;
> +			gpios = <&pio 239 GPIO_ACTIVE_LOW>;
>  			default-state = "off";
>  		};
>  	};
> 
> ?
> 
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-07-16  9:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <trinity-ae29ad25-a4fb-47f3-8d68-f6e58c875a0e-1529682447976@3c-app-gmx-bs42>
2018-06-22 15:53 ` [PATCH] [dts] fix green/blue pio-led on bananapi-r2 Frank Wunderlich
2018-06-25  9:17   ` Sean Wang
     [not found]     ` <trinity-28694d63-092a-48be-aade-ba680b5c4e70-1529921159405@3c-app-gmx-bs16>
2018-06-27  5:54       ` [dts] [v2] " Sean Wang
2018-07-16  9:16       ` Matthias Brugger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox